Infra
/
lemur
5
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

to prevent duplicate emails, we might better remove owner and security email address from the notification recipient

This commit is contained in:
Hossein Shafagh 2019-06-05 17:57:11 -07:00
parent 7eb9c80fb2
commit 28e26a1baf
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lemur/notifications/messaging.py
View File

@ -140,12 +140,6 @@ def send_expiration_notifications(exclude):
notification_data.append(cert_data)
security_data.append(cert_data)
notification_recipient = get_plugin_option(
"recipients", notification.options
)
if notification_recipient:
notification_recipient = notification_recipient.split(",")
if send_notification(
"expiration", notification_data, [owner], notification
):
@ -153,10 +147,16 @@ def send_expiration_notifications(exclude):
else:
failure += 1
notification_recipient = get_plugin_option(
"recipients", notification.options
)
if notification_recipient:
notification_recipient = notification_recipient.split(",")
# removing owner and security_email from notification_recipient
notification_recipient = [i for i in notification_recipient if i not in security_email and i != owner]
if (
notification_recipient
and owner != notification_recipient
and security_email != notification_recipient
):
if send_notification(
"expiration",