wpetit/guesstimate
1
0
Fork 0
Code Issues 3 Pull Requests 1 Releases Wiki Activity

WIP: Ajouter la possibilité d'exporter l'estimation en PDF #1

Draft
tcornaut wants to merge 4 commits from feature/export-pdf into develop
pull from: feature/export-pdf
merge into: wpetit:develop
Conversation 0 Commits 4 Files Changed 27 +1811 -2025
tcornaut commented 2020-06-11 15:34:27 +02:00
Collaborator
Copy Link
No description provided.
bgaude was assigned by tcornaut 2020-06-11 15:34:27 +02:00
wpetit was assigned by tcornaut 2020-06-11 15:34:27 +02:00
tcornaut changed title from Ajouter la possibilité d'exporter l'estimation en PDF to WIP: Ajouter la possibilité d'exporter l'estimation en PDF 2020-06-11 15:34:38 +02:00
wpetit requested changes 2020-06-16 14:19:10 +02:00
server/internal/route/project.go Outdated
@ -77,0 +88,4 @@
url string
)
url = "http://" + string(cfg.Client.BaseURL) + string(cfg.Client.Address) + "/pdf/" + string(projectID)
wpetit commented 2020-06-16 14:17:04 +02:00
Owner
Copy Link

Je ne comprend pas très bien la nécessité du découpage BaseURL et Address. Au final, est ce qu'il ne serait pas plus simple d'avoir un attribut de configuration PublicBaseURL qui comprendrait toute la racine publique de l'application ? Par exemple https://guesstimate.dev.lookingfora.name ?

Je ne comprend pas très bien la nécessité du découpage `BaseURL` et `Address`. Au final, est ce qu'il ne serait pas plus simple d'avoir un attribut de configuration `PublicBaseURL` qui comprendrait toute la racine publique de l'application ? Par exemple `https://guesstimate.dev.lookingfora.name` ?
This pull request has changes conflicting with the target branch.
  • client/package-lock.json
  • client/package.json
  • client/src/components/app.tsx
  • client/src/hooks/use-local-storage.ts
  • client/src/routes/project/export-tab.tsx
  • client/src/routes/project/financial-preview.tsx
  • client/src/routes/project/params-tab.tsx
  • client/src/routes/project/tasks-table.tsx
  • client/src/routes/project/time-preview.tsx
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/export-pdf:feature/export-pdf
git checkout feature/export-pdf
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
bgaude
wpetit
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wpetit/guesstimate#1
No description provided.
Delete Branch "feature/export-pdf"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?