Commit Graph

178 Commits

Author SHA1 Message Date
gwen df3753c36b finally a getvalue without a getattr 2013-02-27 11:09:13 +01:00
gwen c40d33fec3 type shall not be a list 2013-02-27 08:50:41 +01:00
gwen 1f1e5e5d26 type shall not be a list 2013-02-26 17:04:41 +01:00
gwen e515ec145d type shall not be a list 2013-02-26 16:58:44 +01:00
gwen 151bc83ba5 previous value api 2013-02-26 14:56:15 +01:00
gwen 762b0e9c69 is_empty 2013-02-26 14:31:45 +01:00
gwen 8be48e5eba pep8 2013-02-25 16:24:30 +01:00
gwen eb632c002d option names shall be valid names 2013-02-25 16:06:10 +01:00
gwen a02cb26d5f masterlen > instead of != 2013-02-25 15:52:10 +01:00
gwen ea7d297c9b private method _get_multitype() 2013-02-25 15:12:09 +01:00
gwen 77633c84ce private method _get_multitype() 2013-02-25 14:27:12 +01:00
gwen 7b4f3b5d36 option's name shall not have an api's method name 2013-02-25 11:33:20 +01:00
gwen 8f4efe6b00 add masters/slaves in the Values() 2013-02-22 11:09:17 +01:00
gwen e6d5d349c8 refactoring values 2013-02-21 17:07:00 +01:00
gwen d058e2946b doc theme 2013-02-19 16:32:31 +01:00
gwen a619085530 doc theme 2013-02-19 16:24:13 +01:00
gwen b69ecbd2eb update of the doc 2013-02-19 11:24:17 +01:00
gwen a8e6bac87f refactoring, the values are in an OptionValues object 2013-02-08 11:50:22 +01:00
gwen 9259a6e3f7 values are in value objects now 2013-02-07 16:20:21 +01:00
gwen 29914051e0 master groups that have multis 2013-02-06 17:19:56 +01:00
gwen a404c4c992 masters shall have the same names as groups 2013-02-06 16:21:30 +01:00
gwen 6a3b7102b5 adds a freeze_everything possibility 2013-02-06 14:59:24 +01:00
gwen d00a623fc1 validator set to false for read_write in setting 2013-02-06 14:34:12 +01:00
Daniel Dehennin 2cb3ddf2e8 Fix line wrapping and some raise messages spacing
* tiramisu/option.py (Multi.append): do not wrapp short line.
  (validate_requires_arg): Add missing space for multi line strings.
2013-01-31 17:09:59 +01:00
Daniel Dehennin 03baedd4dd Fix appending to a non-grouped multi
When the multi is not grouped, just set the value and do not try to
update len of inexistant slaves.

The code path try to update the len of all other variables under the
OptionDescription of the multi.

* tiramisu/option.py (Multi.append): return after setting the value.

Fixes: #4811 @10m
2013-01-31 17:09:59 +01:00
Daniel Dehennin 170698a5e3 Find breaks on "disabled" property
The exception was raised during unwrap_from_path() call.

* tiramisu/config.py (_filter_by_attrs): do not catch exception arround
  getattr().
  (_find): continue to next option if unwrap_from_path() raise
  PropertiesOptionError.

Fixes: #4728 @5m
2013-01-31 14:38:48 +01:00
Daniel Dehennin f494bb1502 Better raise message
* tiramisu/config.py (Config._valid_len): use master and slave name and
  value.
2013-01-30 18:04:55 +01:00
Daniel Dehennin 184c48db8c Do not append default value on already defined multi slaves
* tiramisu/option.py (Multi.append): append the default value when the
  slaves have no item or lesser than the master.
  Divide looping over slaves by factor 2.

Fixes: #4799 @4h
2013-01-30 18:04:55 +01:00
Daniel Dehennin 064bed9efa Fix infinite recursion on calculated master of multi variable
There was a infinite recursion between option.Multi.append() and
config.Config._getattr() through config.Config.fill_multi() when
calculating the master:

- config.Config._getattr()
-> config.Config.fill_multi()
-> option.Multi.__init__()
-> option.Multi.append()
-> config.Config._getattr()

* tiramisu/option.py (Multi.append): do not pass by
  config.Config._getattr().

* tiramisu/option.py (Multi.__init__): do not catch exception when
  appending.

Ref: #4799 @8h
2013-01-30 18:04:46 +01:00
Daniel Dehennin deaa0942ff Remove useless returns and variables
* tiramisu/option.py (Multi.__setitem__): Do not returns.
  (Multi.append): Ditoo.
  Remove useless "ret" variable.
  (Multi._setvalue): Ditoo.
  (Multi.pop): Do not set "ret" to None, raise if "ret" is not in "locals()"
  (Multi._pop): Avoid useless "oldvalue" variable.
2013-01-30 09:19:48 +01:00
Daniel Dehennin f267073e0d Variable "ret" referenced before assignment
Variable defined in sub-scope ("for", "if") are not defined above.

* tiramisu/option.py (Multi.append): Define "ret" to None.

* tiramisu/option.py (Multi._setvalue): Ditoo.

* tiramisu/option.py (Multi.pop): Ditoo.
2013-01-29 15:21:31 +01:00
gwen e2a02c5b7a find raises an exception if no option found Fixes #4721 2013-01-28 09:55:51 +01:00
gwen c66dcd09ee substitute properties/permissivers in apply_requries 2013-01-28 09:33:08 +01:00
gwen 189053ad03 master subgroups that have subgroups 2013-01-11 09:46:41 +01:00
gwen f9d6f62a70 multi defaults value addition cinematics 2013-01-10 12:03:59 +01:00
gwen e70054c4d4 owners for multi options 2012-12-11 16:22:02 +01:00
gwen cda5d8c0bd generic owners shall live in settings 2012-12-11 11:18:53 +01:00
gwen ca2f4487dd add owner 2012-12-10 14:38:25 +01:00
gwen cd50cf7551 owners are *real* objects now 2012-12-10 14:10:05 +01:00
gwen 07d3cb1037 constants heritage 2012-12-10 09:53:13 +01:00
gwen e118f07539 groupe_types are real types now 2012-12-06 18:14:57 +01:00
gwen 9736298ba2 tests on groups/masters allowed groups 2012-12-06 15:19:43 +01:00
gwen 69d747baec comments on the code 2012-12-05 11:12:04 +01:00
gwen 7574ac43aa Multi()'s and append 2012-12-05 10:54:32 +01:00
gwen 7784a82cde tests on group types 2012-12-05 09:41:53 +01:00
gwen 0db34bbeba master len without getattr 2012-12-04 16:22:39 +01:00
gwen 6538231817 pop and append in multi values 2012-12-04 15:18:13 +01:00
gwen 4393da13ab validation of the len of the multi in a group 2012-12-04 12:06:26 +01:00
gwen d633574cc5 comparison failed 2012-12-03 15:48:04 +01:00
gwen 2dfc906966 symlink has an option's API 2012-11-30 16:23:40 +01:00