fe5d75c7f8
Merge branch 'master' into notification-fixes
2020-10-16 15:20:42 -07:00
60bb0037f0
Miscellaneous notification fixes and tests
2020-10-16 15:13:12 -07:00
dbdfa9eab8
Merge branch 'master' into expanding-S3-plugin
2020-10-16 11:35:38 -07:00
a04cce6044
Initial implementation
2020-10-16 10:40:11 -07:00
503530e935
the test requires region param for sts
2020-10-16 10:32:10 -07:00
11ce540246
formatting
2020-10-16 10:31:19 -07:00
9c04a888d8
adjusting the S3 test
2020-10-16 09:52:04 -07:00
17e528b5dd
adding testing for acme_upload method
2020-10-16 09:50:35 -07:00
d705e3ae3b
expanding the S3 destination plugin to support the acme token upload inteface
2020-10-16 09:49:56 -07:00
7d8eb1c61e
improving test
2020-10-16 09:49:26 -07:00
6aad37e1f9
cleaning up code
2020-10-16 09:49:00 -07:00
d73db59d23
revsering removing region
2020-10-16 09:48:47 -07:00
ab91d58a03
Merge branch 'master' into cab_compliant
2020-10-16 08:33:04 -07:00
55658c5f23
Add double % for escaped SQLALCHEMY_DATABASE_URI
2020-10-16 10:43:52 +02:00
bfe89e131e
adding delete and put interfaces for the S3 plugin
2020-10-15 18:13:50 -07:00
9dc476f393
Use cab_compliant option instead of authority name list
2020-10-15 10:44:46 -07:00
f38380d156
Check if option is present
2020-10-14 17:38:32 -07:00
4d5e712e85
Remove option reset from test
2020-10-14 15:40:23 -07:00
ee1d07000a
Test subject details in reissue with cab_compliant option
2020-10-14 14:49:53 -07:00
90839b4d4b
Unit test for cab_compliant = true
2020-10-14 14:49:53 -07:00
62d099b500
Unit tests to check cab_compliant option
2020-10-14 12:41:56 -07:00
409e12a9d6
Update models.py
...
lint
2020-10-14 10:03:44 -07:00
894e35b4e2
Update schemas.py
...
minor language
2020-10-14 09:48:40 -07:00
97cf54433b
Update models.py
...
language
2020-10-14 09:45:13 -07:00
82dd663942
Moving default key_type to getDefaults
2020-10-13 19:40:32 -07:00
28381737dc
Removed OU from digicert plugin
2020-10-13 19:40:15 -07:00
b677e6e325
Copy subject details for non-CAB-compliant authorities
2020-10-13 19:40:01 -07:00
5db1d31668
Merge branch 'master' into removing-outdated-language
2020-10-12 10:22:53 -07:00
817fc3f0fe
Merge branch 'master' into feature/store-acme-account-details
2020-10-11 14:37:31 +02:00
4c7b429001
Merge branch 'master' into ui_changes
2020-10-09 18:05:33 -07:00
770339f94c
cleaning up outdated phrases
2020-10-09 18:04:16 -07:00
fb4df8865b
Formatting changes and typo
2020-10-09 17:58:03 -07:00
0fc050e17b
Merge branch 'master' into dymanic-digicert-ICAs
2020-10-09 17:53:54 -07:00
475833e8e1
Merge branch 'master' into ui_changes
2020-10-09 17:53:43 -07:00
198e20ce4f
Merge branch 'master' into dymanic-digicert-ICAs
2020-10-09 17:49:33 -07:00
d4819440af
Merge branch 'master' into entrust-plugin
2020-10-09 17:47:01 -07:00
d52e0d4e09
Certificate edit: update role and notification with owner change
2020-10-09 16:55:30 -07:00
42e9b8b627
removing the intermediary from being optional
2020-10-09 15:40:25 -07:00
e67fc09bc8
Merge branch 'entrust-plugin' of github.com:sirferl/lemur into entrust-plugin
2020-10-09 12:11:41 +02:00
5a968ffe63
Lint errors
2020-10-09 12:05:57 +02:00
cc02a0adb0
Merge branch 'master' into entrust-plugin
2020-10-09 11:56:47 +02:00
d43e240a2a
dded ELIF at determine_end_date, becuase of error.
2020-10-09 11:41:44 +02:00
a6a4f458e0
added Tests and removed problems in test-setup
2020-10-09 11:35:04 +02:00
d5ce38bf71
lint error fix - remove whitespace
2020-10-08 12:50:30 -07:00
8928e04385
Fix disable notify
2020-10-08 11:38:52 -07:00
1a270cd315
switching from static DigiCert ICAs to dynamic ones to support:
...
https://knowledge.digicert.com/alerts/DigiCert-ICA-Update.html
2020-10-07 20:06:20 -07:00
4f696abb5d
adding util method to convert PKCS7 to pem
2020-10-07 20:03:46 -07:00
b7d0e62844
Make location optional
...
Remove form validation and default value in input schema
2020-10-07 13:31:23 -07:00
57534d86cd
Disable account saving by default
2020-10-07 12:28:22 +02:00
8353396940
Improve tests
2020-10-07 12:28:22 +02:00
9abd3e97e7
Add test loading acme account from authority
2020-10-07 12:28:22 +02:00
bf66de0bfd
Add Test for saving the accound details
2020-10-07 12:28:22 +02:00
e0708410d0
Add store_account value to options in test_setup_acme_client_success
2020-10-07 12:28:22 +02:00
7e6fb740b3
Fix flake8/linting errors
2020-10-07 12:28:22 +02:00
eed628dbab
Implement storage of acme account
2020-10-07 12:28:22 +02:00
898b5da661
Add store_account option to acme plugin
2020-10-07 12:28:22 +02:00
e64e2a41d5
Add update_options to authorities service
2020-10-07 12:28:22 +02:00
c72661a87f
Removing hardcoded name
2020-10-06 18:50:37 -07:00
6b96aefa21
Authority create: Email added to subject DN for cloudCA
2020-10-06 18:35:28 -07:00
ea513f465f
Remove bit length check from last query
2020-09-29 16:33:10 -07:00
b9100dbf29
Merge branch 'master' of github.com:Netflix/lemur into key_type_column
2020-09-29 10:25:54 -07:00
d7fc84f6e9
Fix dns-providers type missing from schema
2020-09-29 14:36:31 +02:00
aaff0f7581
Fixing UT for key_type on upload schema
2020-09-28 19:03:21 -07:00
7a226241db
Add key_type to CertificateUploadInputSchema
...
Parse cert body to determine algo
2020-09-28 18:13:00 -07:00
96eada297f
lint
2020-09-28 14:40:56 -07:00
0fa136e7a4
Merge branch 'master' into remove-test-secrets
2020-09-25 17:19:39 -07:00
8f1c966079
Merge branch 'master' into remove-test-secrets
2020-09-25 12:48:28 -07:00
d49edd886b
language
2020-09-25 12:32:33 -07:00
e871c5eb18
Update conf.py
2020-09-25 12:30:37 -07:00
57457bfe78
Merge branch 'master' of github.com:Netflix/lemur into key_type_column
2020-09-23 15:23:45 -07:00
cd13832377
Use key_type column for cert get/rotate/reissue/display
...
Added unit tests
2020-09-23 15:16:19 -07:00
4e4a7e9cab
Merge branch 'master' into entrust-revised
2020-09-23 13:33:24 -07:00
e5961146b9
session hook complains about metadata
...
+ consistent language.
2020-09-23 14:22:58 -06:00
12af0ecb45
UT get_key_type_from_certificate
2020-09-23 11:46:38 -07:00
710290f590
Formatting changes
2020-09-23 11:45:36 -07:00
19b693f636
Update c301c59688d2_.py
...
language
2020-09-23 10:21:23 -07:00
e3fa072608
Update c301c59688d2_.py
...
language
2020-09-23 10:17:30 -07:00
921e8d8236
Add error message to the logs
2020-09-22 18:46:15 -07:00
9211178e77
Added date-time and modified log file name
2020-09-22 18:31:38 -07:00
8de9842092
Backfill the key_type column: DB Upgrade
2020-09-22 18:22:45 -07:00
1632b4b078
making lint happy, running make test-python doesn't run lint
2020-09-18 21:58:53 -07:00
21e9a4508d
TypeError: 'float' object cannot be interpreted as an integer
2020-09-18 17:42:28 -07:00
c892cd5ae1
removing anything that remotely looks like a secret in code to set a good example
2020-09-18 17:38:52 -07:00
cc855e2758
modern python style
2020-09-18 17:16:07 -07:00
edab32d9a1
setting the required entrust configs
2020-09-18 17:03:22 -07:00
416f39222a
testing
2020-09-18 17:02:19 -07:00
fae3793255
entrrust plugin revised
2020-09-18 11:09:32 -07:00
51549ae795
Adding comment for the property to be removed
2020-09-15 17:37:58 -07:00
d8cca855e8
Merge branch 'master' of github.com:Netflix/lemur into key_type_column
2020-09-15 15:16:13 -07:00
5ae65c2c4d
Remove unused import
2020-09-15 14:55:04 -07:00
676562ffde
Match column type to db schema
...
No functional change
2020-09-14 18:13:35 -07:00
02d711282d
New column key_type
...
commenting conflicting property for now
2020-09-14 18:12:33 -07:00
02c7a5ca7c
another round of lint errors
2020-09-14 16:34:56 +02:00
e011cc9251
added several enhancements following advice from peer
2020-09-14 16:24:53 +02:00
9778eb7b25
fixed lint errors
2020-09-14 15:56:02 +02:00
5bb0143da4
lint errors and removed _path from the API-Cert variables
2020-09-14 15:42:36 +02:00
84496b0f55
fixed a few problems
2020-09-14 15:18:46 +02:00
b8e3162c5f
added revoke functionality
2020-09-14 14:20:11 +02:00
b337b27146
added response handler
2020-09-14 12:23:58 +02:00
01678a714f
added required vars check
2020-09-14 09:50:55 +02:00
8adca442e1
Merge branch 'master' into entrust-plugin
2020-09-11 17:11:57 -07:00
09a2a8fc76
Log message change
...
PR comments
2020-09-11 15:53:34 -07:00
806aeddd87
Merge branch 'master' into validity
2020-09-11 10:09:01 -07:00
6e588f9c7b
Merge branch 'master' into validity
2020-09-11 09:06:11 -07:00
1c9c377751
Lint errors
2020-09-11 12:31:15 +02:00
fd52438d61
yet lint errors
2020-09-11 12:30:53 +02:00
de9ad82011
Fixed Lint complaints
2020-09-11 12:24:33 +02:00
a99a84b0b2
entrust plugin inital edit
2020-09-10 16:04:31 +02:00
f47f108f43
ientrust plgin - first version
2020-09-10 16:03:29 +02:00
a7be8b6dce
adding support for different types of CSR encodings
2020-09-09 19:54:53 -07:00
4923157dc2
expanding key_type to with EC support
2020-09-09 19:54:20 -07:00
aff7ad7ea2
testing
2020-09-09 19:53:59 -07:00
60fd2134ca
removing duplicate curves, and marking them in existing mapping
2020-09-09 19:53:35 -07:00
5ab9626cbd
overwriting cn and key_type values from CSR, as they take precedence
2020-09-09 19:52:59 -07:00
6fa15c4cb3
methods to extract cn and key_type from csr
2020-09-09 19:48:21 -07:00
de0c38e9ba
mapping of curve name to key_type
2020-09-09 19:47:51 -07:00
8ad4448c85
Match date format for comparison + expected new lines
2020-09-01 12:44:49 -07:00
db4f68f0ed
Logs during cert validity truncate for digicert
2020-08-31 18:20:32 -07:00
9c4fb85dc3
Calculate dates from defaultDays in js
2020-08-31 18:19:32 -07:00
d478def98c
removing the custom key Type and doing the conversion in the backend
2020-08-31 16:35:47 -07:00
9a7a632489
using a standard curve for testing
2020-08-28 09:48:35 -07:00
9671b34485
adding support for all type of ECC curves which existing CA plugins might support
2020-08-27 14:15:14 -07:00
1fc2e29ab8
Remove 397 days validation as it causes error in API calls
...
More to come in future
2020-08-27 14:15:14 -07:00
ab4cda2298
Extended ADCS_TEMPLATE_ Variable
...
If there is a config variable ADCS_TEMPLATE_<upper(authority.name)> take the value as Cert template else default to ADCS_TEMPLATE to be compatible with former versions
2020-08-27 14:15:14 -07:00
7a9500eee0
Lint error fix
2020-08-27 14:15:14 -07:00
5ed109e998
Max end date as per start date + default validity 3 years
2020-08-27 14:15:14 -07:00
7011a4df8b
max date on UI as per max validity configs
2020-08-27 14:15:14 -07:00
4d7c6844e5
Make Organizational Unit optional
2020-08-27 14:15:14 -07:00
2645c4a82d
mention 397 for digicert plugin
2020-08-27 14:15:14 -07:00
3cb386cc0f
maximum 1 year validity for digicert
2020-08-27 14:15:14 -07:00
e06dea106f
Modify unit test test_determine_end_date to match new config
2020-08-27 14:15:14 -07:00
d7d483fa9b
Renaming PUBLIC_CA to PUBLIC_CA_AUTHORITY_NAMES
2020-08-27 14:15:14 -07:00
25125f3257
Cert validity should not exceed 397 days for publicly trusted issuers
2020-08-27 14:15:14 -07:00
404d213e8f
Modified cert description to have cert id being cloned
2020-08-27 14:15:14 -07:00
e75e472a1a
Do not inherit replacement info during cert clone
2020-08-27 14:15:14 -07:00
69b64c63ea
Honor selected algorithm during certificate cloning
2020-08-27 14:15:14 -07:00
f4bcd1cf30
lack of an empty config file was resulting into this error
...
```
Traceback (most recent call last):
File "/home/travis/build/Netflix/lemur/lemur/plugins/lemur_acme/tests/test_acme.py", line 159, in test_request_certificate
self.acme.request_certificate(mock_acme, [], mock_order)
File "/home/travis/build/Netflix/lemur/lemur/plugins/lemur_acme/plugin.py", line 211, in request_certificate
current_app.config.get("IDENTRUST_CROSS_SIGNED_LE_ICA_EXPIRATION_DATE", "17/03/21"), '%d/%m/%y'):
TypeError: strptime() argument 1 must be str, not MagicMock
```
2020-08-27 14:15:14 -07:00
5a6e4e5b43
Let's Encrypt has been using a cross-signed intermediate CA by DST Root CA X3, which is included in any older devices' TrustStore.
...
https://letsencrypt.org/certificates/
Let's Encrypt is transitioning to use the intermediate CA issued by their own root (ISRG X1) starting from September 29th 2020. This is in preparation of concluding the initial bootstrapping of their CA, by having it cross-signed by an older CA.
https://letsencrypt.org/2019/04/15/transitioning-to-isrg-root.html
This PR allows Lemur to pin to the cross-signed ICA (same public/private key pair as the ICA signed by ISRG X1). This will prolong support for incompatible systems.
2020-08-27 14:15:14 -07:00
c169ad291e
adding the correct signing algorithm, and a missing key Type
2020-08-27 13:29:56 -07:00
3242fc1e13
Validity with radio buttons
2020-08-26 19:30:12 -07:00
6aedd3b0d8
Datepicker enhancements
2020-08-25 18:40:36 -07:00
3efe14c43f
Remove 397 days validation as it causes error in API calls
...
More to come in future
2020-08-25 16:26:20 -07:00
4f148f3bc3
Merge branch 'master' into master
2020-08-20 11:33:18 +02:00
1b73b1d080
Merge branch 'master' into master
2020-08-19 12:29:02 +02:00
c2116df652
Extended ADCS_TEMPLATE_ Variable
...
If there is a config variable ADCS_TEMPLATE_<upper(authority.name)> take the value as Cert template else default to ADCS_TEMPLATE to be compatible with former versions
2020-08-19 12:25:52 +02:00
5b96b3a032
Lint error fix
2020-08-18 20:03:15 -07:00
240f0b99c8
Max end date as per start date + default validity 3 years
2020-08-18 19:34:59 -07:00
bc5579e9bf
max date on UI as per max validity configs
2020-08-18 14:50:42 -07:00
5b3f40467b
Make Organizational Unit optional
2020-08-18 14:50:42 -07:00
6ff8910f87
mention 397 for digicert plugin
2020-08-11 18:53:19 -07:00
d7ca1570be
maximum 1 year validity for digicert
2020-08-11 18:02:42 -07:00
bde2829e72
Modify unit test test_determine_end_date to match new config
2020-08-11 17:10:29 -07:00
18a3514974
Renaming PUBLIC_CA to PUBLIC_CA_AUTHORITY_NAMES
2020-08-10 18:06:45 -07:00
7a83799bcd
Cert validity should not exceed 397 days for publicly trusted issuers
2020-08-10 17:30:34 -07:00
9bcfcebb3a
Merge branch 'master' into bootswatch-fix
2020-08-04 14:09:33 -07:00
817a4c3d90
Modified cert description to have cert id being cloned
2020-08-03 19:24:06 -07:00
c3d8501401
Do not inherit replacement info during cert clone
2020-08-03 19:23:24 -07:00
c15a2c62d1
Honor selected algorithm during certificate cloning
2020-08-03 19:22:13 -07:00
3c1d6998fb
Merge branch 'master' into pinning-to-cross-signed-LE-ICA
2020-07-24 10:25:11 -07:00
0fd83d13ae
Fix intermediate CA creation on cryptography plugin
2020-07-23 13:58:32 -07:00
2317967802
lack of an empty config file was resulting into this error
...
```
Traceback (most recent call last):
File "/home/travis/build/Netflix/lemur/lemur/plugins/lemur_acme/tests/test_acme.py", line 159, in test_request_certificate
self.acme.request_certificate(mock_acme, [], mock_order)
File "/home/travis/build/Netflix/lemur/lemur/plugins/lemur_acme/plugin.py", line 211, in request_certificate
current_app.config.get("IDENTRUST_CROSS_SIGNED_LE_ICA_EXPIRATION_DATE", "17/03/21"), '%d/%m/%y'):
TypeError: strptime() argument 1 must be str, not MagicMock
```
2020-07-15 17:04:49 -07:00
d5ae45a0d0
Let's Encrypt has been using a cross-signed intermediate CA by DST Root CA X3, which is included in any older devices' TrustStore.
...
https://letsencrypt.org/certificates/
Let's Encrypt is transitioning to use the intermediate CA issued by their own root (ISRG X1) starting from September 29th 2020. This is in preparation of concluding the initial bootstrapping of their CA, by having it cross-signed by an older CA.
https://letsencrypt.org/2019/04/15/transitioning-to-isrg-root.html
This PR allows Lemur to pin to the cross-signed ICA (same public/private key pair as the ICA signed by ISRG X1). This will prolong support for incompatible systems.
2020-07-14 17:35:13 -07:00
e0c2f4274e
Merge branch 'master' into patch-1
2020-07-02 10:16:02 -07:00
aa11088944
Remove f from non-f string
2020-07-02 16:48:41 +02:00
1f598e3752
Fix unmatched field in Authorization
...
The field in the formatted string was not matching the args
2020-07-02 16:41:19 +02:00
7a5a5531cc
Raise ValidationError if CSR contains invalid CN
...
If we supply a CSR that contains an empty field in the Subject, Lemur will crash with an error 500 as the ValueError exception is not captured. This change captures the exception and raises a ValidationError which in this case is a 400 sent back to client. Example to reproduce:
Subject: C=ZZ, ST=Something, L=, O=My_Org, OU=My_Dept, CN=www.booking.com
The empty L= causes a ValueError which needs to be captured.
2020-07-01 15:44:06 +02:00
4985744bd8
fixing UnboundLocalError bug
2020-06-11 16:47:37 -07:00
a7a309136f
fixing whitespace and imports
2020-06-11 14:15:40 -07:00
f834d10f9a
moving ultradns tests to separate file
2020-06-11 14:04:17 -07:00
c40d297735
Merge branch 'master' into ilabun/optimize-certificates-sql
2020-06-09 14:20:31 -07:00
fd3ea2cf46
Merge branch 'master' into json-logging-rotate
2020-06-09 10:58:53 -07:00
099ebee409
Merge branch 'master' into check-revoke-revised
2020-06-09 10:47:24 -07:00
62469e518f
Merge branch 'master' into json-logging-rotate
2020-06-09 10:45:57 -07:00
c3b36d697f
clarification
2020-06-08 15:17:45 -07:00
5215a71a6d
Merge branch 'master' into check-revoke-revised
2020-06-04 15:51:48 -07:00
704e61dd53
Merge branch 'master' into json-logging-rotate
2020-06-04 15:51:24 -07:00
e06c3ea192
Merge branch 'master' into improve-expiry-email
2020-06-04 15:51:17 -07:00
1bcc9d5d0d
allowing for _ in domains
2020-06-03 13:20:23 -04:00
1b8507636b
fixing quotes, no escape characters in tests, fixed anchors
2020-06-03 12:49:55 -04:00
3ce7cd6c50
fixing escaped string on domain test
2020-06-03 11:34:14 -04:00
8658ac531e
fixing unittests and allowing for single character domains
2020-06-03 08:08:49 -04:00
2a1751ec30
fixing domain validation to account for 2-63 character length and correct character set
2020-06-03 04:56:38 -04:00
50091cca1d
Merge branch 'master' into ilabun/optimize-certificates-sql
2020-05-27 15:29:47 -07:00
d8948a12d3
Merge branch 'master' into check-revoke-revised
2020-05-27 15:29:19 -07:00
86c3771044
Merge branch 'master' into json-logging-rotate
2020-05-27 15:28:48 -07:00
904bc9d8b6
Merge branch 'master' into improve-expiry-email
2020-05-27 15:28:41 -07:00
d95f02d234
Merge branch 'master' into master
2020-05-27 14:25:07 -07:00
8861cc70cb
rewordin
2020-05-26 17:12:47 -07:00
34e3f7c049
improved messaging
2020-05-26 16:38:12 -07:00
4eeab91d73
making lint happy
2020-05-22 18:36:39 -07:00
10dfedee36
making lint happy
2020-05-22 18:33:43 -07:00
86310ff02d
Merge branch 'master' into check-revoke-revised
2020-05-22 18:25:00 -07:00
87a53557cd
Merge branch 'master' into json-logging-rotate
2020-05-22 18:24:53 -07:00
8f16688b0a
Merge branch 'master' into check-revoke-revised
2020-05-22 17:45:50 -07:00
49a8b80df2
better exception handling when OCSP or CRL or not implemented
2020-05-22 17:36:34 -07:00
c9767b3172
adding logging for revoked certs
2020-05-22 17:32:44 -07:00
49c4a9c3b2
making the revocation to be scoped based on the authority plugin name
2020-05-22 17:29:30 -07:00
4923bbf8a7
adding json formatted logging
2020-05-22 16:22:12 -07:00
09016fd2ee
cleaning up the code after more local testing
2020-05-22 16:04:39 -07:00
f83e3f764e
always assign csr_sans to name
2020-05-22 21:52:43 +03:00
Jasmine Schladen
Jasmine Schladen
Hossein Shafagh
Mathias Petermann
sayali
sirferl
sirferl
Hossein Shafagh
Raul Benencia
Javier Ramos
csine-nflx
alwaysjolley
e11it