Prevent creation of empty SubjAltNames extension in CSR (#883)

2017-08-18 19:10:56 +03:00
parent c6d76f580e
commit e7efaf4365
2 changed files with 23 additions and 8 deletions
--- a/lemur/certificates/service.py
+++ b/lemur/certificates/service.py
@ -353,7 +353,8 @@ def create_csr(**csr_config):
            if k in critical_extensions:
                current_app.logger.debug('Adding Critical Extension: {0} {1}'.format(k, v))
                if k == 'sub_alt_names':
-                    builder = builder.add_extension(v['names'], critical=True)
+                    if v['names']:
+                        builder = builder.add_extension(v['names'], critical=True)
                else:
                    builder = builder.add_extension(v, critical=True)