Merge pull request #3295 from sirferl/source_options

make options for sources optional

lemur/plugins/lemur_adcs/plugin.py

@@ -77,15 +77,6 @@ class ADCSSourcePlugin(SourcePlugin):
 
     author = "sirferl"
     author_url = "https://github.com/sirferl/lemur"
-    options = [
-        {
-            "name": "dummy",
-            "type": "str",
-            "required": False,
-            "validation": "/^[0-9]{12,12}$/",
-            "helpMessage": "Just to prevent error",
-        }
-    ]
 
     def get_certificates(self, options, **kwargs):
         adcs_server = current_app.config.get("ADCS_SERVER")

lemur/plugins/lemur_entrust/plugin.py

@@ -319,15 +319,6 @@ class EntrustSourcePlugin(SourcePlugin):
 
     author = "sirferl"
     author_url = "https://github.com/sirferl/lemur"
-    options = [
-        {
-            "name": "dummy",
-            "type": "str",
-            "required": False,
-            "validation": "/^[0-9]{12,12}$/",
-            "helpMessage": "Just to prevent error",
-        }
-    ]
 
     def __init__(self, *args, **kwargs):
         """Initialize the issuer with the appropriate details."""

lemur/sources/views.py

@@ -156,12 +156,19 @@ class SourcesList(AuthenticatedResource):
            :reqheader Authorization: OAuth token to authenticate
            :statuscode 200: no error
         """
-        return service.create(
-            data["label"],
-            data["plugin"]["slug"],
-            data["plugin"]["plugin_options"],
-            data["description"],
-        )
+        if "plugin_options" in data["plugin"]:
+            return service.create(
+                data["label"],
+                data["plugin"]["slug"],
+                data["plugin"]["plugin_options"],
+                data["description"],
+            )
+        else:
+            return service.create(
+                data["label"],
+                data["plugin"]["slug"],
+                data["description"],
+            )
 
 
 class Sources(AuthenticatedResource):