Fixing notification deduplication and roll up

lemur/destinations/service.py

@@ -5,6 +5,8 @@
     :license: Apache, see LICENSE for more details.
 .. moduleauthor:: Kevin Glisson <kglisson@netflix.com>
 """
+from sqlalchemy import func
+
 from lemur import database
 from lemur.destinations.models import Destination
 from lemur.certificates.models import Certificate
@@ -28,9 +30,8 @@ def update(destination_id, label, options, description):
     Updates an existing destination.
 
     :param destination_id:  Lemur assigned ID
-    :param destination_number: AWS assigned ID
     :param label: Destination common name
-    :param comments:
+    :param description:
     :rtype : Destination
     :return:
     """
@@ -107,3 +108,24 @@ def render(args):
         query = database.sort(query, Destination, sort_by, sort_dir)
 
     return database.paginate(query, page, count)
+
+
+def stats(**kwargs):
+    """
+    Helper that defines some useful statistics about destinations.
+
+    :param kwargs:
+    :return:
+    """
+    attr = getattr(Destination, kwargs.get('metric'))
+    query = database.db.session.query(attr, func.count(attr))
+
+    items = query.group_by(attr).all()
+
+    keys = []
+    values = []
+    for key, count in items:
+        keys.append(key)
+        values.append(count)
+
+    return {'labels': keys, 'values': values}

lemur/destinations/views.py

@@ -353,7 +353,21 @@ class CertificateDestinations(AuthenticatedResource):
         return service.render(args)
 
 
+class DestinationsStats(AuthenticatedResource):
+    """ Defines the 'certificates' stats endpoint """
+    def __init__(self):
+        self.reqparse = reqparse.RequestParser()
+        super(DestinationsStats, self).__init__()
+
+    def get(self):
+        self.reqparse.add_argument('metric', type=str, location='args')
+        args = self.reqparse.parse_args()
+        items = service.stats(**args)
+        return dict(items=items, total=len(items))
+
+
 api.add_resource(DestinationsList, '/destinations', endpoint='destinations')
-api.add_resource(Destinations, '/destinations/<int:destination_id>', endpoint='account')
+api.add_resource(Destinations, '/destinations/<int:destination_id>', endpoint='destination')
 api.add_resource(CertificateDestinations, '/certificates/<int:certificate_id>/destinations',
                  endpoint='certificateDestinations')
+api.add_resource(DestinationsStats, '/destinations/stats', endpoint='destinationStats')