Infra
/
lemur
5
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

lemur_digicert: Do not truncate valid_to anymore (#1187) 

* lemur_digicert: Do not truncate valid_to anymore

The valid_to field for Digicert supports YYYY-MM-DDTHH:MM:SSZ so we should stop truncating

* lemur_digicert: Update unit tests for valid_to
This commit is contained in:
Will Bengtson 2018-04-10 13:23:09 -07:00 committed by kevgliss
parent 0b5f85469c
commit 8ca4f730e8
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lemur/plugins/lemur_digicert/plugin.py
View File

@ -157,7 +157,7 @@ def map_cis_fields(options, csr):
"csr": csr, "csr": csr,
"signature_hash": signature_hash(options.get('signing_algorithm')), "signature_hash": signature_hash(options.get('signing_algorithm')),
"validity": { "validity": {
"valid_to": options['validity_end'].format('YYYY-MM-DD') "valid_to": options['validity_end'].format('YYYY-MM-DDTHH:MM:SSZ')
}, },
"organization": { "organization": {
"name": options['organization'], "name": options['organization'],

4
lemur/plugins/lemur_digicert/tests/test_digicert.py
View File

@ -103,7 +103,7 @@ def test_map_cis_fields(app):
'signature_hash': 'sha256', 'signature_hash': 'sha256',
'organization': {'name': 'Example, Inc.', 'units': ['Example Org']}, 'organization': {'name': 'Example, Inc.', 'units': ['Example Org']},
'validity': { 'validity': {
'valid_to': arrow.get(2017, 5, 7).format('YYYY-MM-DD') 'valid_to': arrow.get(2017, 5, 7).format('YYYY-MM-DDTHH:MM:SSZ')
}, },
'profile_name': None 'profile_name': None
} }
@ -132,7 +132,7 @@ def test_map_cis_fields(app):
'signature_hash': 'sha256', 'signature_hash': 'sha256',
'organization': {'name': 'Example, Inc.', 'units': ['Example Org']}, 'organization': {'name': 'Example, Inc.', 'units': ['Example Org']},
'validity': { 'validity': {
'valid_to': arrow.get(2018, 11, 3).format('YYYY-MM-DD') 'valid_to': arrow.get(2018, 11, 3).format('YYYY-MM-DDTHH:MM:SSZ')
}, },
'profile_name': None 'profile_name': None
} }