Infra
/
lemur
5
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Set resolved cert ID before resolving cert; Ignore sentry exceptions when no records on deletion

This commit is contained in:
Curtis Castrapel 2019-05-15 11:43:59 -07:00
parent ed39e30824
commit 7e92edc70a
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lemur/common/celery.py
View File

@ -121,11 +121,11 @@ def fetch_acme_cert(id):
final_cert = pending_certificate_service.create_certificate(pending_cert, real_cert, pending_cert.user) final_cert = pending_certificate_service.create_certificate(pending_cert, real_cert, pending_cert.user)
pending_certificate_service.update( pending_certificate_service.update(
cert.get("pending_cert").id, cert.get("pending_cert").id,
resolved=True resolved_cert_id=final_cert.id
) )
pending_certificate_service.update( pending_certificate_service.update(
cert.get("pending_cert").id, cert.get("pending_cert").id,
resolved_cert_id=final_cert.id resolved=True
) )
# add metrics to metrics extension # add metrics to metrics extension
new += 1 new += 1

1
lemur/plugins/lemur_acme/dyn.py
View File

@ -142,7 +142,6 @@ def delete_txt_record(change_id, account_number, domain, token):
try: try:
all_txt_records = node.get_all_records_by_type('TXT') all_txt_records = node.get_all_records_by_type('TXT')
except DynectGetError: except DynectGetError:
sentry.captureException()
metrics.send('delete_txt_record_geterror', 'counter', 1) metrics.send('delete_txt_record_geterror', 'counter', 1)
# No Text Records remain or host is not in the zone anymore because all records have been deleted. # No Text Records remain or host is not in the zone anymore because all records have been deleted.
return return