Infra
/
lemur
5
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Raise ValidationError if CSR contains invalid CN 

If we supply a CSR that contains an empty field in the Subject, Lemur will crash with an error 500 as the ValueError exception is not captured. This change captures the exception and raises a ValidationError which in this case is a 400 sent back to client. Example to reproduce:

    Subject: C=ZZ, ST=Something, L=, O=My_Org, OU=My_Dept, CN=www.booking.com

The empty L= causes a ValueError which needs to be captured.
This commit is contained in:
Javier Ramos 2020-07-01 15:44:06 +02:00 committed by GitHub
parent 47946510d4
commit 7a5a5531cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lemur/common/validators.py
View File

@ -99,8 +99,12 @@ def csr(data):
raise ValidationError("CSR presented is not valid.") raise ValidationError("CSR presented is not valid.")
# Validate common name and SubjectAltNames # Validate common name and SubjectAltNames
try:
for name in request.subject.get_attributes_for_oid(NameOID.COMMON_NAME): for name in request.subject.get_attributes_for_oid(NameOID.COMMON_NAME):
common_name(name.value) common_name(name.value)
except ValueError as err:
current_app.logger.info("Error parsing Subject from CSR: %s", err)
raise ValidationError("Invalid Subject value in supplied CSR")
try: try:
alt_names = request.extensions.get_extension_for_class( alt_names = request.extensions.get_extension_for_class(