Return 'already deleted' instead of 'not found' when cert has already been deleted

2019-02-27 09:38:25 +01:00
parent a9735e129c
commit 63de8047ce
2 changed files with 5 additions and 2 deletions
--- a/lemur/certificates/views.py
+++ b/lemur/certificates/views.py
@ -691,9 +691,12 @@ class Certificates(AuthenticatedResource):

        cert = service.get(certificate_id)

-        if not cert or cert.deleted:
+        if not cert:
            return dict(message="Cannot find specified certificate"), 404

+        if cert.deleted:
+            return dict(message="Certificate is already deleted"), 412
+
        # allow creators
        if g.current_user != cert.user:
            owner_role = role_service.get_by_name(cert.owner)