Fixing issue where we were seeing AWS API errors due to certificates not having private keys and could not be uploaded or 'synced'

This commit is contained in:
kevgliss 2016-01-07 13:42:46 -08:00
parent a0d50ef03a
commit 5482bbf4bd
2 changed files with 12 additions and 9 deletions

View File

@ -43,6 +43,7 @@ class AWSDestinationPlugin(DestinationPlugin):
# } # }
def upload(self, name, body, private_key, cert_chain, options, **kwargs): def upload(self, name, body, private_key, cert_chain, options, **kwargs):
if private_key:
try: try:
iam.upload_cert(find_value('accountNumber', options), name, body, private_key, cert_chain=cert_chain) iam.upload_cert(find_value('accountNumber', options), name, body, private_key, cert_chain=cert_chain)
except BotoServerError as e: except BotoServerError as e:
@ -52,6 +53,8 @@ class AWSDestinationPlugin(DestinationPlugin):
e = find_value('elb', options) e = find_value('elb', options)
if e: if e:
elb.attach_certificate(kwargs['accountNumber'], ['region'], e['name'], e['port'], e['certificateId']) elb.attach_certificate(kwargs['accountNumber'], ['region'], e['name'], e['port'], e['certificateId'])
else:
raise Exception("Unable to upload to AWS, private key is required")
class AWSSourcePlugin(SourcePlugin): class AWSSourcePlugin(SourcePlugin):

View File

@ -76,7 +76,7 @@ def sync(labels=None):
if source.label not in labels: if source.label not in labels:
continue continue
current_app.logger.error("Retrieving certificates from {0}".format(source.label)) current_app.logger.debug("Retrieving certificates from {0}".format(source.label))
s = plugins.get(source.plugin_name) s = plugins.get(source.plugin_name)
certificates = s.get_certificates(source.options) certificates = s.get_certificates(source.options)