Infra
/
lemur
5
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Handle revoke not implemented and add comments

This commit is contained in:
sayali 2020-12-02 18:07:36 -08:00
parent aecb222de5
commit 33bb17779d
1 changed files with 19 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lemur/certificates/views.py
View File

@ -1413,6 +1413,11 @@ class CertificateRevoke(AuthenticatedResource):
Host: example.com Host: example.com
Accept: application/json, text/javascript Accept: application/json, text/javascript
{
"crlReason": "affiliationChanged",
"comments": "Additional details if any"
}
**Example response**: **Example response**:
.. sourcecode:: http .. sourcecode:: http
@ -1422,12 +1427,13 @@ class CertificateRevoke(AuthenticatedResource):
Content-Type: text/javascript Content-Type: text/javascript
{ {
'id': 1 "id": 1
} }
:reqheader Authorization: OAuth token to authenticate :reqheader Authorization: OAuth token to authenticate
:statuscode 200: no error :statuscode 200: no error
:statuscode 403: unauthenticated :statuscode 403: unauthenticated or cert attached to LB
:statuscode 400: encountered error, more details in error message
""" """
cert = service.get(certificate_id) cert = service.get(certificate_id)
@ -1459,13 +1465,18 @@ class CertificateRevoke(AuthenticatedResource):
403, 403,
) )
try:
error_message = service.revoke(cert, data) error_message = service.revoke(cert, data)
log_service.create(g.current_user, "revoke_cert", certificate=cert) log_service.create(g.current_user, "revoke_cert", certificate=cert)
if error_message: if error_message:
return dict(message=f"Certificate (id:{cert.id}) is revoked - {error_message}"), 400 return dict(message=f"Certificate (id:{cert.id}) is revoked - {error_message}"), 400
return dict(id=cert.id) return dict(id=cert.id)
except NotImplementedError as ne:
return dict(message=f"Revoke is not implemented for issuer of this certificate"), 400
except Exception as e:
sentry.captureException()
return dict(message=f"Failed to revoke: {str(e)}"), 400
api.add_resource( api.add_resource(
CertificateRevoke, CertificateRevoke,