Infra
/
lemur
5
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add test for when there are no notifications on a certificate (#757)

This commit is contained in:
Michael Treacher 2017-04-25 02:04:49 +10:00 committed by kevgliss
parent f90076abe9
commit 1c295896e6
2 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lemur/notifications/messaging.py
View File

@ -131,10 +131,10 @@ def send_expiration_notifications(exclude):
else: else:
failure += 1 failure += 1
if send_notification('expiration', security_data, security_email, notification): if send_notification('expiration', security_data, security_email, notification):
success += 1 success += 1
else: else:
failure += 1 failure += 1
return success, failure return success, failure

9
lemur/tests/test_messaging.py
View File

@ -74,6 +74,15 @@ def test_send_expiration_notification(certificate, notification, notification_pl
assert send_expiration_notifications([]) == (2, 0) assert send_expiration_notifications([]) == (2, 0)
@mock_ses
def test_send_expiration_notification_with_no_notifications(certificate, notification, notification_plugin):
from lemur.notifications.messaging import send_expiration_notifications
delta = certificate.not_after - timedelta(days=10)
with freeze_time(delta.datetime):
assert send_expiration_notifications([]) == (0, 0)
@mock_ses @mock_ses
def test_send_rotation_notification(notification_plugin, certificate): def test_send_rotation_notification(notification_plugin, certificate):
from lemur.notifications.messaging import send_rotation_notification from lemur.notifications.messaging import send_rotation_notification