fix(node): changing statefulset name here is a bad idea

now when you include this project you can change then service and statefulset name from
the valkey-env configMap

components/node/kustomization.yaml

@@ -1,44 +0,0 @@
-apiVersion: kustomize.config.k8s.io/v1alpha1
-kind: Component
-
-resources:
-- resources/sa.yaml
-- resources/statefulset.yaml
-- resources/svc.yaml
-
-configMapGenerator:
-#- name: valkey-env
-#  literals:
-#  - NAMESPACE="default"
-#  - VALKEY_ENV="base"
-#  - VALKEY_NAME="valkey-node"
-#  - VALKEY_SERVICE="valkey-node"
-#  - VALKEY_HEADLESS_SERVICE="valkey-node-headless"
-#  - VALKEY_MASTER_NAME="mymaster"
-#  - VALKEY_REPLICAS="4"
-#  - VALKEY_PORT="6379"
-#  - VALKEY_SENTINEL_PORT="26379"
-#  - ALLOW_EMPTY_PASSWORD="yes"
-#  - VALKEY_TLS_ENABLED="no"
-#  - VALKEY_SENTINEL_TLS_ENABLED="no"
-#  - VALKEY_DATA_DIR="/data"
-#  - VALKEY_LOG_LEVEL="warning"
-#  - VALKEY_QUORUM="2"
-- name: valkey-config
-  files:
-  - files/conf/replication.conf.tpl
-  - files/conf/sentinel.conf.tpl
-- name: valkey-scripts
-  files:
-  - files/scripts/common.sh
-  - files/scripts/startSentinel.sh
-  - files/scripts/pre-stop.sh
-  - files/scripts/pre-stop-sentinel.sh
-  - files/scripts/start-node.sh
-  - files/scripts/ping-sentinel.sh
-  - files/scripts/liveness-local.sh
-  - files/scripts/readiness-local.sh
-
-replacements:
-- path: replacements/service.yaml
-- path: replacements/statefulset.yaml

components/node/replacements/service.yaml

@@ -1,17 +0,0 @@
-- source:
-    kind: ConfigMap
-    name: valkey-env
-    fieldPath: data.VALKEY_SERVICE
-  targets:
-  - select:
-      kind: Service
-      name: valkey-headless
-    fieldPaths:
-    - metadata.labels.app
-    - spec.selector.app
-  - select:
-      kind: Service
-      name: valkey
-    fieldPaths:
-    - metadata.labels.app
-    - spec.selector.app

components/node/replacements/statefulset.yaml

@@ -1,12 +0,0 @@
-- source:
-    kind: ConfigMap
-    name: valkey-env
-    fieldPath: data.VALKEY_SERVICE
-  targets:
-  - select:
-      kind: StatefulSet
-      name: valkey-node
-    fieldPaths:
-    - metadata.labels.app
-    - spec.selector.matchLabels.app
-    - spec.template.metadata.labels.app

kustomization.yaml

@@ -1,5 +1,5 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 
-components:
+resources:
 - resources/node

misc/docker/Dockerfile

@@ -1,5 +1,5 @@
 # Base image
-FROM golang:tip-alpine3.22 AS builder
+FROM golang:tip-alpine3.21 AS builder
 
 # Set directory to known value
 WORKDIR /app
@@ -14,7 +14,7 @@ RUN git clone https://github.com/coveooss/gotemplate.git . && \
     CGO_ENABLED=0 go build
 
 
-FROM alpine:3.22
+FROM alpine:3.21
 #
 COPY --from=builder /app/gotemplate /gotemplate
 COPY --from=builder /usr/bin/valkey-cli /valkey-cli

misc/tests/kustomization.yaml

@@ -1,7 +0,0 @@
-apiVersion: kustomize.config.k8s.io/v1beta1
-kind: Kustomization
-
-resources:
-- resources/namespace.yaml
-- resources/vlone
-- resources/vltwo

misc/tests/resources/namespace.yaml

@@ -1,4 +0,0 @@
-apiVersion: v1
-kind: Namespace
-metadata:
-  name: vltest

misc/tests/resources/vlone/kustomization.yaml

@@ -1,25 +0,0 @@
-apiVersion: kustomize.config.k8s.io/v1beta1
-kind: Kustomization
-namePrefix: vlone-
-
-components:
-- https://forge.cadoles.com/CadolesKube/valkey-kustom//components/node
-
-configMapGenerator:
-- name: valkey-env
-  literals:
-  - NAMESPACE="vltest"
-  - VALKEY_ENV="vltest"
-  - VALKEY_NAME="vlone-valkey-node"
-  - VALKEY_SERVICE="vlone-valkey"
-  - VALKEY_HEADLESS_SERVICE="vlone-valkey-headless"
-  - VALKEY_MASTER_NAME="mymaster"
-  - VALKEY_REPLICAS="6"
-  - VALKEY_PORT="6379"
-  - VALKEY_SENTINEL_PORT="26379"
-  - ALLOW_EMPTY_PASSWORD="yes"
-  - VALKEY_TLS_ENABLED="no"
-  - VALKEY_SENTINEL_TLS_ENABLED="no"
-  - VALKEY_DATA_DIR="/data"
-  - VALKEY_LOG_LEVEL="warning"
-  - VALKEY_QUORUM="2"

misc/tests/resources/vlone/replacements/statefulset.yaml

@@ -1,31 +0,0 @@
-- source:
-    kind: ConfigMap
-    name: vlone
-    fieldPath: data.VALKEY_NAME
-  targets:
-  - select:
-      kind: StatefulSet
-      name: valkey-node
-    fieldPaths:
-    - metadata.name
-- source:
-    kind: ConfigMap
-    name: vlone
-    fieldPath: data.VALKEY_ENV_NAME
-  targets:
-  - select:
-      kind: StatefulSet
-      name: valkey-node
-      fieldPaths:
-      - spec.template.spec.containers[*].envFrom[0].configMapRef.name
-      - spec.template.spec.initContainers[*].envFrom[0].configMapRef.name
-- source:
-    kind: ConfigMap
-    name: vlone
-    fieldPath: data.VALKEY_CONF_NAME
-  targets:
-  - select:
-      kind: StatefulSet
-      name: valkey-node
-      fieldPaths:
-      - spec.template.spec.initContainers[*].volumeMounts[valkey-config].name

misc/tests/resources/vltwo/kustomization.yaml

@@ -1,25 +0,0 @@
-apiVersion: kustomize.config.k8s.io/v1beta1
-kind: Kustomization
-namePrefix: vltwo-
-
-components:
-- https://forge.cadoles.com/CadolesKube/valkey-kustom//components/node
-
-configMapGenerator:
-- name: valkey-env
-  literals:
-  - NAMESPACE="vltest"
-  - VALKEY_ENV="vltest"
-  - VALKEY_NAME="vltwo-valkey-node"
-  - VALKEY_SERVICE="vltwo-valkey"
-  - VALKEY_HEADLESS_SERVICE="vltwo-valkey-headless"
-  - VALKEY_MASTER_NAME="vltwomaster"
-  - VALKEY_REPLICAS="4"
-  - VALKEY_PORT="6379"
-  - VALKEY_SENTINEL_PORT="26379"
-  - ALLOW_EMPTY_PASSWORD="yes"
-  - VALKEY_TLS_ENABLED="no"
-  - VALKEY_SENTINEL_TLS_ENABLED="no"
-  - VALKEY_DATA_DIR="/data"
-  - VALKEY_LOG_LEVEL="warning"
-  - VALKEY_QUORUM="2"

misc/tests/resources/vltwo/replacements/services.yaml

@@ -1,20 +0,0 @@
-- source:
-    kind: ConfigMap
-    name: vltwo
-    fieldPath: data.VALKEY_HEADLESS_SERVICE
-  targets:
-  - select:
-      kind: Service
-      name: valkey-headless
-    fieldPaths:
-    - metadata.name
-- source:
-    kind: ConfigMap
-    name: vltwo
-    fieldPath: data.VALKEY_SERVICE
-  targets:
-  - select:
-      kind: Service
-      name: valkey
-    fieldPaths:
-    - metadata.name

misc/tests/resources/vltwo/replacements/statefulset.yaml

@@ -1,31 +0,0 @@
-- source:
-    kind: ConfigMap
-    name: vltwo
-    fieldPath: data.VALKEY_NAME
-  targets:
-  - select:
-      kind: StatefulSet
-      name: valkey-node
-    fieldPaths:
-    - metadata.name
-- source:
-    kind: ConfigMap
-    name: vltwo
-    fieldPath: data.VALKEY_ENV_NAME
-  targets:
-  - select:
-      kind: StatefulSet
-      name: valkey-node
-      fieldPaths:
-      - spec.template.spec.containers[*].envFrom[0].configMapRef.name
-      - spec.template.spec.initContainers[*].envFrom[0].configMapRef.name
-- source:
-    kind: ConfigMap
-    name: vltwo
-    fieldPath: data.VALKEY_CONF_NAME
-  targets:
-  - select:
-      kind: StatefulSet
-      name: valkey-node
-      fieldPaths:
-      - spec.template.spec.initContainers[*].volumeMounts[valkey-config].name

resources/node/files/conf/sentinel.conf.tpl

@@ -9,13 +9,12 @@
 {{- $fqdn := printf "%s.%s" $hostname $domain }}
 {{- $hostid := sha1sum $hostname }}
 {{- $quorum := env "VALKEY_QUORUM" }}
-{{- $master_name := env "VALKEY_MASTER_NAME" }}
 #-REPLICAS:{{ $replicas }}
 
 dir "/tmp"
 port {{ $sentinel_port }}
-sentinel monitor {{ $master_name }} SENTINEL_MASTER {{ $port }} {{ $quorum }}
-sentinel down-after-milliseconds {{ $master_name }} 60000
+sentinel monitor mymaster SENTINEL_MASTER {{ $port }} {{ $quorum }}
+sentinel down-after-milliseconds mymaster 60000
 
 # User-supplied sentinel configuration:
 # End of sentinel configuration
@@ -33,17 +32,16 @@ protected-mode no
 # gotemplate-pause!
 user default on nopass sanitize-payload ~* &* +@all
 # gotemplate-resume!
-sentinel config-epoch {{ $master_name }} 0
-sentinel leader-epoch {{ $master_name }} 0
+sentinel config-epoch mymaster 0
+sentinel leader-epoch mymaster 0
 sentinel current-epoch 0
 
 {{- range $i, $e := until ( int $replicas ) }}
-  {{- $masterName := printf "%s" $master_name}}
   {{- $ndeHostname := printf "%s-%d" $name $i }}
   {{- $ndeFQDN := printf "%s.%s" $ndeHostname $domain }}
   {{- $nodeID := sha1sum $ndeHostname }}
   {{- if (ne $fqdn $ndeFQDN) }}
-sentinel {{ printf "known-sentinel %s %s %s %s" $masterName $ndeFQDN $sentinel_port $nodeID }}
-sentinel {{ printf "known-replica %s %s %s" $masterName $ndeFQDN $port }}
+sentinel {{ printf "known-sentinel mymaster %s %s %s" $ndeFQDN $sentinel_port $nodeID }}
+sentinel {{ printf "known-replica mymaster %s %s" $ndeFQDN $port }}
   {{- end}}
 {{- end}}

resources/node/files/scripts/common.sh

@@ -15,30 +15,8 @@ pingSentinel() {
 }
 
 getPrimaryInfo() {
-    masterName=${VALKEY_MASTER_NAME:-"mymaster"}
-    it="${1:-0}"
-
-    info=$(valkey-cli --csv -h ${VALKEY_HEADLESS_SERVICE} -p ${VALKEY_SENTINEL_PORT} sentinel get-primary-addr-by-name "${masterName}"| \
-        awk -F ',' '{ gsub(/"/,"",$0); print $1 " " $2 }')
-
-    if [ -z "${info}" ]; then
-        echo "Failed to get primary info for master '${masterName}'"
-        it=$((it + 1))
-        getPrimaryInfo ${it}
-        if [ ${it} -ge 10 ]; then
-            echo "Failed to get primary info after 5 attempts"
-            return 1
-        fi
-    fi
-    if [[ "${info}" =~ /^NULL/ ]]; then
-        it=$((it + 1))
-        getPrimaryInfo ${it}
-        if [ ${it} -ge 10 ]; then
-            echo "Failed to get primary info after 5 attempts"
-            return 1
-        fi
-    fi
-    echo "${info}"
+    valkey-cli --csv -h ${VALKEY_HEADLESS_SERVICE} -p ${VALKEY_SENTINEL_PORT} sentinel get-primary-addr-by-name "mymaster"| \
+        awk -F ',' '{ gsub(/"/,"",$0); print $1 " " $2 }'
     return ${?}
 }
 

resources/node/files/scripts/pre-stop.sh

@@ -15,8 +15,7 @@ vcli-sentinel() {
 getFailOverStatus() {
     # Check if the failover is finished
     local failoverStatus
-    sentinelMasterName="${VALKEY_MASTER_NAME:-"mymaster"}"
-    primaryInfo=$(vcli-sentinel get-primary-addr-by-name "${sentinelMasterName}")
+    primaryInfo=$(vcli-sentinel get-primary-addr-by-name "mymaster")
     primaryHost=$(echo ${primaryInfo} | awk -F ' ' '{print $1}')
     currentHost=$(hostname -f)
     if [[ "${primaryHost}" != "${currentHost}" ]]; then
@@ -45,13 +44,12 @@ isPrimary() {
 }
 
 if isPrimary && ! getFailOverStatus; then
-    sentinelMasterName="${VALKEY_MASTER_NAME}"
     echo "I'm the primary and you are stopping me, pausing client connections"
     #Pausing write connections to avoid data loss"
     vcli CLIENT PAUSE "22000" WRITE
 
     echo "Starting failover"
-    vcli-sentinel failover "${sentinelMasterName}"
+    vcli-sentinel failover "mymaster"
     echo "Waiting for sentinel to complete failover for up to 120s"
     tmout=120
     while true ; do

resources/node/files/scripts/start-node.sh

@@ -12,8 +12,7 @@ pingSentinel() {
 }
 
 getPrimaryInfo() {
-    sentinelMasterName="${VALKEY_MASTER_NAME:-"mymaster"}"
-    valkey-cli -t 15 --csv -h ${VALKEY_HEADLESS_SERVICE} -p ${VALKEY_SENTINEL_PORT} sentinel get-primary-addr-by-name "${sentinelMasterName}"| \
+    valkey-cli -t 15 --csv -h ${VALKEY_HEADLESS_SERVICE} -p ${VALKEY_SENTINEL_PORT} sentinel get-primary-addr-by-name "mymaster"| \
         awk -F ',' '{ gsub(/"/,"",$0); print $1 " " $2 }'
     return ${?}
 }
@@ -81,17 +80,12 @@ else
     echo "Primary host is : ${primaryHost}, port: ${primaryPort}"
     currentHost=$(hostname -f)
     echo "Current host is : ${currentHost}"
-    if [ "${primaryHost}" = "NULL" ]; then
-        echo "Not primary yet, starting as primary"
-        startPrimary=1
+    if [ "${primaryHost}" != "${currentHost}" ]; then
+        echo "Not the primary, setting up as replica"
+        startPrimary=0
     else
-        if [ "${primaryHost}" != "${currentHost}" ]; then
-            echo "Not the primary, setting up as replica"
-            startPrimary=0
-        else
-            echo "This is the primary"
-            startPrimary=1
-        fi
+        echo "This is the primary"
+        startPrimary=1
     fi
 fi
 

resources/node/kustomization.yaml

@@ -0,0 +1,43 @@
+apiVersion: kustomize.config.k8s.io/v1beta1
+kind: Kustomization
+
+resources:
+- resources/sa.yaml
+- resources/statefulset.yaml
+- resources/svc.yaml
+
+configMapGenerator:
+- name: valkey-env
+  literals:
+  - NAMESPACE="default"
+  - VALKEY_ENV="base"
+  - VALKEY_NAME="valkey-node"
+  - VALKEY_SERVICE="valkey-node"
+  - VALKEY_HEADLESS_SERVICE="valkey-node-headless"
+  - VALKEY_REPLICAS="4"
+  - VALKEY_PORT="6379"
+  - VALKEY_SENTINEL_PORT="26379"
+  - ALLOW_EMPTY_PASSWORD="yes"
+  - VALKEY_TLS_ENABLED="no"
+  - VALKEY_SENTINEL_TLS_ENABLED="no"
+  - VALKEY_DATA_DIR="/data"
+  - VALKEY_LOG_LEVEL="warning"
+  - VALKEY_QUORUM="2"
+- name: valkey-config
+  files:
+  - files/conf/replication.conf.tpl
+  - files/conf/sentinel.conf.tpl
+- name: valkey-scripts
+  files:
+  - files/scripts/common.sh
+  - files/scripts/startSentinel.sh
+  - files/scripts/pre-stop.sh
+  - files/scripts/pre-stop-sentinel.sh
+  - files/scripts/start-node.sh
+  - files/scripts/ping-sentinel.sh
+  - files/scripts/liveness-local.sh
+  - files/scripts/readiness-local.sh
+
+replacements:
+- path: ./replacements/services.yaml
+- path: ./replacements/statefulset.yaml

resources/node/replacements/services.yaml

@@ -1,6 +1,6 @@
 - source:
     kind: ConfigMap
-    name: vlone
+    name: valkey-env
     fieldPath: data.VALKEY_HEADLESS_SERVICE
   targets:
   - select:
@@ -10,7 +10,7 @@
     - metadata.name
 - source:
     kind: ConfigMap
-    name: vlone
+    name: valkey-env
     fieldPath: data.VALKEY_SERVICE
   targets:
   - select:

resources/node/replacements/statefulset.yaml

@@ -0,0 +1,20 @@
+- source:
+    kind: ConfigMap
+    name: valkey-env
+    fieldPath: data.VALKEY_REPLICAS
+  targets:
+  - select:
+      kind: StatefulSet
+      name: valkey-node
+    fieldPaths:
+    - spec.replicas
+- source:
+    kind: ConfigMap
+    name: valkey-env
+    fieldPath: data.VALKEY_HEADLESS_SERVICE
+  targets:
+  - select:
+      kind: StatefulSet
+      name: valkey-node
+    fieldPaths:
+    - spec.serviceName

resources/node/resources/statefulset.yaml

@@ -2,13 +2,12 @@ apiVersion: apps/v1
 kind: StatefulSet
 metadata:
   labels:
-    app: CHANGE_ME
     app.kubernetes.io/component: node
     app.kubernetes.io/instance: valkey
     app.kubernetes.io/managed-by: kustomize
     app.kubernetes.io/name: valkey
     app.kubernetes.io/part-of: valkey
-    app.kubernetes.io/version: 8.1.3
+    app.kubernetes.io/version: 8.1.1
   name: valkey-node
 spec:
   persistentVolumeClaimRetentionPolicy:
@@ -24,19 +23,17 @@ spec:
       app.kubernetes.io/component: node
       app.kubernetes.io/instance: valkey
       app.kubernetes.io/name: valkey
-      app: CHANGE_ME
   serviceName: valkey-headless
   updateStrategy:
     type: RollingUpdate
   template:
     metadata:
       labels:
-        app: CHANGE_ME
         app.kubernetes.io/component: node
         app.kubernetes.io/instance: valkey
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: valkey
-        app.kubernetes.io/version: 8.1.3
+        app.kubernetes.io/version: 8.1.1
         helm.sh/chart: valkey-3.0.7
     spec:
       shareProcessNamespace: true
@@ -110,7 +107,7 @@ spec:
           name: valkey-data
       containers:
       - name: valkey
-        image: reg.cadoles.com/dh/valkey/valkey:8.1.3-alpine3.22
+        image: reg.cadoles.com/dh/valkey/valkey:8.1.1-alpine3.21
         command:
         - /opt/scripts/start-node.sh
         args:
@@ -197,7 +194,7 @@ spec:
         - mountPath: /data
           name: valkey-data
       - name: sentinel
-        image: reg.cadoles.com/dh/valkey/valkey:8.1.3-alpine3.22
+        image: reg.cadoles.com/dh/valkey/valkey:8.1.1-alpine3.21
         imagePullPolicy: IfNotPresent
         command:
         - /opt/scripts/startSentinel.sh
@@ -291,8 +288,8 @@ spec:
         runAsGroup: 1001
         fsGroup: 1001
         fsGroupChangePolicy: Always
-      #serviceAccount: valkey
-      #serviceAccountName: valkey
+      serviceAccount: valkey
+      serviceAccountName: valkey
       terminationGracePeriodSeconds: 30
       volumes:
       - name: valkey-scripts
@@ -323,6 +320,9 @@ spec:
       resources:
         requests:
           storage: 8Gi
+      volumeMode: Filesystem
+    status:
+      phase: Pending
   - apiVersion: v1
     kind: PersistentVolumeClaim
     metadata:
@@ -338,3 +338,6 @@ spec:
       resources:
         requests:
           storage: 32Mi
+      volumeMode: Filesystem
+    status:
+      phase: Pending

resources/node/resources/svc.yaml

@@ -2,7 +2,6 @@ apiVersion: v1
 kind: Service
 metadata:
   labels:
-    app: CHANGE_ME
     app.kubernetes.io/component: node
     app.kubernetes.io/instance: valkey
     app.kubernetes.io/managed-by: kustomize
@@ -21,7 +20,6 @@ spec:
     protocol: TCP
     targetPort: 26379
   selector:
-    app: CHANGE_ME
     app.kubernetes.io/component: node
     app.kubernetes.io/instance: valkey
     app.kubernetes.io/name: valkey
@@ -30,11 +28,10 @@ apiVersion: v1
 kind: Service
 metadata:
   labels:
-    app: CHANGE_ME
     app.kubernetes.io/component: node
     app.kubernetes.io/instance: valkey
     app.kubernetes.io/managed-by: kustomize
-    app.kubernetes.io/name: valkey-headless
+    app.kubernetes.io/name: valkey
     app.kubernetes.io/part-of: valkey
     app.kubernetes.io/version: 8.1.1
   name: valkey-headless
@@ -51,6 +48,5 @@ spec:
     targetPort: valkey-sentinel
   publishNotReadyAddresses: true
   selector:
-    app: CHANGE_ME
     app.kubernetes.io/instance: valkey
     app.kubernetes.io/name: valkey