Cadoles/mktools
22
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases 3 Wiki Activity

fix(install): don't use option '-e' for builtin echo #3

Open
lgourvenec wants to merge 1 commits from fix_-e_in_gitignore into master
pull from: fix_-e_in_gitignore
merge into: Cadoles:master
Conversation 1 Commits 1 Files Changed 1 +2 -2
lgourvenec commented 2025-05-28 15:27:31 +02:00
Owner
Copy Link

echo is often a builtin and '-e' is not an option for sh.
sh is the default shell for gnu make (variable "SHELL") -> this leads to an
extra "-e" in .gitignore

echo is often a builtin and '-e' is not an option for sh. sh is the default shell for gnu make (variable "SHELL") -> this leads to an extra "-e" in .gitignore
lgourvenec added 1 commit 2025-05-28 15:27:32 +02:00
fix(install): don't use option '-e' for builtin echo
All checks were successful
Cadoles/mktools/pipeline/head This commit looks good
Details
Cadoles/mktools/pipeline/pr-master This commit looks good
Details
0a3d5add48 
echo is often a builtin and '-e' is not an option for sh.
sh is the default shell for gnu make (variable "SHELL") -> this leads to an
extra "-e" in .gitignore
jenkins commented 2025-05-28 15:31:24 +02:00
Owner
Copy Link

Test report for 0a3d5ad

Output 
mkdir -p tools/checkmake/bin
grep -qF -- "tools/" ".gitignore" 2>/dev/null || echo "tools/" >> ".gitignore"
curl -sL -o tools/checkmake/bin/checkmake  "https://github.com/mrtazz/checkmake/releases/download/0.2.2/checkmake-0.2.2.linux.amd64"
chmod +x tools/checkmake/bin/checkmake
tools/checkmake/bin/checkmake Makefile
# Test report for 0a3d5ad <details open> <summary>Output</summary> ``` mkdir -p tools/checkmake/bin grep -qF -- "tools/" ".gitignore" 2>/dev/null || echo "tools/" >> ".gitignore" curl -sL -o tools/checkmake/bin/checkmake "https://github.com/mrtazz/checkmake/releases/download/0.2.2/checkmake-0.2.2.linux.amd64" chmod +x tools/checkmake/bin/checkmake tools/checkmake/bin/checkmake Makefile ``` </details>
All checks were successful
Cadoles/mktools/pipeline/head This commit looks good
Details
Cadoles/mktools/pipeline/pr-master This commit looks good
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix_-e_in_gitignore:fix_-e_in_gitignore
git checkout fix_-e_in_gitignore
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aardouin AdminInfra afornerot bbohard bgaude cmsassot crappeneau gdupont idargaud jenkins kipp lfornerot lgourvenec lseys mlamalle pcaseiro rmasson tcornaut vcarroy vfebvre wpetit yszemro
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Cadoles/mktools#3
No description provided.
Delete Branch "fix_-e_in_gitignore"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?