complément logs et exceptions #20

Merged
mlamalle merged 4 commits from issue-19 into develop 2024-04-29 11:33:17 +02:00
Owner
Q             A
Bug fixe?     [x] oui [ ] non
Nouvelle fonctionnalié?  [ ] oui [x] non
Dépréciations? [ ] oui [x] non
Modification schéma BDD [ ] oui [x] non
Modification configuration [ ] oui [x] non
Ticket(s)     #19

Ajout de logs en cas d'exception PDOException cacthée avec LoggerInterface pour obtenir le message d'erreur précis dans la console.
Création d'exceptions pour différencier les différentes erreurs PDO possible, notamment différencier la connection à la bdd des erreur de configuration comme par exemple une colonne demandée qui n'existe pas.

##Test

mettre dans le .env.local la valeur de PEPPER indiquée dans le README
docker compose up
http://localhost:8000

Faire une première connexion pour valider le fonctionnement

Pour chaque modification suivante, faire un test de connexion et vérifier qu'un message compréhensible est visible.

ensuite modifier des valeurs dans le fichier de configuration config/sql_login_configuration/sql_login.yaml

  • remplacer email par mail
  • supprimer le contenu de salt
  • modifier le contenu de salt par autre chose
  • dans data_to_fetch, ajouter une entré avec un nom au hasard qui n'existe pas dans la bdd ou modifier un de ceux inscrits

Dans le .env, modifier le DSN de connexion à la bdd pour créer un problème.

| Q             | A | ------------- | --- | Bug fixe?     | [x] oui [ ] non | Nouvelle fonctionnalié? |  [ ] oui [x] non | Dépréciations? | [ ] oui [x] non | Modification schéma BDD | [ ] oui [x] non | Modification configuration | [ ] oui [x] non | Ticket(s)     | #19 Ajout de logs en cas d'exception PDOException cacthée avec LoggerInterface pour obtenir le message d'erreur précis dans la console. Création d'exceptions pour différencier les différentes erreurs PDO possible, notamment différencier la connection à la bdd des erreur de configuration comme par exemple une colonne demandée qui n'existe pas. ##Test mettre dans le .env.local la valeur de PEPPER indiquée dans le README docker compose up http://localhost:8000 Faire une première connexion pour valider le fonctionnement Pour chaque modification suivante, faire un test de connexion et vérifier qu'un message compréhensible est visible. ensuite modifier des valeurs dans le fichier de configuration config/sql_login_configuration/sql_login.yaml * remplacer `email` par `mail` * supprimer le contenu de `salt` * modifier le contenu de `salt` par autre chose * dans data_to_fetch, ajouter une entré avec un nom au hasard qui n'existe pas dans la bdd ou modifier un de ceux inscrits Dans le .env, modifier le DSN de connexion à la bdd pour créer un problème.
rmasson added 2 commits 2023-06-19 16:11:02 +02:00
issue-19: ajout de logs des exceptions PDOExceptions
All checks were successful
Cadoles/hydra-sql/pipeline/head This commit looks good
fe5ca83664
issue-19: séparation des exceptions pour éviter les erreurs génériques, message personalisé par type d'erreur
All checks were successful
Cadoles/hydra-sql/pipeline/head This commit looks good
Cadoles/hydra-sql/pipeline/pr-develop This commit looks good
d056b1feac
Owner

Symfony Security Check Report

No packages have known vulnerabilities.

Note that this checker can only detect vulnerabilities that are referenced in the security advisories database.
Execute this command regularly to check the newly discovered vulnerabilities.

Symfony Security Check Report ============================= No packages have known vulnerabilities. Note that this checker can only detect vulnerabilities that are referenced in the security advisories database. Execute this command regularly to check the newly discovered vulnerabilities.
Owner

Test report

PHP CS Fixer

Overview

State Total
Passed 0
Skipped 0
Failed 8
Error 0

Total duration: 0s

See details
Status Name Class
Cadoles_hydra-sql_PR-20/src/SQLLogin/SQLLoginRequest
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/LoginElementsConfigurationException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DataToFetchConfigurationException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DatabaseConnectionException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/SecurityPatternConfigurationException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullPasswordColumnNameException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullDataToFetchException
Cadoles_hydra-sql_PR-20/src/Service/SQLLoginService

Errors

`Cadoles_hydra-sql_PR-20/src/SQLLogin/SQLLoginRequest`

Output

applied fixers:
---------------
* no_unused_imports```

</details>


<details>
  <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/LoginElementsConfigurationException`</summary>

**Output** 

applied fixers:

  • global_namespace_import
  • no_unused_imports
  • no_extra_blank_lines```
`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DataToFetchConfigurationException`

Output

applied fixers:
---------------
* global_namespace_import
* no_unused_imports
* no_extra_blank_lines```

</details>


<details>
  <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DatabaseConnectionException`</summary>

**Output** 

applied fixers:

  • global_namespace_import
  • no_unused_imports
  • no_extra_blank_lines```
`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/SecurityPatternConfigurationException`

Output

applied fixers:
---------------
* global_namespace_import
* no_unused_imports
* no_extra_blank_lines```

</details>


<details>
  <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullPasswordColumnNameException`</summary>

**Output** 

applied fixers:

  • global_namespace_import
  • no_unused_imports
  • no_extra_blank_lines```
`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullDataToFetchException`

Output

applied fixers:
---------------
* global_namespace_import
* no_unused_imports
* no_extra_blank_lines```

</details>


<details>
  <summary>`Cadoles_hydra-sql_PR-20/src/Service/SQLLoginService`</summary>

**Output** 

applied fixers:

  • global_namespace_import
  • no_unused_imports```
# Test report ## PHP CS Fixer ### Overview | State | Total | |-------|-------| | Passed | 0 | | Skipped | 0 | | Failed | 8 | | Error | 0 | **Total duration**: 0s <details> <summary>See details</summary> | Status | Name | Class | |--------|------|-------| | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/SQLLoginRequest` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/LoginElementsConfigurationException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DataToFetchConfigurationException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DatabaseConnectionException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/SecurityPatternConfigurationException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullPasswordColumnNameException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullDataToFetchException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/Service/SQLLoginService` || </details> <br /> #### Errors <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/SQLLoginRequest`</summary> **Output** ``` applied fixers: --------------- * no_unused_imports``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/LoginElementsConfigurationException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DataToFetchConfigurationException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DatabaseConnectionException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/SecurityPatternConfigurationException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullPasswordColumnNameException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullDataToFetchException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/Service/SQLLoginService`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports``` </details>
Owner

Rapport PHPStan


 [OK] No errors                                                                 


## Rapport PHPStan ``` [OK] No errors ```
rmasson changed title from issue-19 to complément logs et exceptions 2023-06-19 16:17:13 +02:00
rmasson force-pushed issue-19 from d056b1feac to cdecc0b695 2023-06-19 16:21:59 +02:00 Compare
Owner

Symfony Security Check Report

No packages have known vulnerabilities.

Note that this checker can only detect vulnerabilities that are referenced in the security advisories database.
Execute this command regularly to check the newly discovered vulnerabilities.

Symfony Security Check Report ============================= No packages have known vulnerabilities. Note that this checker can only detect vulnerabilities that are referenced in the security advisories database. Execute this command regularly to check the newly discovered vulnerabilities.
Owner

Test report

PHP CS Fixer

Overview

State Total
Passed 0
Skipped 0
Failed 7
Error 0

Total duration: 0s

See details
Status Name Class
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/LoginElementsConfigurationException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DataToFetchConfigurationException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DatabaseConnectionException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/SecurityPatternConfigurationException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullPasswordColumnNameException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullDataToFetchException
Cadoles_hydra-sql_PR-20/src/Service/SQLLoginService

Errors

`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/LoginElementsConfigurationException`

Output

applied fixers:
---------------
* global_namespace_import
* no_unused_imports
* no_extra_blank_lines```

</details>


<details>
  <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DataToFetchConfigurationException`</summary>

**Output** 

applied fixers:

  • global_namespace_import
  • no_unused_imports
  • no_extra_blank_lines```
`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DatabaseConnectionException`

Output

applied fixers:
---------------
* global_namespace_import
* no_unused_imports
* no_extra_blank_lines```

</details>


<details>
  <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/SecurityPatternConfigurationException`</summary>

**Output** 

applied fixers:

  • global_namespace_import
  • no_unused_imports
  • no_extra_blank_lines```
`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullPasswordColumnNameException`

Output

applied fixers:
---------------
* global_namespace_import
* no_unused_imports
* no_extra_blank_lines```

</details>


<details>
  <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullDataToFetchException`</summary>

**Output** 

applied fixers:

  • global_namespace_import
  • no_unused_imports
  • no_extra_blank_lines```
`Cadoles_hydra-sql_PR-20/src/Service/SQLLoginService`

Output

applied fixers:
---------------
* global_namespace_import
* no_unused_imports```

</details>





# Test report ## PHP CS Fixer ### Overview | State | Total | |-------|-------| | Passed | 0 | | Skipped | 0 | | Failed | 7 | | Error | 0 | **Total duration**: 0s <details> <summary>See details</summary> | Status | Name | Class | |--------|------|-------| | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/LoginElementsConfigurationException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DataToFetchConfigurationException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DatabaseConnectionException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/SecurityPatternConfigurationException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullPasswordColumnNameException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullDataToFetchException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/Service/SQLLoginService` || </details> <br /> #### Errors <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/LoginElementsConfigurationException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DataToFetchConfigurationException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DatabaseConnectionException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/SecurityPatternConfigurationException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullPasswordColumnNameException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullDataToFetchException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/Service/SQLLoginService`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports``` </details>
Owner

Rapport PHPStan


 [OK] No errors                                                                 


## Rapport PHPStan ``` [OK] No errors ```
rmasson force-pushed issue-19 from cdecc0b695 to 1e2491f9c6 2023-06-19 16:29:55 +02:00 Compare
Owner

Symfony Security Check Report

No packages have known vulnerabilities.

Note that this checker can only detect vulnerabilities that are referenced in the security advisories database.
Execute this command regularly to check the newly discovered vulnerabilities.

Symfony Security Check Report ============================= No packages have known vulnerabilities. Note that this checker can only detect vulnerabilities that are referenced in the security advisories database. Execute this command regularly to check the newly discovered vulnerabilities.
Owner

Test report

PHP CS Fixer

Overview

State Total
Passed 0
Skipped 0
Failed 7
Error 0

Total duration: 0s

See details
Status Name Class
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/LoginElementsConfigurationException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DataToFetchConfigurationException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DatabaseConnectionException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/SecurityPatternConfigurationException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullPasswordColumnNameException
Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullDataToFetchException
Cadoles_hydra-sql_PR-20/src/Service/SQLLoginService

Errors

`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/LoginElementsConfigurationException`

Output

applied fixers:
---------------
* global_namespace_import
* no_unused_imports
* no_extra_blank_lines```

</details>


<details>
  <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DataToFetchConfigurationException`</summary>

**Output** 

applied fixers:

  • global_namespace_import
  • no_unused_imports
  • no_extra_blank_lines```
`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DatabaseConnectionException`

Output

applied fixers:
---------------
* global_namespace_import
* no_unused_imports
* no_extra_blank_lines```

</details>


<details>
  <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/SecurityPatternConfigurationException`</summary>

**Output** 

applied fixers:

  • global_namespace_import
  • no_unused_imports
  • no_extra_blank_lines```
`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullPasswordColumnNameException`

Output

applied fixers:
---------------
* global_namespace_import
* no_unused_imports
* no_extra_blank_lines```

</details>


<details>
  <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullDataToFetchException`</summary>

**Output** 

applied fixers:

  • global_namespace_import
  • no_unused_imports
  • no_extra_blank_lines```
`Cadoles_hydra-sql_PR-20/src/Service/SQLLoginService`

Output

applied fixers:
---------------
* global_namespace_import
* no_unused_imports```

</details>





# Test report ## PHP CS Fixer ### Overview | State | Total | |-------|-------| | Passed | 0 | | Skipped | 0 | | Failed | 7 | | Error | 0 | **Total duration**: 0s <details> <summary>See details</summary> | Status | Name | Class | |--------|------|-------| | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/LoginElementsConfigurationException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DataToFetchConfigurationException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DatabaseConnectionException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/SecurityPatternConfigurationException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullPasswordColumnNameException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullDataToFetchException` || | &#10799; | `Cadoles_hydra-sql_PR-20/src/Service/SQLLoginService` || </details> <br /> #### Errors <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/LoginElementsConfigurationException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DataToFetchConfigurationException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/DatabaseConnectionException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/SecurityPatternConfigurationException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullPasswordColumnNameException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/SQLLogin/Exception/NullDataToFetchException`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * no_extra_blank_lines``` </details> <details> <summary>`Cadoles_hydra-sql_PR-20/src/Service/SQLLoginService`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports``` </details>
Owner

Rapport PHPStan


 [OK] No errors                                                                 


## Rapport PHPStan ``` [OK] No errors ```
Owner

Symfony Security Check Report

2 packages have known vulnerabilities.

symfony/security-http (v5.4.23)

symfony/twig-bridge (v5.4.22)

  • CVE-2023-46734: Potential XSS vulnerabilities in CodeExtension filters

Note that this checker can only detect vulnerabilities that are referenced in the security advisories database.
Execute this command regularly to check the newly discovered vulnerabilities.

Symfony Security Check Report ============================= 2 packages have known vulnerabilities. symfony/security-http (v5.4.23) ------------------------------- * [CVE-2023-46733][]: Possible session fixation symfony/twig-bridge (v5.4.22) ----------------------------- * [CVE-2023-46734][]: Potential XSS vulnerabilities in CodeExtension filters [CVE-2023-46733]: https://symfony.com/cve-2023-46733 [CVE-2023-46734]: https://symfony.com/cve-2023-46734 Note that this checker can only detect vulnerabilities that are referenced in the security advisories database. Execute this command regularly to check the newly discovered vulnerabilities.
Owner

Test report

PHP CS Fixer

Overview

State Total
Passed 0
Skipped 0
Failed 1
Error 0

Total duration: 0s

See details
Status Name Class
Cadoles_hydra-sql_PR-20/src/Controller/MainController

Errors

`Cadoles_hydra-sql_PR-20/src/Controller/MainController`

Output

applied fixers:
---------------
* class_attributes_separation```

</details>





# Test report ## PHP CS Fixer ### Overview | State | Total | |-------|-------| | Passed | 0 | | Skipped | 0 | | Failed | 1 | | Error | 0 | **Total duration**: 0s <details> <summary>See details</summary> | Status | Name | Class | |--------|------|-------| | &#10799; | `Cadoles_hydra-sql_PR-20/src/Controller/MainController` || </details> <br /> #### Errors <details> <summary>`Cadoles_hydra-sql_PR-20/src/Controller/MainController`</summary> **Output** ``` applied fixers: --------------- * class_attributes_separation``` </details>
Owner

Rapport PHPStan


 [OK] No errors                                                                 


## Rapport PHPStan ``` [OK] No errors ```
Owner

Symfony Security Check Report

2 packages have known vulnerabilities.

symfony/security-http (v5.4.23)

symfony/twig-bridge (v5.4.22)

  • CVE-2023-46734: Potential XSS vulnerabilities in CodeExtension filters

Note that this checker can only detect vulnerabilities that are referenced in the security advisories database.
Execute this command regularly to check the newly discovered vulnerabilities.

Symfony Security Check Report ============================= 2 packages have known vulnerabilities. symfony/security-http (v5.4.23) ------------------------------- * [CVE-2023-46733][]: Possible session fixation symfony/twig-bridge (v5.4.22) ----------------------------- * [CVE-2023-46734][]: Potential XSS vulnerabilities in CodeExtension filters [CVE-2023-46733]: https://symfony.com/cve-2023-46733 [CVE-2023-46734]: https://symfony.com/cve-2023-46734 Note that this checker can only detect vulnerabilities that are referenced in the security advisories database. Execute this command regularly to check the newly discovered vulnerabilities.
Owner

Test report

PHP CS Fixer

Overview

State Total
Passed 0
Skipped 0
Failed 1
Error 0

Total duration: 0s

See details
Status Name Class
Cadoles_hydra-sql_PR-20/src/Controller/MainController

Errors

`Cadoles_hydra-sql_PR-20/src/Controller/MainController`

Output

applied fixers:
---------------
* class_attributes_separation```

</details>





# Test report ## PHP CS Fixer ### Overview | State | Total | |-------|-------| | Passed | 0 | | Skipped | 0 | | Failed | 1 | | Error | 0 | **Total duration**: 0s <details> <summary>See details</summary> | Status | Name | Class | |--------|------|-------| | &#10799; | `Cadoles_hydra-sql_PR-20/src/Controller/MainController` || </details> <br /> #### Errors <details> <summary>`Cadoles_hydra-sql_PR-20/src/Controller/MainController`</summary> **Output** ``` applied fixers: --------------- * class_attributes_separation``` </details>
Owner

Rapport PHPStan


 [OK] No errors                                                                 


## Rapport PHPStan ``` [OK] No errors ```
Owner

Symfony Security Check Report

No packages have known vulnerabilities.

Note that this checker can only detect vulnerabilities that are referenced in the security advisories database.
Execute this command regularly to check the newly discovered vulnerabilities.

Symfony Security Check Report ============================= No packages have known vulnerabilities. Note that this checker can only detect vulnerabilities that are referenced in the security advisories database. Execute this command regularly to check the newly discovered vulnerabilities.
Owner

Test report

PHP CS Fixer

Overview

State Total
Passed 0
Skipped 0
Failed 1
Error 0

Total duration: 0s

See details
Status Name Class
src/Controller/MainController

Errors

`src/Controller/MainController`

Output

applied fixers:
---------------
* class_attributes_separation```

</details>





# Test report ## PHP CS Fixer ### Overview | State | Total | |-------|-------| | Passed | 0 | | Skipped | 0 | | Failed | 1 | | Error | 0 | **Total duration**: 0s <details> <summary>See details</summary> | Status | Name | Class | |--------|------|-------| | &#10799; | `src/Controller/MainController` || </details> <br /> #### Errors <details> <summary>`src/Controller/MainController`</summary> **Output** ``` applied fixers: --------------- * class_attributes_separation``` </details>
Owner

Rapport PHPStan


 [OK] No errors                                                                 


## Rapport PHPStan ``` [OK] No errors ```
Owner

Symfony Security Check Report

No packages have known vulnerabilities.

Note that this checker can only detect vulnerabilities that are referenced in the security advisories database.
Execute this command regularly to check the newly discovered vulnerabilities.

Symfony Security Check Report ============================= No packages have known vulnerabilities. Note that this checker can only detect vulnerabilities that are referenced in the security advisories database. Execute this command regularly to check the newly discovered vulnerabilities.
Owner

Test report

PHP CS Fixer

Overview

State Total
Passed 0
Skipped 0
Failed 1
Error 0

Total duration: 0s

See details
Status Name Class
src/Controller/MainController

Errors

`src/Controller/MainController`

Output

applied fixers:
---------------
* class_attributes_separation```

</details>





# Test report ## PHP CS Fixer ### Overview | State | Total | |-------|-------| | Passed | 0 | | Skipped | 0 | | Failed | 1 | | Error | 0 | **Total duration**: 0s <details> <summary>See details</summary> | Status | Name | Class | |--------|------|-------| | &#10799; | `src/Controller/MainController` || </details> <br /> #### Errors <details> <summary>`src/Controller/MainController`</summary> **Output** ``` applied fixers: --------------- * class_attributes_separation``` </details>
Owner

Rapport PHPStan


 [OK] No errors                                                                 


## Rapport PHPStan ``` [OK] No errors ```
Owner

Symfony Security Check Report

No packages have known vulnerabilities.

Note that this checker can only detect vulnerabilities that are referenced in the security advisories database.
Execute this command regularly to check the newly discovered vulnerabilities.

Symfony Security Check Report ============================= No packages have known vulnerabilities. Note that this checker can only detect vulnerabilities that are referenced in the security advisories database. Execute this command regularly to check the newly discovered vulnerabilities.
Owner

Test report

PHP CS Fixer

Overview

State Total
Passed 0
Skipped 0
Failed 2
Error 0

Total duration: 0s

See details
Status Name Class
src/Controller/MainController
src/Security/Hasher/PasswordEncoder

Errors

`src/Controller/MainController`

Output

applied fixers:
---------------
* class_attributes_separation```

</details>


<details>
  <summary>`src/Security/Hasher/PasswordEncoder`</summary>

**Output** 

applied fixers:

  • phpdoc_add_missing_param_annotation
  • no_superfluous_phpdoc_tags
  • nullable_type_declaration_for_default_null_value```
# Test report ## PHP CS Fixer ### Overview | State | Total | |-------|-------| | Passed | 0 | | Skipped | 0 | | Failed | 2 | | Error | 0 | **Total duration**: 0s <details> <summary>See details</summary> | Status | Name | Class | |--------|------|-------| | &#10799; | `src/Controller/MainController` || | &#10799; | `src/Security/Hasher/PasswordEncoder` || </details> <br /> #### Errors <details> <summary>`src/Controller/MainController`</summary> **Output** ``` applied fixers: --------------- * class_attributes_separation``` </details> <details> <summary>`src/Security/Hasher/PasswordEncoder`</summary> **Output** ``` applied fixers: --------------- * phpdoc_add_missing_param_annotation * no_superfluous_phpdoc_tags * nullable_type_declaration_for_default_null_value``` </details>
Owner

Rapport PHPStan


 [OK] No errors                                                                 


## Rapport PHPStan ``` [OK] No errors ```
vcarroy requested changes 2024-04-24 11:21:27 +02:00
vcarroy left a comment
Owner

Les messages d'erreur pour mauvais mot de passe / mauvais login doivent être les mêmes pour des questions de sécurité. Les exceptions peuvent être différentes pour aider au debug mais les messages doivent être les mêmes.

Les messages d'erreur pour mauvais mot de passe / mauvais login doivent être les mêmes pour des questions de sécurité. Les exceptions peuvent être différentes pour aider au debug mais les messages doivent être les mêmes.
@ -71,3 +72,1 @@
$scope .= $data.',';
}
$scope = substr($scope, 0, -1);
if ($this->config[self::DATA_TO_FETCH]) {
Owner

Inverser cette condition

Inverser cette condition
Author
Owner

ok

ok
@ -90,10 +101,16 @@ class SQLLoginUserAuthenticator extends AbstractLoginFormAuthenticator
return $passport;
Owner

Le type de $passport ne correspond pas au return type de la méthode.

Le type de $passport ne correspond pas au return type de la méthode.
Author
Owner

ok

ok
@ -18,3 +23,3 @@
$this->loggerInterface = $loggerInterface;
}
public function fetchDatas($login)
Owner

typer $login (mixed possible)

typer $login (mixed possible)
Author
Owner

ok

ok
@ -42,3 +54,1 @@
* @return bool
*/
public function fetchPassword($login)
public function fetchPassword($login): array|bool
Owner

typer $login (mixed possible)

typer $login (mixed possible)
Author
Owner

ok

ok
@ -1,4 +1,7 @@
error:
Owner

A supprimer, utiliser les fichier xlf pour les traductions

A supprimer, utiliser les fichier xlf pour les traductions
Author
Owner

ok

ok
@ -1,4 +1,7 @@
error:
Owner

A supprimer

A supprimer
Author
Owner

ok

ok
rmasson force-pushed issue-19 from 1e2491f9c6 to 0791727694 2024-04-29 10:44:55 +02:00 Compare
Owner

Symfony Security Check Report

No packages have known vulnerabilities.

Note that this checker can only detect vulnerabilities that are referenced in the security advisories database.
Execute this command regularly to check the newly discovered vulnerabilities.

Symfony Security Check Report ============================= No packages have known vulnerabilities. Note that this checker can only detect vulnerabilities that are referenced in the security advisories database. Execute this command regularly to check the newly discovered vulnerabilities.
Owner

Test report

PHP CS Fixer

Overview

State Total
Passed 0
Skipped 0
Failed 3
Error 0

Total duration: 0s

See details
Status Name Class
src/SQLLogin/SQLLoginRequest
src/Service/SQLLoginService
src/Security/SQLLoginUserAuthenticator

Errors

`src/SQLLogin/SQLLoginRequest`

Output

applied fixers:
---------------
* concat_space```

</details>


<details>
  <summary>`src/Service/SQLLoginService`</summary>

**Output** 

applied fixers:

  • global_namespace_import
  • no_unused_imports
  • blank_line_before_statement```
`src/Security/SQLLoginUserAuthenticator`

Output

applied fixers:
---------------
* concat_space```

</details>





# Test report ## PHP CS Fixer ### Overview | State | Total | |-------|-------| | Passed | 0 | | Skipped | 0 | | Failed | 3 | | Error | 0 | **Total duration**: 0s <details> <summary>See details</summary> | Status | Name | Class | |--------|------|-------| | &#10799; | `src/SQLLogin/SQLLoginRequest` || | &#10799; | `src/Service/SQLLoginService` || | &#10799; | `src/Security/SQLLoginUserAuthenticator` || </details> <br /> #### Errors <details> <summary>`src/SQLLogin/SQLLoginRequest`</summary> **Output** ``` applied fixers: --------------- * concat_space``` </details> <details> <summary>`src/Service/SQLLoginService`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * blank_line_before_statement``` </details> <details> <summary>`src/Security/SQLLoginUserAuthenticator`</summary> **Output** ``` applied fixers: --------------- * concat_space``` </details>
Owner

Rapport PHPStan


 [OK] No errors                                                                 


## Rapport PHPStan ``` [OK] No errors ```
Owner

Rapport d'analyse du fichier ./misc/images/hydra-sql-standalone/Dockerfile avec Hadolint

Rien à signaler.
## Rapport d'analyse du fichier `./misc/images/hydra-sql-standalone/Dockerfile` avec [Hadolint](https://github.com/hadolint/hadolint) ``` Rien à signaler. ```
Owner

Rapport d'analyse de l'image avec Trivy

Target reg.cadoles.com/cadoles/hydra-sql-standalone:2024.4.29-pr20.1044.0791727 (alpine 3.17.1)

Vulnerabilities (2)

Package ID Severity Installed Version Fixed Version
libcrypto3 CVE-2024-2511 LOW 3.0.12-r4 3.0.12-r5
libssl3 CVE-2024-2511 LOW 3.0.12-r4 3.0.12-r5

No Misconfigurations found

Target Node.js

Vulnerabilities (1)

Package ID Severity Installed Version Fixed Version
tar CVE-2024-28863 MEDIUM 6.2.0 6.2.1

No Misconfigurations found

## Rapport d'analyse de l'image avec [Trivy](https://github.com/aquasecurity/trivy) <h3>Target <code>reg.cadoles.com/cadoles/hydra-sql-standalone:2024.4.29-pr20.1044.0791727 (alpine 3.17.1)</code></h3> <h4>Vulnerabilities (2)</h4> <table> <tr> <th>Package</th> <th>ID</th> <th>Severity</th> <th>Installed Version</th> <th>Fixed Version</th> </tr> <tr> <td><code>libcrypto3</code></td> <td>CVE-2024-2511</td> <td>LOW</td> <td>3.0.12-r4</td> <td>3.0.12-r5</td> </tr> <tr> <td><code>libssl3</code></td> <td>CVE-2024-2511</td> <td>LOW</td> <td>3.0.12-r4</td> <td>3.0.12-r5</td> </tr> </table> <h4>No Misconfigurations found</h4> <h3>Target <code>Node.js</code></h3> <h4>Vulnerabilities (1)</h4> <table> <tr> <th>Package</th> <th>ID</th> <th>Severity</th> <th>Installed Version</th> <th>Fixed Version</th> </tr> <tr> <td><code>tar</code></td> <td>CVE-2024-28863</td> <td>MEDIUM</td> <td>6.2.0</td> <td>6.2.1</td> </tr> </table> <h4>No Misconfigurations found</h4>
Owner

Rapport d'analyse du fichier ./misc/images/hydra-sql-base/Dockerfile avec Hadolint

Rien à signaler.
## Rapport d'analyse du fichier `./misc/images/hydra-sql-base/Dockerfile` avec [Hadolint](https://github.com/hadolint/hadolint) ``` Rien à signaler. ```
Owner

Rapport d'analyse de l'image avec Trivy

Target reg.cadoles.com/cadoles/hydra-sql-base:2024.4.29-pr20.1044.0791727 (alpine 3.17.1)

Vulnerabilities (2)

Package ID Severity Installed Version Fixed Version
libcrypto3 CVE-2024-2511 LOW 3.0.12-r4 3.0.12-r5
libssl3 CVE-2024-2511 LOW 3.0.12-r4 3.0.12-r5

No Misconfigurations found

Target Node.js

Vulnerabilities (1)

Package ID Severity Installed Version Fixed Version
tar CVE-2024-28863 MEDIUM 6.2.0 6.2.1

No Misconfigurations found

## Rapport d'analyse de l'image avec [Trivy](https://github.com/aquasecurity/trivy) <h3>Target <code>reg.cadoles.com/cadoles/hydra-sql-base:2024.4.29-pr20.1044.0791727 (alpine 3.17.1)</code></h3> <h4>Vulnerabilities (2)</h4> <table> <tr> <th>Package</th> <th>ID</th> <th>Severity</th> <th>Installed Version</th> <th>Fixed Version</th> </tr> <tr> <td><code>libcrypto3</code></td> <td>CVE-2024-2511</td> <td>LOW</td> <td>3.0.12-r4</td> <td>3.0.12-r5</td> </tr> <tr> <td><code>libssl3</code></td> <td>CVE-2024-2511</td> <td>LOW</td> <td>3.0.12-r4</td> <td>3.0.12-r5</td> </tr> </table> <h4>No Misconfigurations found</h4> <h3>Target <code>Node.js</code></h3> <h4>Vulnerabilities (1)</h4> <table> <tr> <th>Package</th> <th>ID</th> <th>Severity</th> <th>Installed Version</th> <th>Fixed Version</th> </tr> <tr> <td><code>tar</code></td> <td>CVE-2024-28863</td> <td>MEDIUM</td> <td>6.2.0</td> <td>6.2.1</td> </tr> </table> <h4>No Misconfigurations found</h4>
rmasson added 1 commit 2024-04-29 11:10:04 +02:00
feat (gestion exception) #19: modification fetchPassword
Some checks reported warnings
Cadoles/hydra-sql/pipeline/pr-develop This commit is unstable
51c92a0dba
Owner

Symfony Security Check Report

No packages have known vulnerabilities.

Note that this checker can only detect vulnerabilities that are referenced in the security advisories database.
Execute this command regularly to check the newly discovered vulnerabilities.

Symfony Security Check Report ============================= No packages have known vulnerabilities. Note that this checker can only detect vulnerabilities that are referenced in the security advisories database. Execute this command regularly to check the newly discovered vulnerabilities.
Owner

Test report

PHP CS Fixer

Overview

State Total
Passed 0
Skipped 0
Failed 2
Error 0

Total duration: 0s

See details
Status Name Class
src/Service/SQLLoginService
src/Security/SQLLoginUserAuthenticator

Errors

`src/Service/SQLLoginService`

Output

applied fixers:
---------------
* global_namespace_import
* no_unused_imports
* blank_line_before_statement
* no_whitespace_in_blank_line```

</details>


<details>
  <summary>`src/Security/SQLLoginUserAuthenticator`</summary>

**Output** 

applied fixers:

  • concat_space
  • global_namespace_import
  • no_unused_imports```
# Test report ## PHP CS Fixer ### Overview | State | Total | |-------|-------| | Passed | 0 | | Skipped | 0 | | Failed | 2 | | Error | 0 | **Total duration**: 0s <details> <summary>See details</summary> | Status | Name | Class | |--------|------|-------| | &#10799; | `src/Service/SQLLoginService` || | &#10799; | `src/Security/SQLLoginUserAuthenticator` || </details> <br /> #### Errors <details> <summary>`src/Service/SQLLoginService`</summary> **Output** ``` applied fixers: --------------- * global_namespace_import * no_unused_imports * blank_line_before_statement * no_whitespace_in_blank_line``` </details> <details> <summary>`src/Security/SQLLoginUserAuthenticator`</summary> **Output** ``` applied fixers: --------------- * concat_space * global_namespace_import * no_unused_imports``` </details>
Owner

Rapport PHPStan


 [OK] No errors                                                                 


## Rapport PHPStan ``` [OK] No errors ```
Owner

Rapport d'analyse du fichier ./misc/images/hydra-sql-standalone/Dockerfile avec Hadolint

Rien à signaler.
## Rapport d'analyse du fichier `./misc/images/hydra-sql-standalone/Dockerfile` avec [Hadolint](https://github.com/hadolint/hadolint) ``` Rien à signaler. ```
rmasson requested review from vcarroy 2024-04-29 11:11:30 +02:00
Owner

Rapport d'analyse de l'image avec Trivy

Target reg.cadoles.com/cadoles/hydra-sql-standalone:2024.4.29-pr20.1109.51c92a0 (alpine 3.17.1)

Vulnerabilities (2)

Package ID Severity Installed Version Fixed Version
libcrypto3 CVE-2024-2511 LOW 3.0.12-r4 3.0.12-r5
libssl3 CVE-2024-2511 LOW 3.0.12-r4 3.0.12-r5

No Misconfigurations found

Target Node.js

Vulnerabilities (1)

Package ID Severity Installed Version Fixed Version
tar CVE-2024-28863 MEDIUM 6.2.0 6.2.1

No Misconfigurations found

## Rapport d'analyse de l'image avec [Trivy](https://github.com/aquasecurity/trivy) <h3>Target <code>reg.cadoles.com/cadoles/hydra-sql-standalone:2024.4.29-pr20.1109.51c92a0 (alpine 3.17.1)</code></h3> <h4>Vulnerabilities (2)</h4> <table> <tr> <th>Package</th> <th>ID</th> <th>Severity</th> <th>Installed Version</th> <th>Fixed Version</th> </tr> <tr> <td><code>libcrypto3</code></td> <td>CVE-2024-2511</td> <td>LOW</td> <td>3.0.12-r4</td> <td>3.0.12-r5</td> </tr> <tr> <td><code>libssl3</code></td> <td>CVE-2024-2511</td> <td>LOW</td> <td>3.0.12-r4</td> <td>3.0.12-r5</td> </tr> </table> <h4>No Misconfigurations found</h4> <h3>Target <code>Node.js</code></h3> <h4>Vulnerabilities (1)</h4> <table> <tr> <th>Package</th> <th>ID</th> <th>Severity</th> <th>Installed Version</th> <th>Fixed Version</th> </tr> <tr> <td><code>tar</code></td> <td>CVE-2024-28863</td> <td>MEDIUM</td> <td>6.2.0</td> <td>6.2.1</td> </tr> </table> <h4>No Misconfigurations found</h4>
Owner

Rapport d'analyse du fichier ./misc/images/hydra-sql-base/Dockerfile avec Hadolint

Rien à signaler.
## Rapport d'analyse du fichier `./misc/images/hydra-sql-base/Dockerfile` avec [Hadolint](https://github.com/hadolint/hadolint) ``` Rien à signaler. ```
Owner

Rapport d'analyse de l'image avec Trivy

Target reg.cadoles.com/cadoles/hydra-sql-base:2024.4.29-pr20.1109.51c92a0 (alpine 3.17.1)

Vulnerabilities (2)

Package ID Severity Installed Version Fixed Version
libcrypto3 CVE-2024-2511 LOW 3.0.12-r4 3.0.12-r5
libssl3 CVE-2024-2511 LOW 3.0.12-r4 3.0.12-r5

No Misconfigurations found

Target Node.js

Vulnerabilities (1)

Package ID Severity Installed Version Fixed Version
tar CVE-2024-28863 MEDIUM 6.2.0 6.2.1

No Misconfigurations found

## Rapport d'analyse de l'image avec [Trivy](https://github.com/aquasecurity/trivy) <h3>Target <code>reg.cadoles.com/cadoles/hydra-sql-base:2024.4.29-pr20.1109.51c92a0 (alpine 3.17.1)</code></h3> <h4>Vulnerabilities (2)</h4> <table> <tr> <th>Package</th> <th>ID</th> <th>Severity</th> <th>Installed Version</th> <th>Fixed Version</th> </tr> <tr> <td><code>libcrypto3</code></td> <td>CVE-2024-2511</td> <td>LOW</td> <td>3.0.12-r4</td> <td>3.0.12-r5</td> </tr> <tr> <td><code>libssl3</code></td> <td>CVE-2024-2511</td> <td>LOW</td> <td>3.0.12-r4</td> <td>3.0.12-r5</td> </tr> </table> <h4>No Misconfigurations found</h4> <h3>Target <code>Node.js</code></h3> <h4>Vulnerabilities (1)</h4> <table> <tr> <th>Package</th> <th>ID</th> <th>Severity</th> <th>Installed Version</th> <th>Fixed Version</th> </tr> <tr> <td><code>tar</code></td> <td>CVE-2024-28863</td> <td>MEDIUM</td> <td>6.2.0</td> <td>6.2.1</td> </tr> </table> <h4>No Misconfigurations found</h4>
mlamalle merged commit 69f0a607a3 into develop 2024-04-29 11:33:17 +02:00
mlamalle deleted branch issue-19 2024-04-29 11:33:20 +02:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Cadoles/hydra-sql#20
No description provided.