chore(symfony) #57 : bump symfony to version 6.4 and fix deprecations

composer.json

@@ -26,6 +26,7 @@
         "symfony/translation": "6.4.*",
         "symfony/twig-bundle": "6.4.*",
         "symfony/validator": "6.4.*",
+        "symfony/web-profiler-bundle": "6.4.*",
         "symfony/webpack-encore-bundle": "^1.16",
         "symfony/yaml": "6.4.*"
     },
@@ -80,7 +81,6 @@
     },
     "require-dev": {
         "rector/rector": "^2.1",
-        "symfony/debug-bundle": "6.4.*",
-        "symfony/web-profiler-bundle": "6.4.*"
+        "symfony/debug-bundle": "6.4.*"
     }
 }

src/Controller/MainController.php

@@ -20,8 +20,7 @@ class MainController extends AbstractController
     public function __construct(
         private readonly RequestStack $requestStack,
         private readonly HydraService $hydra,
-        private readonly Client $client,
-        private readonly SQLLoginRequest $sqlLoginRequest
+        private readonly Client $client
     ){
     }
 
@@ -41,7 +40,7 @@ class MainController extends AbstractController
     }
 
     #[Route('/connect/login-accept', name: 'app_login_accept', methods: ['GET'])]
-    public function loginAccept(): RedirectResponse
+    public function loginAccept(SQLLoginRequest $sqlLoginRequest): RedirectResponse
     {
         $user = $this->getUser();
 
@@ -55,7 +54,7 @@ class MainController extends AbstractController
 
         $subject = $user->getLogin();
 
-        $subjectRewriteExpression = $this->sqlLoginRequest->getSubjectRewriteExpression();
+        $subjectRewriteExpression = $sqlLoginRequest->getSubjectRewriteExpression();
         if (null != $subjectRewriteExpression) {
             $expressionLanguage = new ExpressionLanguage();
 

src/Hydra/HydraService.php

@@ -39,7 +39,7 @@ class HydraService extends AbstractController
         // si le challenge est validé par hydra, on le stocke en session pour l'utiliser par la suite et on redirige vers une route interne protégée qui va déclencher l'identification FranceConnect
         $this->requestStack->getSession()->set('challenge', $loginRequestInfo['challenge']);
 
-        return new RedirectResponse($this->baseUrl.'/login');
+        return new RedirectResponse($this->baseUrl.'/connect/login-accept');
     }
 
     public function handleConsentRequest(Request $request): RedirectResponse

src/Security/SQLLoginUserAuthenticator.php

@@ -60,7 +60,7 @@ class SQLLoginUserAuthenticator extends AbstractLoginFormAuthenticator
     public function authenticate(Request $request): SelfValidatingPassport
     {
         $form = $request->request->all(key: 'login');
-        $login = \strtolower($form['login']);
+        $login = $form['login'];
         $plaintextPassword = $form['password'];
         $session = $request->getSession();
         try {

src/Service/SQLLoginService.php

@@ -28,6 +28,7 @@ class SQLLoginService extends AbstractController
     public function fetchPasswordAndDatas(string $login): array
     {
         $dataRequest = $this->sqlLoginRequest->getDatasRequest();
+        $login = \strtolower($login);
         $datas = $this->executeRequestWithLogin($dataRequest, $login);
 
         return $datas;