Cadoles/bouncer
Cadoles
/
bouncer
10
0
Fork 0
Code Issues 6 Pull Requests 1 Projects Releases 3 Wiki Activity

feat(authn) : add case to test multiples CIDR #34 #35

Open
mlamalle wants to merge 1 commits from issue-4 into develop
pull from: issue-4
merge into: Cadoles:develop
Conversation 0 Commits 1 Files Changed 1 +17
mlamalle commented 2024-08-08 08:46:15 +02:00
Owner
Copy Link

Lié à #34

Ajout d'un cas de test authenticatoir CIDR pour tester les CIDR autorisés multiples

Commande de test en isolation :

go test -v -count=1  ./internal/proxy/director/layer/authn/network/...
Lié à https://forge.cadoles.com/Cadoles/bouncer/issues/34 Ajout d'un cas de test authenticatoir CIDR pour tester les CIDR autorisés multiples Commande de test en isolation : ``` go test -v -count=1 ./internal/proxy/director/layer/authn/network/... ```
mlamalle added 1 commit 2024-08-08 08:46:16 +02:00
Cadoles/bouncer/pipeline/head There was a failure building this commit Details
Cadoles/bouncer/pipeline/pr-develop There was a failure building this commit Details
5f948ce83a feat(authn) : add case to test multiples CIDR
wpetit requested changes 2024-08-08 08:53:16 +02:00
internal/proxy/director/layer/authn/network/authenticator_test.go Outdated
@ -42,0 +45,4 @@
"192.168.1.0/24",
"192.168.1.5/32",
},
ExpectedResult: false,
wpetit commented 2024-08-08 08:53:13 +02:00
Owner
Copy Link

Le résultat attendu me semble erroné. L'IP 192.168.1.15 est bien contenu dans le réseau 192.168.1.0/24, le résultat sera donc true. Est ce une erreur ?

Le résultat attendu me semble erroné. L'IP `192.168.1.15` est bien contenu dans le réseau `192.168.1.0/24`, le résultat sera donc `true`. Est ce une erreur ?
wpetit marked this conversation as resolved
mlamalle force-pushed issue-4 from 5f948ce83a to a1b07c568e 2024-08-08 08:57:56 +02:00 Compare
mlamalle changed title from feat(authn) : add case to test multiples CIDR to feat(authn) : add case to test multiples CIDR #4 2024-08-08 09:01:54 +02:00
mlamalle changed title from feat(authn) : add case to test multiples CIDR #4 to feat(authn) : add case to test multiples CIDR #34 2024-08-08 09:02:14 +02:00
All checks were successful
Cadoles/bouncer/pipeline/pr-develop This commit looks good
Details
This pull request has changes requested by an official reviewer.
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
wpetit
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Cadoles/bouncer#35
No description provided.
Delete Branch "issue-4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?