Cleaned unused method, property, variable or parameter

Fixed commit c830097430
Fixed issue #22

src/BeSimple/SoapBundle/Controller/SoapWebServiceController.php

@@ -15,8 +15,6 @@ namespace BeSimple\SoapBundle\Controller;
 use BeSimple\SoapBundle\Handler\ExceptionHandler;
 use BeSimple\SoapBundle\Soap\SoapRequest;
 use BeSimple\SoapBundle\Soap\SoapResponse;
-use BeSimple\SoapServer\Exception as SoapException;
-
 use Symfony\Component\DependencyInjection\ContainerAware;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;

src/BeSimple/SoapBundle/Converter/TypeRepository.php

@@ -12,8 +12,6 @@ namespace BeSimple\SoapBundle\Converter;
 
 use BeSimple\SoapBundle\ServiceDefinition\ServiceDefinition;
 use BeSimple\SoapBundle\Util\Assert;
-use BeSimple\SoapBundle\Util\QName;
-use BeSimple\SoapBundle\Util\String;
 
 /**
  * @author Christian Kerl <christian-kerl@web.de>
@@ -50,8 +48,6 @@ class TypeRepository
 
     public function fixTypeInformation(ServiceDefinition $definition)
     {
-        $typeMap = $this->defaultTypeMap;
-
         foreach($definition->getAllTypes() as $type) {
             $phpType = $type->getPhpType();
             $xmlType = $type->getXmlType();
@@ -67,4 +63,4 @@ class TypeRepository
             $type->setXmlType($xmlType);
         }
     }
-}
+}

src/BeSimple/SoapBundle/Converter/XopIncludeTypeConverter.php

@@ -13,6 +13,7 @@ namespace BeSimple\SoapBundle\Converter;
 use BeSimple\SoapBundle\Soap\SoapRequest;
 use BeSimple\SoapBundle\Soap\SoapResponse;
 use BeSimple\SoapBundle\Util\String;
+use BeSimple\SoapCommon\Converter\TypeConverterInterface;
 
 /**
  * @author Christian Kerl <christian-kerl@web.de>
@@ -52,4 +53,4 @@ class XopIncludeTypeConverter implements TypeConverterInterface
     {
         return $data;
     }
-}
+}

src/BeSimple/SoapBundle/DependencyInjection/BeSimpleSoapExtension.php

@@ -84,7 +84,7 @@ class BeSimpleSoapExtension extends Extension
 
         foreach ($config as $client => $options) {
             $definition = new DefinitionDecorator('besimple.soap.client.builder');
-            $context    = $container->setDefinition(sprintf('besimple.soap.client.builder.%s', $client), $definition);
+            $container->setDefinition(sprintf('besimple.soap.client.builder.%s', $client), $definition);
 
             $definition->replaceArgument(0, $options['wsdl']);
 
@@ -118,7 +118,7 @@ class BeSimpleSoapExtension extends Extension
     private function createClientClassmap($client, array $classmap, ContainerBuilder $container)
     {
         $definition = new DefinitionDecorator('besimple.soap.classmap');
-        $context    = $container->setDefinition(sprintf('besimple.soap.classmap.%s', $client), $definition);
+        $container->setDefinition(sprintf('besimple.soap.classmap.%s', $client), $definition);
 
         $definition->setMethodCalls(array(
             array('set', array($classmap)),
@@ -130,7 +130,7 @@ class BeSimpleSoapExtension extends Extension
     private function createClient($client, ContainerBuilder $container)
     {
         $definition = new DefinitionDecorator('besimple.soap.client');
-        $context    = $container->setDefinition(sprintf('besimple.soap.client.%s', $client), $definition);
+        $container->setDefinition(sprintf('besimple.soap.client.%s', $client), $definition);
 
         $definition->setFactoryService(sprintf('besimple.soap.client.builder.%s', $client));
     }
@@ -142,7 +142,7 @@ class BeSimpleSoapExtension extends Extension
 
         $contextId  = 'besimple.soap.context.'.$config['name'];
         $definition = new DefinitionDecorator('besimple.soap.context.'.$bindingSuffix);
-        $context    = $container->setDefinition($contextId, $definition);
+        $container->setDefinition($contextId, $definition);
 
         if (isset($config['cache_type'])) {
             $config['cache_type'] = $this->getCacheType($config['cache_type']);

src/BeSimple/SoapBundle/EventListener/RequestFormatListener.php

@@ -2,7 +2,6 @@
 
 namespace BeSimple\SoapBundle\EventListener;
 
-use Symfony\Component\HttpKernel\HttpKernelInterface;
 use Symfony\Component\HttpKernel\Event\GetResponseEvent;
 
 class RequestFormatListener

src/BeSimple/SoapBundle/ServiceBinding/RpcLiteralRequestMessageBinder.php

@@ -13,8 +13,6 @@
 namespace BeSimple\SoapBundle\ServiceBinding;
 
 use BeSimple\SoapBundle\ServiceDefinition\Method;
-use BeSimple\SoapBundle\ServiceDefinition\Strategy\MethodComplexType;
-use BeSimple\SoapBundle\ServiceDefinition\Strategy\PropertyComplexType;
 use BeSimple\SoapCommon\Definition\Type\ArrayOfType;
 use BeSimple\SoapCommon\Definition\Type\ComplexType;
 use BeSimple\SoapCommon\Definition\Type\TypeRepository;
@@ -55,7 +53,7 @@ class RpcLiteralRequestMessageBinder implements MessageBinderInterface
         $type = $this->typeRepository->getType($phpType);
         if ($type instanceof ArrayOfType) {
             $isArray = true;
-            $arrayType = $type;
+            $array = array();
 
             $type = $this->typeRepository->getType($type->get('item')->getType());
         }
@@ -65,8 +63,6 @@ class RpcLiteralRequestMessageBinder implements MessageBinderInterface
             $phpType = $type->getPhpType();
 
             if ($isArray) {
-                $array = array();
-
                 if (isset($message->item)) {
                     foreach ($message->item as $complexType) {
                         $array[] = $this->checkComplexType($phpType, $complexType);

src/BeSimple/SoapBundle/ServiceBinding/RpcLiteralResponseMessageBinder.php

@@ -13,8 +13,6 @@
 namespace BeSimple\SoapBundle\ServiceBinding;
 
 use BeSimple\SoapBundle\ServiceDefinition\Method;
-use BeSimple\SoapBundle\ServiceDefinition\Strategy\PropertyComplexType;
-use BeSimple\SoapBundle\ServiceDefinition\Strategy\MethodComplexType;
 use BeSimple\SoapCommon\Definition\Type\ArrayOfType;
 use BeSimple\SoapCommon\Definition\Type\ComplexType;
 use BeSimple\SoapCommon\Definition\Type\TypeRepository;
@@ -44,7 +42,6 @@ class RpcLiteralResponseMessageBinder implements MessageBinderInterface
         $type = $this->typeRepository->getType($phpType);
         if ($type instanceof ArrayOfType) {
             $isArray = true;
-            $arrayType = $type;
 
             $type = $this->typeRepository->getType($type->get('item')->getType());
         }

src/BeSimple/SoapBundle/ServiceBinding/ServiceBinder.php

@@ -10,7 +10,6 @@
 
 namespace BeSimple\SoapBundle\ServiceBinding;
 
-use BeSimple\SoapBundle\ServiceDefinition\Header;
 use BeSimple\SoapBundle\ServiceDefinition\Definition;
 use BeSimple\SoapBundle\Soap\SoapHeader;
 

src/BeSimple/SoapBundle/ServiceDefinition/Definition.php

@@ -21,8 +21,6 @@ use BeSimple\SoapCommon\Definition\Type\TypeRepository;
  */
 class Definition extends BaseDefinition
 {
-    private $complexTypes;
-
     public function __construct(TypeRepository $typeRepository)
     {
         $this->typeRepository = $typeRepository;

src/BeSimple/SoapBundle/ServiceDefinition/Loader/AnnotationClassLoader.php

@@ -16,11 +16,8 @@ use BeSimple\SoapBundle\ServiceDefinition as Definition;
 use BeSimple\SoapBundle\ServiceDefinition\Annotation;
 use BeSimple\SoapCommon\Definition\Type\ComplexType;
 use BeSimple\SoapCommon\Definition\Type\TypeRepository;
-
 use Doctrine\Common\Annotations\Reader;
-
 use Symfony\Component\Config\Loader\Loader;
-use Symfony\Component\Config\Loader\LoaderResolverInterface;
 
 /**
  * AnnotationClassLoader loads ServiceDefinition from a PHP class and its methods.
@@ -144,30 +141,6 @@ class AnnotationClassLoader extends Loader
         }
     }
 
-    /**
-     * @param \ReflectionMethod $method
-     * @param \BeSimple\SoapBundle\ServiceDefinition\Annotation\Param $annotation
-     *
-     * @return \BeSimple\SoapBundle\ServiceDefinition\Type
-     */
-    private function getArgumentType(\ReflectionMethod $method, Annotation\Param $annotation)
-    {
-        $phpType = $annotation->getPhpType();
-        $xmlType = $annotation->getXmlType();
-
-        if (null === $phpType) {
-            foreach ($method->getParameters() as $param) {
-                if ($param->name === $annotation->getName()) {
-                    $phpType = $param->getClass()->name;
-
-                    break;
-                }
-            }
-        }
-
-        return new Definition\Type($phpType, $xmlType);
-    }
-
     private function loadType($phpType)
     {
         if (false !== $arrayOf = $this->typeRepository->getArrayOf($phpType)) {
@@ -177,7 +150,7 @@ class AnnotationClassLoader extends Loader
         if (!$this->typeRepository->hasType($phpType)) {
             $complexTypeResolver = $this->resolve($phpType, 'annotation_complextype');
             if (!$complexTypeResolver) {
-                throw new Exception();
+                throw new \Exception();
             }
 
             $loaded = $complexTypeResolver->load($phpType);

src/BeSimple/SoapBundle/ServiceDefinition/Loader/AnnotationFileLoader.php

@@ -16,7 +16,6 @@ use BeSimple\SoapBundle\ServiceDefinition\ServiceDefinition;
 
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\Config\Loader\FileLoader;
-use Symfony\Component\Config\Resource\FileResource;
 
 /**
  * AnnotationFileLoader loads ServiceDefinition from annotations set
@@ -62,7 +61,7 @@ class AnnotationFileLoader extends FileLoader
         $path = $this->locator->locate($file);
 
         if ($class = $this->findClass($path)) {
-            return $definition = $this->loader->load($class, $type);
+            return $this->loader->load($class, $type);
         }
 
         return null;

src/BeSimple/SoapBundle/Soap/SoapRequest.php

@@ -11,10 +11,7 @@
 namespace BeSimple\SoapBundle\Soap;
 
 use BeSimple\SoapBundle\Util\Collection;
-
 use Symfony\Component\HttpFoundation\Request;
-
-use Zend\Mime\Mime;
 use Zend\Mime\Message;
 
 /**

src/BeSimple/SoapBundle/WebServiceContext.php

@@ -11,14 +11,10 @@
 
 namespace BeSimple\SoapBundle;
 
-use BeSimple\SoapBundle\ServiceBinding\MessageBinderInterface;
 use BeSimple\SoapBundle\ServiceBinding\ServiceBinder;
-use BeSimple\SoapBundle\ServiceDefinition\Dumper\DumperInterface;
-
 use BeSimple\SoapCommon\Converter\TypeConverterCollection;
 use BeSimple\SoapWsdl\Dumper\Dumper;
 use BeSimple\SoapServer\SoapServerBuilder;
-
 use Symfony\Component\Config\ConfigCache;
 use Symfony\Component\Config\Loader\LoaderInterface;
 
@@ -30,8 +26,6 @@ use Symfony\Component\Config\Loader\LoaderInterface;
  */
 class WebServiceContext
 {
-    private $converterRepository;
-
     private $options;
 
     private $serviceDefinition;

src/BeSimple/SoapClient/MimeFilter.php

@@ -90,7 +90,7 @@ class MimeFilter implements SoapRequestFilter, SoapResponseFilter
 
             // TODO
             $headers = $multipart->getHeadersForHttp();
-            list($name, $contentType) = explode(': ', $headers[0]);
+            list(, $contentType) = explode(': ', $headers[0]);
 
             $request->setContentType($contentType);
         }
@@ -135,4 +135,4 @@ class MimeFilter implements SoapRequestFilter, SoapResponseFilter
             $response->setAttachments($attachmentsRecieved);
         }
     }
-}
+}

src/BeSimple/SoapClient/SoapResponse.php

@@ -13,7 +13,6 @@
 namespace BeSimple\SoapClient;
 
 use BeSimple\SoapCommon\SoapResponse as CommonSoapResponse;
-use BeSimple\SoapCommon\SoapMessage;
 
 /**
  * SoapResponse class for SoapClient. Provides factory function for response object.
@@ -44,4 +43,4 @@ class SoapResponse extends CommonSoapResponse
 
         return $response;
     }
-}
+}

src/BeSimple/SoapClient/WsSecurityFilter.php

@@ -14,16 +14,12 @@ namespace BeSimple\SoapClient;
 
 use ass\XmlSecurity\DSig as XmlSecurityDSig;
 use ass\XmlSecurity\Enc as XmlSecurityEnc;
-use ass\XmlSecurity\Key as XmlSecurityKey;
-use ass\XmlSecurity\Pem as XmlSecurityPem;
-
 use BeSimple\SoapCommon\FilterHelper;
 use BeSimple\SoapCommon\Helper;
 use BeSimple\SoapCommon\SoapRequest as CommonSoapRequest;
 use BeSimple\SoapCommon\SoapRequestFilter;
 use BeSimple\SoapCommon\SoapResponse as CommonSoapResponse;
 use BeSimple\SoapCommon\SoapResponseFilter;
-use BeSimple\SoapCommon\WsSecurityKey;
 use BeSimple\SoapCommon\WsSecurityFilterClientServer;
 
 /**
@@ -214,7 +210,7 @@ class WsSecurityFilter extends WsSecurityFilterClientServer implements SoapReque
                 $referenceList = XmlSecurityEnc::createReferenceList($encryptedKey);
                 // token reference to encrypted key
                 $keyInfo = $this->createKeyInfo($filterHelper, self::TOKEN_REFERENCE_SECURITY_TOKEN, $guid);
-                $nodes = $this->createNodeListForEncryption($dom, $security);
+                $nodes = $this->createNodeListForEncryption($dom);
                 foreach ($nodes as $node) {
                     $type = XmlSecurityEnc::ELEMENT;
                     if ($node->localName == 'Body') {
@@ -274,4 +270,4 @@ class WsSecurityFilter extends WsSecurityFilterClientServer implements SoapReque
             $security->parentNode->removeChild($security);
         }
     }
-}
+}

src/BeSimple/SoapClient/XmlMimeFilter.php

@@ -14,13 +14,8 @@ namespace BeSimple\SoapClient;
 
 use BeSimple\SoapCommon\FilterHelper;
 use BeSimple\SoapCommon\Helper;
-use BeSimple\SoapCommon\Mime\MultiPart as MimeMultiPart;
-use BeSimple\SoapCommon\Mime\Parser as MimeParser;
-use BeSimple\SoapCommon\Mime\Part as MimePart;
 use BeSimple\SoapCommon\SoapRequest;
 use BeSimple\SoapCommon\SoapRequestFilter;
-use BeSimple\SoapCommon\SoapResponse;
-use BeSimple\SoapCommon\SoapResponseFilter;
 
 /**
  * XML MIME filter that fixes the namespace of xmime:contentType attribute.
@@ -72,4 +67,4 @@ class XmlMimeFilter implements SoapRequestFilter
         }
 
     }
-}
+}

src/BeSimple/SoapCommon/Converter/SwaTypeConverter.php

@@ -12,7 +12,6 @@
 
 namespace BeSimple\SoapCommon\Converter;
 
-use BeSimple\SoapCommon\Helper;
 use BeSimple\SoapCommon\Mime\Part as MimePart;
 use BeSimple\SoapCommon\SoapKernel;
 use BeSimple\SoapCommon\Converter\SoapKernelAwareInterface;

src/BeSimple/SoapCommon/SoapKernel.php

@@ -14,9 +14,6 @@
 namespace BeSimple\SoapCommon;
 
 use BeSimple\SoapCommon\Mime\Part as MimePart;
-
-use BeSimple\SoapCommon\Converter\MtomTypeConverter;
-use BeSimple\SoapCommon\Converter\SwaTypeConverter;
 use BeSimple\SoapCommon\SoapRequest;
 use BeSimple\SoapCommon\SoapResponse;
 use BeSimple\SoapCommon\SoapRequestFilter;
@@ -129,4 +126,4 @@ class SoapKernel
             $filter->filterResponse($response);
         }
     }
-}
+}

src/BeSimple/SoapCommon/SoapMessage.php

@@ -13,8 +13,6 @@
 
 namespace BeSimple\SoapCommon;
 
-use BeSimple\SoapCommon\Mime\Part as MimePart;
-
 /**
  * Base class for SoapRequest and SoapResponse.
  *
@@ -254,4 +252,4 @@ abstract class SoapMessage
     {
         $this->version = $version;
     }
-}
+}

src/BeSimple/SoapCommon/WsSecurityFilterClientServer.php

@@ -16,13 +16,8 @@ use ass\XmlSecurity\DSig as XmlSecurityDSig;
 use ass\XmlSecurity\Enc as XmlSecurityEnc;
 use ass\XmlSecurity\Key as XmlSecurityKey;
 use ass\XmlSecurity\Pem as XmlSecurityPem;
-
 use BeSimple\SoapCommon\FilterHelper;
 use BeSimple\SoapCommon\Helper;
-use BeSimple\SoapCommon\SoapRequest as CommonSoapRequest;
-use BeSimple\SoapCommon\SoapRequestFilter;
-use BeSimple\SoapCommon\SoapResponse as CommonSoapResponse;
-use BeSimple\SoapCommon\SoapResponseFilter;
 use BeSimple\SoapCommon\WsSecurityKey;
 
 /**
@@ -247,11 +242,10 @@ abstract class WsSecurityFilterClientServer
      * Create a list of \DOMNodes that should be encrypted.
      *
      * @param \DOMDocument $dom      DOMDocument to query
-     * @param \DOMElement  $security Security element
      *
      * @return \DOMNodeList
      */
-    protected function createNodeListForEncryption(\DOMDocument $dom, \DOMElement $security)
+    protected function createNodeListForEncryption(\DOMDocument $dom)
     {
         $xpath = new \DOMXPath($dom);
         $xpath->registerNamespace('SOAP-ENV', $dom->documentElement->namespaceURI);
@@ -355,4 +349,4 @@ abstract class WsSecurityFilterClientServer
 
         return null;
     }
-}
+}

src/BeSimple/SoapCommon/WsdlHandler.php

@@ -174,7 +174,7 @@ class WsdlHandler
             return true;
         // type/* match
         } else {
-            list($ctype, $csubtype) = explode('/', $currentMimeType);
+            list($ctype) = explode('/', $currentMimeType);
             foreach ($mimeTypes as $mimeType) {
                 list($type, $subtype) = explode('/', $mimeType);
                 if ($subtype == '*' && $type == $ctype) {
@@ -202,4 +202,4 @@ class WsdlHandler
             $this->domXpath->registerNamespace('soap', $this->wsdlSoapNamespace);
         }
     }
-}
+}

src/BeSimple/SoapServer/MimeFilter.php

@@ -130,9 +130,9 @@ class MimeFilter implements SoapRequestFilter, SoapResponseFilter
 
             // TODO
             $headers = $multipart->getHeadersForHttp();
-            list($name, $contentType) = explode(': ', $headers[0]);
+            list(, $contentType) = explode(': ', $headers[0]);
 
             $response->setContentType($contentType);
         }
     }
-}
+}

src/BeSimple/SoapServer/WsSecurityFilter.php

@@ -14,16 +14,12 @@ namespace BeSimple\SoapServer;
 
 use ass\XmlSecurity\DSig as XmlSecurityDSig;
 use ass\XmlSecurity\Enc as XmlSecurityEnc;
-use ass\XmlSecurity\Key as XmlSecurityKey;
-use ass\XmlSecurity\Pem as XmlSecurityPem;
-
 use BeSimple\SoapCommon\FilterHelper;
 use BeSimple\SoapCommon\Helper;
 use BeSimple\SoapCommon\SoapRequest as CommonSoapRequest;
 use BeSimple\SoapCommon\SoapRequestFilter;
 use BeSimple\SoapCommon\SoapResponse as CommonSoapResponse;
 use BeSimple\SoapCommon\SoapResponseFilter;
-use BeSimple\SoapCommon\WsSecurityKey;
 use BeSimple\SoapCommon\WsSecurityFilterClientServer;
 
 /**
@@ -230,7 +226,7 @@ class WsSecurityFilter extends WsSecurityFilterClientServer implements SoapReque
                 $referenceList = XmlSecurityEnc::createReferenceList($encryptedKey);
                 // token reference to encrypted key
                 $keyInfo = $this->createKeyInfo($filterHelper, self::TOKEN_REFERENCE_SECURITY_TOKEN, $guid);
-                $nodes = $this->createNodeListForEncryption($dom, $security);
+                $nodes = $this->createNodeListForEncryption($dom);
                 foreach ($nodes as $node) {
                     $type = XmlSecurityEnc::ELEMENT;
                     if ($node->localName == 'Body') {
@@ -241,4 +237,4 @@ class WsSecurityFilter extends WsSecurityFilterClientServer implements SoapReque
             }
         }
     }
-}
+}

src/BeSimple/SoapServer/XmlMimeFilter.php

@@ -14,11 +14,6 @@ namespace BeSimple\SoapServer;
 
 use BeSimple\SoapCommon\FilterHelper;
 use BeSimple\SoapCommon\Helper;
-use BeSimple\SoapCommon\Mime\MultiPart as MimeMultiPart;
-use BeSimple\SoapCommon\Mime\Parser as MimeParser;
-use BeSimple\SoapCommon\Mime\Part as MimePart;
-use BeSimple\SoapCommon\SoapRequest;
-use BeSimple\SoapCommon\SoapRequestFilter;
 use BeSimple\SoapCommon\SoapResponse;
 use BeSimple\SoapCommon\SoapResponseFilter;
 
@@ -72,4 +67,4 @@ class XmlMimeFilter implements SoapResponseFilter
         }
 
     }
-}
+}

src/BeSimple/SoapWsdl/Dumper/Dumper.php

@@ -14,7 +14,6 @@ namespace BeSimple\SoapWsdl\Dumper;
 
 use BeSimple\SoapCommon\Definition\Definition;
 use BeSimple\SoapCommon\Definition\Method;
-use BeSimple\SoapCommon\Definition\Part;
 use BeSimple\SoapCommon\Definition\Type\ArrayOfType;
 use BeSimple\SoapCommon\Definition\Type\ComplexType;