wpetit/super-graph
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove other allocations in psql

Browse Source
This commit is contained in:
Vikram Rangnekar
2019-06-01 19:48:42 -04:00
parent 77e56643c5
commit f9fc5dd7de
5 changed files with 152 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
psql/psql.go
View File

@ -44,20 +44,24 @@ func (c *Compiler) IDColumn(table string) string {
return t.PrimaryCol
}
func (c *Compiler) Compile(qc *qcode.QCode) (uint32, []byte, error) {
func (c *Compiler) CompileEx(qc *qcode.QCode) (uint32, []byte, error) {
w := &bytes.Buffer{}
skipped, err := c.Compile(qc, w)
return skipped, w.Bytes(), err
}
func (c *Compiler) Compile(qc *qcode.QCode, w *bytes.Buffer) (uint32, error) {
if len(qc.Query.Selects) == 0 {
return 0, nil, errors.New("empty query")
return 0, errors.New("empty query")
}
root := &qc.Query.Selects[0]
st := util.NewStack()
ti, err := c.getTable(root)
if err != nil {
return 0, nil, err
return 0, err
}
w := &bytes.Buffer{}
st.Push(&selectBlockClose{nil, root})
st.Push(&selectBlock{nil, root, qc, ti, c})
@ -82,7 +86,7 @@ func (c *Compiler) Compile(qc *qcode.QCode) (uint32, []byte, error) {
case *selectBlock:
skipped, err := v.render(w)
if err != nil {
return 0, nil, err
return 0, err
}
ignored |= skipped
@ -94,7 +98,7 @@ func (c *Compiler) Compile(qc *qcode.QCode) (uint32, []byte, error) {
ti, err := c.getTable(child)
if err != nil {
return 0, nil, err
return 0, err
}
st.Push(&joinClose{child})
@ -113,7 +117,7 @@ func (c *Compiler) Compile(qc *qcode.QCode) (uint32, []byte, error) {
}
if err != nil {
return 0, nil, err
return 0, err
}
}
@ -121,7 +125,7 @@ func (c *Compiler) Compile(qc *qcode.QCode) (uint32, []byte, error) {
alias(w, `done_1337`)
w.WriteString(`;`)
return ignored, w.Bytes(), nil
return ignored, nil
}
func (c *Compiler) getTable(sel *qcode.Select) (*DBTableInfo, error) {

13
psql/psql_test.go
View File

@ -1,6 +1,7 @@
package psql
import (
"bytes"
"log"
"os"
"testing"
@ -128,7 +129,7 @@ func compileGQLToPSQL(gql string) ([]byte, error) {
return nil, err
}
_, sqlStmt, err := pcompile.Compile(qc)
_, sqlStmt, err := pcompile.CompileEx(qc)
if err != nil {
return nil, err
}
@ -503,13 +504,21 @@ func BenchmarkCompileGQLToSQL(b *testing.B) {
}
}`
w := &bytes.Buffer()
b.ResetTimer()
b.ReportAllocs()
for n := 0; n < b.N; n++ {
_, err := compileGQLToPSQL(gql)
qc, err := qcompile.CompileQuery(gql)
if err != nil {
b.Fatal(err)
}
_, sqlStmt, err := pcompile.Compile(qc, w)
if err != nil {
b.Fatal(err)
}
w.Reset()
}
}