From 14d13c238aede974a4aeac77eefc2336ee83acb8 Mon Sep 17 00:00:00 2001 From: William Petit Date: Thu, 5 Dec 2019 13:10:43 +0100 Subject: [PATCH 1/3] Ignore card move in the same lane --- client/src/store/sagas/kanboards.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/client/src/store/sagas/kanboards.js b/client/src/store/sagas/kanboards.js index 3dce6ff..818f94b 100644 --- a/client/src/store/sagas/kanboards.js +++ b/client/src/store/sagas/kanboards.js @@ -10,6 +10,8 @@ export function* moveCardSaga(action) { toPosition, } = action; + if (fromLaneID === toLaneID) return; + const { board, kanboard} = yield select(state => { return { kanboard: state.kanboards.byID[boardID], From 39e2de3ff1cd2418a3b81cb96b17d3683e508f92 Mon Sep 17 00:00:00 2001 From: William Petit Date: Thu, 5 Dec 2019 13:10:58 +0100 Subject: [PATCH 2/3] Remove console.log() --- client/src/store/reducers/kanboards.js | 1 - 1 file changed, 1 deletion(-) diff --git a/client/src/store/reducers/kanboards.js b/client/src/store/reducers/kanboards.js index f193ce6..036d82e 100644 --- a/client/src/store/reducers/kanboards.js +++ b/client/src/store/reducers/kanboards.js @@ -58,7 +58,6 @@ function handleMoveCard(state, action) { } else { fromCards.splice(fromPosition, 1); fromCards.splice(toPosition, 0, card); - console.log(fromCards) } return { From d374999d88372ac68fa06cfaba6f20a9bc675759 Mon Sep 17 00:00:00 2001 From: William Petit Date: Thu, 5 Dec 2019 13:11:32 +0100 Subject: [PATCH 3/3] Clean client generated files --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index 9f60a3d..3c76bc7 100644 --- a/Makefile +++ b/Makefile @@ -26,5 +26,7 @@ clean: rm -rf release rm -rf vendor rm -rf bin + rm -rf client/node_modules + rm -rf client/dist/* .PHONY: lint watch build vendor tidy release \ No newline at end of file