feat(test): adding tests for the "File" struct

feat(test): moving util funcs into utils module
This commit is contained in:
Philippe Caseiro 2022-07-06 14:35:29 +02:00
parent d9379f7e33
commit d58edd7166
8 changed files with 296 additions and 92 deletions

View File

@ -0,0 +1,66 @@
{
"ConfigFiles": [
{
"destination": "/etc/loki/loki-local-config.yaml",
"group": "grafana",
"mode": "600",
"owner": "loki",
"service": "loki",
"source": "loki-local-config.pktpl.hcl"
}
],
"Daemons": {
"Loki": {
"enabled": true,
"name": "loki"
}
},
"Packages": {
"loki": {
"action": "install",
"name": "loki"
},
"nodeExporter": {
"action": "install",
"name": "prometheus-node-exporter"
},
"promtail": {
"action": "install",
"name": "loki-promtail"
}
},
"Repositories": {
"AlpineTesting": {
"enabled": true,
"name": "testing",
"type": "apk",
"url": "http://mirrors.bfsu.edu.cn/alpine/edge/testing"
}
},
"Users": {
"loki": {
"group": "grafana",
"home": "/srv/loki",
"shell": "/bin/nologin",
"username": "loki"
}
},
"Vars": {
"AlertManagerURL": "http://localhost:9092",
"AuthEnabled": false,
"GRPCPort": "9095",
"Group": "grafana",
"HTTPPort": "3099",
"LogLevel": "error",
"ObjectStore": "filesystem",
"S2": {
"APIKey": "",
"APISecretKey": "",
"BucketName": "",
"URL": ""
},
"SharedStore": "filesystem",
"StorageRoot": "/var/loki",
"User": "loki"
}
}

View File

@ -0,0 +1,13 @@
### Go template test ###
{{ if .Vars.AuthEnabled }}
auth_enabled: true
{{ else }}
auth_enabled: false
{{ end }}
server:
http_listen_port: {{ .Vars.HTTPPort }}
grpc_listen_port: {{ .Vars.GRPCPort }}
log_level: {{ .Vars.LogLevel }}
### End Go template test ###

View File

@ -0,0 +1,12 @@
### HCL2 Template test ###
%{ if Vars.AuthEnabled ~}
auth_enabled: true
%{ else }
auth_enabled: false
%{ endif }
server:
http_listen_port: ${Vars.HTTPPort}
grpc_listen_port: ${Vars.GRPCPort}
log_level: ${Vars.LogLevel}
### END HCL Template test ###

View File

@ -1,13 +1,13 @@
{{ if .AuthEnabled }} {{ if .Vars.AuthEnabled }}
auth_enabled: true auth_enabled: true
{{ else }} {{ else }}
auth_enabled: false auth_enabled: false
{{ end }} {{ end }}
server: server:
http_listen_port: {{ .HTTPPort }} http_listen_port: {{ .Vars.HTTPPort }}
grpc_listen_port: {{ .GRPCPort }} grpc_listen_port: {{ .Vars.GRPCPort }}
log_level: {{ .LogLevel }} log_level: {{ .Vars.LogLevel }}
ingester: ingester:
wal: wal:

View File

@ -5,16 +5,8 @@ import (
"path/filepath" "path/filepath"
"strconv" "strconv"
"bytes"
encjson "encoding/json"
"fmt" "fmt"
"os" "os"
"text/template"
"github.com/hashicorp/hcl/v2"
"github.com/hashicorp/hcl/v2/hclsyntax"
"github.com/zclconf/go-cty/cty"
ctyjson "github.com/zclconf/go-cty/cty/json"
"forge.cadoles.com/pcaseiro/templatefile/pkg/utils" "forge.cadoles.com/pcaseiro/templatefile/pkg/utils"
) )
@ -27,19 +19,20 @@ type ConfigFile struct {
Owner string `json:"owner"` // The configuration file owner Owner string `json:"owner"` // The configuration file owner
Service string `json:"service"` // Service to restart after configuration generation Service string `json:"service"` // Service to restart after configuration generation
Group string `json:"group"` // The configuration file group owner Group string `json:"group"` // The configuration file group owner
TemplateDir string
} }
// Generate the configuration file from the template (hcl or json) // Generate the configuration file from the template (hcl or json)
func (cf *ConfigFile) Generate(root string, templateDir string, values []byte) error { func (cf *ConfigFile) Generate(root string, templateDir string, values []byte) error {
var template string var template string
cf.TemplateDir = templateDir
dest := filepath.Join(root, cf.Destination) dest := filepath.Join(root, cf.Destination)
source := filepath.Join(templateDir, cf.Source)
intMod, err := strconv.ParseInt(cf.Mode, 8, 64) intMod, err := strconv.ParseInt(cf.Mode, 8, 64)
if err != nil { if err != nil {
return (err) return (err)
} }
template, err = cf.ProcessTemplate(source, values) template, err = cf.ProcessTemplate(root, values)
if err != nil { if err != nil {
return fmt.Errorf("Process templates failed with error: %v", err) return fmt.Errorf("Process templates failed with error: %v", err)
} }
@ -57,97 +50,22 @@ func (cf *ConfigFile) Generate(root string, templateDir string, values []byte) e
} }
// Process the template with the provided values // Process the template with the provided values
func (cf *ConfigFile) ProcessTemplate(source string, values []byte) (string, error) { func (cf *ConfigFile) ProcessTemplate(root string, values []byte) (string, error) {
var result string var result string
var err error var err error
if cf.TemplateType == "hcl" { if cf.TemplateType == "hcl" {
// The template is an hcl template so we call processHCLTemplate // The template is an hcl template so we call processHCLTemplate
result, err = cf.processHCLTemplate(source, values) result, err = utils.ProcessHCLTemplate(filepath.Join(cf.TemplateDir, cf.Source), values)
if err != nil { if err != nil {
return "", fmt.Errorf("Process HCL template failed with error: %v", err) return "", fmt.Errorf("Process HCL template failed with error: %v", err)
} }
} else if cf.TemplateType == "go" { } else if cf.TemplateType == "go" {
// The template is a go template so we call processGoTemplate // The template is a go template so we call processGoTemplate
result, err = cf.processGoTemplate(source, values) result, err = utils.ProcessGoTemplate(filepath.Join(cf.TemplateDir, cf.Source), values)
if err != nil { if err != nil {
return "", fmt.Errorf("Process GO template failed with error: %v", err) return "", fmt.Errorf("Process GO template failed with error: %v", err)
} }
} }
return result, nil return result, nil
} }
// The actual template processing for Go templates
func (cf *ConfigFile) processGoTemplate(file string, configValues []byte) (string, error) {
// The JSON configuration
var confData map[string]interface{}
var res bytes.Buffer
err := encjson.Unmarshal(configValues, &confData)
utils.CheckErr(err)
// Read the template
data, err := os.ReadFile(file)
utils.CheckErr(err)
tpl, err := template.New("conf").Parse(string(data))
utils.CheckErr(err)
utils.CheckErr(tpl.Execute(&res, confData["Config"]))
return res.String(), nil
}
// The actual template processing for HCL templates
func (cf *ConfigFile) processHCLTemplate(file string, config []byte) (string, error) {
fct, err := os.ReadFile(file)
utils.CheckErr(err)
expr, diags := hclsyntax.ParseTemplate(fct, file, hcl.Pos{Line: 0, Column: 1})
utils.CheckDiags(diags)
// Retrieve values from JSON
var varsVal cty.Value
ctyType, err := ctyjson.ImpliedType(config)
if err != nil {
return "", err
/* Maybe one day
cexpr, diags := hclsyntax.ParseExpression(config, "", hcl.Pos{Line: 0, Column: 1})
if diags.HasErrors() {
panic(diags.Error())
}
varsVal, diags = cexpr.Value(&hcl.EvalContext{})
fmt.Println(cexpr.Variables())
checkDiags(diags)
*/
} else {
varsVal, err = ctyjson.Unmarshal(config, ctyType)
utils.CheckErr(err)
}
ctx := &hcl.EvalContext{
Variables: varsVal.AsValueMap(),
}
for n := range ctx.Variables {
if !hclsyntax.ValidIdentifier(n) {
return "", fmt.Errorf("invalid template variable name %q: must start with a letter, followed by zero or more letters, digits, and underscores", n)
}
}
for _, traversal := range expr.Variables() {
root := traversal.RootName()
if _, ok := ctx.Variables[root]; !ok {
return "", fmt.Errorf("vars map does not contain key %q, referenced at %s", root, traversal[0].SourceRange())
}
}
val, diags := expr.Value(ctx)
if diags.HasErrors() {
return "", diags
}
return val.AsString(), nil
}

View File

@ -0,0 +1,72 @@
package templater
import (
"io/ioutil"
"testing"
)
func TestProcessHCLTemplate(t *testing.T) {
// load the Full configuration from a file
values, err := ioutil.ReadFile("../../data/config/loki-stack.json")
if err != nil {
t.Error(err)
}
_, err = processHCLTemplate("../../data/templates/loki-local-config.tpl", values)
if err != nil {
t.Errorf(err.Error())
}
}
func TestProcessGoTemplate(t *testing.T) {
// load the Full configuration from a file
values, err := ioutil.ReadFile("../../data/config/loki-stack.json")
if err != nil {
t.Error(err)
}
_, err = processGoTemplate("../../data/templates/loki-local-config.tpl", values)
if err != nil {
t.Error(err)
}
}
func TestProcessTemplate(t *testing.T) {
goFile := ConfigFile{
Destination: "/tmp/test.txt",
Source: "loki-local-config.tpl",
TemplateType: "go",
Mode: "700",
TemplateDir: "../../data/templates/",
}
values, err := ioutil.ReadFile("../../data/config/loki-stack.json")
if err != nil {
t.Error(err)
}
_, err = goFile.ProcessTemplate("/tmp/", values)
if err != nil {
t.Errorf(err.Error())
}
}
/*
func TestGenerate(t *testing.T) {
tFile := ConfigFile{
Destination: "/tmp/test.txt",
Source: "../../data/templates/loki-local-config.tpl",
TemplateType: "go",
Mode: "700",
}
values := json.Unmarshal(File.)
_, err := tFile.Generate("/tmp/","../../data/templates/",values)
if err != nil {
t.Errorf(err.Error())
}
}
*/

89
pkg/utils/templates.go Normal file
View File

@ -0,0 +1,89 @@
package utils
import (
"bytes"
"encoding/json"
"fmt"
"os"
"text/template"
"github.com/hashicorp/hcl/v2"
"github.com/hashicorp/hcl/v2/hclsyntax"
"github.com/zclconf/go-cty/cty"
ctyjson "github.com/zclconf/go-cty/cty/json"
)
// The actual template processing for Go templates
func ProcessGoTemplate(file string, configValues []byte) (string, error) {
// The JSON configuration
var confData map[string]interface{}
var res bytes.Buffer
err := json.Unmarshal(configValues, &confData)
CheckErr(err)
// Read the template
templateData, err := os.ReadFile(file)
CheckErr(err)
tpl, err := template.New("conf").Parse(string(templateData))
CheckErr(err)
CheckErr(tpl.Execute(&res, confData))
return res.String(), nil
}
// The actual template processing for HCL templates
func ProcessHCLTemplate(file string, config []byte) (string, error) {
fct, err := os.ReadFile(file)
CheckErr(err)
expr, diags := hclsyntax.ParseTemplate(fct, file, hcl.Pos{Line: 0, Column: 1})
CheckDiags(diags)
// Retrieve values from JSON
var varsVal cty.Value
ctyType, err := ctyjson.ImpliedType(config)
if err != nil {
return "", err
/* Maybe one day
cexpr, diags := hclsyntax.ParseExpression(config, "", hcl.Pos{Line: 0, Column: 1})
if diags.HasErrors() {
panic(diags.Error())
}
varsVal, diags = cexpr.Value(&hcl.EvalContext{})
fmt.Println(cexpr.Variables())
checkDiags(diags)
*/
} else {
varsVal, err = ctyjson.Unmarshal(config, ctyType)
CheckErr(err)
}
ctx := &hcl.EvalContext{
Variables: varsVal.AsValueMap(),
}
for n := range ctx.Variables {
if !hclsyntax.ValidIdentifier(n) {
return "", fmt.Errorf("invalid template variable name %q: must start with a letter, followed by zero or more letters, digits, and underscores", n)
}
}
for _, traversal := range expr.Variables() {
root := traversal.RootName()
if _, ok := ctx.Variables[root]; !ok {
return "", fmt.Errorf("vars map does not contain key %q, referenced at %s", root, traversal[0].SourceRange())
}
}
val, diags := expr.Value(ctx)
if diags.HasErrors() {
return "", diags
}
return val.AsString(), nil
}

View File

@ -0,0 +1,34 @@
package utils
import (
"io/ioutil"
"testing"
)
func TestProcessHCLTemplate(t *testing.T) {
// load the Full configuration from a file
values, err := ioutil.ReadFile("../../data/config/go-test-conf.json")
if err != nil {
t.Error(err)
}
data, err := ProcessHCLTemplate("../../data/templates/go-test-hcl.pktpl.hcl", values)
if err != nil {
t.Errorf(err.Error())
}
t.Logf("%s", data)
}
func TestProcessGoTemplate(t *testing.T) {
// load values from testing json file
values, err := ioutil.ReadFile("../../data/config/go-test-conf.json")
if err != nil {
t.Error(err)
}
data, err := ProcessGoTemplate("../../data/templates/go-test-go.tpl", values)
if err != nil {
t.Error(err)
}
t.Logf("%s", data)
}