fix: prevent bus congestion by flushing out messages

pkg/module/rpc.go

@@ -123,79 +123,83 @@ func (m *RPCModule) handleMessages() {
 	}
 
 	for msg := range clientMessages {
-		clientMessage, ok := msg.(*ClientMessage)
-		if !ok {
-			logger.Warn(ctx, "unexpected bus message", logger.F("message", msg))
+		go m.handleMessage(ctx, msg, sendRes)
+	}
+}
 
-			continue
-		}
+func (m *RPCModule) handleMessage(ctx context.Context, msg bus.Message, sendRes func(ctx context.Context, req *RPCRequest, result goja.Value)) {
+	clientMessage, ok := msg.(*ClientMessage)
+	if !ok {
+		logger.Warn(ctx, "unexpected bus message", logger.F("message", msg))
 
-		ok, req := m.isRPCRequest(clientMessage)
-		if !ok {
-			continue
-		}
+		return
+	}
 
-		logger.Debug(ctx, "received rpc request", logger.F("request", req))
+	ok, req := m.isRPCRequest(clientMessage)
+	if !ok {
+		return
+	}
 
-		rawCallable, exists := m.callbacks.Load(req.Method)
-		if !exists {
-			logger.Debug(ctx, "method not found", logger.F("req", req))
+	logger.Debug(ctx, "received rpc request", logger.F("request", req))
 
-			if err := m.sendMethodNotFoundResponse(clientMessage.Context, req); err != nil {
-				logger.Error(
-					ctx, "could not send method not found response",
-					logger.E(errors.WithStack(err)),
-					logger.F("request", req),
-				)
-			}
+	rawCallable, exists := m.callbacks.Load(req.Method)
+	if !exists {
+		logger.Debug(ctx, "method not found", logger.F("req", req))
 
-			continue
-		}
-
-		callable, ok := rawCallable.(goja.Callable)
-		if !ok {
-			logger.Debug(ctx, "invalid method", logger.F("req", req))
-
-			if err := m.sendMethodNotFoundResponse(clientMessage.Context, req); err != nil {
-				logger.Error(
-					ctx, "could not send method not found response",
-					logger.E(errors.WithStack(err)),
-					logger.F("request", req),
-				)
-			}
-
-			continue
-		}
-
-		result, err := m.server.Exec(clientMessage.Context, callable, clientMessage.Context, req.Params)
-		if err != nil {
+		if err := m.sendMethodNotFoundResponse(clientMessage.Context, req); err != nil {
 			logger.Error(
-				ctx, "rpc call error",
+				ctx, "could not send method not found response",
 				logger.E(errors.WithStack(err)),
 				logger.F("request", req),
 			)
-
-			if err := m.sendErrorResponse(clientMessage.Context, req, err); err != nil {
-				logger.Error(
-					ctx, "could not send error response",
-					logger.E(errors.WithStack(err)),
-					logger.F("originalError", err),
-					logger.F("request", req),
-				)
-			}
-
-			continue
 		}
 
-		promise, ok := app.IsPromise(result)
-		if ok {
-			go func(ctx context.Context, req *RPCRequest, promise *goja.Promise) {
-				result := m.server.WaitForPromise(promise)
-				sendRes(ctx, req, result)
-			}(clientMessage.Context, req, promise)
-		} else {
-			sendRes(clientMessage.Context, req, result)
+		return
+	}
+
+	callable, ok := rawCallable.(goja.Callable)
+	if !ok {
+		logger.Debug(ctx, "invalid method", logger.F("req", req))
+
+		if err := m.sendMethodNotFoundResponse(clientMessage.Context, req); err != nil {
+			logger.Error(
+				ctx, "could not send method not found response",
+				logger.E(errors.WithStack(err)),
+				logger.F("request", req),
+			)
 		}
+
+		return
+	}
+
+	result, err := m.server.Exec(clientMessage.Context, callable, clientMessage.Context, req.Params)
+	if err != nil {
+		logger.Error(
+			ctx, "rpc call error",
+			logger.E(errors.WithStack(err)),
+			logger.F("request", req),
+		)
+
+		if err := m.sendErrorResponse(clientMessage.Context, req, err); err != nil {
+			logger.Error(
+				ctx, "could not send error response",
+				logger.E(errors.WithStack(err)),
+				logger.F("originalError", err),
+				logger.F("request", req),
+			)
+		}
+
+		return
+	}
+
+	promise, ok := app.IsPromise(result)
+	if ok {
+		go func(ctx context.Context, req *RPCRequest, promise *goja.Promise) {
+			result := m.server.WaitForPromise(promise)
+			sendRes(ctx, req, result)
+		}(clientMessage.Context, req, promise)
+	} else {
+		sendRes(clientMessage.Context, req, result)
 	}
 }