Cleaning code to please the linter

Added feature for #145
Fix bug #145
This commit is contained in:
Philippe Caseiro 2018-09-21 16:57:02 +02:00
parent f769ca382e
commit 364dfecb31
4 changed files with 12 additions and 3 deletions

2
go.mod
View File

@ -3,7 +3,7 @@ module forge.cadoles.com/Pyxis/orion
require ( require (
forge.cadoles.com/Pyxis/golang-socketio v0.0.0-20180919100209-bb857ced6b95 forge.cadoles.com/Pyxis/golang-socketio v0.0.0-20180919100209-bb857ced6b95
github.com/caarlos0/env v3.3.0+incompatible github.com/caarlos0/env v3.3.0+incompatible
github.com/davecgh/go-spew v1.1.1 // indirect github.com/davecgh/go-spew v1.1.1
github.com/go-chi/chi v3.3.3+incompatible github.com/go-chi/chi v3.3.3+incompatible
github.com/gorilla/websocket v1.4.0 // indirect github.com/gorilla/websocket v1.4.0 // indirect
github.com/mitchellh/mapstructure v1.0.0 github.com/mitchellh/mapstructure v1.0.0

View File

@ -24,7 +24,7 @@ func NewNetworkWithExecutor(exe Executor) *Network {
return &Network{exec} return &Network{exec}
} }
// ListInterfaces list all available interfaces on a system using "ip" commmand // ListInterfaces list all available interfaces on a system using "ip" command
func (n *Network) ListInterfaces() []net.Interface { func (n *Network) ListInterfaces() []net.Interface {
var result []net.Interface var result []net.Interface
ifaces, err := net.Interfaces() ifaces, err := net.Interfaces()

View File

@ -22,6 +22,15 @@ func TestUCIAdd(t *testing.T) {
} }
} }
func TestUCIAddFailed(t *testing.T) {
exec := createMockExecutor("", "BigError", 3)
uci := NewUCIWithExecutor(exec)
res := uci.Add("wireless", "test")
if res.ReturnCode != 3 {
t.Error("Bad Return Code !")
}
}
func TestUCIDelete(t *testing.T) { func TestUCIDelete(t *testing.T) {
exec := createMockExecutor("", "", 0) exec := createMockExecutor("", "", 0)
uci := NewUCIWithExecutor(exec) uci := NewUCIWithExecutor(exec)

View File

@ -61,7 +61,7 @@ func (w *Wifi) parseWifiCells(stdout string) int {
return 0 return 0
} }
// GetWifiCells retrieves all availabe wifi cells for a card ! // GetWifiCells retrieves all available wifi cells for a card !
func (w *Wifi) GetWifiCells() int { func (w *Wifi) GetWifiCells() int {
res := w.exec.Run("iwinfo", w.iface, "scan") res := w.exec.Run("iwinfo", w.iface, "scan")
if res.ReturnCode != 0 { if res.ReturnCode != 0 {