Commit Graph

255 Commits

Author SHA1 Message Date
Daniel Dehennin 2cb3ddf2e8 Fix line wrapping and some raise messages spacing
* tiramisu/option.py (Multi.append): do not wrapp short line.
  (validate_requires_arg): Add missing space for multi line strings.
2013-01-31 17:09:59 +01:00
Daniel Dehennin 03baedd4dd Fix appending to a non-grouped multi
When the multi is not grouped, just set the value and do not try to
update len of inexistant slaves.

The code path try to update the len of all other variables under the
OptionDescription of the multi.

* tiramisu/option.py (Multi.append): return after setting the value.

Fixes: #4811 @10m
2013-01-31 17:09:59 +01:00
Daniel Dehennin 170698a5e3 Find breaks on "disabled" property
The exception was raised during unwrap_from_path() call.

* tiramisu/config.py (_filter_by_attrs): do not catch exception arround
  getattr().
  (_find): continue to next option if unwrap_from_path() raise
  PropertiesOptionError.

Fixes: #4728 @5m
2013-01-31 14:38:48 +01:00
Daniel Dehennin f494bb1502 Better raise message
* tiramisu/config.py (Config._valid_len): use master and slave name and
  value.
2013-01-30 18:04:55 +01:00
Daniel Dehennin 184c48db8c Do not append default value on already defined multi slaves
* tiramisu/option.py (Multi.append): append the default value when the
  slaves have no item or lesser than the master.
  Divide looping over slaves by factor 2.

Fixes: #4799 @4h
2013-01-30 18:04:55 +01:00
Daniel Dehennin 064bed9efa Fix infinite recursion on calculated master of multi variable
There was a infinite recursion between option.Multi.append() and
config.Config._getattr() through config.Config.fill_multi() when
calculating the master:

- config.Config._getattr()
-> config.Config.fill_multi()
-> option.Multi.__init__()
-> option.Multi.append()
-> config.Config._getattr()

* tiramisu/option.py (Multi.append): do not pass by
  config.Config._getattr().

* tiramisu/option.py (Multi.__init__): do not catch exception when
  appending.

Ref: #4799 @8h
2013-01-30 18:04:46 +01:00
Daniel Dehennin deaa0942ff Remove useless returns and variables
* tiramisu/option.py (Multi.__setitem__): Do not returns.
  (Multi.append): Ditoo.
  Remove useless "ret" variable.
  (Multi._setvalue): Ditoo.
  (Multi.pop): Do not set "ret" to None, raise if "ret" is not in "locals()"
  (Multi._pop): Avoid useless "oldvalue" variable.
2013-01-30 09:19:48 +01:00
Daniel Dehennin f267073e0d Variable "ret" referenced before assignment
Variable defined in sub-scope ("for", "if") are not defined above.

* tiramisu/option.py (Multi.append): Define "ret" to None.

* tiramisu/option.py (Multi._setvalue): Ditoo.

* tiramisu/option.py (Multi.pop): Ditoo.
2013-01-29 15:21:31 +01:00
gwen e2a02c5b7a find raises an exception if no option found Fixes #4721 2013-01-28 09:55:51 +01:00
gwen c66dcd09ee substitute properties/permissivers in apply_requries 2013-01-28 09:33:08 +01:00
gwen 189053ad03 master subgroups that have subgroups 2013-01-11 09:46:41 +01:00
gwen f9d6f62a70 multi defaults value addition cinematics 2013-01-10 12:03:59 +01:00
gwen e70054c4d4 owners for multi options 2012-12-11 16:22:02 +01:00
gwen cda5d8c0bd generic owners shall live in settings 2012-12-11 11:18:53 +01:00
gwen ca2f4487dd add owner 2012-12-10 14:38:25 +01:00
gwen cd50cf7551 owners are *real* objects now 2012-12-10 14:10:05 +01:00
gwen 07d3cb1037 constants heritage 2012-12-10 09:53:13 +01:00
gwen e118f07539 groupe_types are real types now 2012-12-06 18:14:57 +01:00
gwen 9736298ba2 tests on groups/masters allowed groups 2012-12-06 15:19:43 +01:00
gwen 69d747baec comments on the code 2012-12-05 11:12:04 +01:00
gwen 7574ac43aa Multi()'s and append 2012-12-05 10:54:32 +01:00
gwen 7784a82cde tests on group types 2012-12-05 09:41:53 +01:00
gwen 0db34bbeba master len without getattr 2012-12-04 16:22:39 +01:00
gwen 6538231817 pop and append in multi values 2012-12-04 15:18:13 +01:00
gwen 4393da13ab validation of the len of the multi in a group 2012-12-04 12:06:26 +01:00
gwen d633574cc5 comparison failed 2012-12-03 15:48:04 +01:00
gwen 2dfc906966 symlink has an option's API 2012-11-30 16:23:40 +01:00
gwen 43af9cf7f7 getkey() and __eq__ for a SymLink 2012-11-30 15:08:34 +01:00
gwen e0490c2bed add permissive in the requirements 2012-11-30 10:47:35 +01:00
gwen 1dea71c17f getdefault returns the default_multi 2012-11-29 11:40:52 +01:00
gwen de47772958 string representation for a symlink option 2012-11-29 10:15:30 +01:00
gwen d9c8e06236 config's string representation 2012-11-28 10:14:16 +01:00
gwen bf112bc756 custom validator for multis 2012-11-22 11:53:51 +01:00
gwen 426e64ca39 is_default in _getattr 2012-11-22 10:19:13 +01:00
gwen ede518428a doc: migrated to sphinx 2012-11-20 17:15:34 +01:00
gwen 79cf82e328 doc: migrated to sphinx 2012-11-20 17:14:58 +01:00
gwen 60ef6cc2b4 doc 2012-11-20 09:15:29 +01:00
gwen e13fec23fe doc for the settings 2012-11-19 16:48:47 +01:00
gwen 86f9096937 settings are in a separate object 2012-11-19 10:45:03 +01:00
gwen 5969eaa2d6 add custom validator 2012-11-19 09:51:40 +01:00
gwen b353c6ba60 modification of reset's arity 2012-11-16 10:04:25 +01:00
gwen e0bf9faf5c default_multi method 2012-11-15 14:59:36 +01:00
gwen eb7e393864 the value owner is a string now 2012-11-15 10:55:14 +01:00
gwen 5d23a4d921 doc 2012-11-14 11:34:31 +01:00
gwen cf606a0d7e doc 2012-11-14 11:33:49 +01:00
gwen b46651ae7c reset() doc 2012-11-14 11:30:11 +01:00
gwen 09dba4b959 suppression of the override 2012-11-12 12:06:58 +01:00
gwen 1de236d2a8 at_index to check owners 2012-11-08 09:57:29 +01:00
gwen 407c74008c docstrings for special params 2012-11-08 09:03:28 +01:00
gwen 307a3a00a8 permissive getattr in mandatory_warnings() 2012-11-07 17:14:50 +01:00