From 7c710d50b977fa228aebef56caf593713f4735f9 Mon Sep 17 00:00:00 2001 From: Emmanuel Garette Date: Sun, 24 Feb 2019 11:53:30 +0100 Subject: [PATCH] IPy => ipaddress --- test/test_config_ip.py | 6 +- tiramisu/option/broadcastoption.py | 7 ++- tiramisu/option/domainnameoption.py | 8 ++- tiramisu/option/ipoption.py | 15 ++--- tiramisu/option/netmaskoption.py | 92 +++++++++++++++-------------- tiramisu/option/networkoption.py | 9 +-- 6 files changed, 73 insertions(+), 64 deletions(-) diff --git a/test/test_config_ip.py b/test/test_config_ip.py index a515808..3c4713d 100644 --- a/test/test_config_ip.py +++ b/test/test_config_ip.py @@ -52,10 +52,10 @@ def test_ip_reserved(): od = OptionDescription('od', '', [a, b, c]) warnings.simplefilter("always", ValueWarning) cfg = Config(od) - raises(ValueError, "cfg.option('a').value.set('226.94.1.1')") - cfg.option('b').value.set('226.94.1.1') + raises(ValueError, "cfg.option('a').value.set('240.94.1.1')") + cfg.option('b').value.set('240.94.1.1') with warnings.catch_warnings(record=True) as w: - cfg.option('c').value.set('226.94.1.1') + cfg.option('c').value.set('240.94.1.1') assert len(w) == 1 diff --git a/tiramisu/option/broadcastoption.py b/tiramisu/option/broadcastoption.py index 45d7fd4..04f3479 100644 --- a/tiramisu/option/broadcastoption.py +++ b/tiramisu/option/broadcastoption.py @@ -18,7 +18,7 @@ # the rough pypy's guys: http://codespeak.net/svn/pypy/dist/pypy/config/ # the whole pypy projet is under MIT licence # ____________________________________________________________ -from IPy import IP +from ipaddress import ip_address, IPv4Address, ip_network from ..error import ConfigError from ..setting import undefined, Undefined, OptionBag @@ -42,7 +42,8 @@ class BroadcastOption(Option): if val.startswith("0") and len(val) > 1: raise ValueError() try: - IP('{0}/32'.format(value)) + if not isinstance(ip_address(value), IPv4Address): + raise ValueError() except ValueError: raise ValueError() @@ -57,7 +58,7 @@ class BroadcastOption(Option): if None in vals: return broadcast, network, netmask = vals - if IP('{0}/{1}'.format(network, netmask)).broadcast() != IP(broadcast): + if ip_network('{0}/{1}'.format(network, netmask)).broadcast_address != ip_address(broadcast): raise ValueError(_('broadcast "{4}" invalid with network {0}/{1} ("{2}"/"{3}")' '').format(network, netmask, diff --git a/tiramisu/option/domainnameoption.py b/tiramisu/option/domainnameoption.py index eca772b..d1ad2d9 100644 --- a/tiramisu/option/domainnameoption.py +++ b/tiramisu/option/domainnameoption.py @@ -19,7 +19,7 @@ # the whole pypy projet is under MIT licence # ____________________________________________________________ import re -from IPy import IP +from ipaddress import ip_address, IPv4Address from ..setting import undefined, Undefined, OptionBag from ..i18n import _ @@ -113,14 +113,16 @@ class DomainnameOption(StrOption): raise ValueError(_('invalid string')) if self.impl_get_extra('_allow_ip') is True: try: - IP('{0}/32'.format(value)) + if not isinstance(ip_address(value), IPv4Address): + raise ValueError() except ValueError: pass else: return else: try: - IP('{0}/32'.format(value)) + if not isinstance(ip_address(value), IPv4Address): + raise ValueError() except ValueError: pass else: diff --git a/tiramisu/option/ipoption.py b/tiramisu/option/ipoption.py index 3ecbe5a..89f5423 100644 --- a/tiramisu/option/ipoption.py +++ b/tiramisu/option/ipoption.py @@ -18,7 +18,7 @@ # the rough pypy's guys: http://codespeak.net/svn/pypy/dist/pypy/config/ # the whole pypy projet is under MIT licence # ____________________________________________________________ -from IPy import IP +from ipaddress import ip_address, ip_network, IPv4Address from ..error import ConfigError from ..setting import undefined, Undefined, OptionBag @@ -78,21 +78,22 @@ class IPOption(StrOption): raise ValueError() # 'standard' validation try: - IP('{0}/32'.format(value)) + if not isinstance(ip_address(value), IPv4Address): + raise ValueError() except ValueError: raise ValueError() def _second_level_validation(self, value, warnings_only): - ip = IP('{0}/32'.format(value)) - if not self.impl_get_extra('_allow_reserved') and ip.iptype() == 'RESERVED': + ip = ip_address(value) + if not self.impl_get_extra('_allow_reserved') and ip.is_reserved: if warnings_only: msg = _("shouldn't in reserved class") else: msg = _("mustn't be in reserved class") raise ValueError(msg) - if self.impl_get_extra('_private_only') and ip.iptype() != 'PRIVATE': + if self.impl_get_extra('_private_only') and not ip.is_private: if warnings_only: msg = _("should be in private class") else: @@ -110,8 +111,8 @@ class IPOption(StrOption): if len(vals) != 3 or None in vals: return ip, network, netmask = vals - if IP(ip) not in IP('{0}/{1}'.format(network, - netmask)): + if ip_address(ip) not in ip_network('{0}/{1}'.format(network, + netmask)): msg = _('"{4}" is not in network "{0}"/"{1}" ("{2}"/"{3}")') raise ValueError(msg.format(network, netmask, diff --git a/tiramisu/option/netmaskoption.py b/tiramisu/option/netmaskoption.py index 8ad198f..9bb3eb6 100644 --- a/tiramisu/option/netmaskoption.py +++ b/tiramisu/option/netmaskoption.py @@ -18,7 +18,7 @@ # the rough pypy's guys: http://codespeak.net/svn/pypy/dist/pypy/config/ # the whole pypy projet is under MIT licence # ____________________________________________________________ -from IPy import IP +from ipaddress import ip_interface, ip_network from ..error import ConfigError from ..setting import undefined, OptionBag, Undefined @@ -44,7 +44,7 @@ class NetmaskOption(StrOption): if val.startswith("0") and len(val) > 1: raise ValueError() try: - IP('0.0.0.0/{0}'.format(value)) + ip_network('0.0.0.0/{0}'.format(value)) except ValueError: raise ValueError() @@ -59,13 +59,22 @@ class NetmaskOption(StrOption): raise ConfigError(_('network_netmask needs a network and a netmask')) if None in vals or len(vals) != 2: return - return self.__cons_netmask(current_opt, - opts, - vals[0], - vals[1], - False, - warnings_only, - 'network') + msg = None + val_netmask, val_ipnetwork = vals + try: + ip_network('{0}/{1}'.format(val_ipnetwork, val_netmask)) + except ValueError: + if current_opt == opts[1]: + raise ValueError(_('with netmask "{0}" ("{1}")').format(val_netmask, opts[0].impl_get_display_name())) + else: + raise ValueError(_('with network "{0}" ("{1}")').format(val_ipnetwork, opts[1].impl_get_display_name())) + if msg is not None: + self.raise_err(msg, + val_netmask, + val_ipnetwork, + current_opt, + opts, + 'network') def _cons_ip_netmask(self, current_opt, @@ -78,50 +87,45 @@ class NetmaskOption(StrOption): raise ConfigError(_('ip_netmask needs an IP and a netmask')) if None in vals or len(vals) != 2: return - self.__cons_netmask(current_opt, - opts, - vals[0], - vals[1], - True, - warnings_only, - 'ip') - - def __cons_netmask(self, - current_opt, - opts, - val_netmask, - val_ipnetwork, - make_net, - warnings_only, - typ): msg = None + val_netmask, val_ipnetwork = vals try: - ip = IP('{0}/{1}'.format(val_ipnetwork, val_netmask), make_net=make_net) - #if cidr == 32, ip same has network - if make_net and ip.prefixlen() != 32: - val_ip = IP(val_ipnetwork) - if ip.net() == val_ip: + ip = ip_interface('{0}/{1}'.format(val_ipnetwork, val_netmask)) + network = ip.network + #if not ip same has network + if str(network.netmask) != '255.255.255.255': + if ip.ip == network.network_address: if current_opt == opts[1]: msg = _('this is a network with netmask "{0}" ("{1}")') else: msg = _('this is a network with {2} "{0}" ("{1}")') - elif ip.broadcast() == val_ip: + elif ip.ip == network.broadcast_address: if current_opt == opts[1]: msg = _('this is a broadcast with netmask "{0}" ("{1}")') else: msg = _('this is a broadcast with {2} "{0}" ("{1}")') - except ValueError: - if not make_net: - if current_opt == opts[1]: - raise ValueError(_('with netmask "{0}" ("{1}")').format(val_netmask, opts[0].impl_get_display_name())) - else: - raise ValueError(_('with {2} "{0}" ("{1}")').format(val_ipnetwork, opts[1].impl_get_display_name(), typ)) + pass if msg is not None: - if current_opt == opts[1]: - raise ValueError(msg.format(val_netmask, - opts[1].impl_get_display_name())) - else: - raise ValueError(msg.format(val_ipnetwork, - opts[0].impl_get_display_name(), - typ)) + self.raise_err(msg, + val_netmask, + val_ipnetwork, + current_opt, + opts, + 'IP') + + + def raise_err(self, + msg, + val_netmask, + val_ipnetwork, + current_opt, + opts, + typ): + if current_opt == opts[1]: + raise ValueError(msg.format(val_netmask, + opts[1].impl_get_display_name())) + else: + raise ValueError(msg.format(val_ipnetwork, + opts[0].impl_get_display_name(), + typ)) diff --git a/tiramisu/option/networkoption.py b/tiramisu/option/networkoption.py index 375be74..3f2c9c0 100644 --- a/tiramisu/option/networkoption.py +++ b/tiramisu/option/networkoption.py @@ -18,7 +18,7 @@ # the rough pypy's guys: http://codespeak.net/svn/pypy/dist/pypy/config/ # the whole pypy projet is under MIT licence # ____________________________________________________________ -from IPy import IP +from ipaddress import ip_address, IPv4Address from ..setting import undefined from ..i18n import _ @@ -42,15 +42,16 @@ class NetworkOption(Option): if val.startswith("0") and len(val) > 1: raise ValueError() try: - IP(value) + if not isinstance(ip_address(value), IPv4Address): + raise ValueError() except ValueError: raise ValueError() def _second_level_validation(self, value, warnings_only): - ip = IP(value) - if ip.iptype() == 'RESERVED': + ip = ip_address(value) + if ip.is_reserved: if warnings_only: msg = _("shouldn't be in reserved class") else: