From 69da6ed5e689a50f567c0c2b9acdf664e3616c0f Mon Sep 17 00:00:00 2001
From: Emmanuel Garette <egarette@cadoles.com>
Date: Sat, 29 Sep 2018 21:39:58 +0200
Subject: [PATCH] coverage

---
 tiramisu/api.py                     | 8 ++++----
 tiramisu/config.py                  | 4 ++--
 tiramisu/storage/__init__.py        | 2 +-
 tiramisu/storage/sqlite3/storage.py | 2 +-
 tiramisu/storage/sqlite3/value.py   | 2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/tiramisu/api.py b/tiramisu/api.py
index ae47d91..4bb4fb6 100644
--- a/tiramisu/api.py
+++ b/tiramisu/api.py
@@ -736,10 +736,10 @@ class TiramisuContextValue(TiramisuContext):
                                                  **kwargs)
 
     def dict(self,
-                  flatten=False,
-                  withvalue=undefined,
-                  withoption=None,
-                  fullpath=False):
+             flatten=False,
+             withvalue=undefined,
+             withoption=None,
+             fullpath=False):
         """return dict with path as key and value"""
         if not self.config_bag.properties:
             config_bag = self.config_bag
diff --git a/tiramisu/config.py b/tiramisu/config.py
index 2567287..723d8cd 100644
--- a/tiramisu/config.py
+++ b/tiramisu/config.py
@@ -824,7 +824,7 @@ class KernelGroupConfig(_CommonConfig):
         """Setattr not in current KernelGroupConfig, but in each children
         """
         ret = []
-        if isinstance(self, KernelGroupConfig):
+        if self.impl_type == 'group':
             commit = True
         else:
             #Commit only one time
@@ -864,7 +864,7 @@ class KernelGroupConfig(_CommonConfig):
                                                  err._orig_opt))
             except (ValueError, SlaveError) as err:
                 ret.append(err)
-        if _commit and not isinstance(self, KernelGroupConfig):
+        if _commit and self.impl_type != 'group':
             self.cfgimpl_get_values()._p_.commit()
         return ret
 
diff --git a/tiramisu/storage/__init__.py b/tiramisu/storage/__init__.py
index 5866f3e..0911c2c 100644
--- a/tiramisu/storage/__init__.py
+++ b/tiramisu/storage/__init__.py
@@ -133,7 +133,7 @@ def delete_session(session_id):  # pragma: optional cover
     session = storage_module.storage.getsession()
     storage_module.value.delete_session(session_id)
     storage_module.storage.delete_session(session_id)
-    if session:
+    if session:  # pragma: no cover
         session.commit()
     del(session)
 
diff --git a/tiramisu/storage/sqlite3/storage.py b/tiramisu/storage/sqlite3/storage.py
index f872e77..128cb09 100644
--- a/tiramisu/storage/sqlite3/storage.py
+++ b/tiramisu/storage/sqlite3/storage.py
@@ -113,7 +113,7 @@ class Storage(object):
             try:
                 self.execute('INSERT INTO session(session, persistent) VALUES (?, ?)',
                              (session_id, persistent))
-            except sqlite3.IntegrityError:
+            except sqlite3.IntegrityError:  # pragma: no cover
                 raise ConflictError(_('session "{}" already used').format(session_id))
             self.session_id = self._cursor.lastrowid
         self.created = True
diff --git a/tiramisu/storage/sqlite3/value.py b/tiramisu/storage/sqlite3/value.py
index b470e10..4540a7f 100644
--- a/tiramisu/storage/sqlite3/value.py
+++ b/tiramisu/storage/sqlite3/value.py
@@ -172,7 +172,7 @@ class Values(Sqlite3DB):
             # autocreate owners
             try:
                 nowner = getattr(owners, owner[0])
-            except AttributeError:
+            except AttributeError:  # pragma: no cover
                 owners.addowner(owner[0])
                 nowner = getattr(owners, owner[0])
             if not with_value: