refactoring

debian/changelog

@@ -0,0 +1,5 @@
+rougail (0.1) unstable; urgency=low
+
+  * first version
+
+ -- Cadoles <contact@cadoles.com>  Tue, 31 Mar 2020 10:40:42 +0200

src/rougail/annotator.py

@@ -1,5 +1,6 @@
 # coding: utf-8
 from copy import copy
+from typing import List
 
 from collections import OrderedDict
 from os.path import join, basename
@@ -9,8 +10,9 @@ import imp
 
 from .i18n import _
 from .utils import normalize_family
-from .error import CreoleDictConsistencyError
+from .error import DictConsistencyError
 from .xmlreflector import HIGH_COMPATIBILITY
+from .config import variable_namespace
 
 #mode order is important
 modes_level = ('basic', 'normal', 'expert')
@@ -20,25 +22,9 @@ class Mode(object):
     def __init__(self, name, level):
         self.name = name
         self.level = level
-
-    def __cmp__(self, other):
-        return cmp(self.level, other.level)
-
-    def __eq__(self, other):
-        return self.level == other.level
-
-    def __ne__(self, other):
-        return self.level != other.level
-
     def __gt__(self, other):
         return other.level < self.level
 
-    def __ge__(self, other):
-        return not self.level < other.level
-
-    def __le__(self, other):
-        return not other.level < self.level
-
 
 def mode_factory():
     mode_obj = {}
@@ -49,11 +35,12 @@ def mode_factory():
 
 modes = mode_factory()
 
+
 # a CreoleObjSpace's attribute has some annotations
 # that shall not be present in the exported (flatened) XML
 ERASED_ATTRIBUTES = ('redefine', 'exists', 'fallback', 'optional', 'remove_check', 'namespace',
                      'remove_condition', 'path', 'instance_mode', 'index', 'is_in_leadership',
-                     'level', 'submulti')  # , '_real_container')
+                     'level')  # , '_real_container')
 ERASED_CONTAINER_ATTRIBUTES = ('id', 'container', 'group_id', 'group', 'container_group')
 
 FORCE_CHOICE = {'oui/non': ['oui', 'non'],
@@ -71,212 +58,82 @@ KEY_TYPE = {'variable': 'symlink',
             'URLOption': 'web_address',
             'FilenameOption': 'filename'}
 
-TYPE_PARAM_CHECK = ('string', 'python', 'eole', 'variable')
+TYPE_PARAM_CHECK = ('string', 'python', 'variable')
-TYPE_PARAM_CONDITION = ('string', 'python', 'number', 'eole', 'variable')
+TYPE_PARAM_CONDITION = ('string', 'python', 'number', 'variable')
-TYPE_PARAM_FILL = ('string', 'eole', 'number', 'context', 'variable')
+TYPE_PARAM_FILL = ('string', 'number', 'variable')
-
+CONVERSION = {'number': int}
-ERASED_FAMILY_ACTION_ATTRIBUTES = ('index', 'action')
 
 FREEZE_AUTOFREEZE_VARIABLE = 'module_instancie'
 
 
 class ServiceAnnotator:
     """Manage service's object
+    for example::
+        <services>
+            <service name="test">
+                <service_access service='ntp'>
+                    <port protocol='udp' service_accesslist='ntp_udp'>123</port>
+                </service_access>
+            </service>
+        </services>
     """
     def __init__(self, objectspace):
         self.space = objectspace.space
         self.paths = objectspace.paths
         self.objectspace = objectspace
-        """for example::
-                <service_access service='ntp'>
-                    <port protocol='udp' service_accesslist='ntp_udp'>123</port>
-                    <tcpwrapper>ntpd</tcpwrapper>
-                </service_access>
-        """
         self.grouplist_conditions = {}
         self.convert_services()
 
+    def gen_family(self,
+                   name,
+                   ):
+            family = self.objectspace.family()
+            family.name = name
+            family.doc = name
+            family.mode = None
+            return family
+
     def convert_services(self):
-        if hasattr(self.space, 'services'):
+        if not hasattr(self.space, 'services'):
-            if hasattr(self.space.services, 'service'):
+            return
-                subelts = dict()
+        if not hasattr(self.space.services, 'service'):
-                for idx, service in enumerate(self.space.services.service.values()):
+            del self.space.services
-                    family = self.objectspace.family()
+            return
-                    family.name = 'service{}'.format(idx)
+        self.space.services.hidden = True
-                    family.doc = service.name
+        families = {}
-                    family.family = OrderedDict()
+        for idx, service_name in enumerate(self.space.services.service.keys()):
-                    self.convert_service_to_family(family.name, family.family, service)
+            service = self.space.services.service[service_name]
-                    setattr(self.space.services, family.name, family)
+            new_service = self.objectspace.service()
-                del self.space.services.service
+            for elttype, values in vars(service).items():
-            else:
+                if elttype == 'name' or elttype in ERASED_ATTRIBUTES:
-                del self.space.services
+                    setattr(new_service, elttype, values)
-
-    def convert_service_to_family(self, service_name, service_family, service):
-        for elttype, values in vars(service).items():
-            if elttype in ['name', 'index']:
-                continue
-            family = self.objectspace.family()
-            family.name = elttype + 's'
-            if isinstance(values, dict):
-                values = list(values.values())
-            family.family = self.convert_subelement_service(elttype,
-                                                            values,
-                                                            'services.{}.{}'.format(service_name, family.name))
-            family.mode = None
-            service_family[family.name] = family
-
-    def convert_subelement_service(self, name, elts, path):
-        families = []
-        new_elts = self._reorder_elts(name, elts, True)
-        for index, elt_info in enumerate(new_elts):
-            elt = elt_info['elt']
-            elt_name = elt_info['elt_name']
-
-            # try to launch _update_xxxx() function
-            update_elt = '_update_' + elt_name
-            if hasattr(self, update_elt):
-                getattr(self, update_elt)(elt, index, path)
-            variables = []
-            subpath = '{}.{}{}'.format(path, name, index)
-            listname = '{}list'.format(name)
-            activate_path = '.'.join([subpath, 'activate'])
-            if elt in self.grouplist_conditions:
-                # FIXME transformer le activate qui disparait en boolean
-                self.objectspace.list_conditions.setdefault(listname,
-                                                            {}).setdefault(self.grouplist_conditions[elt],
-                                                                           []).append(activate_path)
-            for key in dir(elt):
-                if key.startswith('_') or key.endswith('_type') or key in ERASED_ATTRIBUTES:
                     continue
-                value = getattr(elt, key)
+                eltname = elttype + 's'
-                if isinstance(value, list):
+                family = self.gen_family(eltname)
-                    continue
+                if isinstance(values, dict):
-                if key == 'service':
+                    values = list(values.values())
-                    value = value.name
+                family.family = self.make_group_from_elts(service_name,
-                if key == listname:
+                                                          elttype,
-                    self.objectspace.list_conditions.setdefault(listname,
+                                                          values,
-                                                                {}).setdefault(
+                                                          f'services.{service_name}.{eltname}',
-                                                                    value,
+                                                          )
-                                                                    []).append(activate_path)
+                setattr(new_service, elttype, family)
-                    continue
+            families[service_name] = new_service
-                if key == 'name':
+        self.space.services.service = families
-                    true_key = elt_name
-                else:
-                    true_key = key
-                if true_key in self.objectspace.booleans_attributs:
-                    type_ = 'boolean'
-                else:
-                    type_ = 'string'
-                dtd_key_type = true_key + '_type'
 
-                if hasattr(elt, dtd_key_type):
+    def make_group_from_elts(self,
-                    type_ = KEY_TYPE[getattr(elt, dtd_key_type)]
+                             service_name,
-                multi = isinstance(value, list)
+                             name,
-                variables.append(self._generate_element(elt_name,
+                             elts,
-                                                        key,
+                             path,
-                                                        value,
+                             ):
-                                                        type_,
-                                                        subpath,
-                                                        multi))
-            # FIXME ne devrait pas etre True par défaut
-            variables.append(self._generate_element(name, 'activate', True, 'boolean', subpath))
-            family = self.objectspace.family()
-            family.name = '{}{}'.format(name, index)
-            family.variable = variables
-            family.mode = None
-            self.paths.append('family', subpath, 'services', creoleobj=family)
-            families.append(family)
-        return families
-
-    def _generate_element(self, eltname, name, value, type_, subpath, multi=False):
-        var_data = {'name': name, 'doc': '', 'value': value,
-                    'auto_freeze': False, 'mode': None, 'multi': multi}
-        values = None
-        if type_ == 'string':
-            values = self.objectspace.forced_choice_option.get(eltname, {}).get(name)
-            if values is not None:
-                type_ = 'choice'
-        var_data['type'] = type_
-
-        variable = self.objectspace.variable()
-        variable.mandatory = True
-        for key, value in var_data.items():
-            if key == 'value':
-                if value is None:
-                    continue
-                if type_ == 'symlink':
-                    key = 'opt'
-                else:
-                    # Value is a list of objects
-                    if not multi:
-                        val = self.objectspace.value()
-                        val.name = value
-                        value = [val]
-                    else:
-                        value_list = []
-                        for valiter in value:
-                            val = self.objectspace.value()
-                            val.name = valiter.name
-                            value_list.append(val)
-                        value = value_list
-            if key == 'doc' and type_ == 'symlink':
-                continue
-            setattr(variable, key, value)
-        if values is not None:
-            choices = []
-            for value in values:
-                choice = self.objectspace.choice()
-                choice.name = value
-                choices.append(choice)
-            variable.choice = choices
-        path = '{}.{}'.format(subpath, name)
-        self.paths.append('variable', path, 'services', 'service', variable)
-        return variable
-
-    def _update_file(self, file_, index, service_path):
-        if file_.file_type == "UnicodeOption":
-            if not hasattr(file_, 'source'):
-                file_.source = basename(file_.name)
-        elif not hasattr(file_, 'source'):
-            raise CreoleDictConsistencyError(_('attribute source mandatory for file with variable name '
-                                               'for {}').format(file_.name))
-
-    def _reorder_elts(self, name, elts, duplicate_list):
-        """Reorders by index the elts
-        """
-        dict_elts = OrderedDict()
-        # reorder elts by index
-        new_elts = {}
-        not_indexed = []
-        for elt in elts:
-            idx = elt.index
-            new_elts.setdefault(idx, []).append(elt)
-        idxes = list(new_elts.keys())
-        idxes.sort()
-        elts = not_indexed
-        for idx in idxes:
-            elts.extend(new_elts[idx])
-        for idx, elt in enumerate(elts):
-            elt_added = False
-            for key in dir(elt):
-                if key.startswith('_') or key.endswith('_type') or key in ERASED_ATTRIBUTES:
-                    continue
-                value = getattr(elt, key)
-            if not elt_added:
-                eltname = elt.name
-                dict_elts.setdefault(eltname, []).append({'elt_name': name, 'elt': elt})
-
-        result_elts = []
-        for elt in dict_elts.values():
-            result_elts.extend(elt)
-        return result_elts
-
-    def make_group_from_elts(self, name, elts, path, duplicate_list):
         """Splits each objects into a group (and `OptionDescription`, in tiramisu terms)
         and build elements and its attributes (the `Options` in tiramisu terms)
         """
         families = []
-        new_elts = self._reorder_elts(name, elts, duplicate_list)
+        new_elts = self._reorder_elts(name,
+                                      elts,
+                                      )
         for index, elt_info in enumerate(new_elts):
             elt = elt_info['elt']
             elt_name = elt_info['elt_name']
@@ -284,9 +141,19 @@ class ServiceAnnotator:
             # try to launch _update_xxxx() function
             update_elt = '_update_' + elt_name
             if hasattr(self, update_elt):
-                getattr(self, update_elt)(elt, index, path)
+                getattr(self, update_elt)(elt,
-            variables = []
+                                          index,
-            subpath = '{}.{}{}'.format(path, name, index)
+                                          path,
+                                          service_name,
+                                          )
+
+            if hasattr(elt, 'source'):
+                c_name = elt.source
+            else:
+                c_name = elt.name
+            family = self.gen_family(c_name)
+            family.variable = []
+            subpath = '{}.{}'.format(path, c_name)
             listname = '{}list'.format(name)
             activate_path = '.'.join([subpath, 'activate'])
             if elt in self.grouplist_conditions:
@@ -298,78 +165,118 @@ class ServiceAnnotator:
                 if key.startswith('_') or key.endswith('_type') or key in ERASED_ATTRIBUTES:
                     continue
                 value = getattr(elt, key)
-                if isinstance(value, list) and duplicate_list:
-                    # FIXME plusieurs fichier si calculé !
-                    continue
                 if key == listname:
                     self.objectspace.list_conditions.setdefault(listname,
                                                                 {}).setdefault(
                                                                     value,
                                                                     []).append(activate_path)
                     continue
-                if key in self.objectspace.booleans_attributs:
+                family.variable.append(self._generate_element(elt_name,
-                    type_ = 'boolean'
+                                                              key,
-                else:
+                                                              value,
-                    type_ = 'string'
+                                                              elt,
-                dtd_key_type = key + '_type'
+                                                              f'{subpath}.{key}'
-                if hasattr(elt, dtd_key_type):
+                                                              ))
-                    type_ = KEY_TYPE[getattr(elt, dtd_key_type)]
-                multi = isinstance(value, list)
-                variables.append(self._generate_element(elt_name,
-                                                        key,
-                                                        value,
-                                                        type_,
-                                                        subpath,
-                                                        multi))
             # FIXME ne devrait pas etre True par défaut
-            variables.append(self._generate_element(name, 'activate', True, 'boolean', subpath))
+            # devrait etre un calcule
-            family = self.objectspace.family()
+            family.variable.append(self._generate_element(elt_name,
-            family.name = '{}{}'.format(name, index)
+                                                         'activate',
-            family.variable = variables
+                                                          True,
-            family.mode = None
+                                                          elt,
-            self.paths.append('family', subpath, 'services', creoleobj=family)
+                                                          activate_path,
+                                                          ))
             families.append(family)
         return families
 
+    def _generate_element(self,
+                          elt_name,
+                          key,
+                          value,
+                          elt,
+                          path,
+                          ):
+        variable = self.objectspace.variable()
+        variable.name = key
+        variable.mode = None
+        if key == 'name':
+            true_key = elt_name
+        else:
+            true_key = key
+        dtd_key_type = true_key + '_type'
+        if key == 'activate':
+            type_ = 'boolean'
+        elif hasattr(elt, dtd_key_type):
+            type_ = KEY_TYPE[getattr(elt, dtd_key_type)]
+        elif key in self.objectspace.booleans_attributs:
+            type_ = 'boolean'
+        else:
+            type_ = 'string'
+        variable.type = type_
+        if type_ == 'symlink':
+            variable.opt = value
+            variable.multi = None
+        else:
+            variable.doc = key
+            val = self.objectspace.value()
+            val.type = type_
+            val.name = value
+            variable.value = [val]
+        self.paths.add_variable('services',
+                                path,
+                                'service',
+                                False,
+                                variable,
+                                )
+        return variable
 
-class ActionAnnotator(ServiceAnnotator):
+    def _reorder_elts(self,
-    def __init__(self, objectspace):
+                      name,
-        self.space = objectspace.space
+                      elts,
-        self.paths = objectspace.paths
+                      ):
-        self.objectspace = objectspace
+        """Reorders by index the elts
-        self.grouplist_conditions = {}
+        """
-        self.convert_family_action()
+        new_elts = {}
+        # reorder elts by index
+        for idx, elt in enumerate(elts):
+            new_elts.setdefault(idx, []).append(elt)
+        idxes = list(new_elts.keys())
+        idxes.sort()
+        result_elts = []
+        for idx in idxes:
+            for elt in new_elts[idx]:
+                result_elts.append({'elt_name': name, 'elt': elt})
+        return result_elts
 
-    def convert_family_action(self):
+    def _update_override(self,
-        if hasattr(self.space, 'family_action'):
+                         file_,
-            actions = self.objectspace.family()
+                         index,
-            actions.name = 'actions'
+                         service_path,
-            actions.mode = None
+                         service_name,
-            actions.family = []
+                         ):
-            self.space.actions = actions
+        file_.name = f'/systemd/system/{service_name}.service.d/rougail.conf'
-            namespaces = []
+        # retrieve default value from File object
-            for name, actions in self.space.family_action.items():
+        for attr in ['owner', 'group', 'mode']:
-                subpath = 'actions.{}'.format(normalize_family(name))
+            setattr(file_, attr, getattr(self.objectspace.file, attr))
-                for action in actions.action:
+        if not hasattr(file_, 'source'):
-                    namespace = action.namespace
+            file_.source = f'{service_name}.service'
-                    if namespace in namespaces:
+        self._update_file(file_,
-                        raise CreoleDictConsistencyError(_('only one action allow for {}'
+                          index,
-                                                           '').format(namespace))
+                          service_path,
-                    namespaces.append(namespace)
+                          service_name,
-                    action.name = action.namespace
+                          )
-                new_actions = self.make_group_from_elts('action', actions.action, subpath, False)
+
-                family = self.objectspace.family()
+    def _update_file(self,
-                family.name = actions.name
+                     file_,
-                family.family = new_actions
+                     index,
-                family.mode = None
+                     service_path,
-                variables = []
+                     service_name,
-                for key, value in vars(actions).items():
+                     ):
-                    if key not in ERASED_FAMILY_ACTION_ATTRIBUTES:
+        if not hasattr(file_, 'file_type') or file_.file_type == "UnicodeOption":
-                        variables.append(self._generate_element('action', key, value, 'string',
+            if not hasattr(file_, 'source'):
-                                                                subpath))
+                file_.source = basename(file_.name)
-                family.variable = variables
+        elif not hasattr(file_, 'source'):
-                self.space.actions.family.append(family)
+            raise DictConsistencyError(_('attribute source mandatory for file with variable name '
-            del self.space.family_action
+                                               'for {}').format(file_.name))
 
 
 class SpaceAnnotator(object):
@@ -381,25 +288,21 @@ class SpaceAnnotator(object):
         self.objectspace = objectspace
         self.valid_enums = {}
         self.force_value = {}
-        self.has_calc = []
-        self.force_no_value = []
         self.force_not_mandatory = []
         if eosfunc_file:
             self.eosfunc = imp.load_source('eosfunc', eosfunc_file)
         else:
             self.eosfunc = None
         if HIGH_COMPATIBILITY:
-            self.default_has_no_value = []
+            self.has_hidden_if_in_condition = []
-            self.has_frozen_if_in_condition = []
+        self.convert_variable()
-        self.default_variable_options()
-        self.variable_submulti()
         self.convert_auto_freeze()
         self.convert_groups()
         self.filter_check()
         self.filter_condition()
         self.convert_valid_enums()
         self.convert_check()
-        self.convert_autofill()
+        self.convert_fill()
         self.remove_empty_families()
         self.change_variable_mode()
         self.change_family_mode()
@@ -409,6 +312,7 @@ class SpaceAnnotator(object):
         self.convert_helps()
         if hasattr(self.space, 'constraints'):
             del self.space.constraints.index
+            del self.space.constraints.namespace
             if vars(self.space.constraints):
                 raise Exception('constraints again?')
             del self.space.constraints
@@ -416,14 +320,19 @@ class SpaceAnnotator(object):
     def absolute_path_for_symlink_in_services(self):
         if not hasattr(self.space, 'services'):
             return
-        families = vars(self.space.services).values()
+        for family_name, family in vars(self.space.services).items():
-        for family in families:
+            if not isinstance(family, dict):
-            if hasattr(family, 'family'):
+                continue
-                for fam in family.family.values():
+            for fam in family.values():
-                    for fam1 in fam.family:
+                for fam1_name, fam1 in vars(fam).items():
-                        for variable in fam1.variable:
+                    if fam1_name == 'name' or fam1_name in ERASED_ATTRIBUTES:
+                        continue
+                    for fam2 in fam1.family:
+                        for variable in fam2.variable:
                             if variable.type == 'symlink' and '.' not in variable.name:
-                                variable.opt = self.paths.get_variable_path(variable.opt, 'creole')
+                                variable.opt = self.paths.get_variable_path(variable.opt,
+                                                                            variable_namespace,
+                                                                            )
 
     def convert_helps(self):
         # FIXME l'aide doit etre dans la variable!
@@ -440,64 +349,116 @@ class SpaceAnnotator(object):
                 variable.help = hlp.text
         del self.space.help
 
+    def manage_leader(self,
+                      leader_space: 'Leadership',
+                      leader_family_name: str,
+                      leader_name: str,
+                      namespace: str,
+                      variable: 'Variable',
+                      group: 'Group',
+                      leader_fullname: str,
+                      ) -> None:
+        # manage leader's variable
+        if variable.multi is not True:
+            raise DictConsistencyError(_('the variable {} in a group must be multi').format(variable.name))
+        leader_space.variable = []
+        leader_space.name = leader_name
+        leader_space.hidden = variable.hidden
+        if variable.hidden:
+            leader_is_hidden = True
+            variable.frozen = True
+            variable.force_default_on_freeze = True
+        else:
+            leader_is_hidden = False
+        variable.hidden = None
+        if hasattr(group, 'description'):
+            leader_space.doc = group.description
+        else:
+            leader_space.doc = variable.description
+        leader_path = namespace + '.' + leader_family_name + '.' + leader_name
+        self.paths.add_family(namespace,
+                              leader_path,
+                              leader_space,
+                              )
+        leader_family = self.space.variables[namespace].family[leader_family_name]
+        leader_family.variable[leader_name] = leader_space
+        leader_space.variable.append(variable)
+        self.paths.set_leader(namespace,
+                              leader_family_name,
+                              leader_name,
+                              leader_name,
+                              )
+        leader_space.path = leader_fullname
+        return leader_is_hidden
+
+    def manage_follower(self,
+                        namespace: str,
+                        leader_family_name: str,
+                        variable: 'Variable',
+                        leader_name: str,
+                        follower_names: List[str],
+                        leader_space: 'Leadership',
+                        leader_is_hidden: bool,
+                        ) -> None:
+        if variable.name != follower_names[0]:
+            raise DictConsistencyError(_('cannot found this follower {}').format(follower_names[0]))
+        follower_names.remove(variable.name)
+        if leader_is_hidden:
+            variable.frozen = True
+            variable.force_default_on_freeze = True
+        leader_space.variable.append(variable)  # pylint: disable=E1101
+        self.paths.set_leader(namespace,
+                              leader_family_name,
+                              variable.name,
+                              leader_name,
+                              )
+
     def convert_groups(self):  # pylint: disable=C0111
-        if hasattr(self.space, 'constraints'):
+        if hasattr(self.space, 'constraints') and hasattr(self.space.constraints, 'group'):
-            if hasattr(self.space.constraints, 'group'):
+            for group in self.space.constraints.group:
-                for group in self.space.constraints.group:
+                leader_fullname = group.leader
-                    leader_fullname = group.master
+                follower_names = list(group.follower.keys())
-                    follower_names = list(group.slave.keys())
+                leader_family_name = self.paths.get_variable_family_name(leader_fullname)
-                    leader_family_name = self.paths.get_variable_family_name(leader_fullname)
+                namespace = self.paths.get_variable_namespace(leader_fullname)
-                    namespace = self.paths.get_variable_namespace(leader_fullname)
+                leader_name = self.paths.get_variable_name(leader_fullname)
-                    leader_name = self.paths.get_variable_name(leader_fullname)
+                ori_leader_family = self.space.variables[namespace].family[leader_family_name]
-                    leader_family = self.space.variables[namespace].family[leader_family_name]
+                has_a_leader = False
-                    leader_path = namespace + '.' + leader_family_name
+                for variable in list(ori_leader_family.variable.values()):
-                    is_leader = False
+                    if isinstance(variable, self.objectspace.Leadership):
-                    for variable in list(leader_family.variable.values()):
+                        # append follower to an existed leadership
-                        if isinstance(variable, self.objectspace.Leadership):
+                        if variable.name == leader_name:
-                            # append follower to an existed leadership
+                            leader_space = variable
-                            if variable.name == leader_name:
+                            has_a_leader = True
-                                leader_space = variable
-                                is_leader = True
-                        else:
-                            if is_leader:
-                                if variable.name == follower_names[0]:
-                                    # followers are multi
-                                    if not variable.multi:
-                                        raise CreoleDictConsistencyError(_('the variable {} in a group must be multi or submulti').format(variable.name))
-                                    follower_names.remove(variable.name)
-                                    leader_family.variable.pop(variable.name)
-                                    leader_space.variable.append(variable)  # pylint: disable=E1101
-                                    if namespace == 'creole':
-                                        variable_fullpath = variable.name
-                                    else:
-                                        variable_fullpath = leader_path + '.' + variable.name
-                                    self.paths.set_leader(variable_fullpath, leader_name)
-                                    if follower_names == []:
-                                        break
-                                else:
-                                    raise CreoleDictConsistencyError(_('cannot found this follower {}').format(follower_names[0]))
-                            if is_leader is False and variable.name == leader_name:
-                                leader_space = self.objectspace.Leadership()
-                                leader_space.variable = []
-                                leader_space.name = leader_name
-                                leader_space.hidden = variable.hidden
-                                if hasattr(group, 'description'):
-                                    leader_space.doc = group.description
-                                else:
-                                    leader_space.doc = variable.description
-                                variable.hidden = None
-                                self.paths.append('family', leader_path + '.' + leader_name, namespace, creoleobj=leader_space)
-                                # manage leader's variable
-                                if variable.multi is not True:
-                                    raise CreoleDictConsistencyError(_('the variable {} in a group must be multi').format(variable.name))
-                                leader_family.variable[leader_name] = leader_space
-                                leader_space.variable.append(variable)  # pylint: disable=E1101
-                                self.paths.set_leader(leader_fullname, leader_name)
-                                leader_space.path = leader_fullname
-                                is_leader = True
                     else:
-                        raise CreoleDictConsistencyError(_('cannot found followers {}').format(follower_names))
+                        if has_a_leader:
-                del self.space.constraints.group
+                            # it's a follower
+                            self.manage_follower(namespace,
+                                                 leader_family_name,
+                                                 variable,
+                                                 leader_name,
+                                                 follower_names,
+                                                 leader_space,
+                                                 leader_is_hidden,
+                                                 )
+                            ori_leader_family.variable.pop(variable.name)
+                            if follower_names == []:
+                                # no more follower
+                                break
+                        elif variable.name == leader_name:
+                            # it's a leader
+                            leader_space = self.objectspace.Leadership()
+                            leader_is_hidden = self.manage_leader(leader_space,
+                                                                  leader_family_name,
+                                                                  leader_name,
+                                                                  namespace,
+                                                                  variable,
+                                                                  group,
+                                                                  leader_fullname,
+                                                                  )
+                            has_a_leader = True
+                else:
+                    raise DictConsistencyError(_('cannot found followers {}').format(follower_names))
+            del self.space.constraints.group
 
     def remove_empty_families(self):  # pylint: disable=C0111,R0201
         if hasattr(self.space, 'variables'):
@@ -544,53 +505,37 @@ class SpaceAnnotator(object):
                         varpath = self.paths.get_variable_path(family.dynamic, namespace)
                         family.dynamic = varpath
 
-    def _annotate_variable(self, variable, family_mode, path, is_follower=False):
+    def annotate_variable(self, variable, family_mode, path, is_follower=False):
-        if (HIGH_COMPATIBILITY and variable.type == 'choice' and variable.mode != modes_level[-1] and variable.mandatory is True and path in self.default_has_no_value):
-            variable.mode = modes_level[0]
-        if variable.type == 'choice' and is_follower and family_mode == modes_level[0] and variable.mandatory is True:
-            variable.mode = modes_level[0]
         # if the variable is mandatory and doesn't have any value
         # then the variable's mode is set to 'basic'
         has_value = hasattr(variable, 'value')
-        if (path not in self.has_calc and variable.mandatory is True and
+        if variable.mandatory is True and (not has_value or is_follower):
-                (not has_value or is_follower) and variable.type != 'choice'):
             variable.mode = modes_level[0]
-        if has_value:
+        if variable.mode != None and modes[variable.mode] < modes[family_mode] and (not is_follower or variable.mode != modes_level[0]):
-            if not HIGH_COMPATIBILITY or (not path.startswith('creole.services.') \
+            variable.mode = family_mode
-                    and path not in self.force_no_value and path not in self.force_not_mandatory):
+        if has_value and path not in self.force_not_mandatory:
-                variable.mandatory = True
+            variable.mandatory = True
         if variable.hidden is True:
             variable.frozen = True
             if not variable.auto_save is True and 'force_default_on_freeze' not in vars(variable):
                 variable.force_default_on_freeze = True
-        if variable.name == 'frozen' and not variable.auto_save is True:
-            variable.force_default_on_freeze = True
-        if variable.mode != None and not is_follower and modes[variable.mode] < modes[family_mode]:
-            variable.mode = family_mode
-        if variable.mode != None and variable.mode != modes_level[0] and modes[variable.mode] < modes[family_mode]:
-            variable.mode = family_mode
 
-    def default_variable_options(self):
+    def convert_variable(self):
-        if hasattr(self.space, 'variables'):
+        if not hasattr(self.space, 'variables'):
-            for families in self.space.variables.values():
+            return
-                if hasattr(families, 'family'):
+        for families in self.space.variables.values():
-                    for family in families.family.values():
+            if hasattr(families, 'family'):
-                        if hasattr(family, 'variable'):
+                for family in families.family.values():
-                            for variable in family.variable.values():
+                    if hasattr(family, 'variable'):
-                                if not hasattr(variable, 'type'):
+                        for variable in family.variable.values():
-                                    variable.type = 'string'
+                            if not hasattr(variable, 'type'):
-                                if variable.type != 'symlink' and not hasattr(variable, 'description'):
+                                variable.type = 'string'
-                                    variable.description = variable.name
+                            if variable.type != 'symlink' and not hasattr(variable, 'description'):
-
+                                variable.description = variable.name
-    def variable_submulti(self):
+                            if hasattr(variable, 'value'):
-        if hasattr(self.space, 'variables'):
+                                for value in variable.value:
-            for families in self.space.variables.values():
+                                    if not hasattr(value, 'type'):
-                if hasattr(families, 'family'):
+                                        value.type = variable.type
-                    for family in families.family.values():
-                        if hasattr(family, 'variable'):
-                            for variable in family.variable.values():
-                                if variable.submulti:
-                                    variable.multi = 'submulti'
 
     def convert_auto_freeze(self):  # pylint: disable=C0111
         if hasattr(self.space, 'variables'):
@@ -601,7 +546,7 @@ class SpaceAnnotator(object):
                             for variable in family.variable.values():
                                 if variable.auto_freeze:
                                     new_condition = self.objectspace.condition()
-                                    new_condition.name = 'auto_frozen_if_in'
+                                    new_condition.name = 'auto_hidden_if_not_in'
                                     new_condition.namespace = variables.name
                                     new_condition.source = FREEZE_AUTOFREEZE_VARIABLE
                                     new_param = self.objectspace.param()
@@ -609,7 +554,7 @@ class SpaceAnnotator(object):
                                     new_condition.param = [new_param]
                                     new_target = self.objectspace.target()
                                     new_target.type = 'variable'
-                                    if variables.name == 'creole':
+                                    if variables.name == variable_namespace:
                                         path = variable.name
                                     else:
                                         path = variable.namespace + '.' + family.name + '.' + variable.name
@@ -620,37 +565,43 @@ class SpaceAnnotator(object):
                                     self.space.constraints.condition.append(new_condition)
 
     def _set_valid_enum(self, variable, values, type_):
-        if isinstance(values, list):
+        variable.mandatory = True
-            variable.mandatory = True
+        variable.choice = []
-            variable.choice = []
+        choices = []
-            choices = []
+        for value in values:
-            for value in values:
+            choice = self.objectspace.choice()
-                choice = self.objectspace.choice()
+            try:
-                choice.name = str(value)
+                if type_ in CONVERSION:
-                choices.append(choice.name)
+                    choice.name = CONVERSION[type_](value)
-                choice.type = type_
+                else:
-                variable.choice.append(choice)
+                    choice.name = str(value)
-            if not variable.choice:
+            except:
-                raise CreoleDictConsistencyError(_('empty valid enum is not allowed for variable {}').format(variable.name))
+                raise DictConsistencyError(_(f'unable to change type of a valid_enum entry "{value}" is not a valid "{type_}" for "{variable.name}"'))
-            if hasattr(variable, 'value'):
+            choices.append(choice.name)
-                for value in variable.value:
+            choice.type = type_
-                    value.type = type_
+            variable.choice.append(choice)
-                    if value.name not in choices:
+        if not variable.choice:
-                        raise CreoleDictConsistencyError(_('value "{}" of variable "{}" is not in list of all expected values ({})').format(value.name, variable.name, choices))
+            raise DictConsistencyError(_('empty valid enum is not allowed for variable {}').format(variable.name))
-            else:
+        if hasattr(variable, 'value'):
-                new_value = self.objectspace.value()
+            for value in variable.value:
-                new_value.name = values[0]
+                value.type = type_
-                new_value.type = type_
+                if type_ in CONVERSION:
-                variable.value = [new_value]
+                    cvalue = CONVERSION[type_](value.name)
+                else:
+                    cvalue = value.name
+                if cvalue not in choices:
+                    raise DictConsistencyError(_('value "{}" of variable "{}" is not in list of all expected values ({})').format(value.name, variable.name, choices))
         else:
-            # probe choice
+            new_value = self.objectspace.value()
-            variable.choice = values
+            new_value.name = values[0]
+            new_value.type = type_
+            variable.value = [new_value]
         variable.type = 'choice'
 
     def _convert_valid_enum(self, variable, path):
         if variable.type in FORCE_CHOICE:
             if path in self.valid_enums:
-                raise CreoleDictConsistencyError(_('cannot set valid enum for variable with type {}').format(variable.type))
+                raise DictConsistencyError(_('cannot set valid enum for variable with type {}').format(variable.type))
             self._set_valid_enum(variable, FORCE_CHOICE[variable.type], 'string')
         if path in self.valid_enums:
             values = self.valid_enums[path]['values']
@@ -659,6 +610,7 @@ class SpaceAnnotator(object):
         if path in self.force_value:
             new_value = self.objectspace.value()
             new_value.name = self.force_value[path]
+            new_value.type = variable.type
             variable.value = [new_value]
             del self.force_value[path]
 
@@ -680,7 +632,7 @@ class SpaceAnnotator(object):
                                 self._convert_valid_enum(variable, path)
         # valid_enums must be empty now (all information are store in objects)
         if self.valid_enums:
-            raise CreoleDictConsistencyError(_('valid_enum sets for unknown variables {}').format(self.valid_enums.keys()))
+            raise DictConsistencyError(_('valid_enum sets for unknown variables {}').format(self.valid_enums.keys()))
 
     def change_variable_mode(self):  # pylint: disable=C0111
         if not hasattr(self.space, 'variables'):
@@ -696,11 +648,11 @@ class SpaceAnnotator(object):
                                 mode = modes_level[-1]
                                 for follower in variable.variable:
                                     if follower.auto_save is True:
-                                        raise CreoleDictConsistencyError(_('leader/followers {} '
+                                        raise DictConsistencyError(_('leader/followers {} '
                                                                            'could not be '
                                                                            'auto_save').format(follower.name))
                                     if follower.auto_freeze is True:
-                                        raise CreoleDictConsistencyError(_('leader/followers {} '
+                                        raise DictConsistencyError(_('leader/followers {} '
                                                                            'could not be '
                                                                            'auto_freeze').format(follower.name))
                                     if HIGH_COMPATIBILITY and variable.name != follower.name:  # and variable.variable[0].mode != modes_level[0]:
@@ -708,7 +660,7 @@ class SpaceAnnotator(object):
                                     else:
                                         is_follower = False
                                     path = '{}.{}.{}'.format(family.path, variable.name, follower.name)
-                                    self._annotate_variable(follower, family_mode, path, is_follower)
+                                    self.annotate_variable(follower, family_mode, path, is_follower)
                                     # leader's mode is minimum level
                                     if modes[variable.variable[0].mode] > modes[follower.mode]:
                                         follower.mode = variable.variable[0].mode
@@ -721,118 +673,98 @@ class SpaceAnnotator(object):
                                 if variable.auto_freeze is True and variable.mode != modes_level[-1]:
                                     variable.mode = modes_level[0]
                                 path = '{}.{}'.format(family.path, variable.name)
-                                self._annotate_variable(variable, family_mode, path)
+                                self.annotate_variable(variable, family_mode, path)
 
-    def get_variable(self, name):  # pylint: disable=C0111
+    def convert_fill(self):  # pylint: disable=C0111,R0912
-        return self.paths.get_variable_obj(name)
+        if not hasattr(self.space, 'constraints') or not hasattr(self.space.constraints, 'fill'):
-
+            return
-    def convert_autofill(self):  # pylint: disable=C0111
-        if hasattr(self.space, 'constraints'):
-            self.convert_duplicate_autofill(self.space.constraints)
-            if 'auto' in vars(self.space.constraints):
-                self.convert_auto(self.space.constraints.auto, self.space)
-            if 'fill' in vars(self.space.constraints):
-                self.convert_fill(self.space.constraints.fill, self.space)
-
-    def convert_duplicate_autofill(self, constraints):
-        """ Remove duplicate auto or fill for a variable
-        This variable must be redefined
-        """
-        fills = {}
         # sort fill/auto by index
-        if 'fill' in vars(constraints):
+        fills = {fill.index: fill for idx, fill in enumerate(self.space.constraints.fill)}
-            for idx, fill in enumerate(constraints.fill):
-                fills[fill.index] = {'idx': idx, 'fill': fill, 'type': 'fill'}
-        if 'auto' in vars(constraints):
-            for idx, fill in enumerate(constraints.auto):
-                fills[fill.index] = {'idx': idx, 'fill': fill, 'type': 'auto'}
         indexes = list(fills.keys())
         indexes.sort()
-        targets = {}
+        targets = []
-        remove_autos = []
+        eosfunc = dir(self.eosfunc)
-        remove_fills = []
         for idx in indexes:
-            fill = fills[idx]['fill']
+            fill = fills[idx]
-            redefine = bool(fill.redefine)
+            # test if it's redefined calculation
-            if fill.target in targets:
+            if fill.target in targets and not fill.redefine:
-                if redefine:
+                raise DictConsistencyError(_(f"A fill already exists for the target: {fill.target}"))
-                    if targets[fill.target][1] == 'auto':
+            targets.append(fill.target)
-                        remove_autos.append(targets[fill.target][0])
+            #
-                    else:
+            if not fill.name in eosfunc:
-                        remove_fills.append(targets[fill.target][0])
+                raise DictConsistencyError(_('cannot find fill function {}').format(fill.name))
-                else:
-                    raise CreoleDictConsistencyError(_("An auto or fill already exists "
-                                                       "for the target: {}").format(
-                                                           fill.target))
-            targets[fill.target] = (fills[idx]['idx'], fills[idx]['type'])
-        remove_autos.sort(reverse=True)
-        for idx in remove_autos:
-            constraints.auto.pop(idx)
-        remove_fills.sort(reverse=True)
-        for idx in remove_fills:
-            constraints.fill.pop(idx)
 
-    def convert_auto(self, auto_space, space):  # pylint: disable=C0111
+            namespace = fill.namespace
-        for auto in auto_space:
+            # let's replace the target by the path
-            if HIGH_COMPATIBILITY and auto.target in self.has_frozen_if_in_condition:
+            fill.target = self.paths.get_variable_path(fill.target,
-                # if a variable has a 'frozen_if_in' condition
+                                                       namespace)
-                # then we change the 'auto' variable as a 'fill' variable
+
-                continue
+            value = self.objectspace.value()
-            # an auto is a fill with "hidden" and "frozen" properties
+            value.type = 'calculation'
-            variable = self.get_variable(auto.target)
+            value.name = fill.name
-            if variable.auto_freeze:
+            if hasattr(fill, 'param'):
-                raise CreoleDictConsistencyError(_('variable with auto value '
+                param_to_delete = []
-                                                   'cannot be auto_freeze').format(auto.target))
+                for fill_idx, param in enumerate(fill.param):
-            if variable.auto_save:
+                    if param.type not in TYPE_PARAM_FILL:
-                raise CreoleDictConsistencyError(_('variable with auto value '
+                        raise DictConsistencyError(_(f'cannot use {param.type} type as a param in a fill/auto'))
-                                                   'cannot be auto_save').format(auto.target))
+                    if param.type != 'string' and not hasattr(param, 'text'):
-            leader = self.paths.get_leader(auto.target)
+                        raise DictConsistencyError(_(f"All '{param.type}' variables shall have a value in order to calculate {fill.target}"))
-            if leader is None or variable.name != leader:
+                    if param.type == 'variable':
-                variable.hidden = True
+                        try:
-            else:
+                            param.text, suffix = self.paths.get_variable_path(param.text,
-                leadership = self.paths.get_family_obj(self.paths.get_variable_family_path(auto.target))
+                                                                              namespace,
-                leadership.hidden = True
+                                                                              with_suffix=True)
-            variable.frozen = True
+                            if suffix:
-            variable.force_default_on_freeze = True
+                                param.suffix = suffix
-        if 'fill' not in vars(space.constraints):
+                        except DictConsistencyError as err:
-            space.constraints.fill = []
+                            if param.optional is False:
-        space.constraints.fill.extend(auto_space)
+                                raise err
-        del space.constraints.auto
+                            param_to_delete.append(fill_idx)
+                            continue
+                    else:
+                        param.notraisepropertyerror = None
+                param_to_delete.sort(reverse=True)
+                for param_idx in param_to_delete:
+                    fill.param.pop(param_idx)
+                value.param = fill.param
+            variable = self.paths.get_variable_obj(fill.target)
+            variable.value = [value]
+        del self.space.constraints.fill
 
     def filter_separators(self):  # pylint: disable=C0111,R0201
-        # FIXME devrait etre dans la variable
         if not hasattr(self.space, 'variables'):
             return
         for family in self.space.variables.values():
-            if (hasattr(family, 'separators') and hasattr(family.separators, 'separator')):
+            if not hasattr(family, 'separators'):
-                space = family.separators.separator
+                continue
-                names = []
+            if hasattr(family.separators, 'separator'):
-                for idx, separator in enumerate(space):
+                for idx, separator in enumerate(family.separators.separator):
-                    namespace = self.paths.get_variable_namespace(separator.name)
+                    option = self.paths.get_variable_obj(separator.name)
-                    subpath = self.paths.get_variable_path(separator.name, namespace)
+                    if hasattr(option, 'separator'):
-                    separator.name = subpath
+                        subpath = self.paths.get_variable_path(separator.name,
-                    if separator.name in names:
+                                                               separator.namespace,
-                        raise CreoleDictConsistencyError(_('{} already has a separator').format(separator.name))
+                                                               )
-                    names.append(separator.name)
+                        raise DictConsistencyError(_('{} already has a separator').format(subpath))
-
+                    option.separator = separator.text
+            del family.separators
 
     def load_params_in_validenum(self, param):
         if param.type in ['string', 'python', 'number']:
             if not hasattr(param, 'text') and (param.type == 'python' or param.type == 'number'):
-                raise CreoleDictConsistencyError(_("All '{}' variables shall be set in order to calculate {}").format(param.type, 'valid_enum'))
+                raise DictConsistencyError(_("All '{}' variables shall be set in order to calculate {}").format(param.type, 'valid_enum'))
             if param.type in ['string', 'number']:
                 try:
                     values = literal_eval(param.text)
                 except ValueError:
-                    raise CreoleDictConsistencyError(_('Cannot load {}').format(param.text))
+                    raise DictConsistencyError(_('Cannot load {}').format(param.text))
             elif param.type == 'python':
                 try:
+                    #values = eval(param.text, {'eosfunc': self.eosfunc, '__builtins__': {'range': range, 'str': str}})
                     values = eval(param.text, {'eosfunc': self.eosfunc, '__builtins__': {'range': range, 'str': str}})
-                    #FIXME : eval('[str(i) for i in range(3, 13)]', {'eosfunc': eosfunc, '__builtins__': {'range': range, 'str': str}})
                 except NameError:
-                    raise CreoleDictConsistencyError(_('The function {} is unknown').format(param.text))
+                    raise DictConsistencyError(_('The function {} is unknown').format(param.text))
             if not isinstance(values, list):
-                raise CreoleDictConsistencyError(_('Function {} shall return a list').format(param.text))
+                raise DictConsistencyError(_('Function {} shall return a list').format(param.text))
             new_values = []
             for val in values:
                 new_values.append(val)
@@ -841,136 +773,108 @@ class SpaceAnnotator(object):
             values = param.text
         return values
 
-    def filter_check(self):  # pylint: disable=C0111
+    def check_check(self):
-        # valid param in check
-        if not hasattr(self.space, 'constraints') or not hasattr(self.space.constraints, 'check'):
-            return
-        space = self.space.constraints.check
         remove_indexes = []
-        for check_idx, check in enumerate(space):
+        functions = dir(self.eosfunc)
-            namespace = check.namespace
+        functions.extend(['valid_enum', 'valid_in_network', 'valid_differ'])
+        for check_idx, check in enumerate(self.space.constraints.check):
+            if not check.name in functions:
+                raise DictConsistencyError(_('cannot find check function {}').format(check.name))
             if hasattr(check, 'param'):
                 param_option_indexes = []
                 for idx, param in enumerate(check.param):
                     if param.type not in TYPE_PARAM_CHECK:
-                        raise CreoleDictConsistencyError(_('cannot use {} type as a param in check for {}').format(param.type, check.target))
+                        raise DictConsistencyError(_('cannot use {} type as a param in check for {}').format(param.type, check.target))
-                    if param.type == 'eole':
+                    if param.type == 'variable' and not self.paths.path_is_defined(param.text):
-                        param.type = 'variable'
+                        if param.optional is True:
-                    if param.type == 'variable':
+                            param_option_indexes.append(idx)
-                        # if HIGH_COMPATIBILITY and param.text.startswith('container_ip'):
+                        else:
-                        #     if param.optional is True:
+                            raise DictConsistencyError(_(f'unknown param {param.text} in check'))
-                        #         param_option_indexes.append(idx)
+                    if param.type != 'variable':
-                        try:
+                        param.notraisepropertyerror = None
-                            param.text = self.paths.get_variable_path(param.text, namespace)
-                        except CreoleDictConsistencyError as err:
-                            if param.optional is True:
-                                param_option_indexes.append(idx)
-                            else:
-                                raise err
                 param_option_indexes = list(set(param_option_indexes))
                 param_option_indexes.sort(reverse=True)
                 for idx in param_option_indexes:
                     check.param.pop(idx)
-                if not HIGH_COMPATIBILITY and check.param == []:
+                if check.param == []:
                     remove_indexes.append(check_idx)
         remove_indexes.sort(reverse=True)
         for idx in remove_indexes:
-            del space[idx]
+            del self.space.constraints.check[idx]
-        variables = {}
+
-        for index, check in enumerate(space):
+    def check_replace_text(self):
-            namespace = check.namespace
+        for check_idx, check in enumerate(self.space.constraints.check):
-            if HIGH_COMPATIBILITY:
+            if hasattr(check, 'param'):
-                if not self.paths.path_is_defined(check.target):
+                namespace = check.namespace
-                    continue
+                for idx, param in enumerate(check.param):
-                check.is_in_leadership = self.paths.get_leader(check.target) != None
+                    if param.type == 'variable':
+                        param.text = self.paths.get_variable_path(param.text, namespace)
+            check.is_in_leadership = self.paths.get_leader(check.target) != None
             # let's replace the target by the path
             check.target = self.paths.get_variable_path(check.target, namespace)
-            if check.target not in variables:
+
-                variables[check.target] = []
+    def check_valid_enum(self):
-            variables[check.target].append((index, check))
-        # remove check already set for a variable
         remove_indexes = []
-        for checks in variables.values():
+        for idx, check in enumerate(self.space.constraints.check):
-            names = {}
-            for idx, check in checks:
-                if HIGH_COMPATIBILITY and check.name == 'valid_enum':
-                    redefine = True
-                else:
-                    redefine = False
-                    #redefine = bool(check.redefine)
-                if redefine and check.name in names:
-                    remove_indexes.append(names[check.name])
-                    del names[check.name]
-                names[check.name] = idx
-                del check.index
-        remove_indexes.sort(reverse=True)
-        for idx in remove_indexes:
-            del space[idx]
-        remove_indexes = []
-        functions = dir(self.eosfunc)
-        functions.extend(['valid_enum', 'valid_in_network', 'valid_differ'])
-        for idx, check in enumerate(space):
-            if not check.name in functions:
-                raise CreoleDictConsistencyError(_('cannot find check function {}').format(check.name))
-            #is_probe = not check.name in self.eosfunc.func_on_zephir_context
-            #if is_probe:
-            #    raise CreoleDictConsistencyError(_('cannot have a check with probe function ({})').format(check.name))
             if check.name == 'valid_enum':
                 proposed_value_type = False
                 remove_params = []
                 for param_idx, param in enumerate(check.param):
                     if hasattr(param, 'name') and param.name == 'checkval':
                         try:
-                            proposed_value_type = self.objectspace._convert_boolean(param.text) == False
+                            proposed_value_type = self.objectspace.convert_boolean(param.text) == False
                             remove_params.append(param_idx)
                         except TypeError as err:
-                            raise CreoleDictConsistencyError(_('cannot load checkval value for variable {}: {}').format(check.target, err))
+                            raise DictConsistencyError(_('cannot load checkval value for variable {}: {}').format(check.target, err))
                         if proposed_value_type:
                             # no more supported
-                            raise CreoleDictConsistencyError(_('cannot load checkval value for variable {}, no more supported').format(check.target))
+                            raise DictConsistencyError(_('cannot load checkval value for variable {}, no more supported').format(check.target))
                 remove_params.sort(reverse=True)
                 for param_idx in remove_params:
                     del check.param[param_idx]
                 if len(check.param) != 1:
-                    raise CreoleDictConsistencyError(_('cannot set more than one param '
+                    raise DictConsistencyError(_('cannot set more than one param '
                                                        'for valid_enum for variable {}'
                                                        '').format(check.target))
                 param = check.param[0]
+                if check.target in self.valid_enums:
+                    raise DictConsistencyError(_('valid_enum already set for {}'
+                                                       '').format(check.target))
                 if proposed_value_type:
                     if param.type == 'variable':
                         try:
                             values = self.load_params_in_validenum(param)
                         except NameError as err:
-                            raise CreoleDictConsistencyError(_('cannot load value for variable {}: {}').format(check.target, err))
+                            raise DictConsistencyError(_('cannot load value for variable {}: {}').format(check.target, err))
-                        add_value = True
+                        add_default_value = not check.is_in_leadership
-                        if HIGH_COMPATIBILITY and check.is_in_leadership:
+                        if add_default_value and values:
-                            add_value = False
-                        if add_value and values:
                             self.force_value[check.target] = values[0]
                 else:
-                    if check.target in self.valid_enums:
-                        raise CreoleDictConsistencyError(_('valid_enum already set for {}'
-                                                           '').format(check.target))
                     values = self.load_params_in_validenum(param)
                     self.valid_enums[check.target] = {'type': param.type,
                                                       'values': values}
                     remove_indexes.append(idx)
         remove_indexes.sort(reverse=True)
         for idx in remove_indexes:
-            del space[idx]
+            del self.space.constraints.check[idx]
-        #convert level to "warnings_only" and hidden to "transitive"
+
-        for check in space:
+    def check_change_warning(self):
+        #convert level to "warnings_only"
+        for check in self.space.constraints.check:
             if check.level == 'warning':
                 check.warnings_only = True
             else:
                 check.warnings_only = False
             check.level = None
-            if hasattr(check, 'param'):
-                for param in check.param:
-                    if not param.hidden is True:
-                        check.transitive = False
-                    param.hidden = None
 
+    def filter_check(self):  # pylint: disable=C0111
+        # valid param in check
+        if not hasattr(self.space, 'constraints') or not hasattr(self.space.constraints, 'check'):
+            return
+        self.check_check()
+        self.check_replace_text()
+        self.check_valid_enum()
+        self.check_change_warning()
         if not self.space.constraints.check:
             del self.space.constraints.check
 
@@ -987,20 +891,20 @@ class SpaceAnnotator(object):
             elif name == 'valid_network_netmask':
                 params_len = 1
                 if len(check.param) != params_len:
-                    raise CreoleDictConsistencyError(_('{} must have {} param').format(name, params_len))
+                    raise DictConsistencyError(_('{} must have {} param').format(name, params_len))
             elif name == 'valid_ipnetmask':
                 params_len = 1
                 if len(check.param) != params_len:
-                    raise CreoleDictConsistencyError(_('{} must have {} param').format(name, params_len))
+                    raise DictConsistencyError(_('{} must have {} param').format(name, params_len))
                 name = 'valid_ip_netmask'
             elif name == 'valid_broadcast':
                 params_len = 2
                 if len(check.param) != params_len:
-                    raise CreoleDictConsistencyError(_('{} must have {} param').format(name, params_len))
+                    raise DictConsistencyError(_('{} must have {} param').format(name, params_len))
             elif name == 'valid_in_network':
                 params_len = 2
                 if len(check.param) != params_len:
-                    raise CreoleDictConsistencyError(_('{} must have {} param').format(name, params_len))
+                    raise DictConsistencyError(_('{} must have {} param').format(name, params_len))
             check_.name = name
             check_.warnings_only = check.warnings_only
             if hasattr(check, 'param'):
@@ -1010,189 +914,21 @@ class SpaceAnnotator(object):
             variable.check.append(check_)
         del self.space.constraints.check
 
-
-    def convert_fill(self, fill_space, space):  # pylint: disable=C0111,R0912
-        fills = {}
-        # sort fill/auto by index
-        for idx, fill in enumerate(fill_space):
-            fills[fill.index] = {'idx': idx, 'fill': fill}
-            del fill.index
-        indexes = list(fills.keys())
-        indexes.sort()
-        del_idx = []
-        for idx in indexes:
-            fill = fills[idx]['fill']
-            variable = self.get_variable(fill.target)
-            if hasattr(variable, 'value'):
-                del variable.value
-            namespace = fill.namespace
-            # let's replace the target by the path
-            fill.target = self.paths.get_variable_path(fill.target, namespace)
-            if not fill.name in dir(self.eosfunc):
-                raise CreoleDictConsistencyError(_('cannot find fill function {}').format(fill.name))
-            #is_probe = not fill.name in self.eosfunc.func_on_zephir_context
-            if hasattr(fill, 'param'):
-                for param in fill.param:
-                    if param.type not in TYPE_PARAM_FILL:
-                        raise CreoleDictConsistencyError(_('cannot use {} type as a param '
-                                                           'in a fill/auto').format(param.type))
-                    if param.type == 'eole':
-                        param.type = 'variable'
-                param_option_indexes = []
-                for fill_idx, param in enumerate(fill.param):
-                    if not hasattr(param, 'text') and \
-                            (param.type == 'variable' or param.type == 'number' or \
-                                param.type == 'python'):
-                        raise CreoleDictConsistencyError(_("All '{}' variables shall be set in "
-                                                           "order to calculate {}").format(
-                                                               param.type,
-                                                               fill.target))
-                    # if param.type == 'container':
-                    #     param.type = 'eole'
-                    #     param.text = 'container_ip_{}'.format(param.text)
-                    if param.type == 'variable':
-                        #if is_probe:
-                        #    raise CreoleDictConsistencyError(_('Function {0} used to calculate {1} '
-                        #                                       'is executed on remote server, '
-                        #                                       'so cannot depends to an '
-                        #                                       'other variable'
-                        #                                      ).format(fill.name, fill.target))
-                        # if HIGH_COMPATIBILITY and param.text.startswith('container_ip'):
-                        #     if param.optional is True:
-                        #         param_option_indexes.append(fill_idx)
-                        try:
-                            param.text = self.paths.get_variable_path(param.text, namespace)
-                        except CreoleDictConsistencyError as err:
-                            if param.optional is True:
-                                param_option_indexes.append(fill_idx)
-                            else:
-                                raise err
-                param_option_indexes = list(set(param_option_indexes))
-                param_option_indexes.sort(reverse=True)
-                for param_idx in param_option_indexes:
-                    fill.param.pop(param_idx)
-            self.has_calc.append(fill.target)
-
-            #if is_probe:
-            #    variable.force_default_on_freeze = False
-            #    self.objectspace.probe_variables.append(fill)
-            #    del_idx.append(fills[idx]['idx'])
-        del_idx.sort(reverse=True)
-        for idx in del_idx:
-            space.constraints.fill.pop(idx)
-        for fill in space.constraints.fill:
-            variable = self.paths.get_variable_obj(fill.target)
-            value = self.objectspace.value()
-            value.type = 'calculation'
-            value.name = fill.name
-            if hasattr(fill, 'param'):
-                for param in fill.param:
-                    if param.hidden is True:
-                        param.transitive = False
-                    param.hidden = None
-                value.param = fill.param
-            if not hasattr(variable, 'value'):
-                variable.value = []
-            variable.value.append(value)
-            self.force_not_mandatory.append(fill.target)
-        del space.constraints.fill
-
     def filter_targets(self):  # pylint: disable=C0111
         for condition_idx, condition in enumerate(self.space.constraints.condition):
             namespace = condition.namespace
-            del_idx = []
             for idx, target in enumerate(condition.target):
                 if target.type == 'variable':
-                    if (hasattr(target, 'optional') and target.optional is True and
-                            not self.paths.path_is_defined(target.name)):
-                        del_idx.append(idx)
-                        continue
                     if condition.source == target.name:
-                        raise CreoleDictConsistencyError(_('target name and source name must be different: {}').format(condition.source))
+                        raise DictConsistencyError(_('target name and source name must be different: {}').format(condition.source))
                     target.name = self.paths.get_variable_path(target.name, namespace)
                 elif target.type == 'family':
                     try:
                         target.name = self.paths.get_family_path(target.name, namespace)
                     except KeyError:
-                        raise CreoleDictConsistencyError(_('cannot found family {}').format(target.name))
+                        raise DictConsistencyError(_('cannot found family {}').format(target.name))
-            del_idx = list(set(del_idx))
-            del_idx.sort(reverse=True)
-            for idx in del_idx:
-                condition.target.pop(idx)
 
-    def filter_condition_servicelist(self):
+    def convert_xxxlist_to_variable(self):  # pylint: disable=C0111
-        # automatic generation of the service_access lists
-        # and the service_restriction lists from the servicelist
-        for condition in self.space.constraints.condition:
-            if hasattr(condition, 'target'):
-                new_targets = []
-                for target in condition.target:
-                    if target.type == 'servicelist':
-                        new_target = copy(target)
-                        new_target.type = 'service_accesslist'
-                        new_target.name = '___auto_{}'.format(new_target.name)
-                        new_targets.append(new_target)
-
-                        new_target = copy(target)
-                        new_target.type = 'service_restrictionlist'
-                        new_target.name = '___auto_{}'.format(new_target.name)
-                        new_targets.append(new_target)
-                condition.target.extend(new_targets)
-
-    def check_condition_without_target(self):
-        for condition in self.space.constraints.condition:
-            if not hasattr(condition, 'target'):
-                raise CreoleDictConsistencyError(_('target is mandatory in condition'))
-
-    def check_condition_fallback_not_exists(self, fallback_variables, fallback_lists):
-        # a condition with a fallback **and** the source variable doesn't exist
-        remove_conditions = []
-        for idx, condition in enumerate(self.space.constraints.condition):
-            if (hasattr(condition, 'fallback') and condition.fallback is True and
-                    not self.paths.path_is_defined(condition.source)):
-                for target in condition.target:
-                    if target.type in ['variable', 'family']:
-                        name = target.name.split('.')[-1]
-                        if target.type == 'variable':
-                            variable = self.get_variable(name)
-                        else:
-                            variable = self.paths.get_family_obj(name)
-                        if condition.name in ['disabled_if_in']:
-                            variable.disabled = True
-                        if condition.name in ['mandatory_if_in']:
-                            variable.mandatory = True
-                        if condition.name in ['disabled_if_in', 'disabled_if_not_in',
-                                              'frozen_if_in', 'frozen_if_not_in']:
-                            variable.hidden = False
-                        if HIGH_COMPATIBILITY:
-                            fallback_variables.append(name)
-                    else:
-                        listname = target.type
-                        if not listname.endswith('list'):
-                            raise Exception('not yet implemented')
-                        listvars = self.objectspace.list_conditions.get(listname,
-                                                                        {}).get(target.name)
-                        if listvars:
-                            for listvar in listvars:
-                                try:
-                                    variable = self.get_variable(listvar)
-                                except CreoleDictConsistencyError:
-                                    variable = self.paths.get_family_obj(listvar)
-                                if condition.name in ['disabled_if_in']:
-                                    variable.disabled = True
-                                if condition.name in ['mandatory_if_in']:
-                                    variable.mandatory = True
-                                if condition.name in ['disabled_if_in', 'disabled_if_not_in',
-                                                      'frozen_if_in', 'frozen_if_not_in']:
-                                    variable.hidden = False
-                                fallback_lists.append(listvar)
-                remove_conditions.append(idx)
-        remove_conditions = list(set(remove_conditions))
-        remove_conditions.sort(reverse=True)
-        for idx in remove_conditions:
-            self.space.constraints.condition.pop(idx)
-
-    def convert_xxxlist_to_variable(self, fallback_lists):  # pylint: disable=C0111
         # transform *list to variable or family
         for condition_idx, condition in enumerate(self.space.constraints.condition):
             new_targets = []
@@ -1206,14 +942,8 @@ class SpaceAnnotator(object):
                                                                     {}).get(target.name)
                     if listvars:
                         for listvar in listvars:
-                            if listvar in fallback_lists:
+                            variable = self.paths.get_variable_obj(listvar)
-                                continue
+                            type_ = 'variable'
-                            try:
-                                variable = self.get_variable(listvar)
-                                type_ = 'variable'
-                            except CreoleDictConsistencyError:
-                                variable = self.paths.get_family_obj(listvar)
-                                type_ = 'family'
                             new_target = self.objectspace.target()
                             new_target.type = type_
                             new_target.name = listvar
@@ -1227,25 +957,71 @@ class SpaceAnnotator(object):
             condition.target.extend(new_targets)
 
     def check_condition(self):
-        # if condition.name == 'hidden_if_in':
-        #     condition.name = 'disabled_if_in'
-        # elif condition.name == 'hidden_if_not_in':
-        #     condition.name = 'disabled_if_not_in'
         for condition in self.space.constraints.condition:
-            if condition.name not in ['disabled_if_in', 'disabled_if_not_in', 'frozen_if_in', 'auto_frozen_if_in',
+            if condition.name not in ['disabled_if_in', 'disabled_if_not_in', 'hidden_if_in', 'auto_hidden_if_not_in',
-                                      'frozen_if_not_in', 'mandatory_if_in', 'mandatory_if_not_in']:
+                                      'hidden_if_not_in', 'mandatory_if_in', 'mandatory_if_not_in']:
-                raise CreoleDictConsistencyError(_('unknown condition {}').format(condition.name))
+                raise DictConsistencyError(_(f'unknown condition {condition.name}'))
 
     def check_params(self):
         for condition in self.space.constraints.condition:
             for param in condition.param:
                 if param.type not in TYPE_PARAM_CONDITION:
-                    raise CreoleDictConsistencyError(_('cannot use {} type as a param '
+                    raise DictConsistencyError(_(f'cannot use {param.type} type as a param in a condition'))
-                                                       'in a condition').format(param.type))
-                if param.type == 'eole':
-                    param.type = 'variable'
 
-    def check_choice_option_condition(self, force_remove_targets):
+    def check_target(self):
+        for condition in self.space.constraints.condition:
+            if not hasattr(condition, 'target'):
+                raise DictConsistencyError(_('target is mandatory in condition'))
+            for target in condition.target:
+                if target.type.endswith('list') and condition.name not in ['disabled_if_in', 'disabled_if_not_in']:
+                    raise DictConsistencyError(_(f'target in condition for {target.type} not allow in {condition.name}'))
+
+    def check_condition_fallback_optional(self):
+        # a condition with a fallback **and** the source variable doesn't exist
+        remove_conditions = []
+        for idx, condition in enumerate(self.space.constraints.condition):
+            remove_targets = []
+            if condition.fallback is True and not self.paths.path_is_defined(condition.source):
+                for target in condition.target:
+                    if target.type in ['variable', 'family']:
+                        if target.name.startswith(variable_namespace + '.'):
+                            name = target.name.split('.')[-1]
+                        else:
+                            name = target.name
+                        if target.type == 'variable':
+                            variable = self.paths.get_variable_obj(name)
+                        else:
+                            variable = self.paths.get_family_obj(name)
+                        if condition.name == 'disabled_if_in':
+                            variable.disabled = True
+                        if condition.name == 'mandatory_if_in':
+                            variable.mandatory = True
+                        if condition.name == 'hidden_if_in':
+                            variable.hidden = True
+                    else:
+                        listname = target.type
+                        listvars = self.objectspace.list_conditions.get(listname,
+                                                                        {}).get(target.name, None)
+                        if listvars is not None:
+                            for listvar in listvars:
+                                variable = self.paths.get_variable_obj(listvar)
+                                if condition.name in ['disabled_if_in']:
+                                    variable.value[0].name = False
+                            del self.objectspace.list_conditions[listname][target.name]
+                remove_conditions.append(idx)
+            for idx, target in enumerate(condition.target):
+                if target.optional is True and not self.paths.path_is_defined(target.name):
+                    remove_targets.append(idx)
+            remove_targets = list(set(remove_targets))
+            remove_targets.sort(reverse=True)
+            for idx in remove_targets:
+                condition.target.pop(idx)
+        remove_conditions = list(set(remove_conditions))
+        remove_conditions.sort(reverse=True)
+        for idx in remove_conditions:
+            self.space.constraints.condition.pop(idx)
+
+    def check_choice_option_condition(self):
         # remove condition for ChoiceOption that don't have param
         remove_conditions = []
         for condition_idx, condition in enumerate(self.space.constraints.condition):
@@ -1267,69 +1043,54 @@ class SpaceAnnotator(object):
                 for idx in remove_param:
                     del condition.param[idx]
                 if condition.param == []:
+                    remove_targets = []
                     for target in condition.target:
-                        if target.name.startswith('creole.'):
+                        if target.name.startswith(f'{variable_namespace}.'):
                             name = target.name.split('.')[-1]
                         else:
                             name = target.name
                         if target.type == 'variable':
-                            variable = self.get_variable(name)
+                            variable = self.paths.get_variable_obj(name)
                         else:
                             variable = self.paths.get_family_obj(name)
                         if condition.name == 'disabled_if_not_in':
                             variable.disabled = True
-                            force_remove_targets.setdefault(condition.name,
+                        elif condition.name == 'hidden_if_not_in':
-                                                            []).append(target.name)
-                        elif condition.name == 'frozen_if_not_in':
                             variable.hidden = True
-                            force_remove_targets.setdefault(condition.name,
-                                                            []).append(target.name)
                         elif condition.name == 'mandatory_if_not_in':
                             variable.mandatory = True
-                            force_remove_targets.setdefault(condition.name,
+                    remove_targets = list(set(remove_targets))
-                                                            []).append(target.name)
+                    remove_targets.sort(reverse=True)
-                        elif HIGH_COMPATIBILITY and condition.name == 'disabled_if_in':
+                    for target_idx in remove_targets:
-                            variable.hidden = False
+                        condition.target.pop(target_idx)
                     remove_conditions.append(condition_idx)
         remove_conditions = list(set(remove_conditions))
         remove_conditions.sort(reverse=True)
         for idx in remove_conditions:
             self.space.constraints.condition.pop(idx)
 
-    def manage_variable_property(self, force_remove_targets, fallback_variables):
+    def manage_variable_property(self):
         for condition in self.space.constraints.condition:
-            remove_targets = []
             #parse each variable and family
             for target_idx, target in enumerate(condition.target):
-                if target.name in force_remove_targets.get(condition.name, []):
+                if target.name.startswith(f'{variable_namespace}.'):
-                    remove_targets.append(target_idx)
-                if target.name.startswith('creole.'):
                     name = target.name.split('.')[-1]
                 else:
                     name = target.name
                 if target.type == 'variable':
-                    variable = self.get_variable(name)
+                    variable = self.paths.get_variable_obj(name)
                 else:
                     variable = self.paths.get_family_obj(name)
-                if name in fallback_variables:
+                if condition.name in ['hidden_if_in', 'hidden_if_not_in']:
-                    remove_targets.append(target_idx)
-                    continue
-                if condition.name in ['disabled_if_in', 'disabled_if_not_in',
-                                      'frozen_if_in', 'frozen_if_not_in']:
                     variable.hidden = False
                 if condition.name in ['mandatory_if_in', 'mandatory_if_not_in']:
                     variable.mandatory = False
-                if HIGH_COMPATIBILITY and condition.name in ['frozen_if_in',
+                if HIGH_COMPATIBILITY and condition.name in ['hidden_if_in',
-                                                             'frozen_if_not_in']:
+                                                             'hidden_if_not_in']:
-                    self.has_frozen_if_in_condition.append(name)
+                    self.has_hidden_if_in_condition.append(name)
                 if condition.name in ['mandatory_if_in', 'mandatory_if_not_in']:
                     self.force_not_mandatory.append(target.name)
 
-            remove_targets = list(set(remove_targets))
-            remove_targets.sort(reverse=True)
-            for target_idx in remove_targets:
-                condition.target.pop(target_idx)
-
     def remove_condition_with_empty_target(self):
         remove_conditions = []
         for condition_idx, condition in enumerate(self.space.constraints.condition):
@@ -1343,53 +1104,37 @@ class SpaceAnnotator(object):
     def filter_condition(self):  # pylint: disable=C0111
         if not hasattr(self.space, 'constraints') or not hasattr(self.space.constraints, 'condition'):
             return
-        fallback_variables = []
-        fallback_lists = []
-        force_remove_targets = {}
         self.check_condition()
         self.check_params()
-        self.check_condition_without_target()
+        self.check_target()
-        self.filter_condition_servicelist()
+        self.check_condition_fallback_optional()
-        self.check_condition_fallback_not_exists(fallback_variables, fallback_lists)
         self.filter_targets()
-        self.convert_xxxlist_to_variable(fallback_lists)
+        self.convert_xxxlist_to_variable()
-        self.check_choice_option_condition(force_remove_targets)
+        self.check_choice_option_condition()
-        self.manage_variable_property(force_remove_targets, fallback_variables)
+        self.manage_variable_property()
         self.remove_condition_with_empty_target()
         for condition in self.space.constraints.condition:
-            if condition.name == 'disabled_if_in':
+            inverse = condition.name.endswith('_if_not_in')
+            if condition.name.startswith('disabled_if_'):
                 actions = ['disabled']
-                inverse = False
+            elif condition.name.startswith('hidden_if_'):
-            elif condition.name == 'disabled_if_not_in':
-                actions = ['disabled']
-                inverse = True
-            elif condition.name == 'frozen_if_in':
                 actions = ['frozen', 'hidden', 'force_default_on_freeze']
-                inverse = False
+            elif condition.name.startswith('mandatory_if_'):
-            elif condition.name == 'frozen_if_not_in':
-                actions = ['frozen', 'hidden', 'force_default_on_freeze']
-                inverse = True
-            elif condition.name == 'mandatory_if_in':
                 actions = ['mandatory']
-                inverse = False
+            elif condition.name == 'auto_hidden_if_not_in':
-            elif condition.name == 'mandatory_if_not_in':
-                actions = ['mandatory']
-                inverse = True
-            elif condition.name == 'auto_frozen_if_in':
                 actions = ['auto_frozen']
-                inverse = True
             for param in condition.param:
                 if hasattr(param, 'text'):
                     param = param.text
                 else:
                     param = None
                 for target in condition.target:
-                    if target.name.startswith('creole.'):
+                    if target.name.startswith(f'{variable_namespace}.'):
                         name = target.name.split('.')[-1]
                     else:
                         name = target.name
                     if target.type == 'variable':
-                        variable = self.get_variable(name)
+                        variable = self.paths.get_variable_obj(name)
                     else:
                         variable = self.paths.get_family_obj(name)
                     if not hasattr(variable, 'property'):

src/rougail/config.py

@@ -15,3 +15,5 @@ dtdfilename = join(dtddir, 'rougail.dtd')
 
 # chemin du répertoire source des fichiers templates
 patch_dir = '/srv/rougail/patch'
+
+variable_namespace = 'rougail'

src/rougail/data/rougail.dtd

@@ -13,7 +13,7 @@
 
 #    Forked by:
 #    Cadoles (http://www.cadoles.com)
-#    Copyright (C) 2019
+#    Copyright (C) 2019-2020
 
 #    distribued with GPL-2 or later license
 
@@ -37,54 +37,22 @@
 <!-- root element    -->
 <!-- =============== -->
 
-<!ELEMENT rougail (services | family_action | variables | constraints | help)*>
+<!ELEMENT rougail (services | variables | constraints | help)*>
 
 <!-- ============== -->
 <!-- files element  -->
 <!-- ============== -->
 
-<!ELEMENT family_action (action)>
-<!ATTLIST family_action name CDATA #REQUIRED>
-<!ATTLIST family_action description CDATA #IMPLIED>
-<!ATTLIST family_action color CDATA #IMPLIED>
-<!ATTLIST family_action image CDATA #IMPLIED>
-<!ELEMENT action ((input* | profile* | ewtapp* | tag* | saltaction*)*)>
-<!ATTLIST action type (form|custom|external|reader|apache) "custom">
-<!ATTLIST action title CDATA #REQUIRED>
-<!ATTLIST action description CDATA #REQUIRED>
-<!ATTLIST action rewrite CDATA #IMPLIED>
-<!ATTLIST action image CDATA #IMPLIED>
-<!ATTLIST action actionlist CDATA #IMPLIED>
-<!-- for apache action -->
-<!ATTLIST action apache_path CDATA #IMPLIED>
-<!ATTLIST action apache_path_type (FilenameOption|SymLinkOption|variable) "FilenameOption">
-<!-- for external action -->
-<!ATTLIST action url CDATA #IMPLIED>
-<!ATTLIST action url_type (URLOption|SymLinkOption|variable) "URLOption">
-<!-- for form action -->
-<!ATTLIST action save (True|False) "False">
-
 <!ELEMENT services (service*)>
 
-<!ELEMENT service ((port* | tcpwrapper* | ip* | interface* | package* | file* | digitalcertificate*)*) >
+<!ELEMENT service ((port* | tcpwrapper* | ip* | interface* | package* | file* | digitalcertificate* | override*)*) >
 <!ATTLIST service name CDATA #REQUIRED>
-<!ATTLIST service method (systemd|upstart|apache|network) "systemd">
-
-<!ELEMENT input (#PCDATA)>
-<!ELEMENT profile (#PCDATA)>
-<!ELEMENT ewtapp (#PCDATA)>
-<!ELEMENT tag (#PCDATA)>
-<!ELEMENT saltaction (#PCDATA)>
 
 <!ELEMENT port (#PCDATA)>
 <!ATTLIST port port_type (PortOption|SymLinkOption|variable) "PortOption">
 <!ATTLIST port portlist CDATA #IMPLIED >
 <!ATTLIST port protocol (tcp|udp) "tcp">
 
-<!ELEMENT tcpwrapper (#PCDATA)>
-<!ATTLIST tcpwrapper tcpwrapper_type (UnicodeOption|SymLinkOption|variable) "UnicodeOption">
-<!ATTLIST tcpwrapper tcpwrapperlist CDATA #IMPLIED >
-
 <!ELEMENT ip (#PCDATA)>
 <!ATTLIST ip iplist CDATA #IMPLIED >
 <!ATTLIST ip ip_type (NetworkOption|SymLinkOption|variable) "NetworkOption">
@@ -93,9 +61,6 @@
 <!ATTLIST ip netmask_type (NetmaskOption|SymLinkOption|variable) "NetmaskOption">
 <!ATTLIST ip netmask CDATA "255.255.255.255">
 
-<!ELEMENT package (#PCDATA)>
-<!ATTLIST package packagelist CDATA #IMPLIED >
-
 <!ELEMENT file EMPTY>
 <!ATTLIST file name CDATA #REQUIRED >
 <!ATTLIST file file_type (UnicodeOption|SymLinkOption|variable) "UnicodeOption">
@@ -106,9 +71,8 @@
 <!ATTLIST file owner CDATA "root">
 <!ATTLIST file group CDATA "root">
 <!ATTLIST file filelist CDATA #IMPLIED >
-<!ATTLIST file mkdir (True|False) "False">
-<!ATTLIST file rm (True|False) "False">
 <!ATTLIST file redefine (True|False) "False">
+<!ATTLIST file templating (True|False) "True">
 
 <!ELEMENT digitalcertificate EMPTY>
 <!ATTLIST digitalcertificate name CDATA #REQUIRED >
@@ -118,12 +82,15 @@
 <!ATTLIST digitalcertificate type CDATA #REQUIRED >
 <!ATTLIST digitalcertificate ca CDATA #REQUIRED >
 
+<!ELEMENT override EMPTY>
+<!ATTLIST override source CDATA #IMPLIED >
+<!ATTLIST override templating (True|False) "True">
+
 <!ELEMENT variables (family*, separators*)>
 <!ELEMENT family (#PCDATA | variable)*>
 <!ATTLIST family name CDATA #REQUIRED>
 <!ATTLIST family description CDATA #IMPLIED>
 <!ATTLIST family mode (basic|normal|expert) "basic">
-<!ATTLIST family icon CDATA #IMPLIED>
 <!ATTLIST family hidden (True|False) "False">
 <!ATTLIST family dynamic CDATA #IMPLIED>
 
@@ -134,7 +101,6 @@
 <!ATTLIST variable hidden (True|False) "False">
 <!ATTLIST variable disabled (True|False) "False">
 <!ATTLIST variable multi (True|False) "False">
-<!ATTLIST variable submulti (True|False) "False">
 <!ATTLIST variable redefine (True|False) "False">
 <!ATTLIST variable exists (True|False) "True">
 <!ATTLIST variable mandatory (True|False) "False">
@@ -149,11 +115,10 @@
 
 <!ELEMENT separator (#PCDATA)>
 <!ATTLIST separator name CDATA #REQUIRED>
-<!ATTLIST separator never_hidden CDATA #IMPLIED>
 
 <!ELEMENT value (#PCDATA)>
 
-<!ELEMENT constraints ((fill* | check* | condition* | auto* | group*)*)>
+<!ELEMENT constraints ((fill* | check* | condition* | group*)*)>
 <!ELEMENT fill (param*)>
 <!ATTLIST fill name CDATA #REQUIRED>
 <!ATTLIST fill target CDATA #REQUIRED>
@@ -163,29 +128,25 @@
 <!ATTLIST check target CDATA #REQUIRED>
 <!ATTLIST check level (error|warning) "error">
 
-<!ELEMENT auto ((param)*)>
-<!ATTLIST auto name CDATA #REQUIRED>
-<!ATTLIST auto target CDATA #REQUIRED>
-
 <!ELEMENT condition ((target | param)+ )>
 <!ATTLIST condition name CDATA #REQUIRED>
 <!ATTLIST condition source CDATA #REQUIRED>
 <!ATTLIST condition fallback (True|False) "False">
 
-<!ELEMENT group (slave+)>
+<!ELEMENT group (follower+)>
-<!ATTLIST group master CDATA #REQUIRED>
+<!ATTLIST group leader CDATA #REQUIRED>
 <!ATTLIST group description CDATA #IMPLIED>
 
 <!ELEMENT param (#PCDATA)>
 <!ATTLIST param type (string|variable|number|python) "string">
 <!ATTLIST param name CDATA #IMPLIED>
-<!ATTLIST param hidden (True|False) "True">
+<!ATTLIST param notraisepropertyerror (True|False) "False">
 <!ATTLIST param optional (True|False) "False">
 
 <!ELEMENT target (#PCDATA)>
-<!ATTLIST target type (family|variable|filelist|iplist|portlist|tcpwrapperlist|packagelist|actionlist) "variable">
+<!ATTLIST target type (family|variable|filelist|iplist|portlist) "variable">
 <!ATTLIST target optional (True|False) "False">
 
-<!ELEMENT slave (#PCDATA)>
+<!ELEMENT follower (#PCDATA)>
 
 <!ELEMENT help ((variable* | family*)*)>

src/rougail/error.py

@@ -1,9 +1,4 @@
 # -*- coding: utf-8 -*-
-"""
-Erreurs Creole
-"""
-
-
 class ConfigError(Exception):
     pass
 
@@ -19,7 +14,7 @@ class TemplateDisabled(TemplateError):
     pass
 
 
-class CreoleOperationError(Exception):
+class OperationError(Exception):
     """Type error or value Error for Creole variable's type or values
     """
 
@@ -30,7 +25,11 @@ class SpaceObjShallNotBeUpdated(Exception):
     """
 
 
-class CreoleDictConsistencyError(Exception):
+class DictConsistencyError(Exception):
     """It's not only that the Creole XML is valid against the Creole DTD
     it's that it is not consistent.
     """
+
+
+class LoaderError(Exception):
+    pass

src/rougail/i18n.py

@@ -24,7 +24,7 @@ import sys
 import locale
 
 # Application Name
-APP_NAME = 'creole'
+APP_NAME = 'rougail'
 
 # Traduction dir
 APP_DIR = os.path.join(sys.prefix, 'share')
@@ -44,8 +44,8 @@ mo_location = LOCALE_DIR
 
 gettext.find(APP_NAME, mo_location)
 gettext.textdomain(APP_NAME)
-gettext.bind_textdomain_codeset(APP_NAME, "UTF-8")
+#gettext.bind_textdomain_codeset(APP_NAME, "UTF-8")
-gettext.translation(APP_NAME, fallback=True)
+#gettext.translation(APP_NAME, fallback=True)
 
 t = gettext.translation(APP_NAME, fallback=True)
 

src/rougail/loader.py

@@ -1,66 +1,34 @@
-"""creole loader
+"""loader
 flattened XML specific
 """
-from os.path import join, isfile, isdir
+from os.path import isfile
-from os import listdir
+from lxml.etree import DTD
-#from ast import literal_eval
-from lxml.etree import parse, DTD
 
-from tiramisu import (StrOption, OptionDescription, DynOptionDescription, PortOption,
+from .config import dtdfilename, variable_namespace
-                      IntOption, ChoiceOption, BoolOption, SymLinkOption, IPOption,
-                      NetworkOption, NetmaskOption, DomainnameOption, BroadcastOption,
-                      URLOption, EmailOption, FilenameOption, UsernameOption, DateOption,
-                      PasswordOption, BoolOption, MACOption, Leadership, submulti,
-                      Params, ParamSelfOption, ParamOption, ParamValue, Calculation, calc_value,
-                      groups, owners)
-from tiramisu.error import ConfigError
-
-from .config import dtdfilename
 from .i18n import _
-#For compatibility
+from .error import LoaderError
-from .xmlreflector import HIGH_COMPATIBILITY
-#from . import eosfunc
-from .objspace import CreoleObjSpace
-from .utils import normalize_family
-import imp
 
 
 FUNC_TO_DICT = ['valid_not_equal']
+FORCE_INFORMATIONS = ['help', 'test', 'separator']
 
 
-class ConvertDynOptionDescription(DynOptionDescription):
+def convert_boolean(value):
-    def convert_suffix_to_path(self, suffix):
+    prop = {'True': True,
-        if not isinstance(suffix, str):
+            'False': False,
-            suffix = str(suffix)
+            'None': None}
-        return normalize_family(suffix,
+    if value not in prop:
-                                check_name=False)
+        raise Exception('unknown value {} while trying to cast {} to boolean'.format(value, obj))
+    return prop[value]
 
 
-class CreoleLoaderError(Exception):
+def convert_tiramisu_value(value, type_):
-    pass
-
-
-def convert_tiramisu_value(value, obj):
     """
     convertit les variables dans le bon type si nécessaire
     """
     if value is None:
         return value
-    def _convert_boolean(value):
+    func = CONVERT_OPTION[type_].get('func', None)
-        if isinstance(value, bool):
-            return value
-        prop = {'True': True,
-                'False': False,
-                'None': None}
-        if value not in prop:
-            raise Exception('unknown value {} while trying to cast {} to boolean'.format(value, obj))
-        return prop[value]
-
-    func = {IntOption: int, StrOption: str, PortOption: str,
-            DomainnameOption: str, EmailOption: str, URLOption: str,
-            IPOption: str, NetmaskOption: str, NetworkOption: str,
-            BroadcastOption: str, FilenameOption: str,
-            BoolOption: _convert_boolean}.get(obj, None)
     if func is None:
         return value
     if isinstance(value, list):
@@ -69,526 +37,460 @@ def convert_tiramisu_value(value, obj):
         return func(value)
 
 
-CONVERT_OPTION = {'number': dict(opttype=IntOption),
+CONVERT_OPTION = {'number': dict(opttype="IntOption", func=int),
-                  'choice': dict(opttype=ChoiceOption),
+                  'choice': dict(opttype="ChoiceOption"),
-                  'string': dict(opttype=StrOption),
+                  'string': dict(opttype="StrOption"),
-                  'password': dict(opttype=PasswordOption),
+                  'password': dict(opttype="PasswordOption"),
-                  'mail': dict(opttype=EmailOption),
+                  'mail': dict(opttype="EmailOption"),
-                  'boolean': dict(opttype=BoolOption),
+                  'boolean': dict(opttype="BoolOption", initkwargs={'default': [True]}, func=convert_boolean),
-                  'symlink': dict(opttype=SymLinkOption),
+                  'symlink': dict(opttype="SymLinkOption"),
-                  'filename': dict(opttype=FilenameOption),
+                  'filename': dict(opttype="FilenameOption"),
-                  'date': dict(opttype=DateOption),
+                  'date': dict(opttype="DateOption"),
-                  'unix_user': dict(opttype=UsernameOption),
+                  'unix_user': dict(opttype="UsernameOption"),
-                  'ip': dict(opttype=IPOption, initkwargs={'allow_reserved': True}),
+                  'ip': dict(opttype="IPOption", initkwargs={'allow_reserved': True}),
-                  'local_ip': dict(opttype=IPOption, initkwargs={'private_only': True, 'warnings_only': True}),
+                  'local_ip': dict(opttype="IPOption", initkwargs={'private_only': True, 'warnings_only': True}),
-                  'netmask': dict(opttype=NetmaskOption),
+                  'netmask': dict(opttype="NetmaskOption"),
-                  'network': dict(opttype=NetworkOption),
+                  'network': dict(opttype="NetworkOption"),
-                  'broadcast': dict(opttype=BroadcastOption),
+                  'broadcast': dict(opttype="BroadcastOption"),
-                  'netbios': dict(opttype=DomainnameOption, initkwargs={'type': 'netbios', 'warnings_only': True}),
+                  'netbios': dict(opttype="DomainnameOption", initkwargs={'type': 'netbios', 'warnings_only': True}),
-                  'domain': dict(opttype=DomainnameOption, initkwargs={'type': 'domainname', 'allow_ip': True, 'allow_without_dot': True}),
+                  'domain': dict(opttype="DomainnameOption", initkwargs={'type': 'domainname', 'allow_ip': True, 'allow_without_dot': True}),
-                  'domain_strict': dict(opttype=DomainnameOption, initkwargs={'type': 'domainname', 'allow_ip': False}),
+                  'domain_strict': dict(opttype="DomainnameOption", initkwargs={'type': 'domainname', 'allow_ip': False}),
-                  'hostname': dict(opttype=DomainnameOption, initkwargs={'type': 'hostname', 'allow_ip': True}),
+                  'hostname': dict(opttype="DomainnameOption", initkwargs={'type': 'hostname', 'allow_ip': True}),
-                  'hostname_strict': dict(opttype=DomainnameOption, initkwargs={'type': 'hostname', 'allow_ip': False}),
+                  'hostname_strict': dict(opttype="DomainnameOption", initkwargs={'type': 'hostname', 'allow_ip': False}),
-                  'web_address': dict(opttype=URLOption, initkwargs={'allow_ip': True, 'allow_without_dot': True}),
+                  'web_address': dict(opttype="URLOption", initkwargs={'allow_ip': True, 'allow_without_dot': True}),
-                  'port': dict(opttype=PortOption, initkwargs={'allow_private': True}),
+                  'port': dict(opttype="PortOption", initkwargs={'allow_private': True}),
-                  'mac': dict(opttype=MACOption),
+                  'mac': dict(opttype="MACOption"),
-                  'cidr': dict(opttype=IPOption, initkwargs={'cidr': True}),
+                  'cidr': dict(opttype="IPOption", initkwargs={'cidr': True}),
-                  'network_cidr': dict(opttype=NetworkOption, initkwargs={'cidr': True}),
+                  'network_cidr': dict(opttype="NetworkOption", initkwargs={'cidr': True}),
                   }
 
 
-class Elt(object):
+class PopulateTiramisuObjects:
-    def __init__(self, attrib):
+    def __init__(self,
-        self.attrib = attrib
+                 xmlroot,
+                 funcs_path,
+                 ):
+        self.storage = ElementStorage(self.parse_dtd())
+        self.storage.text = ["from tiramisu import *",
+                             "from rougail.tiramisu import ConvertDynOptionDescription",
+                             "import imp",
+                             f"func = imp.load_source('func', '{funcs_path}')",
+                             ]
+        self.make_tiramisu_objects(xmlroot)
+        # parse object
+        self.storage.get('.').get()
 
-
+    def parse_dtd(self):
-class PopulateTiramisuObjects(object):
+        """Loads the DTD
-    def __init__(self):
-        self.storage = ElementStorage()
-        self.booleans = []
-        self.force_store_values = set()
-        self.separators = {}
-        self.groups = {}
-
-    def parse_dtd(self, dtdfilename):
-        """Loads the Creole DTD
 
         :raises IOError: if the DTD is not found
 
-        :param dtdfilename: the full filename of the Creole DTD
+        :param dtdfilename: the full filename of the DTD
         """
         if not isfile(dtdfilename):
             raise IOError(_("no such DTD file: {}").format(dtdfilename))
+        booleans = []
         with open(dtdfilename, 'r') as dtdfd:
             dtd = DTD(dtdfd)
             for elt in dtd.iterelements():
                 if elt.name == 'variable':
                     for attr in elt.iterattributes():
                         if set(attr.itervalues()) == set(['True', 'False']):
-                            self.booleans.append(attr.name)
+                            booleans.append(attr.name)
+        return booleans
 
-    def make_tiramisu_objects(self, xmlroot, creolefunc_file):
+    def make_tiramisu_objects(self,
-        elt = Elt({'name': 'baseoption'})
+                              xmlroot,
-        if creolefunc_file is None:
+                              ):
-            self.eosfunc = None
+        family = self.get_root_family()
-        else:
+        for xmlelt in self.reorder_family(xmlroot):
-            self.eosfunc = imp.load_source('eosfunc', creolefunc_file)
+            self.iter_family(xmlelt,
-        family = Family(elt, self.booleans, self.storage, self.eosfunc)
+                             family,
-        self.storage.add('.', family)
+                             None,
+                             )
 
-        elts = {}
+    def get_root_family(self):
-        for elt in xmlroot:
+        family = Family(BaseElt({'name': 'baseoption',
-            elts.setdefault(elt.tag, []).append(elt)
+                                 'doc': 'baseoption'}),
-        list_elts = list(elts.keys())
+                        self.storage,
-        if 'family' in list_elts:
+                        False,
-            list_elts.remove('family')
+                        '.',
-            list_elts.insert(0, 'family')
+                        )
-        for elt in list_elts:
-            xmlelts_ = elts[elt]
-            if elt == 'family':
-                xmlelts = []
-                actions = None
-                # `creole` family has to be loaded before any other family
-                # because `extra` family could use `creole` variables.
-                # `actions` family has to be loaded at the very end
-                # because it may use `creole` or `extra` variables
-                for xml in xmlelts_:
-                    if xml.attrib['name'] == 'creole':
-                        xmlelts.insert(0, xml)
-                    elif xml.attrib['name'] == 'actions':
-                        actions = xml
-                    else:
-                        xmlelts.append(xml)
-                if actions is not None:
-                    xmlelts.append(actions)
-            else:
-                xmlelts = xmlelts_
-            for xmlelt in xmlelts:
-                if xmlelt.tag != 'family':
-                    raise CreoleLoaderError(_('unknown tag {}').format(xmlelt.tag))
-                self._iter_family(xmlelt, family)
-
-    def _populate_variable(self, elt, subpath, is_follower, is_leader):
-        variable = Variable(elt, self.booleans, self.storage, is_follower, is_leader, self.eosfunc)
-        path = self._build_path(subpath, elt)
-        properties = variable.attrib.get('properties', [])
-        if 'force_store_value' in properties or "auto_freeze" in properties:
-            self.force_store_values.add(path)
-        self.storage.add(path, variable)
-        return variable
-
-    def _populate_family(self, elt, subpath):
-        if subpath is None:
-            force_icon = False
-        else:
-            force_icon = not subpath.startswith('containers') and not subpath.startswith('actions')
-        family = Family(elt, self.booleans, self.storage, self.eosfunc, force_icon)
-        path = self._build_path(subpath, elt)
-        self.storage.add(path, family)
         return family
 
-    def _build_path(self, subpath, elt):
+    def reorder_family(self, xmlroot):
-        if subpath is None:
+        xmlelts = []
-            subpath = elt.attrib['name']
+        for xmlelt in xmlroot:
-        else:
+            # variable_namespace family has to be loaded before any other family
-            subpath += '.' + elt.attrib['name']
+            # because `extra` family could use `variable_namespace` variables.
-        return subpath
+            if xmlelt.attrib['name'] == variable_namespace:
-
+                xmlelts.insert(0, xmlelt)
-    def _iter_leader(self, leader, subpath):
-        subpath = self._build_path(subpath, leader)
-        family = Family(leader, self.booleans, self.storage, self.eosfunc)
-        family.set_leader()
-        self.storage.add(subpath, family)
-        leader_name = None
-        for var in leader:
-            if var.tag == 'property':
-                self._parse_properties(family, var)
-            elif var.tag == 'variable':
-                if leader_name is None:
-                    leader_name = var.attrib['name']
-                    self.groups[leader_name] = []
-                else:
-                    self.groups[leader_name].append(var.attrib['name'])
-                self._iter_family(var, family, subpath=subpath)
             else:
-                raise CreoleLoaderError(_('unknown tag {}').format(var.tag))
+                xmlelts.append(xmlelt)
-        return family
+        return xmlelts
 
-    def _iter_family(self, child, family, subpath=None):
+    def iter_family(self,
-        if child.tag not in ['family', 'variable', 'separators', 'leader', 'property']:
+                    child,
-            raise CreoleLoaderError(_('unknown tag {}').format(child.tag))
+                    family,
-        if child.tag == 'family':
+                    subpath,
-            old_family = family
+                    ):
-            family = self._populate_family(child, subpath)
+        if child.tag in ['family', 'leader']:
-            if old_family is not None:
+            function = self.populate_family
-                old_family.add(family)
-            if len(child) != 0:
-                subpath = self._build_path(subpath, child)
-                for c in child:
-                    self._iter_family(c, family, subpath=subpath)
-        elif child.tag == 'leader':
-            leader = self._iter_leader(child, subpath)
-            family.add(leader)
-        elif child.tag == 'separators':
-            self._parse_separators(child)
         elif child.tag == 'variable':
-            if family is None:
+            function = self.populate_variable
-                raise CreoleLoaderError(_('variable without family'))
-
-            is_follower = False
-            is_leader = False
-            if family.is_leader:
-                if child.attrib['name'] != family.attrib['name']:
-                    is_follower = True
-                else:
-                    is_leader = True
-            variable = self._populate_variable(child, subpath, is_follower, is_leader)
-            family.add(variable)
         elif child.tag == 'property':
-            self._parse_properties(family, child)
+            # property already imported with family
+            return
         else:
             raise Exception('unknown tag {}'.format(child.tag))
+        function(family,
+                 child,
+                 subpath,
+                 )
 
-    def _parse_properties(self, family, child):
+    def populate_family(self,
-        if child.get('type') == 'calculation':
+                        parent_family,
-            kwargs = {'condition': child.attrib['source'],
+                        elt,
-                      'expected':  ParamValue(child.attrib.get('expected'))}
+                        subpath,
-            if child.attrib['inverse'] == 'True':
+                        ):
-                kwargs['reverse_condition'] = ParamValue(True)
+        path = self.build_path(subpath,
-            family.attrib['properties'].append((ParamValue(child.text), kwargs))
+                               elt,
-        else:
+                               )
-            family.attrib['properties'].append(child.text)
+        family = Family(elt,
+                        self.storage,
+                        elt.tag == 'leader',
+                        path,
+                        )
+        parent_family.add(family)
+        if len(elt) != 0:
+            for child in elt:
+                self.iter_family(child,
+                                 family,
+                                 path,
+                                 )
 
-    def _parse_separators(self, separators):
+    def populate_variable(self,
-        for separator in separators:
+                          family,
-            elt = self.storage.get(separator.attrib['name'])
+                          elt,
-            never_hidden = separator.attrib.get('never_hidden')
+                          subpath,
-            if never_hidden == 'True':
+                          ):
-                never_hidden = True
+        is_follower = False
+        is_leader = False
+        if family.is_leader:
+            if elt.attrib['name'] != family.elt.attrib['name']:
+                is_follower = True
             else:
-                never_hidden = None
+                is_leader = True
-            info = (separator.text, never_hidden)
+        family.add(Variable(elt,
-            self.separators[separator.attrib['name']] = info
+                            self.storage,
-            elt.add_information('separator', info)
+                            is_follower,
+                            is_leader,
+                            self.build_path(subpath,
+                                            elt,
+                                            )
+                            ))
+
+    def build_path(self,
+                   subpath,
+                   elt,
+                   ):
+        if subpath is None:
+            return elt.attrib['name']
+        return subpath + '.' + elt.attrib['name']
+
+    def get_text(self):
+        return '\n'.join(self.storage.get('.').get_text())
+
+
+class BaseElt:
+    def __init__(self, attrib):
+        self.attrib = attrib
+
+    def __iter__(self):
+        return iter([])
 
 
 class ElementStorage:
-    def __init__(self):
+    def __init__(self,
+                 booleans,
+                 ):
         self.paths = {}
+        self.text = []
+        self.index = 0
+        self.booleans = booleans
 
     def add(self, path, elt):
-        if path in self.paths:
+        self.paths[path] = (elt, self.index)
-            raise CreoleLoaderError(_('path already loaded {}').format(path))
+        self.index += 1
-        self.paths[path] = elt
-
-    def add_information(self, path, name, information):
-        elt = self.get(path)
-        elt.add_information(name, information)
 
     def get(self, path):
+        if path not in self.paths or self.paths[path][0] is None:
+            raise LoaderError(_('there is no element for path {}').format(path))
+        return self.paths[path][0]
+
+    def get_name(self, path):
         if path not in self.paths:
-            raise CreoleLoaderError(_('there is no element for path {}').format(path))
+            raise LoaderError(_('there is no element for index {}').format(path))
-        return self.paths[path]
+        return f'option_{self.paths[path][1]}'
 
 
 class Common:
-    def build_properties(self):
+    def __init__(self,
-        for index, prop in enumerate(self.attrib['properties']):
+                 elt,
-            if isinstance(prop, tuple):
+                 storage,
-                action, kwargs = prop
+                 is_leader,
-                kwargs['condition'] = ParamOption(self.storage.get(kwargs['condition']).get(), todict=True)
+                 path,
-                prop = Calculation(calc_value,
+                 ):
-                                   Params(action,
+        self.option_name = None
-                                          kwargs=kwargs))
+        self.path = path
-                self.attrib['properties'][index] = prop
+        self.attrib = {}
-        if self.attrib['properties']:
+        self.informations = {}
-            self.attrib['properties'] = tuple(self.attrib['properties'])
+        self.storage = storage
+        self.is_leader = is_leader
+        self.storage.add(self.path, self)
+
+    def populate_properties(self, child):
+        if child.get('type') == 'calculation':
+            action = f"ParamValue('{child.text}')"
+            option_name = self.storage.get(child.attrib['source']).get()
+            kwargs = f"'condition': ParamOption({option_name}, todict=True), 'expected': ParamValue('{child.attrib.get('expected')}')"
+            if child.attrib['inverse'] == 'True':
+                kwargs += ", 'reverse_condition': ParamValue(True)"
+            prop = 'Calculation(calc_value, Params(' + action + ', kwargs={' + kwargs + '}))'
         else:
+            prop = "'" + child.text + "'"
+        if self.attrib['properties']:
+            self.attrib['properties'] += ', '
+        self.attrib['properties'] += prop
+        if not self.attrib['properties']:
             del self.attrib['properties']
 
+    def get_attrib(self, attrib):
+        ret_list = []
+        for key, value in self.attrib.items():
+            if key == 'properties':
+                value = 'frozenset([' + self.attrib[key] + '])'
+            elif key in ['default', 'multi', 'suffixes', 'validators']:
+                value = self.attrib[key]
+            elif isinstance(value, str) and key != 'opt' and not value.startswith('['):
+                value = "'" + value.replace("'", "\\\'") + "'"
+            ret_list.append(f'{key}={value}')
+        return ', '.join(ret_list)
+
+    def populate_informations(self):
+        for key, value in self.informations.items():
+            value = value.replace('"', '\"')
+            self.storage.text.append(f'{self.option_name}.impl_set_information("{key}", "{value}")')
+
+    def get_text(self,
+                 ):
+        return self.storage.text
+
 
 class Variable(Common):
-    def __init__(self, elt, booleans, storage, is_follower, is_leader, eosfunc):
+    def __init__(self,
-        self.option = None
+                 elt,
-        self.informations = {}
+                 storage,
-        self.attrib = {}
+                 is_follower,
-        self.attrib['properties'] = []
+                 is_leader,
-        self.attrib['validators'] = []
+                 path,
-        self.eosfunc = eosfunc
+                 ):
-        self.storage = storage
+        super().__init__(elt,
-        is_submulti = False
+                         storage,
-        for key, value in elt.attrib.items():
+                         is_leader,
-            if key in booleans:
+                         path,
-                if value == 'True':
+                         )
-                    value = True
+        self.is_follower = is_follower
-                elif value == 'False':
-                    value = False
-                elif key == 'multi' and value == 'submulti':
-                    is_submulti = True
-                    value = submulti
-                else:
-                    raise CreoleLoaderError(_('unknown value {} for {}').format(value, key))
-            if key in ['help', 'test']:
-                self.add_information(key, value)
-            elif key == 'type':
-                pass
-            else:
-                self.attrib[key] = value
         convert_option = CONVERT_OPTION[elt.attrib['type']]
+        del elt.attrib['type']
         self.object_type = convert_option['opttype']
-        if elt.attrib['type'] == 'choice':
+        self.attrib.update(convert_option.get('initkwargs', {}))
-            if self.attrib.get('choice'):
+        if self.object_type != 'SymLinkOption':
-                self.attrib['values'] = getattr(self.eosfunc, self.attrib.get('choice'))
+            self.attrib['properties'] = ''
-            else:
+            self.attrib['validators'] = []
-                self.attrib['values'] = []
+        self.elt = elt
-                for child in elt:
-                    if child.tag == 'choice':
-                        value = child.text
-                        if 'type' in child.attrib and child.attrib['type'] == 'number':
-                            value = int(value)
-                        if value is None:
-                            value = u''
-                        self.attrib['values'].append(value)
-                self.attrib['values'] = tuple(self.attrib['values'])
-        for child in elt:
-            if child.tag == 'property':
-                if child.get('type') == 'calculation':
-                    kwargs = {'condition': child.attrib['source'],
-                              'expected':  ParamValue(child.attrib.get('expected'))}
-                    if child.attrib['inverse'] == 'True':
-                        kwargs['reverse_condition'] = ParamValue(True)
-                    self.attrib['properties'].append((ParamValue(child.text), kwargs))
-                else:
-                    self.attrib['properties'].append(child.text)
-            elif child.tag == 'value':
-                if child.attrib.get('type') == 'calculation':
-                    if child.text is not None and child.text.strip():
-                        self.attrib['default'] = (child.text.strip(),)
-                    else:
-                        params = []
-                        for param in child:
-                            params.append(self.parse_param(param))
-                        self.attrib['default'] = (child.attrib['name'], params, False)
-                else:
-                    if "type" in child.attrib:
-                        type_ = CONVERT_OPTION[child.attrib['type']]['opttype']
-                    else:
-                        type_ = self.object_type
-                    if self.attrib['multi'] is True and not is_follower:
-                        if 'default' not in self.attrib:
-                            self.attrib['default'] = []
-                        value = convert_tiramisu_value(child.text, type_)
-                        self.attrib['default'].append(value)
-                        if 'default_multi' not in self.attrib and not is_leader:
-                            self.attrib['default_multi'] = value
-                    elif self.attrib['multi'] == submulti:
-                        if 'default' not in self.attrib:
-                            self.attrib['default'] = []
-                        value = convert_tiramisu_value(child.text, type_)
-                        if not isinstance(value, list) and not is_follower:
-                            value = [value]
-                        self.attrib['default'].append(value)
-                        if 'default_multi' not in self.attrib and not is_leader:
-                            self.attrib['default_multi'] = value
-                    else:
-                        if 'default' in self.attrib:
-                            raise CreoleLoaderError(_('default value already set for {}'
-                                                      '').format(self.attrib['path']))
-                        value = convert_tiramisu_value(child.text, type_)
-                        if value is None:  # and (elt.attrib['type'] != 'choice' or value not in self.attrib['values']):
-                            value = u''
-                        if is_follower:
-                            self.attrib['default_multi'] = value
-                        else:
-                            self.attrib['default'] = value
-            elif child.tag == 'choice':
-                # already load
-                pass
-            elif child.tag == 'check':
-                params = []
-                for param in child:
-                    params.append(self.parse_param(param))
-                #check.params = params
-                self.attrib['validators'].append((child.attrib['name'], params, child.attrib['warnings_only']))
-            else:
-                raise Exception('unknown tag {}'.format(child.tag))
-        if 'initkwargs' in convert_option:
-            self.attrib.update(convert_option['initkwargs'])
-        if elt.attrib['type'] == 'symlink':
-            del self.attrib['properties']
-            del self.attrib['multi']
-            self.attrib['opt'] = storage.get(self.attrib['opt'])
-
-    def parse_param(self, param):
-        name = param.attrib.get('name', '')
-        if param.attrib['type'] == 'string':
-            value = param.text
-        elif param.attrib['type'] == 'variable':
-            transitive = param.attrib.get('transitive', 'False')
-            if transitive == 'True':
-                transitive = True
-            elif transitive == 'False':
-                transitive = False
-            else:
-                raise CreoleLoaderError(_('unknown transitive boolean {}').format(transitive))
-            value = [param.text, transitive]
-        elif param.attrib['type'] == 'number':
-            value = int(param.text)
-        else:
-            raise CreoleLoaderError(_('unknown param type {}').format(param.attrib['type']))
-        return(name, value)
-
-    def add_information(self, key, value):
-        if key in self.informations:
-            raise CreoleLoaderError(_('key already exists in information {}').format(key))
-        self.informations[key] = value
-
-    def build_calculator(self, key):
-        if key in self.attrib:
-            values = self.attrib[key]
-            if isinstance(values, list):
-                is_list = True
-            else:
-                is_list = False
-                values = [values]
-            ret = []
-            for value in values:
-                if isinstance(value, tuple):
-                    if key == 'validators':
-                        args = [ParamSelfOption()]
-                    else:
-                        args = []
-                    kwargs = {}
-                    if len(value) == 3:
-                        for param in value[1]:
-                            if isinstance(param[1], list):
-                                if value[0] in FUNC_TO_DICT:
-                                    param_value = ParamOption(self.storage.get(param[1][0]).get(), notraisepropertyerror=param[1][1], todict=True)
-                                else:
-                                    param_value = ParamOption(self.storage.get(param[1][0]).get(), notraisepropertyerror=param[1][1])
-                            else:
-                                param_value = ParamValue(param[1])
-                            if not param[0]:
-                                args.append(param_value)
-                            else:
-                                kwargs[param[0]] = param_value
-
-                    ret.append(Calculation(getattr(self.eosfunc, value[0]),
-                                           Params(tuple(args),
-                                           kwargs=kwargs)))
-                else:
-                    ret.append(value)
-            if not is_list:
-                self.attrib[key] = ret[0]
-            else:
-                self.attrib[key] = ret
-
 
     def get(self):
-        if self.option is None:
+        if self.option_name is None:
-            if self.object_type is SymLinkOption:
+            self.populate_attrib()
-                self.attrib['opt'] = self.attrib['opt'].get()
+            if self.object_type == 'SymLinkOption':
+                self.attrib['opt'] = self.storage.get(self.attrib['opt']).get()
             else:
-                self.build_properties()
+                self.parse_multi()
-                self.build_calculator('default')
+                self.parse_children()
-                self.build_calculator('validators')
+            attrib = self.get_attrib(self.attrib)
-            if not self.attrib['validators']:
+            self.option_name = self.storage.get_name(self.path)
-                del self.attrib['validators']
+            self.storage.text.append(f'{self.option_name} = {self.object_type}({attrib})')
-            try:
+            self.populate_informations()
-                option = self.object_type(**self.attrib)
+        return self.option_name
-            except Exception as err:
+
-                import traceback
+    def populate_attrib(self):
-                traceback.print_exc()
+        for key, value in self.elt.attrib.items():
-                name = self.attrib['name']
+            if key in self.storage.booleans:
-                raise CreoleLoaderError(_('cannot create option {}: {}').format(name, err))
+                value = convert_boolean(value)
-            for key, value in self.informations.items():
+            if key in FORCE_INFORMATIONS:
-                option.impl_set_information(key, value)
+                self.informations[key] = value
-            self.option = option
+            else:
-        return self.option
+                self.attrib[key] = value
+
+    def parse_children(self):
+        if not 'default' in self.attrib or self.attrib['multi']:
+            self.attrib['default'] = []
+        if self.attrib['multi'] == 'submulti' and self.is_follower:
+            self.attrib['default_multi'] = []
+        choices = []
+        for child in self.elt:
+            if child.tag == 'property':
+                self.populate_properties(child)
+            elif child.tag == 'value':
+                if child.attrib['type'] == 'calculation':
+                    self.attrib['default'] = self.calculation_value(child, [])
+                else:
+                    self.populate_value(child)
+            elif child.tag == 'check':
+                self.attrib['validators'].append(self.calculation_value(child, ['ParamSelfOption()']))
+            elif child.tag == 'choice':
+                choices.append(convert_tiramisu_value(child.text, child.attrib['type']))
+        if choices:
+            self.attrib['values'] = tuple(choices)
+        if self.attrib['default'] == []:
+            del self.attrib['default']
+        elif not self.attrib['multi'] and isinstance(self.attrib['default'], list):
+            self.attrib['default'] = self.attrib['default'][-1]
+        if self.attrib['validators'] == []:
+            del self.attrib['validators']
+        else:
+            self.attrib['validators'] = '[' + ', '.join(self.attrib['validators']) + ']'
+
+    def parse_multi(self):
+        if self.is_follower:
+            if self.attrib['multi'] is True:
+                self.attrib['multi'] = 'submulti'
+            else:
+                self.attrib['multi'] = True
+
+    def calculation_value(self, child, args):
+        kwargs = []
+        if 'name' in child.attrib:
+            # has parameters
+            function = child.attrib['name']
+            for param in child:
+                value = self.populate_param(param)
+                if 'name' not in param.attrib:
+                    args.append(str(value))
+                else:
+                    kwargs.append(f"'{param.attrib['name']}': " + value)
+        else:
+            # function without any parameter
+            function = child.text.strip()
+        ret = f"Calculation(func.{function}, Params((" + ', '.join(args) + "), kwargs=" + "{" + ', '.join(kwargs) + "})"
+        if 'warnings_only' in child.attrib:
+            ret += f', warnings_only={child.attrib["warnings_only"]}'
+        return ret + ')'
+
+    def populate_param(self,
+                       param,
+                       ):
+        if param.attrib['type'] == 'string':
+            return f'ParamValue("{param.text}")'
+        elif param.attrib['type'] == 'number':
+            return f'ParamValue({param.text})'
+        elif param.attrib['type'] == 'variable':
+            value = {'option': param.text,
+                     'notraisepropertyerror': convert_boolean(param.attrib['notraisepropertyerror']),
+                     'todict': param.text in FUNC_TO_DICT,
+                     }
+            if 'suffix' in param.attrib:
+                value['suffix'] = param.attrib['suffix']
+            return self.build_param(value)
+        raise LoaderError(_('unknown param type {}').format(param.attrib['type']))
+
+    def populate_value(self,
+                       child,
+                       ):
+        value = convert_tiramisu_value(child.text, child.attrib['type'])
+        if self.attrib['multi'] == 'submulti':
+            self.attrib['default_multi'].append(value)
+        elif self.is_follower:
+            self.attrib['default_multi'] = value
+        elif self.attrib['multi']:
+            self.attrib['default'].append(value)
+            if not self.is_leader:
+                self.attrib['default_multi'] = value
+        elif isinstance(value, int):
+            self.attrib['default'].append(value)
+        else:
+            self.attrib['default'].append("'" + value + "'")
+
+    def build_param(self,
+                    param,
+                    ):
+        option_name = self.storage.get(param['option']).get()
+        if 'suffix' in param:
+            family = '.'.join(param['option'].split('.')[:-1])
+            family_option = self.storage.get_name(family)
+            return f"ParamDynOption({option_name}, '{param['suffix']}', {family_option}, notraisepropertyerror={param['notraisepropertyerror']}, todict={param['todict']})"
+        return f"ParamOption({option_name}, notraisepropertyerror={param['notraisepropertyerror']}, todict={param['todict']})"
 
 
 class Family(Common):
-    def __init__(self, elt, booleans, storage, eosfunc, force_icon=False):
+    def __init__(self,
-        self.option = None
+                 elt,
-        self.attrib = {}
+                 storage,
-        self.is_leader = False
+                 is_leader,
-        if force_icon:
+                 path,
-            self.informations = {'icon': None}
+                 ):
-        else:
+        super().__init__(elt,
-            self.informations = {}
+                         storage,
+                         is_leader,
+                         path,
+                         )
         self.children = []
-        self.storage = storage
+        self.elt = elt
-        self.eosfunc = eosfunc
-        self.attrib['properties'] = []
-        for key, value in elt.attrib.items():
-            if key in booleans:
-                if value == 'True':
-                    value = True
-                elif value == 'False':
-                    value = False
-                else:
-                    raise CreoleLoaderError(_('unknown value {} for {}').format(value, key))
-            if key == 'icon':
-                self.add_information('icon', value)
-                continue
-            elif key == 'hidden':
-                if value:
-                    self.attrib['properties'].append(key)
-            elif key == 'mode':
-                self.attrib['properties'].append(value)
-            elif key == 'help':
-                self.add_information(key, value)
-            elif key == 'type':
-                pass
-            else:
-                self.attrib[key] = value
-        if 'doc' not in self.attrib:
-            self.attrib['doc'] = u''
 
     def add(self, child):
         self.children.append(child)
 
-    def add_information(self, key, value):
-        if key in self.informations and not (key == 'icon' and self.informations[key] is None):
-            raise CreoleLoaderError(_('key already exists in information {}').format(key))
-        self.informations[key] = value
-
-    def set_leader(self):
-        self.is_leader = True
-
     def get(self):
-        if self.option is None:
+        if not self.option_name:
-            self.attrib['children'] = []
+            self.populate_attrib()
-            for child in self.children:
+            self.parse_children()
-                self.attrib['children'].append(child.get())
+            self.option_name = self.storage.get_name(self.path)
-            self.build_properties()
+            object_name = self.get_object_name()
-            try:
+            attrib = self.get_attrib(self.attrib) + ', children=[' + ', '.join([child.get() for child in self.children]) + ']'
-                if 'dynamic' in self.attrib:
+            self.storage.text.append(f'{self.option_name} = {object_name}({attrib})')
-                    dynamic = self.storage.get(self.attrib['dynamic']).get()
+            self.populate_informations()
-                    del self.attrib['dynamic']
+        return self.option_name
-                    self.attrib['suffixes'] = Calculation(self.eosfunc.calc_value,
-                                                          Params((ParamOption(dynamic),)))
-                    option = ConvertDynOptionDescription(**self.attrib)
-                elif not self.is_leader:
-                    option = OptionDescription(**self.attrib)
-                else:
-                    option = Leadership(**self.attrib)
-            except Exception as err:
-                raise CreoleLoaderError(_('cannot create optiondescription {}: {}').format(self.attrib['name'], err))
-            for key, value in self.informations.items():
-                option.impl_set_information(key, value)
-            self.option = option
-            #if self.is_leader:
-            #    self.option.impl_set_group_type(groups.leader)
 
-        return self.option
+    def populate_attrib(self):
+        for key, value in self.elt.attrib.items():
+            if key == 'help':
+                self.informations[key] = value
+            elif key == 'dynamic':
+                dynamic = self.storage.get(value).get()
+                self.attrib['suffixes'] = f"Calculation(func.calc_value, Params((ParamOption({dynamic}))))"
+            else:
+                self.attrib[key] = value
+
+    def parse_children(self):
+        self.attrib['properties'] = ''
+        for child in self.elt:
+            if child.tag == 'property':
+                self.populate_properties(child)
+        if not self.attrib['properties']:
+            del self.attrib['properties']
+
+    def get_object_name(self):
+        if 'suffixes' in self.attrib:
+            return 'ConvertDynOptionDescription'
+        elif not self.is_leader:
+            return 'OptionDescription'
+        return 'Leadership'
 
 
 def load(xmlroot: str,
-         dtd_path: str,
          funcs_path: str):
-    tiramisu_objects = PopulateTiramisuObjects()
+    tiramisu_objects = PopulateTiramisuObjects(xmlroot,
-    tiramisu_objects.parse_dtd(dtd_path)
+                                               funcs_path,
-    tiramisu_objects.make_tiramisu_objects(xmlroot,
+                                               )
-                                           funcs_path)
+    return tiramisu_objects.get_text()
-    return tiramisu_objects.storage.paths['.'].get()

src/rougail/objspace.py

@@ -4,11 +4,11 @@ as an input and outputs a human readable flatened XML
 
 Sample usage::
 
-    >>> from creole.objspace import CreoleObjSpace
+    >>> from rougail.objspace import CreoleObjSpace
-    >>> eolobj = CreoleObjSpace('/usr/share/creole/creole.dtd')
+    >>> eolobj = CreoleObjSpace('/usr/share/rougail/rougail.dtd')
-    >>> eolobj.create_or_populate_from_xml('creole', ['/usr/share/eole/creole/dicos'])
+    >>> eolobj.create_or_populate_from_xml('rougail', ['/usr/share/eole/rougail/dicos'])
     >>> eolobj.space_visitor()
-    >>> eolobj.save('/tmp/creole_flatened_output.xml')
+    >>> eolobj.save('/tmp/rougail_flatened_output.xml')
 
 The CreoleObjSpace
 
@@ -25,21 +25,21 @@ has to be moved in family2. The visit procedure changes the varable1's object sp
 """
 from collections import OrderedDict
 from lxml.etree import Element, SubElement  # pylint: disable=E0611
-from json import dump
-
 
 from .i18n import _
 from .xmlreflector import XMLReflector, HIGH_COMPATIBILITY
-from .annotator import ERASED_ATTRIBUTES, ActionAnnotator, ServiceAnnotator, SpaceAnnotator
+from .annotator import ERASED_ATTRIBUTES,  ServiceAnnotator, SpaceAnnotator
 from .utils import normalize_family
-from .error import CreoleOperationError, SpaceObjShallNotBeUpdated, CreoleDictConsistencyError
+from .error import OperationError, SpaceObjShallNotBeUpdated, DictConsistencyError
+from .path import Path
+from .config import variable_namespace
 
-# CreoleObjSpace's elements like 'family' or 'slave', that shall be forced to the Redefinable type
+# CreoleObjSpace's elements like 'family' or 'follower', that shall be forced to the Redefinable type
-FORCE_REDEFINABLES = ('family', 'slave', 'service', 'disknod', 'variables', 'family_action')
+FORCE_REDEFINABLES = ('family', 'follower', 'service', 'disknod', 'variables')
 # CreoleObjSpace's elements that shall be forced to the UnRedefinable type
-FORCE_UNREDEFINABLES = ('value', 'input', 'profile', 'ewtapp', 'tag', 'saltaction')
+FORCE_UNREDEFINABLES = ('value',)
 # CreoleObjSpace's elements that shall be set to the UnRedefinable type
-UNREDEFINABLE = ('submulti', 'multi', 'type')
+UNREDEFINABLE = ('multi', 'type')
 
 PROPERTIES = ('hidden', 'frozen', 'auto_freeze', 'auto_save', 'force_default_on_freeze',
               'force_store_value', 'disabled', 'mandatory')
@@ -47,17 +47,24 @@ CONVERT_PROPERTIES = {'auto_save': ['force_store_value'], 'auto_freeze': ['force
 
 RENAME_ATTIBUTES = {'description': 'doc'}
 
-INCOMPATIBLE_ATTRIBUTES = [['multi', 'submulti']]
+FORCED_TEXT_ELTS_AS_NAME = ('choice', 'property', 'value', 'target')
 
-#TYPE_TARGET_CONDITION = ('variable', 'family')
+CONVERT_EXPORT = {'Leadership': 'leader',
+                  'Variable': 'variable',
+                  'Value': 'value',
+                  'Property': 'property',
+                  'Choice': 'choice',
+                  'Param': 'param',
+                  'Check': 'check',
+                  }
 
 # _____________________________________________________________________________
 # special types definitions for the Object Space's internal representation
-class RootCreoleObject(object):
+class RootCreoleObject:
     ""
 
 
-class CreoleObjSpace(object):
+class CreoleObjSpace:
     """DOM XML reflexion free internal representation of a Creole Dictionary
     """
     choice = type('Choice', (RootCreoleObject,), OrderedDict())
@@ -78,149 +85,174 @@ class CreoleObjSpace(object):
 
     def __init__(self, dtdfilename):  # pylint: disable=R0912
         self.index = 0
-        class ObjSpace(object):  # pylint: disable=R0903
+        class ObjSpace:  # pylint: disable=R0903
             """
             Base object space
             """
         self.space = ObjSpace()
+        self.paths = Path()
         self.xmlreflector = XMLReflector()
         self.xmlreflector.parse_dtd(dtdfilename)
         self.redefine_variables = None
-        self.probe_variables = []
+        self.check_removed = None
+        self.condition_removed = None
 
         # ['variable', 'separator', 'family']
         self.forced_text_elts = set()
-        self.forced_text_elts_as_name = set(['choice', 'property'])
+        self.forced_text_elts_as_name = set(FORCED_TEXT_ELTS_AS_NAME)
-        self.forced_choice_option = {}
-        self.paths = Path()
         self.list_conditions = {}
-
         self.booleans_attributs = []
 
-        for elt in self.xmlreflector.dtd.iterelements():
+        self.make_object_space_class()
-            attrs = {}
-            clstype = self.UnRedefinable
-            atomic = True
-            forced_text_elt = False
-            if elt.type == 'mixed':
-                forced_text_elt = True
-            if elt.name == 'service':
-                self.parse_dtd_right_left_elt(elt.content)
-            for attr in elt.iterattributes():
-                atomic = False
-                if attr.default_value:
-                    if attr.default_value == 'True':
-                        default_value = True
-                    elif attr.default_value == 'False':
-                        default_value = False
-                    else:
-                        default_value = attr.default_value
-                    attrs[attr.name] = default_value
-                if not attr.name.endswith('_type'):
-                    values = list(attr.itervalues())
-                    if values != []:
-                        self.forced_choice_option.setdefault(elt.name, {})[attr.name] = values
 
-                if attr.name == 'redefine':
+    def make_object_space_class(self):
+        """Create Rougail ObjectSpace class types, it enables us to create objects like:
+        File(), Variable(), Ip(), Family(), Constraints()... and so on.
+        
+        Creole ObjectSpace is an object's reflexion of the XML elements"""
+
+        for dtd_elt in self.xmlreflector.dtd.iterelements():
+            attrs = {}
+            if dtd_elt.name in FORCE_REDEFINABLES:
+                clstype = self.Redefinable
+            else:
+                clstype = self.UnRedefinable
+            atomic = dtd_elt.name not in FORCE_UNREDEFINABLES and dtd_elt.name not in FORCE_REDEFINABLES
+            forced_text_elt = dtd_elt.type == 'mixed'
+            for dtd_attr in dtd_elt.iterattributes():
+                atomic = False
+                if set(dtd_attr.itervalues()) == set(['True', 'False']):
+                    # it's a boolean
+                    self.booleans_attributs.append(dtd_attr.name)
+                if dtd_attr.default_value:
+                    # set default value for this attribute
+                    default_value = dtd_attr.default_value
+                    if dtd_attr.name in self.booleans_attributs:
+                        default_value = self.convert_boolean(dtd_attr.default_value)
+                    attrs[dtd_attr.name] = default_value
+                if dtd_attr.name == 'redefine':
+                    # has a redefine attribute, so it's a Redefinable object
                     clstype = self.Redefinable
-                if attr.name == 'name' and forced_text_elt is True:
+                if dtd_attr.name == 'name' and forced_text_elt:
-                    self.forced_text_elts.add(elt.name)
+                    # child.text should be transform has a "name" attribute
+                    self.forced_text_elts.add(dtd_elt.name)
                     forced_text_elt = False
 
-                if set(attr.itervalues()) == set(['True', 'False']):
-                    self.booleans_attributs.append(attr.name)
-
             if forced_text_elt is True:
-                self.forced_text_elts_as_name.add(elt.name)
+                self.forced_text_elts_as_name.add(dtd_elt.name)
-
+            if atomic:
-            if elt.name in FORCE_REDEFINABLES:
+                # has any attribute so it's an Atomic object
-                clstype = self.Redefinable
-            elif elt.name in FORCE_UNREDEFINABLES:
-                clstype = self.UnRedefinable
-            elif atomic:
                 clstype = self.Atom
 
-            # Creole ObjectSpace class types, it enables us to create objects like:
+            # create ObjectSpace object
-            # Service_restriction(), Ip(), Interface(), Host(), Fstab(), Package(), Disknod(),
+            setattr(self, dtd_elt.name, type(dtd_elt.name.capitalize(), (clstype,), attrs))
-            # File(), Variables(), Family(), Variable(), Separators(), Separator(), Value(),
-            # Constraints()... and so on. Creole ObjectSpace is an object's reflexion of
-            # the XML elements
-            setattr(self, elt.name, type(elt.name.capitalize(), (clstype,), attrs))
 
-    def parse_dtd_right_left_elt(self, elt):
+    def create_or_populate_from_xml(self,
-        if elt.right.type == 'or':
+                                    namespace,
-            self.parse_dtd_right_left_elt(elt.right)
+                                    xmlfolders):
-
+        """Parses a bunch of XML files
-    def _convert_boolean(self, value):  # pylint: disable=R0201
+        populates the CreoleObjSpace
-        """Boolean coercion. The Creole XML may contain srings like `True` or `False`
         """
-        if isinstance(value, bool):
+        for xmlfile, document in self.xmlreflector.load_xml_from_folders(xmlfolders):
-            return value
+            self.redefine_variables = []
-        if value == 'True':
+            self.check_removed = []
-            return True
+            self.condition_removed = []
-        elif value == 'False':
+            self.xml_parse_document(document,
-            return False
+                                    self.space,
-        else:
+                                    namespace,
-            raise TypeError(_('{} is not True or False').format(value))  # pragma: no cover
+                                    )
 
-    def _is_already_exists(self, name, space, child, namespace):
+    def xml_parse_document(self,
-        if isinstance(space, self.family):  # pylint: disable=E1101
+                           document,
-            if namespace != 'creole':
+                           space,
-                name = space.path + '.' + name
+                           namespace,
-            return self.paths.path_is_defined(name)
+                           ):
-        if child.tag in ['family', 'family_action']:
+        """Parses a Creole XML file
-            norm_name = normalize_family(name)
+        populates the CreoleObjSpace
-        else:
+        """
-            norm_name = name
+        family_names = []
-        return norm_name in getattr(space, child.tag, {})
+        for child in document:
+            # this index enables us to reorder objects
+            self.index += 1
+            # doesn't proceed the XML commentaries
+            if not isinstance(child.tag, str):
+                continue
+            if child.tag == 'family':
+                if child.attrib['name'] in family_names:
+                    raise DictConsistencyError(_('Family {} is set several times').format(child.attrib['name']))
+                family_names.append(child.attrib['name'])
+            if child.tag == 'variables':
+                child.attrib['name'] = namespace
+            if HIGH_COMPATIBILITY and child.tag == 'value' and child.text == None:
+                # FIXME should not be here
+                continue
+            # variable objects creation
+            try:
+                variableobj = self.generate_variableobj(child,
+                                                    space,
+                                                    namespace,
+                                                    )
+            except SpaceObjShallNotBeUpdated:
+                continue
+            self.set_text_to_obj(child,
+                                 variableobj,
+                                 )
+            self.set_xml_attributes_to_obj(child,
+                                           variableobj,
+                                           )
+            self.variableobj_tree_visitor(child,
+                                          variableobj,
+                                          namespace,
+                                          )
+            self.fill_variableobj_path_attribute(space,
+                                                 child,
+                                                 namespace,
+                                                 document,
+                                                 variableobj,
+                                                 )
+            self.add_to_tree_structure(variableobj,
+                                       space,
+                                       child,
+                                       )
+            if list(child) != []:
+                self.xml_parse_document(child,
+                                        variableobj,
+                                        namespace,
+                                        )
 
-    def _translate_in_space(self, name, family, variable, namespace):
+    def generate_variableobj(self,
-        if not isinstance(family, self.family):  # pylint: disable=E1101
+                           child,
-            if variable.tag in ['family', 'family_action']:
+                           space,
-                norm_name = normalize_family(name)
+                           namespace,
-            else:
+                           ):
-                norm_name = name
+        """
-            return getattr(family, variable.tag)[norm_name]
+        instanciates or creates Creole Object Subspace objects
-        if namespace == 'creole':
+        """
-            path = name
+        variableobj = getattr(self, child.tag)()
-        else:
+        if isinstance(variableobj, self.Redefinable):
-            path = family.path + '.' + name
+            variableobj = self.create_or_update_redefinable_object(child.attrib,
-        old_family_name = self.paths.get_variable_family_name(path)
+                                                                 space,
-        if normalize_family(family.name) == old_family_name:
+                                                                 child,
-            return getattr(family, variable.tag)[name]
+                                                                 namespace,
-        old_family = self.space.variables['creole'].family[old_family_name]  # pylint: disable=E1101
+                                                                 )
-        variable_obj = old_family.variable[name]
+        elif isinstance(variableobj, self.Atom) and child.tag in vars(space):
-        del old_family.variable[name]
+            # instanciates an object from the CreoleObjSpace's builtins types
-        if 'variable' not in vars(family):
+            # example : child.tag = constraints -> a self.Constraints() object is created
-            family.variable = OrderedDict()
+            # this Atom instance has to be a singleton here
-        family.variable[name] = variable_obj
+            # we do not re-create it, we reuse it
-        self.paths.append('variable', name, namespace, family.name, variable_obj)
+            variableobj = getattr(space, child.tag)
-        return variable_obj
+        self.create_tree_structure(space,
+                                   child,
+                                   variableobj,
+                                   )
+        return variableobj
 
-    def remove_check(self, name):  # pylint: disable=C0111
+    def create_or_update_redefinable_object(self,
-        if hasattr(self.space, 'constraints') and hasattr(self.space.constraints, 'check'):
+                                            subspace,
-            remove_checks = []
+                                            space,
-            for idx, check in enumerate(self.space.constraints.check):  # pylint: disable=E1101
+                                            child,
-                if hasattr(check, 'target') and check.target == name:
+                                            namespace,
-                    remove_checks.append(idx)
+                                            ):
-
-            remove_checks = list(set(remove_checks))
-            remove_checks.sort(reverse=True)
-            for idx in remove_checks:
-                self.space.constraints.check.pop(idx)  # pylint: disable=E1101
-    def remove_condition(self, name):  # pylint: disable=C0111
-        for idx, condition in enumerate(self.space.constraints.condition):  # pylint: disable=E1101
-            remove_targets = []
-            if hasattr(condition, 'target'):
-                for target_idx, target in enumerate(condition.target):
-                    if target.name == name:
-                        remove_targets.append(target_idx)
-            remove_targets = list(set(remove_targets))
-            remove_targets.sort(reverse=True)
-            for idx in remove_targets:
-                del condition.target[idx]
-
-    def create_or_update_space_object(self, subspace, space, child, namespace):
         """Creates or retrieves the space object that corresponds
         to the `child` XML object
 
@@ -249,46 +281,34 @@ class CreoleObjSpace(object):
             name = child.text
         else:
             name = subspace['name']
-        if self._is_already_exists(name, space, child, namespace):
+        if self.is_already_exists(name,
-            if child.tag in FORCE_REDEFINABLES:
+                                  space,
-                redefine = self._convert_boolean(subspace.get('redefine', True))
+                                  child,
-            else:
+                                  namespace,
-                redefine = self._convert_boolean(subspace.get('redefine', False))
+                                  ):
-            exists = self._convert_boolean(subspace.get('exists', True))
+            default_redefine = child.tag in FORCE_REDEFINABLES
+            redefine = self.convert_boolean(subspace.get('redefine', default_redefine))
+            exists = self.convert_boolean(subspace.get('exists', True))
             if redefine is True:
-                return self._translate_in_space(name, space, child, namespace)
+                return self.translate_in_space(name,
+                                               space,
+                                               child,
+                                               namespace,
+                                               )
             elif exists is False:
                 raise SpaceObjShallNotBeUpdated()
-            else:
+            raise DictConsistencyError(_(f'Already present in another XML file, {name} cannot be re-created'))
-                raise CreoleDictConsistencyError(_('Already present in another XML file, {} '
+        redefine = self.convert_boolean(subspace.get('redefine', False))
-                                                   'cannot be re-created').format(name))
+        exists = self.convert_boolean(subspace.get('exists', False))
-        else:
+        if redefine is False or exists is True:
-            redefine = self._convert_boolean(subspace.get('redefine', False))
+            return getattr(self, child.tag)()
-            exists = self._convert_boolean(subspace.get('exists', False))
+        raise DictConsistencyError(_(f'Redefined object: {name} does not exist yet'))
-            if redefine is False or exists is True:
-                return getattr(self, child.tag)()
-            else:
-                raise CreoleDictConsistencyError(_('Redefined object: '
-                                                   '{} does not exist yet').format(name))
 
-    def generate_creoleobj(self, child, space, namespace):
+    def create_tree_structure(self,
-        """
+                              space,
-        instanciates or creates Creole Object Subspace objects
+                              child,
-        """
+                              variableobj,
-        if issubclass(getattr(self, child.tag), self.Redefinable):
+                              ):  # pylint: disable=R0201
-            creoleobj = self.create_or_update_space_object(child.attrib, space, child, namespace)
-        else:
-            # instanciates an object from the CreoleObjSpace's builtins types
-            # example : child.tag = constraints -> a self.Constraints() object is created
-            creoleobj = getattr(self, child.tag)()
-            # this Atom instance has to be a singleton here
-            # we do not re-create it, we reuse it
-            if isinstance(creoleobj, self.Atom) and child.tag in vars(space):
-                creoleobj = getattr(space, child.tag)
-        self.create_tree_structure(space, child, creoleobj)
-        return creoleobj
-
-    def create_tree_structure(self, space, child, creoleobj):  # pylint: disable=R0201
         """
         Builds the tree structure of the object space here
         we set services attributes in order to be populated later on
@@ -301,166 +321,207 @@ class CreoleObjSpace(object):
             space.value = list()
         """
         if child.tag not in vars(space):
-            if isinstance(creoleobj, self.Redefinable):
+            if isinstance(variableobj, self.Redefinable):
                 setattr(space, child.tag, OrderedDict())
-            elif isinstance(creoleobj, self.UnRedefinable):
+            elif isinstance(variableobj, self.UnRedefinable):
                 setattr(space, child.tag, [])
-            elif isinstance(creoleobj, self.Atom):
+            elif not isinstance(variableobj, self.Atom):  # pragma: no cover
-                pass
+                raise OperationError(_("Creole object {} "
-            else: # pragma: no cover
+                                             "has a wrong type").format(type(variableobj)))
-                raise CreoleOperationError(_("Creole object {} "
-                                             "has a wrong type").format(type(creoleobj)))
 
-    def _add_to_tree_structure(self, creoleobj, space, child):  # pylint: disable=R0201
+    def is_already_exists(self, name, space, child, namespace):
-        if isinstance(creoleobj, self.Redefinable):
+        if isinstance(space, self.family):  # pylint: disable=E1101
-            name = creoleobj.name
+            if namespace != variable_namespace:
-            if child.tag == 'family' or child.tag == 'family_action':
+                name = space.path + '.' + name
-                name = normalize_family(name)
+            return self.paths.path_is_defined(name)
-            getattr(space, child.tag)[name] = creoleobj
+        if child.tag == 'family':
-        elif isinstance(creoleobj, self.UnRedefinable):
+            norm_name = normalize_family(name)
-            getattr(space, child.tag).append(creoleobj)
         else:
-            setattr(space, child.tag, creoleobj)
+            norm_name = name
+        return norm_name in getattr(space, child.tag, {})
 
-    def _set_text_to_obj(self, child, creoleobj):
+    def convert_boolean(self, value):  # pylint: disable=R0201
+        """Boolean coercion. The Creole XML may contain srings like `True` or `False`
+        """
+        if isinstance(value, bool):
+            return value
+        if value == 'True':
+            return True
+        elif value == 'False':
+            return False
+        else:
+            raise TypeError(_('{} is not True or False').format(value))  # pragma: no cover
+
+    def translate_in_space(self,
+                           name,
+                           family,
+                           variable,
+                           namespace,
+                           ):
+        if not isinstance(family, self.family):  # pylint: disable=E1101
+            if variable.tag == 'family':
+                norm_name = normalize_family(name)
+            else:
+                norm_name = name
+            return getattr(family, variable.tag)[norm_name]
+        if namespace == variable_namespace:
+            path = name
+        else:
+            path = family.path + '.' + name
+        old_family_name = self.paths.get_variable_family_name(path)
+        if normalize_family(family.name) == old_family_name:
+            return getattr(family, variable.tag)[name]
+        old_family = self.space.variables[variable_namespace].family[old_family_name]  # pylint: disable=E1101
+        variable_obj = old_family.variable[name]
+        del old_family.variable[name]
+        if 'variable' not in vars(family):
+            family.variable = OrderedDict()
+        family.variable[name] = variable_obj
+        self.paths.add_variable(namespace,
+                                name,
+                                family.name,
+                                False,
+                                variable_obj,
+                                )
+        return variable_obj
+
+    def remove_check(self, name):  # pylint: disable=C0111
+        if hasattr(self.space, 'constraints') and hasattr(self.space.constraints, 'check'):
+            remove_checks = []
+            for idx, check in enumerate(self.space.constraints.check):  # pylint: disable=E1101
+                if hasattr(check, 'target') and check.target == name:
+                    remove_checks.append(idx)
+
+            remove_checks = list(set(remove_checks))
+            remove_checks.sort(reverse=True)
+            for idx in remove_checks:
+                self.space.constraints.check.pop(idx)  # pylint: disable=E1101
+
+    def remove_condition(self, name):  # pylint: disable=C0111
+        for idx, condition in enumerate(self.space.constraints.condition):  # pylint: disable=E1101
+            remove_targets = []
+            if hasattr(condition, 'target'):
+                for target_idx, target in enumerate(condition.target):
+                    if target.name == name:
+                        remove_targets.append(target_idx)
+            remove_targets = list(set(remove_targets))
+            remove_targets.sort(reverse=True)
+            for idx in remove_targets:
+                del condition.target[idx]
+
+    def add_to_tree_structure(self,
+                              variableobj,
+                              space,
+                              child,
+                              ):  # pylint: disable=R0201
+        if isinstance(variableobj, self.Redefinable):
+            name = variableobj.name
+            if child.tag == 'family':
+                name = normalize_family(name)
+            getattr(space, child.tag)[name] = variableobj
+        elif isinstance(variableobj, self.UnRedefinable):
+            getattr(space, child.tag).append(variableobj)
+        else:
+            setattr(space, child.tag, variableobj)
+
+    def set_text_to_obj(self,
+                        child,
+                        variableobj,
+                        ):
         if child.text is None:
             text = None
         else:
             text = child.text.strip()
         if text:
             if child.tag in self.forced_text_elts_as_name:
-                creoleobj.name = text
+                variableobj.name = text
             else:
-                creoleobj.text = text
+                variableobj.text = text
 
-    def _set_xml_attributes_to_obj(self, child, creoleobj):
+    def set_xml_attributes_to_obj(self,
-        redefine = self._convert_boolean(child.attrib.get('redefine', False))
+                                  child,
-        has_value = hasattr(creoleobj, 'value')
+                                  variableobj,
+                                  ):
+        redefine = self.convert_boolean(child.attrib.get('redefine', False))
+        has_value = hasattr(variableobj, 'value')
         if HIGH_COMPATIBILITY and has_value:
             has_value = len(child) != 1 or child[0].text != None
-        if (redefine is True and child.tag == 'variable' and has_value
+        if redefine is True and child.tag == 'variable' and has_value and len(child) != 0:
-                and len(child) != 0):
+            del variableobj.value
-            del creoleobj.value
         for attr, val in child.attrib.items():
             if redefine and attr in UNREDEFINABLE:
                 # UNREDEFINABLE concerns only 'variable' node so we can fix name
                 # to child.attrib['name']
                 name = child.attrib['name']
-                raise CreoleDictConsistencyError(_("cannot redefine attribute {} for variable {}").format(attr, name))
+                raise DictConsistencyError(_(f'cannot redefine attribute {attr} for variable {name}'))
-            if isinstance(getattr(creoleobj, attr, None), bool):
+            if attr in self.booleans_attributs:
-                if val == 'False':
+                val = self.convert_boolean(val)
-                    val = False
+            if not (attr == 'name' and getattr(variableobj, 'name', None) != None):
-                elif val == 'True':
+                setattr(variableobj, attr, val)
-                    val = True
+        keys = list(vars(variableobj).keys())
-                else: # pragma: no cover
-                    raise CreoleOperationError(_('value for {} must be True or False, '
-                                                 'not {}').format(attr, val))
-            if not (attr == 'name' and getattr(creoleobj, 'name', None) != None):
-                setattr(creoleobj, attr, val)
-        keys = list(vars(creoleobj).keys())
-        for incompatible in INCOMPATIBLE_ATTRIBUTES:
-            found = False
-            for inc in incompatible:
-                if inc in keys:
-                    if found:
-                        raise CreoleDictConsistencyError(_('those attributes are incompatible {}').format(incompatible))
-                    found = True
 
-
+    def variableobj_tree_visitor(self,
-    def _creoleobj_tree_visitor(self, child, creoleobj, namespace):
+                                 child,
+                                 variableobj,
+                                 namespace,
+                                 ):
         """Creole object tree manipulations
         """
-        if child.tag == 'variable' and child.attrib.get('remove_check', False):
+        if child.tag == 'variable':
-            self.remove_check(creoleobj.name)
+            if child.attrib.get('remove_check', False):
-        if child.tag == 'variable' and child.attrib.get('remove_condition', False):
+                self.remove_check(variableobj.name)
-            self.remove_condition(creoleobj.name)
+            if child.attrib.get('remove_condition', False):
-        if child.tag in ['auto', 'fill', 'check']:
+                self.remove_condition(variableobj.name)
-            variable_name = child.attrib['target']
+        if child.tag == 'fill':
-            # XXX not working with variable not in creole and in leader/followers
+            # if variable is a redefine in current dictionary
-            if variable_name in self.redefine_variables:
+            # XXX not working with variable not in variable and in leader/followers
-                creoleobj.redefine = True
+            variableobj.redefine = child.attrib['target'] in self.redefine_variables
-            else:
+        if not hasattr(variableobj, 'index'):
-                creoleobj.redefine = False
+            variableobj.index = self.index
-        if not hasattr(creoleobj, 'index'):
+        if child.tag == 'check' and child.attrib['target'] in self.redefine_variables and child.attrib['target'] not in self.check_removed:
-            creoleobj.index = self.index
+            self.remove_check(child.attrib['target'])
-        if child.tag in ['auto', 'fill', 'condition', 'check', 'action']:
+            self.check_removed.append(child.attrib['target'])
-            creoleobj.namespace = namespace
+        if child.tag == 'condition' and child.attrib['source'] in self.redefine_variables and child.attrib['source'] not in self.check_removed:
+            self.remove_condition(child.attrib['source'])
+            self.condition_removed.append(child.attrib['source'])
+        variableobj.namespace = namespace
 
-    def xml_parse_document(self, document, space, namespace, is_in_family=False):
+    def fill_variableobj_path_attribute(self,
-        """Parses a Creole XML file
+                                        space,
-        populates the CreoleObjSpace
+                                        child,
-        """
+                                        namespace,
-        family_names = []
+                                        document,
-        for child in document:
+                                        variableobj,
-            # this index enables us to reorder the 'fill' and 'auto' objects
+                                        ):  # pylint: disable=R0913
-            self.index += 1
-            # doesn't proceed the XML commentaries
-            if not isinstance(child.tag, str):
-                continue
-            if child.tag == 'family':
-                is_in_family = True
-                if child.attrib['name'] in family_names:
-                    raise CreoleDictConsistencyError(_('Family {} is set several times').format(child.attrib['name']))
-                family_names.append(child.attrib['name'])
-            if child.tag == 'variables':
-                child.attrib['name'] = namespace
-            if HIGH_COMPATIBILITY and child.tag == 'value' and child.text == None:
-                continue
-            # creole objects creation
-            try:
-                creoleobj = self.generate_creoleobj(child, space, namespace)
-            except SpaceObjShallNotBeUpdated:
-                continue
-            self._set_text_to_obj(child, creoleobj)
-            self._set_xml_attributes_to_obj(child, creoleobj)
-            self._creoleobj_tree_visitor(child, creoleobj, namespace)
-            self._fill_creoleobj_path_attribute(space, child, namespace, document, creoleobj)
-            self._add_to_tree_structure(creoleobj, space, child)
-            if list(child) != []:
-                self.xml_parse_document(child, creoleobj, namespace, is_in_family)
-
-    def _fill_creoleobj_path_attribute(self, space, child, namespace, document, creoleobj):  # pylint: disable=R0913
         """Fill self.paths attributes
         """
-        if not isinstance(space, self.help):  # pylint: disable=E1101
+        if isinstance(space, self.help):  # pylint: disable=E1101
-            if child.tag == 'variable':
+            return
-                family_name = normalize_family(document.attrib['name'])
+        if child.tag == 'variable':
-                self.paths.append('variable', child.attrib['name'], namespace, family_name,
+            family_name = normalize_family(document.attrib['name'])
-                                  creoleobj)
+            self.paths.add_variable(namespace,
-                if child.attrib.get('redefine', 'False') == 'True':
+                                    child.attrib['name'],
-                    if namespace == 'creole':
+                                    family_name,
-                        self.redefine_variables.append(child.attrib['name'])
+                                    document.attrib.get('dynamic') != None,
-                    else:
+                                    variableobj)
-                        self.redefine_variables.append(namespace + '.' + family_name + '.' +
+            if child.attrib.get('redefine', 'False') == 'True':
-                                                       child.attrib['name'])
+                if namespace == variable_namespace:
+                    self.redefine_variables.append(child.attrib['name'])
+                else:
+                    self.redefine_variables.append(namespace + '.' + family_name + '.' +
+                                                   child.attrib['name'])
 
-            if child.tag == 'family':
+        elif child.tag == 'family':
-                family_name = normalize_family(child.attrib['name'])
+            family_name = normalize_family(child.attrib['name'])
-                if namespace != 'creole':
+            if namespace != variable_namespace:
-                    family_name = namespace + '.' + family_name
+                family_name = namespace + '.' + family_name
-                self.paths.append('family', family_name, namespace, creoleobj=creoleobj)
+            self.paths.add_family(namespace,
-                creoleobj.path = self.paths.get_family_path(family_name, namespace)
+                                  family_name,
-
+                                  variableobj,
-    def create_or_populate_from_xml(self, namespace, xmlfolders, from_zephir=None):
+                                  )
-        """Parses a bunch of XML files
+            variableobj.path = self.paths.get_family_path(family_name, namespace)
-        populates the CreoleObjSpace
-        """
-        documents = self.xmlreflector.load_xml_from_folders(xmlfolders, from_zephir)
-        for xmlfile, document in documents:
-            try:
-                self.redefine_variables = []
-                self.xml_parse_document(document, self.space, namespace)
-            except Exception as err:
-                #print(_('error in XML file {}').format(xmlfile))
-                raise err
-
-    def populate_from_zephir(self, namespace, xmlfile):
-        self.redefine_variables = []
-        document = self.xmlreflector.parse_xmlfile(xmlfile, from_zephir=True, zephir2=True)
-        self.xml_parse_document(document, self.space, namespace)
 
     def space_visitor(self, eosfunc_file):  # pylint: disable=C0111
-        ActionAnnotator(self)
         ServiceAnnotator(self)
         SpaceAnnotator(self, eosfunc_file)
 
@@ -469,42 +530,13 @@ class CreoleObjSpace(object):
 
         :param filename: the full XML filename
         """
-        xml = Element('creole')
+        xml = Element('rougail')
         self._xml_export(xml, self.space)
         if not force_no_save:
             self.xmlreflector.save_xmlfile(filename, xml)
         return xml
 
-    def save_probes(self, filename, force_no_save=False):
+    def get_attributes(self, space):  # pylint: disable=R0201
-        """Save an XML output on disk
-
-        :param filename: the full XML filename
-        """
-        ret = {}
-        for variable in self.probe_variables:
-            args = []
-            kwargs = {}
-            if hasattr(variable, 'param'):
-                for param in variable.param:
-                    list_param = list(vars(param).keys())
-                    if 'index' in list_param:
-                        list_param.remove('index')
-                    if list_param == ['text']:
-                        args.append(param.text)
-                    elif list_param == ['text', 'name']:
-                        kwargs[param.name] = param.text
-                    else:
-                        print(vars(param))
-                        raise Exception('hu?')
-            ret[variable.target] = {'function': variable.name,
-                                    'args': args,
-                                    'kwargs': kwargs}
-        if not force_no_save:
-            with open(filename, 'w') as fhj:
-                dump(ret, fhj)
-        return ret
-
-    def _get_attributes(self, space):  # pylint: disable=R0201
         for attr in dir(space):
             if not attr.startswith('_'):
                 yield attr
@@ -514,183 +546,58 @@ class CreoleObjSpace(object):
             space = list(space.values())
         if isinstance(space, list):
             for subspace in space:
-                if isinstance(subspace, self.Leadership):
+                if name == 'value' and (not hasattr(subspace, 'name') or subspace.name is None):
-                    _name = 'leader'
+                    raise Exception('pfff')
-                else:
-                    _name = name
-                if name in ['services', 'variables', 'actions']:
-                    _name = 'family'
-                    if HIGH_COMPATIBILITY and not hasattr(subspace, 'doc'):
-                        subspace.doc = ''
-                if _name == 'value' and (not hasattr(subspace, 'name') or subspace.name is None):
                     continue
+                _name = CONVERT_EXPORT.get(subspace.__class__.__name__, 'family')
                 child_node = SubElement(node, _name)
                 self._xml_export(child_node, subspace, _name)
-        elif isinstance(space, self.Atom):
+        elif isinstance(space, (self.Atom, (self.Redefinable, self.UnRedefinable))):
-            if name == 'services':
+            _name = CONVERT_EXPORT.get(space.__class__.__name__, 'family')
-                child_node = SubElement(node, 'family')
+            child_node = SubElement(node, _name)
+            if _name != name:
                 child_node.attrib['name'] = name
+                if 'doc' not in child_node.attrib.keys():
+                    child_node.attrib['doc'] = name
+            for subname in self.get_attributes(space):
+                subspace = getattr(space, subname)
+                self._sub_xml_export(subname, child_node, name, subspace, space)
+        elif name not in ERASED_ATTRIBUTES:
+            # # FIXME plutot dans annotator ...
+            if node.tag in ['variable', 'family', 'leader']:
+                if name in PROPERTIES:
+                    if space is True:
+                        for prop in CONVERT_PROPERTIES.get(name, [name]):
+                            SubElement(node, 'property').text = prop
+                    return
+                if name == 'mode' and space:
+                    SubElement(node, 'property').text = space
+                    return
+            # Not param for calculation ...
+            if name == 'name' and node_name in FORCED_TEXT_ELTS_AS_NAME and not hasattr(current_space, 'param'):
+                node.text = str(space)
+            elif name == 'text' and node_name in self.forced_text_elts:
+                node.text = space
+            elif node.tag == 'family' and name == 'name':
+                if 'doc' not in node.attrib.keys():
+                    node.attrib['doc'] = space
+                node.attrib['name'] = normalize_family(space, check_name=False)
             else:
-                child_node = SubElement(node, name)
+                if name in RENAME_ATTIBUTES:
-            for subname in self._get_attributes(space):
+                    name = RENAME_ATTIBUTES[name]
-                subspace = getattr(space, subname)
+                if space is not None:
-                self._sub_xml_export(subname, child_node, name, subspace, space)
+                    node.attrib[name] = str(space)
-        elif isinstance(space, self.Redefinable):
-            child_node = SubElement(node, 'family')
-            child_node.attrib['name'] = name
-            for subname in self._get_attributes(space):
-                subspace = getattr(space, subname)
-                self._sub_xml_export(subname, child_node, name, subspace, space)
-        else:
-            # FIXME plutot dans annotator ...
-            if name in PROPERTIES and node.tag in ['variable', 'family', 'leader']:
-                if space is True:
-                    for prop in CONVERT_PROPERTIES.get(name, [name]):
-                        SubElement(node, 'property').text = prop
 
-            elif name not in ERASED_ATTRIBUTES:
+    def _xml_export(self,
-                if name == 'name' and node_name in self.forced_text_elts_as_name and not hasattr(current_space, 'param'):
+                    node,
-                    if isinstance(space, str):
+                    space,
-                        node.text = space
+                    node_name=variable_namespace,
-                    else:
+                    ):
-                        node.text = str(space)
+        for name in self.get_attributes(space):
-                elif name == 'text' and node_name in self.forced_text_elts:
-                    node.text = space
-                elif node.tag == 'family' and name == 'name':
-                    if 'doc' not in node.attrib.keys():
-                        node.attrib['doc'] = space
-                    node.attrib['name'] = normalize_family(space, check_name=False)
-                elif node.tag in ['variable', 'family', 'leader'] and name == 'mode':
-                    if space is not None:
-                        SubElement(node, 'property').text = space
-                else:
-                    if name in RENAME_ATTIBUTES:
-                        name = RENAME_ATTIBUTES[name]
-                    if space is not None:
-                        node.attrib[name] = str(space)
-
-    def _xml_export(self, node, space, node_name='creole'):
-        for name in self._get_attributes(space):
             subspace = getattr(space, name)
-            self._sub_xml_export(name, node, node_name, subspace, space)
+            self._sub_xml_export(name,
-
+                                 node,
-
+                                 node_name,
-class Path(object):
+                                 subspace,
-    """Helper class to handle the `path` attribute of a CreoleObjSpace
+                                 space,
-    instance.
+                                 )
-
-    sample: path="creole.general.condition"
-    """
-    def __init__(self):
-        self.variables = {}
-        self.families = {}
-
-    def append(self, pathtype, name, namespace, family=None, creoleobj=None):  # pylint: disable=C0111
-        if pathtype == 'family':
-            self.families[name] = dict(name=name, namespace=namespace, creoleobj=creoleobj)
-        elif pathtype == 'variable':
-            if namespace == 'creole':
-                varname = name
-            else:
-                if '.' in name:
-                    varname = name
-                else:
-                    varname = '.'.join([namespace, family, name])
-            self.variables[varname] = dict(name=name, family=family, namespace=namespace,
-                                           leader=None, creoleobj=creoleobj)
-        else:  # pragma: no cover
-            raise Exception('unknown pathtype {}'.format(pathtype))
-
-    def get_family_path(self, name, current_namespace):  # pylint: disable=C0111
-        if current_namespace is None:  # pragma: no cover
-            raise CreoleOperationError('current_namespace must not be None')
-        dico = self.families[normalize_family(name,
-                                              check_name=False,
-                                              allow_dot=True)]
-        if dico['namespace'] != 'creole' and current_namespace != dico['namespace']:
-            raise CreoleDictConsistencyError(_('A family located in the {} namespace '
-                                               'shall not be used in the {} namespace').format(
-                                                   dico['namespace'], current_namespace))
-        path = dico['name']
-        if dico['namespace'] is not None and '.' not in dico['name']:
-            path = '.'.join([dico['namespace'], path])
-        return path
-
-    def get_family_namespace(self, name):  # pylint: disable=C0111
-        dico = self.families[name]
-        if dico['namespace'] is None:
-            return dico['name']
-        return dico['namespace']
-
-    def get_family_obj(self, name):  # pylint: disable=C0111
-        if name not in self.families:
-            raise CreoleDictConsistencyError(_('unknown family {}').format(name))
-        dico = self.families[name]
-        return dico['creoleobj']
-
-    def get_variable_name(self, name):  # pylint: disable=C0111
-        dico = self._get_variable(name)
-        return dico['name']
-
-    def get_variable_obj(self, name):  # pylint: disable=C0111
-        dico = self._get_variable(name)
-        return dico['creoleobj']
-
-    def get_variable_family_name(self, name):  # pylint: disable=C0111
-        dico = self._get_variable(name)
-        return dico['family']
-
-    def get_variable_family_path(self, name):  # pylint: disable=C0111
-        dico = self._get_variable(name)
-        list_path = [dico['namespace'], dico['family']]
-        if dico['leader'] is not None:
-            list_path.append(dico['leader'])
-        return '.'.join(list_path)
-
-    def get_variable_namespace(self, name):  # pylint: disable=C0111
-        return self._get_variable(name)['namespace']
-
-    def get_variable_path(self, name, current_namespace, allow_source=False):  # pylint: disable=C0111
-        if current_namespace is None:  # pragma: no cover
-            raise CreoleOperationError('current_namespace must not be None')
-        dico = self._get_variable(name)
-        if not allow_source:
-            if dico['namespace'] not in ['creole', 'services'] and current_namespace != dico['namespace']:
-                raise CreoleDictConsistencyError(_('A variable located in the {} namespace '
-                                                   'shall not be used in the {} namespace').format(
-                                                       dico['namespace'], current_namespace))
-        if '.' in dico['name']:
-            return dico['name']
-        list_path = [dico['namespace'], dico['family']]
-        if dico['leader'] is not None:
-            list_path.append(dico['leader'])
-        list_path.append(dico['name'])
-        return '.'.join(list_path)
-
-    def path_is_defined(self, name):  # pylint: disable=C0111
-        return name in self.variables
-
-    def set_leader(self, name, leader):  # pylint: disable=C0111
-        dico = self._get_variable(name)
-        namespace = dico['namespace']
-        if dico['leader'] != None:
-            raise CreoleDictConsistencyError(_('Already defined leader {} for variable'
-                                               ' {}'.format(dico['leader'], name)))
-        dico['leader'] = leader
-        if namespace != 'creole':
-            new_path = self.get_variable_path(name, namespace)
-            self.append('variable', new_path, namespace, family=dico['family'], creoleobj=dico['creoleobj'])
-            self.variables[new_path]['leader'] = leader
-            del self.variables[name]
-
-    def _get_variable(self, name):
-        if name not in self.variables:
-            if name.startswith('creole.'):
-                name = name.split('.')[-1]
-            if name not in self.variables:
-                raise CreoleDictConsistencyError(_('unknown option {}').format(name))
-        return self.variables[name]
-
-    def get_leader(self, name):  # pylint: disable=C0111
-        dico = self._get_variable(name)
-        return dico['leader']

src/rougail/path.py

@@ -0,0 +1,174 @@
+from .i18n import _
+from .utils import normalize_family
+from .error import OperationError, DictConsistencyError
+from .config import variable_namespace
+
+
+class Path:
+    """Helper class to handle the `path` attribute of a CreoleObjSpace
+    instance.
+
+    sample: path="creole.general.condition"
+    """
+    def __init__(self):
+        self.variables = {}
+        self.families = {}
+
+    # Family
+    def add_family(self,
+                   namespace: str,
+                   name: str,
+                   variableobj: str,
+                   ) -> str:  # pylint: disable=C0111
+        self.families[name] = dict(name=name,
+                                   namespace=namespace,
+                                   variableobj=variableobj,
+                                   )
+
+    def get_family_path(self,
+                        name: str,
+                        current_namespace: str,
+                        ) -> str:  # pylint: disable=C0111
+        if current_namespace is None:  # pragma: no cover
+            raise OperationError('current_namespace must not be None')
+        dico = self.families[normalize_family(name,
+                                              check_name=False,
+                                              allow_dot=True,
+                                              )]
+        if dico['namespace'] != variable_namespace and current_namespace != dico['namespace']:
+            raise DictConsistencyError(_('A family located in the {} namespace '
+                                               'shall not be used in the {} namespace').format(
+                                                   dico['namespace'], current_namespace))
+        path = dico['name']
+        if dico['namespace'] is not None and '.' not in dico['name']:
+            path = '.'.join([dico['namespace'], path])
+        return path
+
+    def get_family_obj(self,
+                       name: str,
+                       ) -> 'Family':  # pylint: disable=C0111
+        if name not in self.families:
+            raise DictConsistencyError(_('unknown family {}').format(name))
+        dico = self.families[name]
+        return dico['variableobj']
+
+    # Leadership
+    def set_leader(self,
+                   namespace: str,
+                   leader_family_name: str,
+                   name: str,
+                   leader_name: str,
+                   ) -> None:  # pylint: disable=C0111
+        if namespace != variable_namespace:
+            # need rebuild path and move object in new path
+            old_path = namespace + '.' + leader_family_name + '.' + name
+            dico = self._get_variable(old_path)
+            del self.variables[old_path]
+            new_path = namespace + '.' + leader_family_name + '.' + leader_name + '.' + name
+            self.add_variable(namespace,
+                              new_path,
+                              dico['family'],
+                              False,
+                              dico['variableobj'],
+                              )
+            name = new_path
+        dico = self._get_variable(name)
+        if dico['leader'] != None:
+            raise DictConsistencyError(_('Already defined leader {} for variable'
+                                               ' {}'.format(dico['leader'], name)))
+        dico['leader'] = leader_name
+
+    def get_leader(self, name):  # pylint: disable=C0111
+        return self._get_variable(name)['leader']
+
+    # Variable
+    def add_variable(self,
+                     namespace: str,
+                     name: str,
+                     family: str,
+                     is_dynamic: bool,
+                     variableobj,
+                     ) -> str:  # pylint: disable=C0111
+        if namespace == variable_namespace or '.' in name:
+            varname = name
+        else:
+            varname = '.'.join([namespace, family, name])
+        self.variables[varname] = dict(name=name,
+                                       family=family,
+                                       namespace=namespace,
+                                       leader=None,
+                                       is_dynamic=is_dynamic,
+                                       variableobj=variableobj)
+
+    def get_variable_name(self,
+                          name,
+                          ):  # pylint: disable=C0111
+        return self._get_variable(name)['name']
+
+    def get_variable_obj(self,
+                         name:str,
+                         ) -> 'Variable':  # pylint: disable=C0111
+        return self._get_variable(name)['variableobj']
+
+    def get_variable_family_name(self,
+                                 name: str,
+                                 ) -> str:  # pylint: disable=C0111
+        return self._get_variable(name)['family']
+
+    def get_variable_namespace(self,
+                               name: str,
+                               ) -> str:  # pylint: disable=C0111
+        return self._get_variable(name)['namespace']
+
+    def get_variable_path(self,
+                          name: str,
+                          current_namespace: str,
+                          allow_source: str=False,
+                          with_suffix: bool=False,
+                          ) -> str:  # pylint: disable=C0111
+        if current_namespace is None:  # pragma: no cover
+            raise OperationError('current_namespace must not be None')
+        if with_suffix:
+            dico, suffix = self._get_variable(name,
+                                              with_suffix=True,
+                                              )
+        else:
+            dico = self._get_variable(name)
+        if not allow_source:
+            if dico['namespace'] not in [variable_namespace, 'services'] and current_namespace != dico['namespace']:
+                raise DictConsistencyError(_('A variable located in the {} namespace '
+                                                   'shall not be used in the {} namespace').format(
+                                                       dico['namespace'], current_namespace))
+        if '.' in dico['name']:
+            value = dico['name']
+        else:
+            list_path = [dico['namespace'], dico['family']]
+            if dico['leader'] is not None:
+                list_path.append(dico['leader'])
+            list_path.append(dico['name'])
+            value = '.'.join(list_path)
+        if with_suffix:
+            return value, suffix
+        return value
+
+    def path_is_defined(self,
+                        name: str,
+                        ) -> str:  # pylint: disable=C0111
+        return name in self.variables
+
+    def _get_variable(self,
+                      name: str,
+                      with_suffix: bool=False,
+                      ) -> str:
+        if name not in self.variables:
+            if name.startswith(f'{variable_namespace}.'):
+                name = name.split('.')[-1]
+            if name not in self.variables:
+                for var_name, variable in self.variables.items():
+                    if variable['is_dynamic'] and name.startswith(var_name):
+                        return variable, name[len(var_name):]
+                raise DictConsistencyError(_('unknown option {}').format(name))
+        if with_suffix:
+            return self.variables[name], None
+        return self.variables[name]
+

src/rougail/template.py

@@ -5,32 +5,12 @@ On travaille sur les fichiers cibles
 """
 
 import imp
-import sys
 from shutil import copy
 import logging
 from typing import Dict, Any
-
 from subprocess import call
-from os import listdir, unlink, makedirs
+from os import listdir, makedirs
-from os.path import dirname, basename, join, split, isfile, isdir
+from os.path import dirname, join, isfile
-
-from tempfile import mktemp
-
-from Cheetah import Parser
-
-
-# l'encoding du template est déterminé par une regexp (encodingDirectiveRE dans Parser.py)
-# il cherche un ligne qui ressemble à '#encoding: utf-8
-# cette classe simule le module 're' et retourne toujours l'encoding utf-8
-# 6224
-class FakeEncoding:
-    def groups(self):
-        return ('utf-8',)
-
-    def search(self, *args):
-        return self
-Parser.encodingDirectiveRE = FakeEncoding()
-
 
 from Cheetah.Template import Template as ChtTemplate
 from Cheetah.NameMapper import NotFound as CheetahNotFound
@@ -38,8 +18,8 @@ from Cheetah.NameMapper import NotFound as CheetahNotFound
 from tiramisu import Config
 from tiramisu.error import PropertiesOptionError
 
-from .config import patch_dir
+from .config import patch_dir, variable_namespace
-from .error import FileNotFound, TemplateError, TemplateDisabled
+from .error import FileNotFound, TemplateError
 from .i18n import _
 from .utils import normalize_family
 
@@ -47,6 +27,7 @@ from .utils import normalize_family
 log = logging.getLogger(__name__)
 log.addHandler(logging.NullHandler())
 
+
 class IsDefined:
     """
     filtre permettant de ne pas lever d'exception au cas où
@@ -59,34 +40,16 @@ class IsDefined:
         if '.' in varname:
             splitted_var = varname.split('.')
             if len(splitted_var) != 2:
-                msg = _("Group variables must be of type master.slave")
+                msg = _("Group variables must be of type leader.follower")
                 raise KeyError(msg)
-            master, slave = splitted_var
+            leader, follower = splitted_var
-            if master in self.context:
+            if leader in self.context:
-                return slave in self.context[master].slave.keys()
+                return follower in self.context[leader].follower.keys()
             return False
         else:
             return varname in self.context
 
 
-class CreoleGet:
-    def __init__(self, context):
-        self.context = context
-
-    def __call__(self, varname):
-        return self.context[varname]
-
-    def __getitem__(self, varname):
-        """For bracket and dotted notation
-        """
-        return self.context[varname]
-
-    def __contains__(self, varname):
-        """Check variable existence in context
-        """
-        return varname in self.context
-
-
 @classmethod
 def cl_compile(kls, *args, **kwargs):
     kwargs['compilerSettings'] = {'directiveStartToken' : '%',
@@ -103,12 +66,6 @@ ChtTemplate.old_compile = ChtTemplate.compile
 ChtTemplate.compile = cl_compile
 
 
-class CreoleClient:
-    def __init__(self,
-                 config: Config):
-        self.config = config
-
-
 class CheetahTemplate(ChtTemplate):
     """classe pour personnaliser et faciliter la construction
     du template Cheetah
@@ -133,7 +90,7 @@ class CheetahTemplate(ChtTemplate):
 
 
 class CreoleLeader:
-    def __init__(self, value, slave=None, index=None):
+    def __init__(self, value, follower=None, index=None):
         """
         On rend la variable itérable pour pouvoir faire:
         for ip in iplist:
@@ -143,20 +100,20 @@ class CreoleLeader:
         index is used for CreoleLint
         """
         self._value = value
-        if slave is not None:
+        if follower is not None:
-            self.slave = slave
+            self.follower = follower
         else:
-            self.slave = {}
+            self.follower = {}
         self._index = index
 
     def __getattr__(self, name):
-        """Get slave variable or attribute of master value.
+        """Get follower variable or attribute of leader value.
 
-        If the attribute is a name of a slave variable, return its value.
+        If the attribute is a name of a follower variable, return its value.
-        Otherwise, returns the requested attribute of master value.
+        Otherwise, returns the requested attribute of leader value.
         """
-        if name in self.slave:
+        if name in self.follower:
-            value = self.slave[name]
+            value = self.follower[name]
             if isinstance(value, PropertiesOptionError):
                 raise AttributeError()
             return value
@@ -164,36 +121,36 @@ class CreoleLeader:
             return getattr(self._value, name)
 
     def __getitem__(self, index):
-        """Get a master.slave at requested index.
+        """Get a leader.follower at requested index.
         """
         ret = {}
-        for key, values in self.slave.items():
+        for key, values in self.follower.items():
             ret[key] = values[index]
         return CreoleLeader(self._value[index], ret, index)
 
     def __iter__(self):
-        """Iterate over master.slave.
+        """Iterate over leader.follower.
 
-        Return synchronised value of master.slave.
+        Return synchronised value of leader.follower.
         """
         for i in range(len(self._value)):
             ret = {}
-            for key, values in self.slave.items():
+            for key, values in self.follower.items():
                 ret[key] = values[i]
             yield CreoleLeader(self._value[i], ret, i)
 
     def __len__(self):
-        """Delegate to master value
+        """Delegate to leader value
         """
         return len(self._value)
 
     def __repr__(self):
         """Show CreoleLeader as dictionary.
 
-        The master value is stored under 'value' key.
+        The leader value is stored under 'value' key.
-        The slaves are stored under 'slave' key.
+        The followers are stored under 'follower' key.
         """
-        return repr({'value': self._value, 'slave': self.slave})
+        return repr({'value': self._value, 'follower': self.follower})
 
     def __eq__(self, value):
         return value == self._value
@@ -214,7 +171,7 @@ class CreoleLeader:
         return self._value >= value
 
     def __str__(self):
-        """Delegate to master value
+        """Delegate to leader value
         """
         return str(self._value)
 
@@ -227,7 +184,7 @@ class CreoleLeader:
     def __contains__(self, item):
         return item in self._value
 
-    async def add_slave(self, config, name, path):
+    async def add_follower(self, config, name, path):
         if isinstance(self._value, list):
             values = []
             for idx in range(len(self._value)):
@@ -237,7 +194,7 @@ class CreoleLeader:
                     values.append(err)
         else:
             raise Exception('hu?')
-        self.slave[name] = values
+        self.follower[name] = values
 
 
 class CreoleExtra:
@@ -252,6 +209,9 @@ class CreoleExtra:
     def __repr__(self):
         return self.suboption.__str__()
 
+    def __iter__(self):
+        return iter(self.suboption.values())
+
 
 class CreoleTemplateEngine:
     """Engine to process Creole cheetah template
@@ -261,7 +221,8 @@ class CreoleTemplateEngine:
                  eosfunc_file: str,
                  distrib_dir: str,
                  tmp_dir: str,
-                 dest_dir:str) -> None:
+                 dest_dir: str,
+                 ) -> None:
         self.config = config
         self.dest_dir = dest_dir
         self.tmp_dir = tmp_dir
@@ -273,25 +234,25 @@ class CreoleTemplateEngine:
                  if not func.startswith('_'):
                      eos[func] = getattr(eosfunc, func)
         self.eosfunc = eos
-        self.creole_variables_dict = {}
+        self.rougail_variables_dict = {}
 
-    async def load_eole_variables_creole(self,
+    async def load_eole_variables_rougail(self,
-                                         optiondescription):
+                                          optiondescription):
         for option in await optiondescription.list('all'):
             if await option.option.isoptiondescription():
                 if await option.option.isleadership():
                     for idx, suboption in enumerate(await option.list('all')):
                         if idx == 0:
                             leader = CreoleLeader(await suboption.value.get())
-                            self.creole_variables_dict[await suboption.option.name()] = leader
+                            self.rougail_variables_dict[await suboption.option.name()] = leader
                         else:
-                            await leader.add_slave(self.config,
+                            await leader.add_follower(self.config,
                                                    await suboption.option.name(),
                                                    await suboption.option.path())
                 else:
-                    await self.load_eole_variables_creole(option)
+                    await self.load_eole_variables_rougail(option)
             else:
-                self.creole_variables_dict[await option.option.name()] = await option.value.get()
+                self.rougail_variables_dict[await option.option.name()] = await option.value.get()
 
     async def load_eole_variables(self,
                                   namespace,
@@ -300,20 +261,26 @@ class CreoleTemplateEngine:
         for family in await optiondescription.list('all'):
             variables = {}
             for variable in await family.list('all'):
-                if await variable.option.isoptiondescription() and await variable.option.isleadership():
+                if await variable.option.isoptiondescription():
-                    for idx, suboption in enumerate(await variable.list('all')):
+                    if await variable.option.isleadership():
-                        if idx == 0:
+                        for idx, suboption in enumerate(await variable.list('all')):
-                            leader = CreoleLeader(await suboption.value.get())
+                            if idx == 0:
-                            leader_name = await suboption.option.name()
+                                leader = CreoleLeader(await suboption.value.get())
-                        else:
+                                leader_name = await suboption.option.name()
-                            await leader.add_slave(self.config,
+                            else:
-                                                   await suboption.option.name(),
+                                await leader.add_follower(self.config,
-                                                   await suboption.option.path())
+                                                       await suboption.option.name(),
-                    variables[leader_name] = leader
+                                                       await suboption.option.path())
+                        variables[leader_name] = leader
+                    else:
+                        subfamilies = await self.load_eole_variables(await variable.option.name(),
+                                                                     variable,
+                                                                     )
+                        variables[await variable.option.name()] = subfamilies
                 else:
                     variables[await variable.option.name()] = await variable.value.get()
             families[await family.option.name()] = CreoleExtra(variables)
-        self.creole_variables_dict[namespace] = CreoleExtra(families)
+        return CreoleExtra(families)
 
     def patch_template(self,
                        filename: str):
@@ -342,6 +309,8 @@ class CreoleTemplateEngine:
         self.patch_template(filename)
 
     def process(self,
+                source: str,
+                true_destfilename: str,
                 destfilename: str,
                 filevar: Dict,
                 variable: Any):
@@ -350,12 +319,12 @@ class CreoleTemplateEngine:
         # full path of the destination file
         log.info(_(f"Cheetah processing: '{destfilename}'"))
         try:
-            cheetah_template = CheetahTemplate(join(self.tmp_dir,
+            cheetah_template = CheetahTemplate(source,
-                                               filevar['source']),
+                                               self.rougail_variables_dict,
-                                               self.creole_variables_dict,
                                                self.eosfunc,
-                                               destfilename,
+                                               true_destfilename,
-                                               variable)
+                                               variable,
+                                               )
             data = str(cheetah_template)
         except CheetahNotFound as err:
             varname = err.args[0][13:-1]
@@ -368,51 +337,53 @@ class CreoleTemplateEngine:
 
     def instance_file(self,
                       filevar: Dict,
-                      systemd_rights: list) -> None:
+                      service_name: str) -> None:
         """Run templatisation on one file
         """
         log.info(_("Instantiating file '{filename}'"))
-        filenames = filevar['name']
         if 'variable' in filevar:
             variable = filevar['variable']
         else:
             variable = None
+        filenames = filevar['name']
         if not isinstance(filenames, list):
             filenames = [filenames]
             if variable:
                 variable = [variable]
         for idx, filename in enumerate(filenames):
-            destfilename = join(self.dest_dir,
+            destfilename = join(self.dest_dir, filename[1:])
-                                filename[1:])
             makedirs(dirname(destfilename), exist_ok=True)
             if variable:
                 var = variable[idx]
             else:
                 var = None
-            self.process(destfilename,
+            source = join(self.tmp_dir, filevar['source'])
-                         filevar,
+            if filevar['templating']:
-                         var)
+                self.process(source,
-            systemd_rights.append(f'C {filename} {filevar["mode"]} {filevar["owner"]} {filevar["group"]} - -')
+                             filename,
-            systemd_rights.append(f'z {filename} - - - - -')
+                             destfilename,
+                             filevar,
+                             var)
+            else:
+                copy(source, destfilename)
 
     async def instance_files(self) -> None:
         """Run templatisation on all files
         """
         for option in await self.config.option.list(type='all'):
             namespace = await option.option.name()
-            if namespace in ['services', 'actions']:
+            if namespace == variable_namespace:
-                continue
+                await self.load_eole_variables_rougail(option)
-            elif namespace == 'creole':
-                await self.load_eole_variables_creole(option)
             else:
-                await self.load_eole_variables(namespace,
+                families = await self.load_eole_variables(namespace,
-                                               option)
+                                                          option)
+                self.rougail_variables_dict[namespace] = families
         for template in listdir(self.distrib_dir):
             self.prepare_template(join(self.distrib_dir, template))
-        systemd_rights = []
         for service_obj in await self.config.option('services').list('all'):
+            service_name = await service_obj.option.doc()
             for fills in await service_obj.list('all'):
-                if await fills.option.name() == 'files':
+                if await fills.option.name() in ['files', 'overrides']:
                     for fill_obj in await fills.list('all'):
                         fill = await fill_obj.value.dict()
                         filename = fill['source']
@@ -421,23 +392,22 @@ class CreoleTemplateEngine:
                             raise FileNotFound(_(f"File {distib_file} does not exist."))
                         if fill.get('activate', False):
                             self.instance_file(fill,
-                                               systemd_rights)
+                                               service_name,
+                                               )
                         else:
                             log.debug(_("Instantiation of file '{filename}' disabled"))
 
-        with open(join(self.dest_dir, 'rougail.conf'), 'w') as fh:
-            fh.write('\n'.join(systemd_rights))
-            fh.write('\n')
-
 
 async def generate(config: Config,
-             eosfunc_file: str,
+                   eosfunc_file: str,
-             distrib_dir: str,
+                   distrib_dir: str,
-             tmp_dir: str,
+                   tmp_dir: str,
-             dest_dir: str) -> None:
+                   dest_dir: str,
+                   ) -> None:
     engine = CreoleTemplateEngine(config,
                                   eosfunc_file,
                                   distrib_dir,
                                   tmp_dir,
-                                  dest_dir)
+                                  dest_dir,
+                                  )
     await engine.instance_files()

src/rougail/tiramisu.py

@@ -0,0 +1,10 @@
+from tiramisu import DynOptionDescription
+from .utils import normalize_family
+
+
+class ConvertDynOptionDescription(DynOptionDescription):
+    def convert_suffix_to_path(self, suffix):
+        if not isinstance(suffix, str):
+            suffix = str(suffix)
+        return normalize_family(suffix,
+                                check_name=False)

src/rougail/xmlreflector.py

@@ -6,7 +6,7 @@ from os import listdir
 from lxml.etree import DTD, parse, tostring  # , XMLParser
 
 from .i18n import _
-from .error import CreoleDictConsistencyError
+from .error import DictConsistencyError
 
 HIGH_COMPATIBILITY = True
 
@@ -35,58 +35,53 @@ class XMLReflector(object):
 
         :returns: the root element tree object
         """
-        # FIXME zephir2
         # document = parse(BytesIO(xmlfile), XMLParser(remove_blank_text=True))
         document = parse(xmlfile)
         if not self.dtd.validate(document):
-            raise CreoleDictConsistencyError(_("not a valid xml file: {}").format(xmlfile))
+            raise DictConsistencyError(_("not a valid xml file: {}").format(xmlfile))
         return document.getroot()
 
-    def load_xml_from_folders(self, xmlfolders, from_zephir):
+    def load_xml_from_folders(self, xmlfolders):
         """Loads all the XML files located in the xmlfolders' list
 
         :param xmlfolders: list of full folder's name
         """
         documents = []
-        if from_zephir:
+        if not isinstance(xmlfolders, list):
-            for idx, xmlfile in enumerate(xmlfolders):
+            xmlfolders = [xmlfolders]
-                documents.append(('generate_{}'.format(idx), self.parse_xmlfile(xmlfile, from_zephir=from_zephir)))
+        for xmlfolder in xmlfolders:
-        else:
+            if isinstance(xmlfolder, list) or isinstance(xmlfolder, tuple):
-            if not isinstance(xmlfolders, list):
+                # directory group : collect files from each
-                xmlfolders = [xmlfolders]
+                # directory and sort them before loading
-            for xmlfolder in xmlfolders:
+                group_files = []
-                if isinstance(xmlfolder, list) or isinstance(xmlfolder, tuple):
+                for idx, subdir in enumerate(xmlfolder):
-                    # directory group : collect files from each
+                    if isdir(subdir):
-                    # directory and sort them before loading
+                        for filename in listdir(subdir):
-                    group_files = []
+                            group_files.append((filename, idx, subdir))
-                    for idx, subdir in enumerate(xmlfolder):
+                    else:
-                        if isdir(subdir):
+                        group_files.append(basename(subdir), idx, dirname(subdir))
-                            for filename in listdir(subdir):
+                def sort_group(file1, file2):
-                                group_files.append((filename, idx, subdir))
+                    if file1[0] == file2[0]:
-                        else:
+                        # sort by initial xmlfolder order if same name
-                            group_files.append(basename(subdir), idx, dirname(subdir))
+                        return file1[1].__cmp__(file2[1])
-                    def sort_group(file1, file2):
+                    # sort by filename
-                        if file1[0] == file2[0]:
+                    elif file1[0] > file2[0]:
-                            # sort by initial xmlfolder order if same name
+                        return 1
-                            return file1[1].__cmp__(file2[1])
+                    else:
-                        # sort by filename
+                        return -1
-                        elif file1[0] > file2[0]:
+                group_files.sort(sort_group)
-                            return 1
+                filenames = [join(f[2], f[0]) for f in group_files]
-                        else:
+            elif isdir(xmlfolder):
-                            return -1
+                filenames = []
-                    group_files.sort(sort_group)
+                for filename in listdir(xmlfolder):
-                    filenames = [join(f[2], f[0]) for f in group_files]
+                    filenames.append(join(xmlfolder, filename))
-                elif isdir(xmlfolder):
+                filenames.sort()
-                    filenames = []
+            else:
-                    for filename in listdir(xmlfolder):
+                filenames = [xmlfolder]
-                        filenames.append(join(xmlfolder, filename))
+            for xmlfile in filenames:
-                    filenames.sort()
+                if xmlfile.endswith('.xml'):
-                else:
+                    #xmlfile_path = join(xmlfolder, xmlfile)
-                    filenames = [xmlfolder]
+                    documents.append((xmlfile, self.parse_xmlfile(xmlfile)))
-                for xmlfile in filenames:
-                    if xmlfile.endswith('.xml'):
-                        #xmlfile_path = join(xmlfolder, xmlfile)
-                        documents.append((xmlfile, self.parse_xmlfile(xmlfile)))
         return documents
 
     def save_xmlfile(self, xmlfilename, xml):  # pylint: disable=R0201

tests/eosfunc/test.py

@@ -59,3 +59,7 @@ def cdrom_minormajor(*args, **kwargs):
 
 def device_type(*args, **kwargs):
     pass
+
+
+def calc_list(*args, **kwargs):
+    return []

tests/flattener_dicos/00empty/result/00-base.xml

@@ -1,8 +1,7 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family name="services">
+  <family name="services" doc="services">
-    <family name="service0" doc="tata">
+    <property>hidden</property>
-      <property>basic</property>
+    <family doc="tata" name="tata"/>
-    </family>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/00empty/tiramisu/base.py

@@ -0,0 +1,7 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_2 = OptionDescription(doc='tata', name='tata', children=[])
+option_1 = OptionDescription(name='services', doc='services', properties=frozenset(['hidden']), children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/00load_autofreeze/00-base.xml

@@ -1,8 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <rougail>
 
-    <services/>
-
     <variables>
         <family name="général">
             <variable name="mode_conteneur_actif" type="oui/non" description="No change" auto_freeze="True">

tests/flattener_dicos/00load_autofreeze/makedict/base.json

@@ -1 +1 @@
-{"creole.general.mode_conteneur_actif": "non", "creole.general.module_instancie": "non"}
+{"rougail.general.mode_conteneur_actif": "non", "rougail.general.module_instancie": "non"}

tests/flattener_dicos/00load_autofreeze/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="général" name="general">
       <property>basic</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -10,7 +10,7 @@
         <choice type="string">non</choice>
         <property>mandatory</property>
         <property>basic</property>
-        <property expected="oui" inverse="True" source="creole.general.module_instancie" type="calculation">auto_frozen</property>
+        <property expected="oui" inverse="True" source="rougail.general.module_instancie" type="calculation">auto_frozen</property>
         <value type="string">non</value>
       </variable>
       <variable doc="No change" multi="False" name="module_instancie" type="choice">
@@ -21,6 +21,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/00load_autofreeze/tiramisu/base.py

@@ -0,0 +1,9 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_4 = ChoiceOption(properties=frozenset(['mandatory', 'normal']), doc='No change', multi=False, name='module_instancie', default='non', values=('oui', 'non'))
+option_3 = ChoiceOption(properties=frozenset(['force_store_value', 'auto_freeze', 'mandatory', 'basic', Calculation(calc_value, Params(ParamValue('auto_frozen'), kwargs={'condition': ParamOption(option_4, todict=True), 'expected': ParamValue('oui'), 'reverse_condition': ParamValue(True)}))]), doc='No change', multi=False, name='mode_conteneur_actif', default='non', values=('oui', 'non'))
+option_2 = OptionDescription(doc='général', name='general', properties=frozenset(['basic']), children=[option_3, option_4])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/00load_autofreezeexpert/makedict/base.json

@@ -1 +1 @@
-{"creole.general.mode_conteneur_actif": "non", "creole.general.module_instancie": "non"}
+{"rougail.general.mode_conteneur_actif": "non", "rougail.general.module_instancie": "non"}

tests/flattener_dicos/00load_autofreezeexpert/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="général" name="general">
       <property>normal</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -10,7 +10,7 @@
         <choice type="string">non</choice>
         <property>mandatory</property>
         <property>expert</property>
-        <property expected="oui" inverse="True" source="creole.general.module_instancie" type="calculation">auto_frozen</property>
+        <property expected="oui" inverse="True" source="rougail.general.module_instancie" type="calculation">auto_frozen</property>
         <value type="string">non</value>
       </variable>
       <variable doc="No change" multi="False" name="module_instancie" type="choice">
@@ -21,6 +21,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/00load_autofreezeexpert/tiramisu/base.py

@@ -0,0 +1,9 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_4 = ChoiceOption(properties=frozenset(['mandatory', 'normal']), doc='No change', multi=False, name='module_instancie', default='non', values=('oui', 'non'))
+option_3 = ChoiceOption(properties=frozenset(['force_store_value', 'auto_freeze', 'mandatory', 'expert', Calculation(calc_value, Params(ParamValue('auto_frozen'), kwargs={'condition': ParamOption(option_4, todict=True), 'expected': ParamValue('oui'), 'reverse_condition': ParamValue(True)}))]), doc='No change', multi=False, name='mode_conteneur_actif', default='non', values=('oui', 'non'))
+option_2 = OptionDescription(doc='général', name='general', properties=frozenset(['normal']), children=[option_3, option_4])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/00load_autosave/makedict/base.json

@@ -1 +1 @@
-{"creole.general.mode_conteneur_actif": "non"}
+{"rougail.general.mode_conteneur_actif": "non"}

tests/flattener_dicos/00load_autosave/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="général" name="general">
       <property>basic</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -12,6 +12,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/00load_autosave/tiramisu/base.py

@@ -0,0 +1,8 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_3 = ChoiceOption(properties=frozenset(['force_store_value', 'mandatory', 'basic']), doc='No change', multi=False, name='mode_conteneur_actif', default='non', values=('oui', 'non'))
+option_2 = OptionDescription(doc='général', name='general', properties=frozenset(['basic']), children=[option_3])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/00load_autosaveexpert/makedict/base.json

@@ -1 +1 @@
-{"creole.general.mode_conteneur_actif": "non"}
+{"rougail.general.mode_conteneur_actif": "non"}

tests/flattener_dicos/00load_autosaveexpert/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="général" name="general">
       <property>expert</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -12,6 +12,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/00load_autosaveexpert/tiramisu/base.py

@@ -0,0 +1,8 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_3 = ChoiceOption(properties=frozenset(['force_store_value', 'mandatory', 'expert']), doc='No change', multi=False, name='mode_conteneur_actif', default='non', values=('oui', 'non'))
+option_2 = OptionDescription(doc='général', name='general', properties=frozenset(['expert']), children=[option_3])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/00load_comment/makedict/base.json

@@ -0,0 +1 @@
+{"rougail.general.mode_conteneur_actif": "non"}

tests/flattener_dicos/00load_comment/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="général" name="general">
       <property>normal</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -14,6 +14,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/00load_comment/tiramisu/base.py

@@ -0,0 +1,8 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_3 = ChoiceOption(properties=frozenset(['force_default_on_freeze', 'frozen', 'hidden', 'mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif', default='non', values=('oui', 'non'))
+option_2 = OptionDescription(doc='général', name='general', properties=frozenset(['normal']), children=[option_3])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/00load_notype/makedict/base.json

@@ -1 +1 @@
-{"creole.general.without_type": "non"}
+{"rougail.general.mode_conteneur_actif": "non", "rougail.general.without_type": "non"}

tests/flattener_dicos/00load_notype/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="général" name="general">
       <property>normal</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -16,9 +16,8 @@
       <variable doc="without_type" multi="False" name="without_type" type="string">
         <property>mandatory</property>
         <property>normal</property>
-        <value>non</value>
+        <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/00load_notype/tiramisu/base.py

@@ -0,0 +1,9 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_3 = ChoiceOption(properties=frozenset(['force_default_on_freeze', 'frozen', 'hidden', 'mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif', default='non', values=('oui', 'non'))
+option_4 = StrOption(properties=frozenset(['mandatory', 'normal']), doc='without_type', multi=False, name='without_type', default='non')
+option_2 = OptionDescription(doc='général', name='general', properties=frozenset(['normal']), children=[option_3, option_4])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/00load_save/makedict/base.json

@@ -0,0 +1 @@
+{"rougail.general.mode_conteneur_actif": "non"}

tests/flattener_dicos/00load_save/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="général" name="general">
       <property>normal</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -14,6 +14,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/00load_save/tiramisu/base.py

@@ -0,0 +1,8 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_3 = ChoiceOption(properties=frozenset(['force_default_on_freeze', 'frozen', 'hidden', 'mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif', default='non', values=('oui', 'non'))
+option_2 = OptionDescription(doc='général', name='general', properties=frozenset(['normal']), children=[option_3])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/00load_subfolder/makedict/base.json

@@ -0,0 +1 @@
+{"rougail.general.mode_conteneur_actif": "non", "rougail.general.mode_conteneur_actif1": "non"}

tests/flattener_dicos/00load_subfolder/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="général" name="general">
       <property>normal</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -24,6 +24,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/00load_subfolder/tiramisu/base.py

@@ -0,0 +1,9 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_3 = ChoiceOption(properties=frozenset(['force_default_on_freeze', 'frozen', 'hidden', 'mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif', default='non', values=('oui', 'non'))
+option_4 = ChoiceOption(properties=frozenset(['force_default_on_freeze', 'frozen', 'hidden', 'mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif1', default='non', values=('oui', 'non'))
+option_2 = OptionDescription(doc='général', name='general', properties=frozenset(['normal']), children=[option_3, option_4])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/01auto_base/00-base.xml

@@ -16,9 +16,9 @@
     </variables>
 
     <constraints>
-        <auto name="calc_val" target="mode_conteneur_actif">
+        <fill name="calc_val" target="mode_conteneur_actif">
             <param type="variable">mode_conteneur_actif1</param>
-        </auto>
+        </fill>
     </constraints>
 
     <help/>

tests/flattener_dicos/01auto_base/makedict/base.json

@@ -1 +1 @@
-{"creole.general.mode_conteneur_actif1": "non"}
+{"rougail.general.mode_conteneur_actif": null, "rougail.general.mode_conteneur_actif1": "non"}

tests/flattener_dicos/01auto_base/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="general" name="general">
       <property>normal</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -12,7 +12,7 @@
         <property>mandatory</property>
         <property>normal</property>
         <value name="calc_val" type="calculation">
-          <param transitive="False" type="variable">creole.general.mode_conteneur_actif1</param>
+          <param notraisepropertyerror="False" type="variable">rougail.general.mode_conteneur_actif1</param>
         </value>
       </variable>
       <variable doc="No change" multi="False" name="mode_conteneur_actif1" type="choice">
@@ -23,6 +23,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/01auto_base/tiramisu/base.py

@@ -0,0 +1,9 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_4 = ChoiceOption(properties=frozenset(['mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif1', default='non', values=('oui', 'non'))
+option_3 = ChoiceOption(properties=frozenset(['force_default_on_freeze', 'frozen', 'hidden', 'mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif', default=Calculation(func.calc_val, Params((ParamOption(option_4, notraisepropertyerror=False, todict=False)), kwargs={})), values=('oui', 'non'))
+option_2 = OptionDescription(doc='general', name='general', properties=frozenset(['normal']), children=[option_3, option_4])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/01auto_withoutparam/00-base.xml

@@ -16,8 +16,8 @@
     </variables>
 
     <constraints>
-        <auto name="calc_val" target="mode_conteneur_actif">
+        <fill name="calc_val" target="mode_conteneur_actif">
-        </auto>
+        </fill>
     </constraints>
 
     <help/>

tests/flattener_dicos/01auto_withoutparam/makedict/base.json

@@ -1 +1 @@
-{"creole.general.mode_conteneur_actif1": "non"}
+{"rougail.general.mode_conteneur_actif": null, "rougail.general.mode_conteneur_actif1": "non"}

tests/flattener_dicos/01auto_withoutparam/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="general" name="general">
       <property>normal</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -21,6 +21,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/01auto_withoutparam/tiramisu/base.py

@@ -0,0 +1,9 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_3 = ChoiceOption(properties=frozenset(['force_default_on_freeze', 'frozen', 'hidden', 'mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif', default=Calculation(func.calc_val, Params((), kwargs={})), values=('oui', 'non'))
+option_4 = ChoiceOption(properties=frozenset(['mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif1', default='non', values=('oui', 'non'))
+option_2 = OptionDescription(doc='general', name='general', properties=frozenset(['normal']), children=[option_3, option_4])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/01base_multi/makedict/base.json

@@ -0,0 +1 @@
+{"rougail.general.mode_conteneur_actif": ["non"]}

tests/flattener_dicos/01base_multi/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="general" name="general">
       <property>normal</property>
       <variable doc="Redefine description" multi="True" name="mode_conteneur_actif" type="choice">
@@ -14,6 +14,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/01base_multi/tiramisu/base.py

@@ -0,0 +1,8 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_3 = ChoiceOption(properties=frozenset(['force_default_on_freeze', 'frozen', 'hidden', 'mandatory', 'normal']), doc='Redefine description', multi=True, name='mode_conteneur_actif', default=['non'], default_multi='non', values=('oui', 'non'))
+option_2 = OptionDescription(doc='general', name='general', properties=frozenset(['normal']), children=[option_3])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/01base_submulti/result/00-base.xml

@@ -1,19 +0,0 @@
-<?xml version='1.0' encoding='UTF-8'?>
-<creole>
-  <family doc="" name="creole">
-    <family doc="general" name="general">
-      <property>normal</property>
-      <variable doc="Redefine description" multi="submulti" name="mode_conteneur_actif" type="choice">
-        <choice type="string">oui</choice>
-        <choice type="string">non</choice>
-        <property>force_default_on_freeze</property>
-        <property>frozen</property>
-        <property>hidden</property>
-        <property>mandatory</property>
-        <property>normal</property>
-        <value type="string">non</value>
-      </variable>
-    </family>
-    <separators/>
-  </family>
-</creole>

tests/flattener_dicos/01fill_autofreeze/makedict/base.json

@@ -1 +1 @@
-{"creole.general.mode_conteneur_actif": null, "creole.general.mode_conteneur_actif1": "non", "creole.general.module_instancie": "non"}
+{"rougail.general.mode_conteneur_actif": null, "rougail.general.mode_conteneur_actif1": "non", "rougail.general.module_instancie": "non"}

tests/flattener_dicos/01fill_autofreeze/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="general" name="general">
       <property>basic</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -10,9 +10,9 @@
         <choice type="string">non</choice>
         <property>mandatory</property>
         <property>basic</property>
-        <property expected="oui" inverse="True" source="creole.general.module_instancie" type="calculation">auto_frozen</property>
+        <property expected="oui" inverse="True" source="rougail.general.module_instancie" type="calculation">auto_frozen</property>
         <value name="calc_val" type="calculation">
-          <param transitive="False" type="variable">creole.general.mode_conteneur_actif1</param>
+          <param notraisepropertyerror="False" type="variable">rougail.general.mode_conteneur_actif1</param>
         </value>
       </variable>
       <variable doc="No change" multi="False" name="mode_conteneur_actif1" type="choice">
@@ -30,6 +30,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/01fill_autofreeze/tiramisu/base.py

@@ -0,0 +1,10 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_5 = ChoiceOption(properties=frozenset(['mandatory', 'normal']), doc='No change', multi=False, name='module_instancie', default='non', values=('oui', 'non'))
+option_4 = ChoiceOption(properties=frozenset(['mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif1', default='non', values=('oui', 'non'))
+option_3 = ChoiceOption(properties=frozenset(['force_store_value', 'auto_freeze', 'mandatory', 'basic', Calculation(calc_value, Params(ParamValue('auto_frozen'), kwargs={'condition': ParamOption(option_5, todict=True), 'expected': ParamValue('oui'), 'reverse_condition': ParamValue(True)}))]), doc='No change', multi=False, name='mode_conteneur_actif', default=Calculation(func.calc_val, Params((ParamOption(option_4, notraisepropertyerror=False, todict=False)), kwargs={})), values=('oui', 'non'))
+option_2 = OptionDescription(doc='general', name='general', properties=frozenset(['basic']), children=[option_3, option_4, option_5])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/01fill_autosave/makedict/base.json

@@ -1 +1 @@
-{"creole.general.mode_conteneur_actif": null, "creole.general.mode_conteneur_actif1": "non"}
+{"rougail.general.mode_conteneur_actif": null, "rougail.general.mode_conteneur_actif1": "non"}

tests/flattener_dicos/01fill_autosave/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="general" name="general">
       <property>basic</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -10,7 +10,7 @@
         <property>mandatory</property>
         <property>basic</property>
         <value name="calc_val" type="calculation">
-          <param transitive="False" type="variable">creole.general.mode_conteneur_actif1</param>
+          <param notraisepropertyerror="False" type="variable">rougail.general.mode_conteneur_actif1</param>
         </value>
       </variable>
       <variable doc="No change" multi="False" name="mode_conteneur_actif1" type="choice">
@@ -21,6 +21,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/01fill_autosave/tiramisu/base.py

@@ -0,0 +1,9 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_4 = ChoiceOption(properties=frozenset(['mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif1', default='non', values=('oui', 'non'))
+option_3 = ChoiceOption(properties=frozenset(['force_store_value', 'mandatory', 'basic']), doc='No change', multi=False, name='mode_conteneur_actif', default=Calculation(func.calc_val, Params((ParamOption(option_4, notraisepropertyerror=False, todict=False)), kwargs={})), values=('oui', 'non'))
+option_2 = OptionDescription(doc='general', name='general', properties=frozenset(['basic']), children=[option_3, option_4])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/01fill_base/makedict/base.json

@@ -1 +1 @@
-{"creole.general.mode_conteneur_actif1": "non"}
+{"rougail.general.mode_conteneur_actif": null, "rougail.general.mode_conteneur_actif1": "non"}

tests/flattener_dicos/01fill_base/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="general" name="general">
       <property>normal</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -12,7 +12,7 @@
         <property>mandatory</property>
         <property>normal</property>
         <value name="calc_val" type="calculation">
-          <param transitive="False" type="variable">creole.general.mode_conteneur_actif1</param>
+          <param notraisepropertyerror="False" type="variable">rougail.general.mode_conteneur_actif1</param>
         </value>
       </variable>
       <variable doc="No change" multi="False" name="mode_conteneur_actif1" type="choice">
@@ -23,6 +23,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/01fill_base/tiramisu/base.py

@@ -0,0 +1,9 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_4 = ChoiceOption(properties=frozenset(['mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif1', default='non', values=('oui', 'non'))
+option_3 = ChoiceOption(properties=frozenset(['force_default_on_freeze', 'frozen', 'hidden', 'mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif', default=Calculation(func.calc_val, Params((ParamOption(option_4, notraisepropertyerror=False, todict=False)), kwargs={})), values=('oui', 'non'))
+option_2 = OptionDescription(doc='general', name='general', properties=frozenset(['normal']), children=[option_3, option_4])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/01fill_baseaccent/makedict/base.json

@@ -1 +1 @@
-{"creole.general.mode_conteneur_actif1": "non"}
+{"rougail.general.mode_conteneur_actif": null, "rougail.general.mode_conteneur_actif1": "non"}

tests/flattener_dicos/01fill_baseaccent/result/00-base.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="Général" name="general">
       <property>normal</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="choice">
@@ -12,7 +12,7 @@
         <property>mandatory</property>
         <property>normal</property>
         <value name="calc_val" type="calculation">
-          <param transitive="False" type="variable">creole.general.mode_conteneur_actif1</param>
+          <param notraisepropertyerror="False" type="variable">rougail.general.mode_conteneur_actif1</param>
         </value>
       </variable>
       <variable doc="No change" multi="False" name="mode_conteneur_actif1" type="choice">
@@ -23,6 +23,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>

tests/flattener_dicos/01fill_baseaccent/tiramisu/base.py

@@ -0,0 +1,9 @@
+from tiramisu import *
+from rougail.tiramisu import ConvertDynOptionDescription
+import imp
+func = imp.load_source('func', 'tests/flattener_dicos/../eosfunc/test.py')
+option_4 = ChoiceOption(properties=frozenset(['mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif1', default='non', values=('oui', 'non'))
+option_3 = ChoiceOption(properties=frozenset(['force_default_on_freeze', 'frozen', 'hidden', 'mandatory', 'normal']), doc='No change', multi=False, name='mode_conteneur_actif', default=Calculation(func.calc_val, Params((ParamOption(option_4, notraisepropertyerror=False, todict=False)), kwargs={})), values=('oui', 'non'))
+option_2 = OptionDescription(doc='Général', name='general', properties=frozenset(['normal']), children=[option_3, option_4])
+option_1 = OptionDescription(doc='rougail', name='rougail', children=[option_2])
+option_0 = OptionDescription(name='baseoption', doc='baseoption', children=[option_1])

tests/flattener_dicos/01fill_mandatory/makedict/base.json

@@ -1 +1 @@
-{"creole.general.mode_conteneur_actif": null, "creole.general.mode_conteneur_actif1": "non"}
+{"rougail.general.mode_conteneur_actif": null, "rougail.general.mode_conteneur_actif1": "non"}

tests/flattener_dicos/01fill_mandatory/result/00-base.xml

@@ -1,13 +1,13 @@
 <?xml version='1.0' encoding='UTF-8'?>
-<creole>
+<rougail>
-  <family doc="" name="creole">
+  <family doc="rougail" name="rougail">
     <family doc="general" name="general">
       <property>normal</property>
       <variable doc="No change" multi="False" name="mode_conteneur_actif" type="domain">
         <property>mandatory</property>
         <property>expert</property>
         <value name="calc_val" type="calculation">
-          <param transitive="False" type="variable">creole.general.mode_conteneur_actif1</param>
+          <param notraisepropertyerror="False" type="variable">rougail.general.mode_conteneur_actif1</param>
         </value>
       </variable>
       <variable doc="No change" multi="False" name="mode_conteneur_actif1" type="choice">
@@ -18,6 +18,5 @@
         <value type="string">non</value>
       </variable>
     </family>
-    <separators/>
   </family>
-</creole>
+</rougail>