add port_type example

src/rougail/annotator/condition.py

@@ -235,8 +235,16 @@ class ConditionAnnotator(TargetAnnotator, ParamAnnotator, Walk):
                 or_needed = len(condition.param) != 1
             if len(condition.param) == 1:
                 values = getattr(condition.param[0], 'text', None)
+                param_type = condition.param[0].type
             else:
                 values = tuple([getattr(param, 'text', None) for param in condition.param])
+                param_type = None
+                for param in condition.param:
+                    if param_type is None or param_type == 'nil':
+                        param_type = param.type
+                    if param_type != param.type:
+                        msg = _(f'param with type "{target.type}" has multi param types')
+                        raise DictConsistencyError(msg, 59, condition.xmlfiles)
             param3 = self.objectspace.param(target.xmlfiles)
             param3.name = f'condition_{fill.index}'
             param3.type = 'variable'
@@ -245,7 +253,7 @@ class ConditionAnnotator(TargetAnnotator, ParamAnnotator, Walk):
             param4 = self.objectspace.param(target.xmlfiles)
             param4.name = f'expected_{fill.index}'
             param4.text = values
-            param4.type = condition.param[0].type
+            param4.type = param_type
             fill.param.append(param4)
             if condition.name != 'disabled_if_in':
                 param5 = self.objectspace.param(target.xmlfiles)

src/rougail/annotator/param.py

@@ -45,21 +45,12 @@ class ParamAnnotator:
             param_to_delete = []
             variable_type = self.valid_type_validation(obj)
             for param_idx, param in enumerate(obj.param):
-                if param.type == 'suffix':
                 if hasattr(param, 'text'):
+                    if param.type == 'suffix':
                         msg = _(f'"{param.type}" parameter must not have a value')
                         raise DictConsistencyError(msg, 28, obj.xmlfiles)
-                    for target in obj.target:
-                        if not self.objectspace.paths.variable_is_dynamic(target.name.path):
-                            msg = _(f'"suffix" parameter cannot be set with target "{target.name}"'
-                                    f' which is not a dynamic variable')
-                            raise DictConsistencyError(msg, 53, obj.xmlfiles)
-                elif not hasattr(param, 'text'):
-                    if not param.type == 'nil':
-                        msg = _(f'"{param.type}" parameter must have a value')
-                        raise DictConsistencyError(msg, 27, obj.xmlfiles)
-                    param.text = None
                     elif param.type == 'nil':
+                        if param.text is not None:
                             msg = _(f'"{param.type}" parameter must not have a value')
                             raise DictConsistencyError(msg, 40, obj.xmlfiles)
                     elif param.type == 'variable':
@@ -82,6 +73,32 @@ class ParamAnnotator:
                                 raise err
                             param_to_delete.append(param_idx)
                     elif variable_type:
+                        self._convert_with_variable_type(variable_type, param)
+                    continue
+                # no param.text
+                if param.type == 'suffix':
+                    for target in obj.target:
+                        if not self.objectspace.paths.variable_is_dynamic(target.name.path):
+                            msg = _(f'"suffix" parameter cannot be set with target "{target.name}"'
+                                    f' which is not a dynamic variable')
+                            raise DictConsistencyError(msg, 53, obj.xmlfiles)
+                elif param.type == 'nil':
+                    param.text = None
+                elif param.type == 'string':
+                    param.text = ''
+                    if variable_type:
+                        self._convert_with_variable_type(variable_type, param)
+                else:
+                    msg = _(f'"{param.type}" parameter must have a value')
+                    raise DictConsistencyError(msg, 27, obj.xmlfiles)
+            param_to_delete.sort(reverse=True)
+            for param_idx in param_to_delete:
+                obj.param.pop(param_idx)
+
+    def _convert_with_variable_type(self,
+                                    variable_type: str,
+                                    param: 'self.objectspace.param',
+                                    ) -> None:
         if 'type' in vars(param) and variable_type != param.type:
             msg = _(f'parameter has incompatible type "{param.type}" '
                     f'with type "{variable_type}"')
@@ -93,6 +110,3 @@ class ParamAnnotator:
                     f'is not a valid "{variable_type}"')
             raise DictConsistencyError(msg, 13, param.xmlfiles) from err
         param.type = variable_type
-            param_to_delete.sort(reverse=True)
-            for param_idx in param_to_delete:
-                obj.param.pop(param_idx)

src/rougail/tiramisureflector.py

@@ -242,7 +242,7 @@ class Common:
                        ):
         """Populate variable parameters
         """
-        if param.type in ['number', 'boolean', 'nil', 'string']:
+        if param.type in ['number', 'boolean', 'nil', 'string', 'port']:
             value = param.text
             if param.type == 'string' and value is not None:
                 value = self.convert_str(value)

tests/dictionaries/70port_portlist/00-base.xml

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<rougail>
+
+    <services>
+        <service name='ntp'>
+            <port protocol='udp' port_type="variable" portlist="example">my_variable</port>
+            <port protocol='tcp' port_type="variable" portlist="example">my_variable</port>
+        </service>
+    </services>
+
+    <variables>
+        <variable name='my_variable' type='port'>
+            <value>123</value>
+        </variable>
+    </variables>
+    <constraints>
+        <condition name="disabled_if_in" source="my_variable">
+            <param type='nil'/>
+            <param></param>
+            <target type="portlist">example</target>
+        </condition>
+    </constraints>
+</rougail>
+<!-- vim: ts=4 sw=4 expandtab
+-->

tests/dictionaries/70port_portlist/makedict/base.json

@@ -0,0 +1 @@
+{"rougail.my_variable": "123", "services.ntp.ports.my_variable.name": "123", "services.ntp.ports.my_variable.protocol": "udp", "services.ntp.ports.my_variable.activate": true, "services.ntp.ports.my_variable_1.name": "123", "services.ntp.ports.my_variable_1.protocol": "tcp", "services.ntp.ports.my_variable_1.activate": true}

tests/dictionaries/70port_portlist/tiramisu/base.py

@@ -0,0 +1,27 @@
+from importlib.machinery import SourceFileLoader
+from importlib.util import spec_from_loader, module_from_spec
+loader = SourceFileLoader('func', 'tests/dictionaries/../eosfunc/test.py')
+spec = spec_from_loader(loader.name, loader)
+func = module_from_spec(spec)
+loader.exec_module(func)
+for key, value in dict(locals()).items():
+    if key != ['SourceFileLoader', 'func']:
+        setattr(func, key, value)
+try:
+    from tiramisu3 import *
+except:
+    from tiramisu import *
+option_2 = PortOption(name="my_variable", doc="my_variable", default="123", allow_private=True, properties=frozenset({"mandatory", "normal"}))
+option_1 = OptionDescription(name="rougail", doc="rougail", children=[option_2])
+option_7 = SymLinkOption(name="name", opt=option_2)
+option_8 = StrOption(name="protocol", doc="protocol", default="udp")
+option_9 = BoolOption(name="activate", doc="activate", default=Calculation(func.calc_value, Params((ParamValue(False)), kwargs={'default': ParamValue(True), 'condition_0': ParamOption(option_2), 'expected_0': ParamValue((None, '')), 'condition_operator': ParamValue("OR")})))
+option_6 = OptionDescription(name="my_variable", doc="my_variable", children=[option_7, option_8, option_9])
+option_11 = SymLinkOption(name="name", opt=option_2)
+option_12 = StrOption(name="protocol", doc="protocol", default="tcp")
+option_13 = BoolOption(name="activate", doc="activate", default=Calculation(func.calc_value, Params((ParamValue(False)), kwargs={'default': ParamValue(True), 'condition_0': ParamOption(option_2), 'expected_0': ParamValue((None, '')), 'condition_operator': ParamValue("OR")})))
+option_10 = OptionDescription(name="my_variable_1", doc="my_variable_1", children=[option_11, option_12, option_13])
+option_5 = OptionDescription(name="ports", doc="ports", children=[option_6, option_10])
+option_4 = OptionDescription(name="ntp", doc="ntp", children=[option_5])
+option_3 = OptionDescription(name="services", doc="services", children=[option_4], properties=frozenset({"hidden"}))
+option_0 = OptionDescription(name="baseoption", doc="baseoption", children=[option_1, option_3])