do not stop daemon when on_join failed

debian/changelog

@@ -0,0 +1,5 @@
+risotto (0.1) unstable; urgency=low
+
+  * first version
+
+ -- Cadoles <contact@cadoles.com>  Fri, 20 Mar 2020 15:18:25 +0100

debian/control

@@ -2,23 +2,13 @@ Source: risotto
 Section: admin
 Priority: extra
 Maintainer: Cadoles <contact@cadoles.com>
-Build-depends: debhelper (>=11), python3-all, python3-setuptools, dh-python
+Build-depends: debhelper (>=11), python3-all, python3-setuptools
 Standards-Version: 3.9.4
 Homepage: https://forge.cadoles.com/Infra/risotto
 
-Package: python3-risotto
-Architecture: any
-Pre-Depends: dpkg, python3, ${misc:Pre-Depends}
-Depends: ${python:Depends}, ${misc:Depends},
-	python3-asyncpg,
-	python3-rougail,
-	python3-aiohttp,
-	python3-sdnotify
-Description: configuration manager libraries
-
 Package: risotto
 Architecture: any
 Pre-Depends: dpkg, python3, ${misc:Pre-Depends}
-Depends: ${python:Depends}, ${misc:Depends}, python3-risotto
+Depends: ${python:Depends}, ${misc:Depends}
 Description: configuration manager
 

debian/risotto.install

@@ -1,2 +0,0 @@
-script/risotto-server usr/bin/
-sql/risotto.sql usr/share/eole/db/eole-risotto/gen/

src/risotto/controller.py

@@ -48,6 +48,31 @@ class Controller:
                                  **kwargs,
                                  )
 
+    @staticmethod
+    async def check_role(self,
+                         uri: str,
+                         username: str,
+                         **kwargs: dict,
+                         ) -> None:
+        # create a new config
+        async with await Config(dispatcher.option) as config:
+            await config.property.read_write()
+            await config.option('message').value.set(uri)
+            subconfig = config.option(uri)
+            for key, value in kwargs.items():
+                try:
+                    await subconfig.option(key).value.set(value)
+                except AttributeError:
+                    if get_config()['global']['debug']:
+                        print_exc()
+                    raise ValueError(_(f'unknown parameter in "{uri}": "{key}"'))
+                except ValueOptionError as err:
+                    raise ValueError(_(f'invalid parameter in "{uri}": {err}'))
+            await dispatcher.check_role(subconfig,
+                                        username,
+                                        uri,
+                                        )
+
     async def on_join(self,
                       risotto_context,
                       ):

src/risotto/dispatcher.py

@@ -342,7 +342,8 @@ class Dispatcher(register.RegisterDispatcher,
     async def check_role(self,
                          config: Config,
                          user_login: str,
-                         uri: str) -> None:
+                         uri: str,
+                         ) -> None:
         async with self.pool.acquire() as connection:
             async with connection.transaction():
                 # Verify if user exists and get ID

src/risotto/register.py

@@ -7,6 +7,7 @@ from typing import Callable, Optional, List
 from asyncpg import create_pool
 from json import dumps, loads
 from pkg_resources import iter_entry_points
+from traceback import print_exc
 import risotto
 from .utils import _
 from .error import RegistrationError
@@ -277,7 +278,7 @@ class RegisterDispatcher:
         try:
             self.injected_self[submodule_name] = module.Risotto(test)
         except AttributeError as err:
-            raise RegistrationError(_(f'unable to register the module {submodule_name}, this module must have Risotto class'))
+            print(_(f'unable to register the module {submodule_name}, this module must have Risotto class'))
 
     def validate(self):
         """ check if all messages have a function
@@ -319,7 +320,13 @@ class RegisterDispatcher:
                     await log.info_msg(risotto_context,
                                        None,
                                        info_msg)
+                    try:
                         await module.on_join(risotto_context)
+                    except Exception as err:
+                        if get_config()['global']['debug']:
+                            print_exc()
+                        msg = _(f'on_join returns an error in module {submodule_name}: {err}')
+                        await log.error_msg(risotto_context, {}, msg)
 
     async def load(self):
         # valid function's arguments