From e90b08b3633c7a277da84ad19cde45324ca9bf5a Mon Sep 17 00:00:00 2001
From: Jasmine Schladen <jschladen@netflix.com>
Date: Fri, 16 Oct 2020 17:08:44 -0700
Subject: [PATCH] Correct typo and enable Slack notification test

---
 lemur/notifications/messaging.py              |  4 +-
 lemur/plugins/lemur_slack/tests/test_slack.py | 40 +++++++++++--------
 2 files changed, 26 insertions(+), 18 deletions(-)

diff --git a/lemur/notifications/messaging.py b/lemur/notifications/messaging.py
index 5452f4fc..aa85123d 100644
--- a/lemur/notifications/messaging.py
+++ b/lemur/notifications/messaging.py
@@ -217,9 +217,9 @@ def send_rotation_notification(certificate, notification_plugin=None):
         notification_plugin.send("rotation", data, [data["owner"]], [])
         status = SUCCESS_METRIC_STATUS
     except Exception as e:
-        log_data["message"] = "Unable to send rotation notification for certificate {0} to ownner {1}" \
+        log_data["message"] = "Unable to send rotation notification for certificate {0} to owner {1}" \
             .format(certificate.name, data["owner"])
-        current_app.logger.error(log_data)
+        current_app.logger.error(log_data, exc_info=True)
         sentry.captureException()
 
     metrics.send(
diff --git a/lemur/plugins/lemur_slack/tests/test_slack.py b/lemur/plugins/lemur_slack/tests/test_slack.py
index 77abd542..da232d61 100644
--- a/lemur/plugins/lemur_slack/tests/test_slack.py
+++ b/lemur/plugins/lemur_slack/tests/test_slack.py
@@ -1,3 +1,10 @@
+from datetime import timedelta
+
+import arrow
+
+from lemur.tests.factories import NotificationFactory, CertificateFactory
+
+
 def test_formatting(certificate):
     from lemur.plugins.lemur_slack.plugin import create_expiration_attachments
     from lemur.certificates.schemas import certificate_notification_output_schema
@@ -27,32 +34,33 @@ def get_options():
     return [
         {"name": "interval", "value": 10},
         {"name": "unit", "value": "days"},
+        {"name": "webhook", "value": "https://slack.com/api/api.test"},
     ]
 
 
-# Currently disabled as we have no good way to mock Slack webhooks
-# def test_send_expiration_notification():
-#     from lemur.notifications.messaging import send_expiration_notifications
-#     from lemur.tests.factories import CertificateFactory
-#
-#     now = arrow.utcnow()
-#     in_ten_days = now + timedelta(days=10, hours=1)  # a bit more than 10 days since we'll check in the future
-#     certificate = CertificateFactory()
-#     notification = NotificationFactory(plugin_name="slack-notification")
-#
-#     certificate.not_after = in_ten_days
-#     certificate.notifications.append(notification)
-#     certificate.notifications[0].options = get_options()
-#
-#     assert send_expiration_notifications([]) == (2, 0)
+def test_send_expiration_notification():
+    from lemur.notifications.messaging import send_expiration_notifications
+
+    notification = NotificationFactory(plugin_name="slack-notification")
+    notification.options = get_options()
+
+    now = arrow.utcnow()
+    in_ten_days = now + timedelta(days=10, hours=1)  # a bit more than 10 days since we'll check in the future
+
+    certificate = CertificateFactory()
+    certificate.not_after = in_ten_days
+    certificate.notifications.append(notification)
+
+    assert send_expiration_notifications([]) == (2, 0)
 
 
-# Currently disabled as we have no good way to mock Slack webhooks
+# Currently disabled as the Slack plugin doesn't support this type of notification
 # def test_send_rotation_notification(endpoint, source_plugin):
 #     from lemur.notifications.messaging import send_rotation_notification
 #     from lemur.deployment.service import rotate_certificate
 #
 #     notification = NotificationFactory(plugin_name="slack-notification")
+#     notification.options = get_options()
 #
 #     new_certificate = CertificateFactory()
 #     rotate_certificate(endpoint, new_certificate)