From 50761d9d3b1603dc2780ea5c11acd7ed26056bef Mon Sep 17 00:00:00 2001 From: Curtis Castrapel Date: Mon, 29 Oct 2018 13:22:50 -0700 Subject: [PATCH] safer reissue, fix celery sync job --- lemur/certificates/cli.py | 12 +++++++++++- lemur/common/celery.py | 2 +- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/lemur/certificates/cli.py b/lemur/certificates/cli.py index 013a4cb1..7a46138c 100644 --- a/lemur/certificates/cli.py +++ b/lemur/certificates/cli.py @@ -238,7 +238,17 @@ def reissue(old_certificate_name, commit): if not old_cert: for certificate in get_all_pending_reissue(): - request_reissue(certificate, commit) + try: + request_reissue(certificate, commit) + except Exception as e: + sentry.captureException() + current_app.logger.exception( + "Error reissuing certificate: {}".format(certificate.name), exc_info=True) + print( + "[!] Failed to reissue certificates. Reason: {}".format( + e + ) + ) else: request_reissue(old_cert, commit) diff --git a/lemur/common/celery.py b/lemur/common/celery.py index c12c6f06..1711b452 100644 --- a/lemur/common/celery.py +++ b/lemur/common/celery.py @@ -210,4 +210,4 @@ def sync_source(source): :return: """ current_app.logger.debug("Syncing source {}".format(source)) - sync([source], True) + sync([source])