From 252f84cf213b6a66926e72df56c49fb11f68165c Mon Sep 17 00:00:00 2001
From: Hossein Shafagh <hshafagh@netflix.com>
Date: Tue, 10 Nov 2020 17:46:00 -0800
Subject: [PATCH] adding also response to upload acme token, just for future
 use-cases

---
 lemur/plugins/lemur_aws/plugin.py            | 18 +++++++++---------
 lemur/plugins/lemur_aws/tests/test_plugin.py |  9 +++++----
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/lemur/plugins/lemur_aws/plugin.py b/lemur/plugins/lemur_aws/plugin.py
index 8fca73e9..fcc2e0cf 100644
--- a/lemur/plugins/lemur_aws/plugin.py
+++ b/lemur/plugins/lemur_aws/plugin.py
@@ -419,7 +419,7 @@ class S3DestinationPlugin(ExportDestinationPlugin):
         :param kwargs:
         :return:
         """
-        current_app.logger.debug("S3 destination plugin is started for HTTP-01 challenge")
+        current_app.logger.debug("S3 destination plugin is started to upload HTTP-01 challenge")
 
         function = f"{__name__}.{sys._getframe().f_code.co_name}"
 
@@ -431,16 +431,16 @@ class S3DestinationPlugin(ExportDestinationPlugin):
         if not prefix.endswith("/"):
             prefix + "/"
 
-        res = s3.put(bucket_name=bucket_name,
-                     region_name=region,
-                     prefix=prefix + filename,
-                     data=token,
-                     encrypt=False,
-                     account_number=account_number)
-        res = "Success" if res else "Failure"
+        response = s3.put(bucket_name=bucket_name,
+                          region_name=region,
+                          prefix=prefix + filename,
+                          data=token,
+                          encrypt=False,
+                          account_number=account_number)
+        res = "Success" if response else "Failure"
         log_data = {
             "function": function,
-            "message": "check if any valid certificate is revoked",
+            "message": "upload acme token challenge",
             "result": res,
             "bucket_name": bucket_name,
             "filename": filename
diff --git a/lemur/plugins/lemur_aws/tests/test_plugin.py b/lemur/plugins/lemur_aws/tests/test_plugin.py
index 89a318ca..e032cf02 100644
--- a/lemur/plugins/lemur_aws/tests/test_plugin.py
+++ b/lemur/plugins/lemur_aws/tests/test_plugin.py
@@ -68,10 +68,11 @@ def test_upload_acme_token(app):
     s3_client.create_bucket(Bucket=bucket)
     p = plugins.get("aws-s3")
 
-    p.upload_acme_token(token_path=token_path,
-                        token_content=token_content,
-                        token=token_content,
-                        options=additional_options)
+    response = p.upload_acme_token(token_path=token_path,
+                                   token_content=token_content,
+                                   token=token_content,
+                                   options=additional_options)
+    assert response
 
     response = get(bucket_name=bucket,
                    prefixed_object_name=prefix + token_name,