From ea365b551a95be3cd28ecaf8b335ddf2d7de32ed Mon Sep 17 00:00:00 2001 From: Dalton Hubble Date: Tue, 21 Aug 2018 21:25:22 -0700 Subject: [PATCH] Fix docs mentions of ELBs to NLBs * Typhoon AWS clusters use an NLB rather than an ELB, since v1.10.5 * Add a few missing links in CHANGES --- CHANGES.md | 6 +++--- aws/container-linux/kubernetes/nlb.tf | 2 +- aws/fedora-atomic/kubernetes/nlb.tf | 2 +- docs/addons/ingress.md | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index c053a79f..307284ab 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -6,7 +6,7 @@ Notable changes between versions. #### AWS -* Remove firewall rule allowing ICMP packets to nodes +* Remove firewall rule allowing ICMP packets to nodes ([#285](https://github.com/poseidon/typhoon/pull/285)) #### Bare-Metal @@ -14,7 +14,7 @@ Notable changes between versions. #### Google Cloud -* Remove firewall rule allowing workers to access Nginx Ingress health check +* Remove firewall rule allowing workers to access Nginx Ingress health check ([#284](https://github.com/poseidon/typhoon/pull/284)) * Nginx Ingress addon no longer uses hostNetwork, Prometheus scrapes via CNI network ## v1.11.2 @@ -29,7 +29,7 @@ Notable changes between versions. * Introduce [Container Linux Config snippets](https://typhoon.psdn.io/advanced/customization/#container-linux) on bare-metal * Validate and additively merge custom Container Linux Configs during terraform plan * Define files, systemd units, dropins, networkd configs, mounts, users, and more - * [Require](https://typhoon.psdn.io/cl/bare-metal/#terraform-setup) `terraform-provider-ct` plugin v0.2.1 (action required!) + * [Require](https://typhoon.psdn.io/cl/bare-metal/#terraform-setup) `terraform-provider-ct` plugin v0.2.1 (**action required!**) #### Addons diff --git a/aws/container-linux/kubernetes/nlb.tf b/aws/container-linux/kubernetes/nlb.tf index 4a0eef77..ddcc52f5 100644 --- a/aws/container-linux/kubernetes/nlb.tf +++ b/aws/container-linux/kubernetes/nlb.tf @@ -5,7 +5,7 @@ resource "aws_route53_record" "apiserver" { name = "${format("%s.%s.", var.cluster_name, var.dns_zone)}" type = "A" - # AWS recommends their special "alias" records for ELBs + # AWS recommends their special "alias" records for NLBs alias { name = "${aws_lb.nlb.dns_name}" zone_id = "${aws_lb.nlb.zone_id}" diff --git a/aws/fedora-atomic/kubernetes/nlb.tf b/aws/fedora-atomic/kubernetes/nlb.tf index 4a0eef77..ddcc52f5 100644 --- a/aws/fedora-atomic/kubernetes/nlb.tf +++ b/aws/fedora-atomic/kubernetes/nlb.tf @@ -5,7 +5,7 @@ resource "aws_route53_record" "apiserver" { name = "${format("%s.%s.", var.cluster_name, var.dns_zone)}" type = "A" - # AWS recommends their special "alias" records for ELBs + # AWS recommends their special "alias" records for NLBs alias { name = "${aws_lb.nlb.dns_name}" zone_id = "${aws_lb.nlb.zone_id}" diff --git a/docs/addons/ingress.md b/docs/addons/ingress.md index a2474aba..33fb4aa6 100644 --- a/docs/addons/ingress.md +++ b/docs/addons/ingress.md @@ -12,7 +12,7 @@ Create the Ingress controller deployment, service, RBAC roles, RBAC bindings, de kubectl apply -R -f addons/nginx-ingress/aws ``` -For each application, add a DNS CNAME resolving to the ELB's DNS record. +For each application, add a DNS CNAME resolving to the NLB's DNS record. ``` app1.example.com -> tempest-ingress.123456.us-west2.elb.amazonaws.com @@ -20,7 +20,7 @@ aap2.example.com -> tempest-ingress.123456.us-west2.elb.amazonaws.com app3.example.com -> tempest-ingress.123456.us-west2.elb.amazonaws.com ``` -Find the ELB's DNS name through the console or use the Typhoon module's output `ingress_dns_name`. For example, you might use Terraform to manage a Google Cloud DNS record: +Find the NLB's DNS name through the console or use the Typhoon module's output `ingress_dns_name`. For example, you might use Terraform to manage a Google Cloud DNS record: ```tf resource "google_dns_record_set" "some-application" {