From bb586b60da062208c06c5f035a8962d07e42f1c2 Mon Sep 17 00:00:00 2001 From: Dalton Hubble Date: Mon, 6 Jan 2020 21:14:03 -0800 Subject: [PATCH] Reduce Prometheus addon's node-exporter tolerations * Change node-exporter DaemonSet tolerations from tolerating all possible NoSchedule taints to tolerating the master taint and the not ready taint (we'd like metrics regardless) * Users who add custom node taints must add their custom taints to the addon node-exporter DaemonSet. As an addon, its expected users copy and manipulate manifests out-of-band in their own systems --- CHANGES.md | 1 + addons/prometheus/exporters/node-exporter/daemonset.yaml | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index a2c9b3be..04b70ba8 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -16,6 +16,7 @@ Notable changes between versions. * Update Prometheus from v2.14.0 to [v2.15.1](https://github.com/prometheus/prometheus/releases/tag/v2.15.1) * Add discovery for kube-proxy service endpoints * Update kube-state-metrics from v1.8.0 to v1.9.0 +* Reduce node-exporter DaemonSet tolerations ([#614](https://github.com/poseidon/typhoon/pull/614)) * Update Grafana from v6.5.1 to v6.5.2 ## v1.17.0 diff --git a/addons/prometheus/exporters/node-exporter/daemonset.yaml b/addons/prometheus/exporters/node-exporter/daemonset.yaml index a8e58421..7ef88739 100644 --- a/addons/prometheus/exporters/node-exporter/daemonset.yaml +++ b/addons/prometheus/exporters/node-exporter/daemonset.yaml @@ -57,7 +57,9 @@ spec: mountPath: /host/root readOnly: true tolerations: - - effect: NoSchedule + - key: node-role.kubernetes.io/master + operator: Exists + - key: node.kubernetes.io/not-ready operator: Exists volumes: - name: proc