From 949cc2199b677d649c48f49cf972dc61e61d21c3 Mon Sep 17 00:00:00 2001
From: Philippe Caseiro <pcaseiro@cadoles.com>
Date: Fri, 3 Mar 2023 10:41:56 +0100
Subject: [PATCH] Add support for devince binding

In some cases we need to use block devices directly (Physical volume
storage).

This new variable allows the user to mount devices with the --device
option for flatcar baremetal.

How to use :

add a list of objects like this to the cluster definition :

worker_bind_devices = [
  { source = "/dev/sdb" target = "/dev/sdb" },
  { source = "/dev/sdc" target = "/dev/sdd" },
  { source = "/dev/sdd" target = "/dev/sdd" }
]

This will bind the source device on the target directory in evry node.
---
 bare-metal/flatcar-linux/kubernetes/variables.tf   | 14 ++++++++++++++
 .../kubernetes/worker/butane/worker.yaml           |  3 +++
 .../flatcar-linux/kubernetes/worker/matchbox.tf    |  1 +
 bare-metal/flatcar-linux/kubernetes/workers.tf     |  1 +
 4 files changed, 19 insertions(+)

diff --git a/bare-metal/flatcar-linux/kubernetes/variables.tf b/bare-metal/flatcar-linux/kubernetes/variables.tf
index 6623c038..f13ada35 100644
--- a/bare-metal/flatcar-linux/kubernetes/variables.tf
+++ b/bare-metal/flatcar-linux/kubernetes/variables.tf
@@ -73,6 +73,20 @@ variable "worker_node_taints" {
   default     = {}
 }
 
+variable "worker_bind_devices" {
+  type        = list(object({
+    source = string
+    target = string
+  }))
+  description = <<EOD
+  List of devices to bind on kubelet container for direct storage usage
+  [
+    { source = "/dev/sdb", target = "/dev/sdb" },
+    { source = "/dev/sdc", target = "/dev/sdc" }
+  ]
+  EOD
+}
+
 # configuration
 
 variable "k8s_domain_name" {
diff --git a/bare-metal/flatcar-linux/kubernetes/worker/butane/worker.yaml b/bare-metal/flatcar-linux/kubernetes/worker/butane/worker.yaml
index 3c828334..185a7b4d 100644
--- a/bare-metal/flatcar-linux/kubernetes/worker/butane/worker.yaml
+++ b/bare-metal/flatcar-linux/kubernetes/worker/butane/worker.yaml
@@ -77,6 +77,9 @@ systemd:
           --register-with-taints=${taint} \
           %{~ endfor ~}
           --node-labels=node.kubernetes.io/node
+          %{~ for device in compact(split(",", node_devices)) ~}
+          --device=${device.source}:${device.target}
+          %{~ endfor ~}
         ExecStart=docker logs -f kubelet
         ExecStop=docker stop kubelet
         ExecStopPost=docker rm kubelet
diff --git a/bare-metal/flatcar-linux/kubernetes/worker/matchbox.tf b/bare-metal/flatcar-linux/kubernetes/worker/matchbox.tf
index 37930d62..f0dd75a7 100644
--- a/bare-metal/flatcar-linux/kubernetes/worker/matchbox.tf
+++ b/bare-metal/flatcar-linux/kubernetes/worker/matchbox.tf
@@ -81,6 +81,7 @@ data "ct_config" "worker" {
     cluster_domain_suffix  = var.cluster_domain_suffix
     node_labels            = join(",", var.node_labels)
     node_taints            = join(",", var.node_taints)
+    node_devices           = var.node_devices
   })
   strict   = true
   snippets = var.snippets
diff --git a/bare-metal/flatcar-linux/kubernetes/workers.tf b/bare-metal/flatcar-linux/kubernetes/workers.tf
index 746e48c5..09d1e0d7 100644
--- a/bare-metal/flatcar-linux/kubernetes/workers.tf
+++ b/bare-metal/flatcar-linux/kubernetes/workers.tf
@@ -22,6 +22,7 @@ module "workers" {
   node_labels           = lookup(var.worker_node_labels, var.workers[count.index].name, [])
   node_taints           = lookup(var.worker_node_taints, var.workers[count.index].name, [])
   snippets              = lookup(var.snippets, var.workers[count.index].name, [])
+  node_devices          = lookup(var.worker_bind_devices, var.workers[count.index].name, [])
 
   # optional
   download_protocol = var.download_protocol