diff --git a/CHANGES.md b/CHANGES.md index fe1d344e..5d1e7f92 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -6,6 +6,11 @@ Notable changes between versions. * Update Calico from v3.7.3 to [v3.7.4](https://docs.projectcalico.org/v3.7/release-notes/) +#### Google Cloud + +* Allow controller nodes to span more than 3 zones if available in a region ([#504](https://github.com/poseidon/typhoon/pull/504)) +* Eliminate extraneous controller instance groups in single-controller clusters ([#504](https://github.com/poseidon/typhoon/pull/504)) + #### Addons * Update Grafana from v6.2.4 to v6.2.5 diff --git a/google-cloud/container-linux/kubernetes/apiserver.tf b/google-cloud/container-linux/kubernetes/apiserver.tf index c6080f9c..62809a9e 100644 --- a/google-cloud/container-linux/kubernetes/apiserver.tf +++ b/google-cloud/container-linux/kubernetes/apiserver.tf @@ -45,16 +45,11 @@ resource "google_compute_backend_service" "apiserver" { timeout_sec = "300" # controller(s) spread across zonal instance groups - backend { - group = google_compute_instance_group.controllers[0].self_link - } - - backend { - group = google_compute_instance_group.controllers[1].self_link - } - - backend { - group = google_compute_instance_group.controllers[2].self_link + dynamic "backend" { + for_each = google_compute_instance_group.controllers + content { + group = backend.value.self_link + } } health_checks = [google_compute_health_check.apiserver.self_link] @@ -64,11 +59,7 @@ resource "google_compute_backend_service" "apiserver" { resource "google_compute_instance_group" "controllers" { count = length(local.zones) - name = format( - "%s-controllers-%s", - var.cluster_name, - element(local.zones, count.index), - ) + name = format("%s-controllers-%s", var.cluster_name, element(local.zones, count.index)) zone = element(local.zones, count.index) named_port { diff --git a/google-cloud/container-linux/kubernetes/controllers.tf b/google-cloud/container-linux/kubernetes/controllers.tf index 2ba068c7..06a921a6 100644 --- a/google-cloud/container-linux/kubernetes/controllers.tf +++ b/google-cloud/container-linux/kubernetes/controllers.tf @@ -20,9 +20,7 @@ data "google_compute_zones" "all" { } locals { - # TCP proxy load balancers require a fixed number of zonal backends. Spread - # controllers over up to 3 zones, since all GCP regions have at least 3. - zones = slice(data.google_compute_zones.all.names, 0, 3) + zones = data.google_compute_zones.all.names controllers_ipv4_public = google_compute_instance.controllers.*.network_interface.0.access_config.0.nat_ip }