Remove Terraform template provider dependency

* Use Terraform builtin templatefile functionality
* Remove dependency on deprecated Terraform template provider

Rel:

* https://registry.terraform.io/providers/hashicorp/template/2.2.0
* https://github.com/poseidon/terraform-render-bootstrap/pull/293

CHANGES.md

@@ -5,6 +5,7 @@ Notable changes between versions.
 ## Latest
 
 * Update Calico from v3.23.1 to [v3.23.3](https://github.com/projectcalico/calico/releases/tag/v3.23.3)
+* Remove use of deprecated Terraform [template](https://registry.terraform.io/providers/hashicorp/template) provider
 
 ## v1.24.3
 

aws/fedora-coreos/kubernetes/controllers.tf

@@ -23,7 +23,7 @@ resource "aws_instance" "controllers" {
 
   instance_type = var.controller_type
   ami           = var.arch == "arm64" ? data.aws_ami.fedora-coreos-arm[0].image_id : data.aws_ami.fedora-coreos.image_id
-  user_data     = data.ct_config.controller-ignitions.*.rendered[count.index]
+  user_data     = data.ct_config.controllers.*.rendered[count.index]
 
   # storage
   root_block_device {
@@ -46,41 +46,22 @@ resource "aws_instance" "controllers" {
   }
 }
 
-# Controller Ignition configs
+# Fedora CoreOS controllers
-data "ct_config" "controller-ignitions" {
+data "ct_config" "controllers" {
   count = var.controller_count
-  content  = data.template_file.controller-configs.*.rendered[count.index]
+  content = templatefile("${path.module}/fcc/controller.yaml", {
-  strict   = true
-  snippets = var.controller_snippets
-}
-
-# Controller Fedora CoreOS configs
-data "template_file" "controller-configs" {
-  count = var.controller_count
-
-  template = file("${path.module}/fcc/controller.yaml")
-
-  vars = {
     # Cannot use cyclic dependencies on controllers or their DNS records
     etcd_name   = "etcd${count.index}"
     etcd_domain = "${var.cluster_name}-etcd${count.index}.${var.dns_zone}"
     # etcd0=https://cluster-etcd0.example.com,etcd1=https://cluster-etcd1.example.com,...
-    etcd_initial_cluster   = join(",", data.template_file.etcds.*.rendered)
+    etcd_initial_cluster = join(",", [
+      for i in range(var.controller_count) : "etcd${i}=https://${var.cluster_name}-etcd${i}.${var.dns_zone}:2380"
+    ])
     kubeconfig             = indent(10, module.bootstrap.kubeconfig-kubelet)
     ssh_authorized_key     = var.ssh_authorized_key
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
-  }
+  })
+  strict   = true
+  snippets = var.controller_snippets
 }
-
-data "template_file" "etcds" {
-  count    = var.controller_count
-  template = "etcd$${index}=https://$${cluster_name}-etcd$${index}.$${dns_zone}:2380"
-
-  vars = {
-    index        = count.index
-    cluster_name = var.cluster_name
-    dns_zone     = var.dns_zone
-  }
-}
-

aws/fedora-coreos/kubernetes/versions.tf

@@ -4,9 +4,7 @@ terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
     aws  = ">= 2.23, <= 5.0"
-    template = "~> 2.2"
     null = ">= 2.1"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"

aws/fedora-coreos/kubernetes/workers/versions.tf

@@ -4,8 +4,6 @@ terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
     aws = ">= 2.23, <= 5.0"
-    template = "~> 2.2"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"

aws/fedora-coreos/kubernetes/workers/workers.tf

@@ -47,7 +47,7 @@ resource "aws_launch_configuration" "worker" {
   spot_price        = var.spot_price > 0 ? var.spot_price : null
   enable_monitoring = false
 
-  user_data = data.ct_config.worker-ignition.rendered
+  user_data = data.ct_config.worker.rendered
 
   # storage
   root_block_device {
@@ -67,24 +67,16 @@ resource "aws_launch_configuration" "worker" {
   }
 }
 
-# Worker Ignition config
+# Fedora CoreOS worker
-data "ct_config" "worker-ignition" {
+data "ct_config" "worker" {
-  content  = data.template_file.worker-config.rendered
+  content = templatefile("${path.module}/fcc/worker.yaml", {
-  strict   = true
-  snippets = var.snippets
-}
-
-# Worker Fedora CoreOS config
-data "template_file" "worker-config" {
-  template = file("${path.module}/fcc/worker.yaml")
-
-  vars = {
     kubeconfig             = indent(10, var.kubeconfig)
     ssh_authorized_key     = var.ssh_authorized_key
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
     node_labels            = join(",", var.node_labels)
     node_taints            = join(",", var.node_taints)
-  }
+  })
+  strict   = true
+  snippets = var.snippets
 }
-

aws/flatcar-linux/kubernetes/controllers.tf

@@ -24,7 +24,7 @@ resource "aws_instance" "controllers" {
   instance_type = var.controller_type
 
   ami       = local.ami_id
-  user_data = data.ct_config.controller-ignitions.*.rendered[count.index]
+  user_data = data.ct_config.controllers.*.rendered[count.index]
 
   # storage
   root_block_device {
@@ -47,41 +47,22 @@ resource "aws_instance" "controllers" {
   }
 }
 
-# Controller Ignition configs
+# Flatcar Linux controllers
-data "ct_config" "controller-ignitions" {
+data "ct_config" "controllers" {
   count = var.controller_count
-  content  = data.template_file.controller-configs.*.rendered[count.index]
+  content = templatefile("${path.module}/cl/controller.yaml", {
-  strict   = true
-  snippets = var.controller_snippets
-}
-
-# Controller Container Linux configs
-data "template_file" "controller-configs" {
-  count = var.controller_count
-
-  template = file("${path.module}/cl/controller.yaml")
-
-  vars = {
     # Cannot use cyclic dependencies on controllers or their DNS records
     etcd_name   = "etcd${count.index}"
     etcd_domain = "${var.cluster_name}-etcd${count.index}.${var.dns_zone}"
     # etcd0=https://cluster-etcd0.example.com,etcd1=https://cluster-etcd1.example.com,...
-    etcd_initial_cluster   = join(",", data.template_file.etcds.*.rendered)
+    etcd_initial_cluster = join(",", [
+      for i in range(var.controller_count) : "etcd${i}=https://${var.cluster_name}-etcd${i}.${var.dns_zone}:2380"
+    ])
     kubeconfig             = indent(10, module.bootstrap.kubeconfig-kubelet)
     ssh_authorized_key     = var.ssh_authorized_key
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
-  }
+  })
+  strict   = true
+  snippets = var.controller_snippets
 }
-
-data "template_file" "etcds" {
-  count    = var.controller_count
-  template = "etcd$${index}=https://$${cluster_name}-etcd$${index}.$${dns_zone}:2380"
-
-  vars = {
-    index        = count.index
-    cluster_name = var.cluster_name
-    dns_zone     = var.dns_zone
-  }
-}
-

aws/flatcar-linux/kubernetes/versions.tf

@@ -4,9 +4,7 @@ terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
     aws  = ">= 2.23, <= 5.0"
-    template = "~> 2.2"
     null = ">= 2.1"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"

aws/flatcar-linux/kubernetes/workers/versions.tf

@@ -4,8 +4,6 @@ terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
     aws = ">= 2.23, <= 5.0"
-    template = "~> 2.2"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"

aws/flatcar-linux/kubernetes/workers/workers.tf

@@ -47,7 +47,7 @@ resource "aws_launch_configuration" "worker" {
   spot_price        = var.spot_price > 0 ? var.spot_price : null
   enable_monitoring = false
 
-  user_data = data.ct_config.worker-ignition.rendered
+  user_data = data.ct_config.worker.rendered
 
   # storage
   root_block_device {
@@ -67,24 +67,16 @@ resource "aws_launch_configuration" "worker" {
   }
 }
 
-# Worker Ignition config
+# Flatcar Linux worker
-data "ct_config" "worker-ignition" {
+data "ct_config" "worker" {
-  content  = data.template_file.worker-config.rendered
+  content = templatefile("${path.module}/cl/worker.yaml", {
-  strict   = true
-  snippets = var.snippets
-}
-
-# Worker Container Linux config
-data "template_file" "worker-config" {
-  template = file("${path.module}/cl/worker.yaml")
-
-  vars = {
     kubeconfig             = indent(10, var.kubeconfig)
     ssh_authorized_key     = var.ssh_authorized_key
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
     node_labels            = join(",", var.node_labels)
     node_taints            = join(",", var.node_taints)
-  }
+  })
+  strict   = true
+  snippets = var.snippets
 }
-

azure/fedora-coreos/kubernetes/controllers.tf

@@ -35,7 +35,7 @@ resource "azurerm_linux_virtual_machine" "controllers" {
   availability_set_id = azurerm_availability_set.controllers.id
 
   size        = var.controller_type
-  custom_data = base64encode(data.ct_config.controller-ignitions.*.rendered[count.index])
+  custom_data = base64encode(data.ct_config.controllers.*.rendered[count.index])
 
   # storage
   source_image_id = var.os_image
@@ -111,41 +111,22 @@ resource "azurerm_network_interface_backend_address_pool_association" "controlle
   backend_address_pool_id = azurerm_lb_backend_address_pool.controller.id
 }
 
-# Controller Ignition configs
+# Fedora CoreOS controllers
-data "ct_config" "controller-ignitions" {
+data "ct_config" "controllers" {
   count = var.controller_count
-  content  = data.template_file.controller-configs.*.rendered[count.index]
+  content = templatefile("${path.module}/fcc/controller.yaml", {
-  strict   = true
-  snippets = var.controller_snippets
-}
-
-# Controller Fedora CoreOS configs
-data "template_file" "controller-configs" {
-  count = var.controller_count
-
-  template = file("${path.module}/fcc/controller.yaml")
-
-  vars = {
     # Cannot use cyclic dependencies on controllers or their DNS records
     etcd_name   = "etcd${count.index}"
     etcd_domain = "${var.cluster_name}-etcd${count.index}.${var.dns_zone}"
     # etcd0=https://cluster-etcd0.example.com,etcd1=https://cluster-etcd1.example.com,...
-    etcd_initial_cluster   = join(",", data.template_file.etcds.*.rendered)
+    etcd_initial_cluster = join(",", [
+      for i in range(var.controller_count) : "etcd${i}=https://${var.cluster_name}-etcd${i}.${var.dns_zone}:2380"
+    ])
     kubeconfig             = indent(10, module.bootstrap.kubeconfig-kubelet)
     ssh_authorized_key     = var.ssh_authorized_key
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
-  }
+  })
+  strict   = true
+  snippets = var.controller_snippets
 }
-
-data "template_file" "etcds" {
-  count    = var.controller_count
-  template = "etcd$${index}=https://$${cluster_name}-etcd$${index}.$${dns_zone}:2380"
-
-  vars = {
-    index        = count.index
-    cluster_name = var.cluster_name
-    dns_zone     = var.dns_zone
-  }
-}
-

azure/fedora-coreos/kubernetes/versions.tf

@@ -4,9 +4,7 @@ terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
     azurerm = ">= 2.8, < 4.0"
-    template = "~> 2.2"
     null    = ">= 2.1"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"

azure/fedora-coreos/kubernetes/workers/versions.tf

@@ -4,8 +4,6 @@ terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
     azurerm = ">= 2.8, < 4.0"
-    template = "~> 2.2"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"

azure/fedora-coreos/kubernetes/workers/workers.tf

@@ -9,7 +9,7 @@ resource "azurerm_linux_virtual_machine_scale_set" "workers" {
   # instance name prefix for instances in the set
   computer_name_prefix   = "${var.name}-worker"
   single_placement_group = false
-  custom_data            = base64encode(data.ct_config.worker-ignition.rendered)
+  custom_data            = base64encode(data.ct_config.worker.rendered)
 
   # storage
   source_image_id = var.os_image
@@ -70,24 +70,17 @@ resource "azurerm_monitor_autoscale_setting" "workers" {
   }
 }
 
-# Worker Ignition configs
+# Fedora CoreOS worker
-data "ct_config" "worker-ignition" {
+data "ct_config" "worker" {
-  content  = data.template_file.worker-config.rendered
+  content = templatefile("${path.module}/fcc/worker.yaml", {
-  strict   = true
-  snippets = var.snippets
-}
-
-# Worker Fedora CoreOS configs
-data "template_file" "worker-config" {
-  template = file("${path.module}/fcc/worker.yaml")
-
-  vars = {
     kubeconfig             = indent(10, var.kubeconfig)
     ssh_authorized_key     = var.ssh_authorized_key
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
     node_labels            = join(",", var.node_labels)
     node_taints            = join(",", var.node_taints)
-  }
+  })
+  strict   = true
+  snippets = var.snippets
 }
 

azure/flatcar-linux/kubernetes/controllers.tf

@@ -41,7 +41,7 @@ resource "azurerm_linux_virtual_machine" "controllers" {
   availability_set_id = azurerm_availability_set.controllers.id
 
   size        = var.controller_type
-  custom_data = base64encode(data.ct_config.controller-ignitions.*.rendered[count.index])
+  custom_data = base64encode(data.ct_config.controllers.*.rendered[count.index])
 
   # storage
   os_disk {
@@ -130,41 +130,22 @@ resource "azurerm_network_interface_backend_address_pool_association" "controlle
   backend_address_pool_id = azurerm_lb_backend_address_pool.controller.id
 }
 
-# Controller Ignition configs
+# Flatcar Linux controllers
-data "ct_config" "controller-ignitions" {
+data "ct_config" "controllers" {
   count = var.controller_count
-  content  = data.template_file.controller-configs.*.rendered[count.index]
+  content = templatefile("${path.module}/cl/controller.yaml", {
-  strict   = true
-  snippets = var.controller_snippets
-}
-
-# Controller Container Linux configs
-data "template_file" "controller-configs" {
-  count = var.controller_count
-
-  template = file("${path.module}/cl/controller.yaml")
-
-  vars = {
     # Cannot use cyclic dependencies on controllers or their DNS records
     etcd_name   = "etcd${count.index}"
     etcd_domain = "${var.cluster_name}-etcd${count.index}.${var.dns_zone}"
     # etcd0=https://cluster-etcd0.example.com,etcd1=https://cluster-etcd1.example.com,...
-    etcd_initial_cluster   = join(",", data.template_file.etcds.*.rendered)
+    etcd_initial_cluster = join(",", [
+      for i in range(var.controller_count) : "etcd${i}=https://${var.cluster_name}-etcd${i}.${var.dns_zone}:2380"
+    ])
     kubeconfig             = indent(10, module.bootstrap.kubeconfig-kubelet)
     ssh_authorized_key     = var.ssh_authorized_key
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
-  }
+  })
+  strict   = true
+  snippets = var.controller_snippets
 }
-
-data "template_file" "etcds" {
-  count    = var.controller_count
-  template = "etcd$${index}=https://$${cluster_name}-etcd$${index}.$${dns_zone}:2380"
-
-  vars = {
-    index        = count.index
-    cluster_name = var.cluster_name
-    dns_zone     = var.dns_zone
-  }
-}
-

azure/flatcar-linux/kubernetes/versions.tf

@@ -4,9 +4,7 @@ terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
     azurerm = ">= 2.8, < 4.0"
-    template = "~> 2.2"
     null    = ">= 2.1"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"

azure/flatcar-linux/kubernetes/workers/versions.tf

@@ -4,8 +4,6 @@ terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
     azurerm = ">= 2.8, < 4.0"
-    template = "~> 2.2"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"

azure/flatcar-linux/kubernetes/workers/workers.tf

@@ -14,7 +14,7 @@ resource "azurerm_linux_virtual_machine_scale_set" "workers" {
   # instance name prefix for instances in the set
   computer_name_prefix   = "${var.name}-worker"
   single_placement_group = false
-  custom_data            = base64encode(data.ct_config.worker-ignition.rendered)
+  custom_data            = base64encode(data.ct_config.worker.rendered)
 
   # storage
   os_disk {
@@ -88,24 +88,16 @@ resource "azurerm_monitor_autoscale_setting" "workers" {
   }
 }
 
-# Worker Ignition configs
+# Flatcar Linux worker
-data "ct_config" "worker-ignition" {
+data "ct_config" "worker" {
-  content  = data.template_file.worker-config.rendered
+  content = templatefile("${path.module}/cl/worker.yaml", {
-  strict   = true
-  snippets = var.snippets
-}
-
-# Worker Container Linux configs
-data "template_file" "worker-config" {
-  template = file("${path.module}/cl/worker.yaml")
-
-  vars = {
     kubeconfig             = indent(10, var.kubeconfig)
     ssh_authorized_key     = var.ssh_authorized_key
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
     node_labels            = join(",", var.node_labels)
     node_taints            = join(",", var.node_taints)
-  }
+  })
+  strict   = true
+  snippets = var.snippets
 }
-

bare-metal/fedora-coreos/kubernetes/profiles.tf

@@ -38,29 +38,22 @@ resource "matchbox_profile" "controllers" {
   initrd = local.initrd
   args   = concat(local.args, var.kernel_args)
 
-  raw_ignition = data.ct_config.controller-ignitions.*.rendered[count.index]
+  raw_ignition = data.ct_config.controllers.*.rendered[count.index]
 }
 
-data "ct_config" "controller-ignitions" {
+# Fedora CoreOS controllers
-  count = length(var.controllers)
+data "ct_config" "controllers" {
-
+  count = var.controller_count
-  content  = data.template_file.controller-configs.*.rendered[count.index]
+  content = templatefile("${path.module}/fcc/controller.yaml", {
-  strict   = true
-  snippets = lookup(var.snippets, var.controllers.*.name[count.index], [])
-}
-
-data "template_file" "controller-configs" {
-  count = length(var.controllers)
-
-  template = file("${path.module}/fcc/controller.yaml")
-  vars = {
     domain_name            = var.controllers.*.domain[count.index]
     etcd_name              = var.controllers.*.name[count.index]
     etcd_initial_cluster   = join(",", formatlist("%s=https://%s:2380", var.controllers.*.name, var.controllers.*.domain))
     cluster_dns_service_ip = module.bootstrap.cluster_dns_service_ip
     cluster_domain_suffix  = var.cluster_domain_suffix
     ssh_authorized_key     = var.ssh_authorized_key
-  }
+  })
+  strict   = true
+  snippets = lookup(var.snippets, var.controllers.*.name[count.index], [])
 }
 
 // Fedora CoreOS worker profile
@@ -72,28 +65,20 @@ resource "matchbox_profile" "workers" {
   initrd = local.initrd
   args   = concat(local.args, var.kernel_args)
 
-  raw_ignition = data.ct_config.worker-ignitions.*.rendered[count.index]
+  raw_ignition = data.ct_config.workers.*.rendered[count.index]
 }
 
-data "ct_config" "worker-ignitions" {
+# Fedora CoreOS workers
+data "ct_config" "workers" {
   count = length(var.workers)
-
+  content = templatefile("${path.module}/fcc/worker.yaml", {
-  content  = data.template_file.worker-configs.*.rendered[count.index]
-  strict   = true
-  snippets = lookup(var.snippets, var.workers.*.name[count.index], [])
-}
-
-data "template_file" "worker-configs" {
-  count = length(var.workers)
-
-  template = file("${path.module}/fcc/worker.yaml")
-  vars = {
     domain_name            = var.workers.*.domain[count.index]
     cluster_dns_service_ip = module.bootstrap.cluster_dns_service_ip
     cluster_domain_suffix  = var.cluster_domain_suffix
     ssh_authorized_key     = var.ssh_authorized_key
     node_labels            = join(",", lookup(var.worker_node_labels, var.workers.*.name[count.index], []))
     node_taints            = join(",", lookup(var.worker_node_taints, var.workers.*.name[count.index], []))
-  }
+  })
+  strict   = true
+  snippets = lookup(var.snippets, var.workers.*.name[count.index], [])
 }
-

bare-metal/fedora-coreos/kubernetes/versions.tf

@@ -3,14 +3,11 @@
 terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
-    template = "~> 2.2"
     null = ">= 2.1"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"
     }
-
     matchbox = {
       source  = "poseidon/matchbox"
       version = "~> 0.5.0"

bare-metal/flatcar-linux/kubernetes/profiles.tf

@@ -83,56 +83,42 @@ data "template_file" "cached-install-configs" {
 resource "matchbox_profile" "controllers" {
   count        = length(var.controllers)
   name         = format("%s-controller-%s", var.cluster_name, var.controllers.*.name[count.index])
-  raw_ignition = data.ct_config.controller-ignitions.*.rendered[count.index]
+  raw_ignition = data.ct_config.controllers.*.rendered[count.index]
 }
 
-data "ct_config" "controller-ignitions" {
+# Flatcar Linux controllers
-  count    = length(var.controllers)
+data "ct_config" "controllers" {
-  content  = data.template_file.controller-configs.*.rendered[count.index]
+  count = var.controller_count
-  strict   = true
+  content = templatefile("${path.module}/cl/controller.yaml", {
-  snippets = lookup(var.snippets, var.controllers.*.name[count.index], [])
-}
-
-data "template_file" "controller-configs" {
-  count = length(var.controllers)
-
-  template = file("${path.module}/cl/controller.yaml")
-
-  vars = {
     domain_name            = var.controllers.*.domain[count.index]
     etcd_name              = var.controllers.*.name[count.index]
     etcd_initial_cluster   = join(",", formatlist("%s=https://%s:2380", var.controllers.*.name, var.controllers.*.domain))
     cluster_dns_service_ip = module.bootstrap.cluster_dns_service_ip
     cluster_domain_suffix  = var.cluster_domain_suffix
     ssh_authorized_key     = var.ssh_authorized_key
-  }
+  })
+  strict   = true
+  snippets = lookup(var.snippets, var.controllers.*.name[count.index], [])
 }
 
 // Kubernetes Worker profiles
 resource "matchbox_profile" "workers" {
   count        = length(var.workers)
   name         = format("%s-worker-%s", var.cluster_name, var.workers.*.name[count.index])
-  raw_ignition = data.ct_config.worker-ignitions.*.rendered[count.index]
+  raw_ignition = data.ct_config.workers.*.rendered[count.index]
 }
 
-data "ct_config" "worker-ignitions" {
+# Flatcar Linux workers
+data "ct_config" "workers" {
   count = length(var.workers)
-  content  = data.template_file.worker-configs.*.rendered[count.index]
+  content = templatefile("${path.module}/cl/worker.yaml", {
-  strict   = true
-  snippets = lookup(var.snippets, var.workers.*.name[count.index], [])
-}
-
-data "template_file" "worker-configs" {
-  count = length(var.workers)
-
-  template = file("${path.module}/cl/worker.yaml")
-
-  vars = {
     domain_name            = var.workers.*.domain[count.index]
     cluster_dns_service_ip = module.bootstrap.cluster_dns_service_ip
     cluster_domain_suffix  = var.cluster_domain_suffix
     ssh_authorized_key     = var.ssh_authorized_key
     node_labels            = join(",", lookup(var.worker_node_labels, var.workers.*.name[count.index], []))
     node_taints            = join(",", lookup(var.worker_node_taints, var.workers.*.name[count.index], []))
-  }
+  })
+  strict   = true
+  snippets = lookup(var.snippets, var.workers.*.name[count.index], [])
 }

bare-metal/flatcar-linux/kubernetes/versions.tf

@@ -3,14 +3,11 @@
 terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
-    template = "~> 2.2"
     null = ">= 2.1"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"
     }
-
     matchbox = {
       source  = "poseidon/matchbox"
       version = "~> 0.5.0"

digital-ocean/fedora-coreos/kubernetes/controllers.tf

@@ -45,7 +45,7 @@ resource "digitalocean_droplet" "controllers" {
   # TODO: Only official DigitalOcean images support IPv6
   ipv6 = false
 
-  user_data = data.ct_config.controller-ignitions.*.rendered[count.index]
+  user_data = data.ct_config.controllers.*.rendered[count.index]
   ssh_keys  = var.ssh_fingerprints
 
   tags = [
@@ -62,39 +62,20 @@ resource "digitalocean_tag" "controllers" {
   name = "${var.cluster_name}-controller"
 }
 
-# Controller Ignition configs
+# Fedora CoreOS controllers
-data "ct_config" "controller-ignitions" {
+data "ct_config" "controllers" {
   count = var.controller_count
-  content  = data.template_file.controller-configs.*.rendered[count.index]
+  content = templatefile("${path.module}/fcc/controller.yaml", {
-  strict   = true
-  snippets = var.controller_snippets
-}
-
-# Controller Fedora CoreOS configs
-data "template_file" "controller-configs" {
-  count = var.controller_count
-
-  template = file("${path.module}/fcc/controller.yaml")
-
-  vars = {
     # Cannot use cyclic dependencies on controllers or their DNS records
     etcd_name   = "etcd${count.index}"
     etcd_domain = "${var.cluster_name}-etcd${count.index}.${var.dns_zone}"
     # etcd0=https://cluster-etcd0.example.com,etcd1=https://cluster-etcd1.example.com,...
-    etcd_initial_cluster   = join(",", data.template_file.etcds.*.rendered)
+    etcd_initial_cluster = join(",", [
+      for i in range(var.controller_count) : "etcd${i}=https://${var.cluster_name}-etcd${i}.${var.dns_zone}:2380"
+    ])
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
-  }
+  })
+  strict   = true
+  snippets = var.controller_snippets
 }
-
-data "template_file" "etcds" {
-  count    = var.controller_count
-  template = "etcd$${index}=https://$${cluster_name}-etcd$${index}.$${dns_zone}:2380"
-
-  vars = {
-    index        = count.index
-    cluster_name = var.cluster_name
-    dns_zone     = var.dns_zone
-  }
-}
-

digital-ocean/fedora-coreos/kubernetes/versions.tf

@@ -3,14 +3,11 @@
 terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
-    template = "~> 2.2"
     null = ">= 2.1"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"
     }
-
     digitalocean = {
       source  = "digitalocean/digitalocean"
       version = ">= 2.12, < 3.0"

digital-ocean/fedora-coreos/kubernetes/workers.tf

@@ -41,7 +41,7 @@ resource "digitalocean_droplet" "workers" {
   # TODO: Only official DigitalOcean images support IPv6
   ipv6 = false
 
-  user_data = data.ct_config.worker-ignition.rendered
+  user_data = data.ct_config.worker.rendered
   ssh_keys  = var.ssh_fingerprints
 
   tags = [
@@ -58,20 +58,12 @@ resource "digitalocean_tag" "workers" {
   name = "${var.cluster_name}-worker"
 }
 
-# Worker Ignition config
+# Fedora CoreOS worker
-data "ct_config" "worker-ignition" {
+data "ct_config" "worker" {
-  content  = data.template_file.worker-config.rendered
+  content = templatefile("${path.module}/fcc/worker.yaml", {
+    cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
+    cluster_domain_suffix  = var.cluster_domain_suffix
+  })
   strict   = true
   snippets = var.worker_snippets
 }
-
-# Worker Fedora CoreOS config
-data "template_file" "worker-config" {
-  template = file("${path.module}/fcc/worker.yaml")
-
-  vars = {
-    cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
-    cluster_domain_suffix  = var.cluster_domain_suffix
-  }
-}
-

digital-ocean/flatcar-linux/kubernetes/controllers.tf

@@ -50,7 +50,7 @@ resource "digitalocean_droplet" "controllers" {
   # TODO: Only official DigitalOcean images support IPv6
   ipv6 = false
 
-  user_data = data.ct_config.controller-ignitions.*.rendered[count.index]
+  user_data = data.ct_config.controllers.*.rendered[count.index]
   ssh_keys  = var.ssh_fingerprints
 
   tags = [
@@ -67,39 +67,20 @@ resource "digitalocean_tag" "controllers" {
   name = "${var.cluster_name}-controller"
 }
 
-# Controller Ignition configs
+# Flatcar Linux controllers
-data "ct_config" "controller-ignitions" {
+data "ct_config" "controllers" {
   count = var.controller_count
-  content  = data.template_file.controller-configs.*.rendered[count.index]
+  content = templatefile("${path.module}/cl/controller.yaml", {
-  strict   = true
-  snippets = var.controller_snippets
-}
-
-# Controller Container Linux configs
-data "template_file" "controller-configs" {
-  count = var.controller_count
-
-  template = file("${path.module}/cl/controller.yaml")
-
-  vars = {
     # Cannot use cyclic dependencies on controllers or their DNS records
     etcd_name   = "etcd${count.index}"
     etcd_domain = "${var.cluster_name}-etcd${count.index}.${var.dns_zone}"
     # etcd0=https://cluster-etcd0.example.com,etcd1=https://cluster-etcd1.example.com,...
-    etcd_initial_cluster   = join(",", data.template_file.etcds.*.rendered)
+    etcd_initial_cluster = join(",", [
+      for i in range(var.controller_count) : "etcd${i}=https://${var.cluster_name}-etcd${i}.${var.dns_zone}:2380"
+    ])
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
-  }
+  })
+  strict   = true
+  snippets = var.controller_snippets
 }
-
-data "template_file" "etcds" {
-  count    = var.controller_count
-  template = "etcd$${index}=https://$${cluster_name}-etcd$${index}.$${dns_zone}:2380"
-
-  vars = {
-    index        = count.index
-    cluster_name = var.cluster_name
-    dns_zone     = var.dns_zone
-  }
-}
-

digital-ocean/flatcar-linux/kubernetes/versions.tf

@@ -3,14 +3,11 @@
 terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
-    template = "~> 2.2"
     null = ">= 2.1"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"
     }
-
     digitalocean = {
       source  = "digitalocean/digitalocean"
       version = ">= 2.12, < 3.0"

digital-ocean/flatcar-linux/kubernetes/workers.tf

@@ -39,7 +39,7 @@ resource "digitalocean_droplet" "workers" {
   # only official DigitalOcean images support IPv6
   ipv6 = local.is_official_image
 
-  user_data = data.ct_config.worker-ignition.rendered
+  user_data = data.ct_config.worker.rendered
   ssh_keys  = var.ssh_fingerprints
 
   tags = [
@@ -56,20 +56,12 @@ resource "digitalocean_tag" "workers" {
   name = "${var.cluster_name}-worker"
 }
 
-# Worker Ignition config
+# Flatcar Linux worker
-data "ct_config" "worker-ignition" {
+data "ct_config" "worker" {
-  content  = data.template_file.worker-config.rendered
+  content = templatefile("${path.module}/cl/worker.yaml", {
+    cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
+    cluster_domain_suffix  = var.cluster_domain_suffix
+  })
   strict   = true
   snippets = var.worker_snippets
 }
-
-# Worker Container Linux config
-data "template_file" "worker-config" {
-  template = file("${path.module}/cl/worker.yaml")
-
-  vars = {
-    cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
-    cluster_domain_suffix  = var.cluster_domain_suffix
-  }
-}
-

google-cloud/fedora-coreos/kubernetes/controllers.tf

@@ -35,7 +35,7 @@ resource "google_compute_instance" "controllers" {
   machine_type = var.controller_type
 
   metadata = {
-    user-data = data.ct_config.controller-ignitions.*.rendered[count.index]
+    user-data = data.ct_config.controllers.*.rendered[count.index]
   }
 
   boot_disk {
@@ -66,41 +66,22 @@ resource "google_compute_instance" "controllers" {
   }
 }
 
-# Controller Ignition configs
+# Fedora CoreOS controllers
-data "ct_config" "controller-ignitions" {
+data "ct_config" "controllers" {
   count = var.controller_count
-  content  = data.template_file.controller-configs.*.rendered[count.index]
+  content = templatefile("${path.module}/fcc/controller.yaml", {
-  strict   = true
-  snippets = var.controller_snippets
-}
-
-# Controller Fedora CoreOS configs
-data "template_file" "controller-configs" {
-  count = var.controller_count
-
-  template = file("${path.module}/fcc/controller.yaml")
-
-  vars = {
     # Cannot use cyclic dependencies on controllers or their DNS records
     etcd_name   = "etcd${count.index}"
     etcd_domain = "${var.cluster_name}-etcd${count.index}.${var.dns_zone}"
     # etcd0=https://cluster-etcd0.example.com,etcd1=https://cluster-etcd1.example.com,...
-    etcd_initial_cluster   = join(",", data.template_file.etcds.*.rendered)
+    etcd_initial_cluster = join(",", [
+      for i in range(var.controller_count) : "etcd${i}=https://${var.cluster_name}-etcd${i}.${var.dns_zone}:2380"
+    ])
     kubeconfig             = indent(10, module.bootstrap.kubeconfig-kubelet)
     ssh_authorized_key     = var.ssh_authorized_key
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
-  }
+  })
+  strict   = true
+  snippets = var.controller_snippets
 }
-
-data "template_file" "etcds" {
-  count    = var.controller_count
-  template = "etcd$${index}=https://$${cluster_name}-etcd$${index}.$${dns_zone}:2380"
-
-  vars = {
-    index        = count.index
-    cluster_name = var.cluster_name
-    dns_zone     = var.dns_zone
-  }
-}
-

google-cloud/fedora-coreos/kubernetes/versions.tf

@@ -4,9 +4,7 @@ terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
     google = ">= 2.19, < 5.0"
-    template = "~> 2.2"
     null   = ">= 2.1"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"

google-cloud/fedora-coreos/kubernetes/workers/versions.tf

@@ -4,8 +4,6 @@ terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
     google = ">= 2.19, < 5.0"
-    template = "~> 2.2"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"

google-cloud/fedora-coreos/kubernetes/workers/workers.tf

@@ -32,7 +32,7 @@ resource "google_compute_instance_template" "worker" {
   machine_type = var.machine_type
 
   metadata = {
-    user-data = data.ct_config.worker-ignition.rendered
+    user-data = data.ct_config.worker.rendered
   }
 
   scheduling {
@@ -72,24 +72,16 @@ resource "google_compute_instance_template" "worker" {
   }
 }
 
-# Worker Ignition config
+# Fedora CoreOS worker
-data "ct_config" "worker-ignition" {
+data "ct_config" "worker" {
-  content  = data.template_file.worker-config.rendered
+  content = templatefile("${path.module}/fcc/worker.yaml", {
-  strict   = true
-  snippets = var.snippets
-}
-
-# Worker Fedora CoreOS config
-data "template_file" "worker-config" {
-  template = file("${path.module}/fcc/worker.yaml")
-
-  vars = {
     kubeconfig             = indent(10, var.kubeconfig)
     ssh_authorized_key     = var.ssh_authorized_key
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
     node_labels            = join(",", var.node_labels)
     node_taints            = join(",", var.node_taints)
-  }
+  })
+  strict   = true
+  snippets = var.snippets
 }
-

google-cloud/flatcar-linux/kubernetes/controllers.tf

@@ -35,7 +35,7 @@ resource "google_compute_instance" "controllers" {
   machine_type = var.controller_type
 
   metadata = {
-    user-data = data.ct_config.controller-ignitions.*.rendered[count.index]
+    user-data = data.ct_config.controllers.*.rendered[count.index]
   }
 
   boot_disk {
@@ -66,41 +66,22 @@ resource "google_compute_instance" "controllers" {
   }
 }
 
-# Controller Ignition configs
+# Flatcar Linux controllers
-data "ct_config" "controller-ignitions" {
+data "ct_config" "controllers" {
   count = var.controller_count
-  content  = data.template_file.controller-configs.*.rendered[count.index]
+  content = templatefile("${path.module}/cl/controller.yaml", {
-  strict   = true
-  snippets = var.controller_snippets
-}
-
-# Controller Container Linux configs
-data "template_file" "controller-configs" {
-  count = var.controller_count
-
-  template = file("${path.module}/cl/controller.yaml")
-
-  vars = {
     # Cannot use cyclic dependencies on controllers or their DNS records
     etcd_name   = "etcd${count.index}"
     etcd_domain = "${var.cluster_name}-etcd${count.index}.${var.dns_zone}"
     # etcd0=https://cluster-etcd0.example.com,etcd1=https://cluster-etcd1.example.com,...
-    etcd_initial_cluster   = join(",", data.template_file.etcds.*.rendered)
+    etcd_initial_cluster = join(",", [
+      for i in range(var.controller_count) : "etcd${i}=https://${var.cluster_name}-etcd${i}.${var.dns_zone}:2380"
+    ])
     kubeconfig             = indent(10, module.bootstrap.kubeconfig-kubelet)
     ssh_authorized_key     = var.ssh_authorized_key
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
-  }
+  })
+  strict   = true
+  snippets = var.controller_snippets
 }
-
-data "template_file" "etcds" {
-  count    = var.controller_count
-  template = "etcd$${index}=https://$${cluster_name}-etcd$${index}.$${dns_zone}:2380"
-
-  vars = {
-    index        = count.index
-    cluster_name = var.cluster_name
-    dns_zone     = var.dns_zone
-  }
-}
-

google-cloud/flatcar-linux/kubernetes/image.tf

@@ -1,6 +1,6 @@
 # Flatcar Linux most recent image from channel
 data "google_compute_image" "flatcar-linux" {
   project = "kinvolk-public"
-  family  = "${var.os_image}"
+  family  = var.os_image
 }
 

google-cloud/flatcar-linux/kubernetes/versions.tf

@@ -4,9 +4,7 @@ terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
     google = ">= 2.19, < 5.0"
-    template = "~> 2.2"
     null   = ">= 2.1"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"

google-cloud/flatcar-linux/kubernetes/workers/image.tf

@@ -1,5 +1,5 @@
 # Flatcar Linux most recent image from channel
 data "google_compute_image" "flatcar-linux" {
   project = "kinvolk-public"
-  family  = "${var.os_image}"
+  family  = var.os_image
 }

google-cloud/flatcar-linux/kubernetes/workers/versions.tf

@@ -4,8 +4,6 @@ terraform {
   required_version = ">= 0.13.0, < 2.0.0"
   required_providers {
     google = ">= 2.19, < 5.0"
-    template = "~> 2.2"
-
     ct = {
       source  = "poseidon/ct"
       version = "~> 0.9"

google-cloud/flatcar-linux/kubernetes/workers/workers.tf

@@ -32,7 +32,7 @@ resource "google_compute_instance_template" "worker" {
   machine_type = var.machine_type
 
   metadata = {
-    user-data = data.ct_config.worker-ignition.rendered
+    user-data = data.ct_config.worker.rendered
   }
 
   scheduling {
@@ -69,24 +69,16 @@ resource "google_compute_instance_template" "worker" {
   }
 }
 
-# Worker Ignition config
+# Flatcar Linux worker
-data "ct_config" "worker-ignition" {
+data "ct_config" "worker" {
-  content  = data.template_file.worker-config.rendered
+  content = templatefile("${path.module}/cl/worker.yaml", {
-  strict   = true
-  snippets = var.snippets
-}
-
-# Worker Container Linux config
-data "template_file" "worker-config" {
-  template = file("${path.module}/cl/worker.yaml")
-
-  vars = {
     kubeconfig             = indent(10, var.kubeconfig)
     ssh_authorized_key     = var.ssh_authorized_key
     cluster_dns_service_ip = cidrhost(var.service_cidr, 10)
     cluster_domain_suffix  = var.cluster_domain_suffix
     node_labels            = join(",", var.node_labels)
     node_taints            = join(",", var.node_taints)
-  }
+  })
+  strict   = true
+  snippets = var.snippets
 }
-