CadolesKube/sso-kustom
14
0
Fork 0
Code Issues 17 Pull Requests 4 Projects Releases Wiki Activity

Modification des deployements pour le passage à Caddy #36

Merged
wpetit merged 4 commits from cmsassot into develop 2024-04-04 17:09:47 +02:00
Conversation 0 Commits 4 Files Changed 6 +148 -96
cmsassot commented 2024-03-26 11:47:27 +01:00
Member
Copy Link

CNOUS/mse#3422

  • Modification du deployment hydra-sql
  • Modification du deployment hydra-oidc
  • Modification du deployment hydra-dispatcher
  • Modification du nom des conteneurs : XXXX-XXX-nginx en XXXX-XXX-caddy
    Ajout des directives suivantes sur chaque conteneur :
          securityContext:
            runAsNonRoot: true
            runAsGroup: 1000
            runAsUser: 1000
https://forge.cadoles.com/CNOUS/mse/issues/3422 - Modification du deployment `hydra-sql` - Modification du deployment `hydra-oidc` - Modification du deployment `hydra-dispatcher` - Modification du nom des conteneurs : `XXXX-XXX-nginx` en `XXXX-XXX-caddy` Ajout des directives suivantes sur chaque conteneur : ``` securityContext: runAsNonRoot: true runAsGroup: 1000 runAsUser: 1000 ```
cmsassot added 7 commits 2024-03-26 11:47:27 +01:00
cmsassot force-pushed cmsassot from f8b5caa53a to 80a8adf92d 2024-03-26 11:51:18 +01:00 Compare
cmsassot force-pushed cmsassot from 80a8adf92d to 4e7799c128 2024-03-27 14:10:35 +01:00 Compare
cmsassot changed title from WIP: cmsassot to WIP: Modification des deployements pour le passage à Caddy 2024-03-27 14:12:15 +01:00
cmsassot force-pushed cmsassot from 4e7799c128 to 6e5787cee7 2024-04-02 15:43:17 +02:00 Compare
cmsassot added 1 commit 2024-04-02 16:07:33 +02:00
cmsassot force-pushed cmsassot from e3811fe666 to e2698673a0 2024-04-03 09:13:14 +02:00 Compare
cmsassot added 1 commit 2024-04-03 09:35:52 +02:00
cmsassot force-pushed cmsassot from eca5c86037 to ea9a27bb00 2024-04-03 09:45:59 +02:00 Compare
pcaseiro requested changes 2024-04-03 11:12:45 +02:00
pcaseiro left a comment
Owner
Copy Link

Attention, l'indentation n'est pas en phase avec les usages sur ce projet.

Attention, l'indentation n'est pas en phase avec les usages sur ce projet.
components/hydra-oidc/resources/hydra-oidc-service.yaml Outdated
@ -8,3 +8,2 @@
ports:
- name: hydra-oidc
port: 8080
- name: hydra-oidc
pcaseiro commented 2024-04-03 11:08:37 +02:00
Owner
Copy Link

L'indentation n'est pas bonne, les listes doivent commencer au même niveau que la première lettre du "parent".

spec:
  ports:
  - name: toto
     ...
L'indentation n'est pas bonne, les listes doivent commencer au même niveau que la première lettre du "parent". ``` spec: ports: - name: toto ... ```
wpetit marked this conversation as resolved
resources/hydra-dispatcher/resources/hydra-dispatcher-deployment.yaml Outdated
@ -84,2 +94,3 @@
value: "/app/public/"
ports:
- containerPort: 8080
- containerPort: 80
pcaseiro commented 2024-04-03 11:11:01 +02:00
Owner
Copy Link

Le conteneur étant "non root", je penses qu'il n'est pas possible d'écouter sur le port 80, je n'ai pas encore testé mais il semble que ce puisse être un problème.

Le port doit avoir un "nom", c'est plus simple pour le référencer ailleurs (dans les services par exemple).

Le conteneur étant "non root", je penses qu'il n'est pas possible d'écouter sur le port 80, je n'ai pas encore testé mais il semble que ce puisse être un problème. Le port doit avoir un "nom", c'est plus simple pour le référencer ailleurs (dans les services par exemple).
wpetit marked this conversation as resolved
cmsassot added 1 commit 2024-04-03 14:43:03 +02:00
cmsassot force-pushed cmsassot from 92ddaee3e5 to d0a0dc0f3a 2024-04-03 14:48:22 +02:00 Compare
cmsassot force-pushed cmsassot from d0a0dc0f3a to fda2255569 2024-04-03 14:50:45 +02:00 Compare
cmsassot force-pushed cmsassot from fda2255569 to 933ddd7cc1 2024-04-03 14:57:33 +02:00 Compare
cmsassot force-pushed cmsassot from 933ddd7cc1 to df371ae1bb 2024-04-03 15:01:52 +02:00 Compare
cmsassot force-pushed cmsassot from df371ae1bb to ec36af1bf5 2024-04-03 15:11:27 +02:00 Compare
cmsassot force-pushed cmsassot from ec36af1bf5 to 165fa89b67 2024-04-04 08:37:16 +02:00 Compare
cmsassot force-pushed cmsassot from 165fa89b67 to 496a894535 2024-04-04 09:54:35 +02:00 Compare
cmsassot force-pushed cmsassot from 496a894535 to b403676d95 2024-04-04 10:02:24 +02:00 Compare
cmsassot force-pushed cmsassot from b403676d95 to 6a02f1ed0c 2024-04-04 10:12:48 +02:00 Compare
cmsassot force-pushed cmsassot from 6a02f1ed0c to 0af7fa545e 2024-04-04 10:22:53 +02:00 Compare
cmsassot force-pushed cmsassot from 0af7fa545e to 400d9633f4 2024-04-04 10:29:48 +02:00 Compare
cmsassot force-pushed cmsassot from 400d9633f4 to 546f31b2dd 2024-04-04 11:34:24 +02:00 Compare
wpetit changed title from WIP: Modification des deployements pour le passage à Caddy to Modification des deployements pour le passage à Caddy 2024-04-04 17:08:55 +02:00
wpetit approved these changes 2024-04-04 17:09:05 +02:00
wpetit merged commit bd317f937f into develop 2024-04-04 17:09:47 +02:00
wpetit deleted branch cmsassot 2024-04-04 17:09:48 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
pcaseiro
wpetit
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: CadolesKube/sso-kustom#36
No description provided.
Delete Branch "cmsassot"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?