CadolesKube/hydra-maester
7
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: treat Hydra 401 response like a 404 (#50)

Browse Source 
Fixes #49
This commit is contained in:
Jeffrey Hutchins 2020-02-27 05:21:30 -07:00 committed by GitHub
parent f26a820fe9
commit c56ba7d6b6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hydra/client.go
View File

@ -33,7 +33,7 @@ func (c *Client) GetOAuth2Client(id string) (*OAuth2ClientJSON, bool, error) {
switch resp.StatusCode { switch resp.StatusCode {
case http.StatusOK: case http.StatusOK:
return jsonClient, true, nil return jsonClient, true, nil
case http.StatusNotFound: case http.StatusNotFound, http.StatusUnauthorized:
return nil, false, nil return nil, false, nil
default: default:
return nil, false, fmt.Errorf("%s %s http request returned unexpected status code %s", req.Method, req.URL.String(), resp.Status) return nil, false, fmt.Errorf("%s %s http request returned unexpected status code %s", req.Method, req.URL.String(), resp.Status)

6
hydra/client_test.go
View File

@ -30,6 +30,7 @@ const (
testClientWithMetadataCreated = `{"client_id":"test-id-21","client_secret":"TmGkvcY7k526","owner":"test-name-21","scope":"some,other,scopes","grant_types":["type2"],"token_endpoint_auth_method":"client_secret_basic","metadata":{"property1":1,"property2":"2"}}` testClientWithMetadataCreated = `{"client_id":"test-id-21","client_secret":"TmGkvcY7k526","owner":"test-name-21","scope":"some,other,scopes","grant_types":["type2"],"token_endpoint_auth_method":"client_secret_basic","metadata":{"property1":1,"property2":"2"}}`
statusNotFoundBody = `{"error":"Not Found","error_description":"Unable to locate the requested resource","status_code":404,"request_id":"id"}` statusNotFoundBody = `{"error":"Not Found","error_description":"Unable to locate the requested resource","status_code":404,"request_id":"id"}`
statusUnauthorizedBody = `{"error":"The request could not be authorized","error_description":"The requested OAuth 2.0 client does not exist or you did not provide the necessary credentials","status_code":401,"request_id":"id"}`
statusConflictBody = `{"error":"Unable to insert or update resource because a resource with that value exists already","error_description":"","status_code":409,"request_id":"id"` statusConflictBody = `{"error":"Unable to insert or update resource because a resource with that value exists already","error_description":"","status_code":409,"request_id":"id"`
statusInternalServerErrorBody = "the server encountered an internal error or misconfiguration and was unable to complete your request" statusInternalServerErrorBody = "the server encountered an internal error or misconfiguration and was unable to complete your request"
) )
@ -77,6 +78,11 @@ func TestCRUD(t *testing.T) {
statusNotFoundBody, statusNotFoundBody,
nil, nil,
}, },
"getting unauthorized request": {
http.StatusUnauthorized,
statusUnauthorizedBody,
nil,
},
"internal server error when requesting": { "internal server error when requesting": {
http.StatusInternalServerError, http.StatusInternalServerError,
statusInternalServerErrorBody, statusInternalServerErrorBody,