comments

README.md

@@ -27,6 +27,7 @@ The project is based on [Kubebuilder](https://github.com/kubernetes-sigs/kubebui
 - kustomize
 - [ginkgo](https://onsi.github.io/ginkgo/) for local integration testing
 - access to K8s environment: minikube or a remote K8s cluster
+- [mockery](https://github.com/vektra/mockery) to generate mocks for testing purposes
 
 
 
@@ -48,4 +49,13 @@ To deploy the controller, edit the value of the ```--hydra-url``` argument in th
 | Name            | Required | Description                  | Default value | Example values                                       |
 |-----------------|----------|------------------------------|---------------|------------------------------------------------------|
 | **hydra-url**   | yes      | ORY Hydra's service address  | -             | ` ory-hydra-admin.ory.svc.cluster.local`             |
-| **hydra-port**  | no       | ORY Hydra's service port     | `4445`        | `4445`                                               |
+| **hydra-port**  | no       | ORY Hydra's service port     | `4445`        | `4445`                                               |
+
+## Development
+
+### Testing
+
+Use mockery to generate mock types that implement existing interfaces. To generate a mock type for an interface, navigate to the directory containing that interface and run this command:
+```
+mockery -name={INTERFACE_NAME}
+```

controllers/oauth2client_controller.go

@@ -107,10 +107,11 @@ func (r *OAuth2ClientReconciler) registerOAuth2Client(ctx context.Context, clien
 			Description: err.Error(),
 		}
 		if updateErr := r.Status().Update(ctx, client); updateErr != nil {
-			return err
+			r.Log.Error(err, fmt.Sprintf("error registring client %s/%s ", client.Name, client.Namespace), "oauth2client", "register")
+			return updateErr
 		}
 
-		return err
+		return nil
 	}
 
 	clientSecret := apiv1.Secret{