From 4c707c5899e593df8378d1ba07221f33fcb87ff6 Mon Sep 17 00:00:00 2001
From: afornerot <afornerot@cadoles.com>
Date: Tue, 16 Mar 2021 10:37:36 +0100
Subject: [PATCH] =?UTF-8?q?mise=20=C3=A0=20plat=20des=20r=C3=A8gles=20de?=
 =?UTF-8?q?=20d=C3=A9sinscription=20(ref=20#235)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../CoreBundle/Controller/GroupController.php  | 11 ++++++++---
 .../Resources/views/Config/list.html.twig      |  2 ++
 .../Resources/views/User/edit.html.twig        | 18 +++++++++++++-----
 tmpl/ninegate-init-01.sql                      |  3 ++-
 4 files changed, 25 insertions(+), 9 deletions(-)

diff --git a/src/ninegate-1.0/src/Cadoles/CoreBundle/Controller/GroupController.php b/src/ninegate-1.0/src/Cadoles/CoreBundle/Controller/GroupController.php
index fe0e6143..b5047643 100644
--- a/src/ninegate-1.0/src/Cadoles/CoreBundle/Controller/GroupController.php
+++ b/src/ninegate-1.0/src/Cadoles/CoreBundle/Controller/GroupController.php
@@ -175,7 +175,7 @@ class GroupController extends Controller
                 if(!$data->getFgall()) $action .="<a href='".$this->generateUrl('cadoles_core_config_group_users', array('id'=>$data->getId()))."'><i class='fa fa-users fa-2x fa-fw'></i></a>";
                 
                 if($data->getFgcanshare())
-                    $action.="<a href='".$this->generateUrl('cadoles_core_'.$access.'_group_statistic', array('id'=>$data->getId()))."'><i class='fa fa-bar-chart-o fa-fw fa-2x'></i></a>";
+                    $action.="<a href='".$this->generateUrl('cadoles_core_'.$access.'_group_statistic', array('id'=>$data->getId()))."'><i class='fa fa-chart-area fa-fw fa-2x'></i></a>";
             }
             else {
                 $fgproprio=($user==$data->getOwner());
@@ -194,11 +194,16 @@ class GroupController extends Controller
                     $action .="<a href='".$this->generateUrl('cadoles_core_'.$access.'_group_users', array('id'=>$data->getId()))."'><i class='fa fa-users fa-2x fa-fw'></i></a>";
                 }
                 else {
-                    $action.="<a href='".$this->generateUrl('cadoles_core_'.$access.'_group_out', array('id'=>$data->getId()))."'><i class='fa fa-sign-out-alt fa-fw fa-2x'></i></a>";
+                    // On ne peut se désinscrire que si le groupe est ouvert et qu'il n'est pas lié à un groupe ldap ou sso
+                    $fgcanleave=true;
+                    if($data->getFgtemplate() or $data->getFgall()) $fgcanleave=false;
+                    elseif(!$data->getFgcanshare() && !$data->getFgopen()) $fgcanleave=false;
+                    elseif($data->getFgcanshare() && !$this->get('session')->get('permunsubscribe') && !$data->getFgopen()) $fgcanleave=false;
+                    if($fgcanleave) $action.="<a href='".$this->generateUrl('cadoles_core_'.$access.'_group_out', array('id'=>$data->getId()))."'><i class='fa fa-sign-out-alt fa-fw fa-2x'></i></a>";
                 }
 
                 if($data->getFgcanshare())
-                    $action.="<a href='".$this->generateUrl('cadoles_core_'.$access.'_group_statistic', array('id'=>$data->getId()))."'><i class='fa fa-bar-chart-o fa-fw fa-2x'></i></a>";
+                    $action.="<a href='".$this->generateUrl('cadoles_core_'.$access.'_group_statistic', array('id'=>$data->getId()))."'><i class='fa fa-chart-area fa-fw fa-2x'></i></a>";
             }
             
 
diff --git a/src/ninegate-1.0/src/Cadoles/CoreBundle/Resources/views/Config/list.html.twig b/src/ninegate-1.0/src/Cadoles/CoreBundle/Resources/views/Config/list.html.twig
index 7a8e0202..be686877 100644
--- a/src/ninegate-1.0/src/Cadoles/CoreBundle/Resources/views/Config/list.html.twig
+++ b/src/ninegate-1.0/src/Cadoles/CoreBundle/Resources/views/Config/list.html.twig
@@ -17,6 +17,7 @@
                         <th width="90px">Action</th>
                         <th width="70px">Ordre</th>
                         <th width="200px">Clé</th>
+                        <th>Description</th>
                         <th>Valeur</th>
                     </tr>
                     </thead>
@@ -38,6 +39,7 @@
                             </td>
                             <td>{{ config.order }}</td>
                             <td>{{ config.id }}</td>
+                            <td>{{ config.help|raw }}</td>
                             <td>
                                 {% if config.type == "boolean" %}
                                     {% if config.value == "0" %}
diff --git a/src/ninegate-1.0/src/Cadoles/CoreBundle/Resources/views/User/edit.html.twig b/src/ninegate-1.0/src/Cadoles/CoreBundle/Resources/views/User/edit.html.twig
index 80d90126..8522fdf1 100755
--- a/src/ninegate-1.0/src/Cadoles/CoreBundle/Resources/views/User/edit.html.twig
+++ b/src/ninegate-1.0/src/Cadoles/CoreBundle/Resources/views/User/edit.html.twig
@@ -182,13 +182,21 @@
                             <tbody>
                             {% for group in user.groups %}
                                 <tr id="linkgroup{{ group.group.id }}">
-                                    {% if access=="config" and not group.group.fgall and group.group.ldapfilter=="" and group.group.attributes ==""  %}
-                                        <td><a style="cursor:pointer" title="Se Désinscrire"><i class="fa fa-sign-out fa-fw" onclick="removeLinkGroup({{ group.group.id }})"></i></a></td>
-                                    {% elseif (group.group.fgopen or group.group.fgcanshare) and group.group.owner!=app.user and not group.group.fgall and group.group.ldapfilter=="" and group.group.attributes =="" %}
+                                    {% set canleave = true %}
+                                    {% if group.group.fgtemplate or group.group.fgall or group.group.owner==user %}
+                                        {% set canleave = false %}
+                                    {% elseif access!="config" %}
+                                        {% if not group.group.fgcanshare and not group.group.fgopen %}
+                                            {% set canleave = false %}
+                                        {% elseif group.group.fgcanshare and not app.session.get('permunsubscribe') and not group.group.fgopen %}
+                                            {% set canleave = false %}
+                                        {% endif %}
+                                    {% endif %}
+
+                                    {% if canleave  %}
                                         <td><a style="cursor:pointer" title="Se Désinscrire"><i class="fa fa-sign-out-alt fa-fw" onclick="removeLinkGroup({{ group.group.id }})"></i></a></td>
                                     {% else %}
-                                    <td>
-                                    </td>                                    
+                                        <td></td>                                    
                                     {% endif %}
                                     
                                     <td>
diff --git a/tmpl/ninegate-init-01.sql b/tmpl/ninegate-init-01.sql
index 2e1a423a..702d2dba 100644
--- a/tmpl/ninegate-init-01.sql
+++ b/tmpl/ninegate-init-01.sql
@@ -120,6 +120,7 @@ INSERT IGNORE INTO `config` (`order`, `visible`, `changeable`, `required`, `type
 %end if
 
 ('500', 1, 1, 1, 'permgroup',		'permgroup',        'ROLE_ANIM',											    '',				'Determine quel rôle aura la permission de créer des groupes de travail'),
-('501', 1, 1, 1, 'permgroup',		'permannu',         'ROLE_USER',											    '',				'Determine quel rôle aura la permission de voir l\'annuaire');
+('501', 1, 1, 1, 'permgroup',		'permannu',         'ROLE_USER',											    '',				'Determine quel rôle aura la permission de voir l\'annuaire'),
+('502', 1, 1, 1, 'boolean',		    'permunsubscribe',  '0',											            '',				'Permettre aux utilisateurs de se désinscrire par eux-mêmes des groupes de travail');