fix code quality, typage, php-csfixer

src/Controller/CustomErrorController.php

@@ -4,12 +4,13 @@ namespace App\Controller;
 
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\ErrorHandler\Exception\FlattenException;
+use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
 
 class CustomErrorController extends AbstractController
 {
     #[Route(path: '/error', name: 'custom_error_controller')]
-    public function show(FlattenException $exception)
+    public function show(FlattenException $exception): Response
     {
         $statusCode = $exception->getStatusCode();
         $message = $exception->getMessage();

src/Controller/LocaleController.php

@@ -4,6 +4,7 @@ namespace App\Controller;
 
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
+use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\Routing\Annotation\Route;
 
@@ -17,7 +18,7 @@ class LocaleController extends AbstractController
     }
 
     #[Route(path: 'locale/{locale?}', name: 'locale_change')]
-    public function changeLocal(?string $locale, Request $request)
+    public function changeLocal(?string $locale, Request $request): RedirectResponse
     {
         if (empty($locale)) {
             $locale = $this->params->get('default_locale');

src/Controller/MainController.php

@@ -8,18 +8,18 @@ use App\Hydra\HydraService;
 use App\SQLLogin\SQLLoginRequest;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\ExpressionLanguage\ExpressionLanguage;
+use Symfony\Component\Finder\Exception\AccessDeniedException;
+use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route;
-use Symfony\Component\HttpFoundation\RedirectResponse;
-use Symfony\Component\Finder\Exception\AccessDeniedException;
 use Symfony\Component\HttpFoundation\Session\SessionInterface;
+use Symfony\Component\Routing\Annotation\Route;
 
 class MainController extends AbstractController
 {
-    public HydraService $hydra;
-    public Client $client;
-    public SessionInterface $session;
+    private HydraService $hydra;
+    private Client $client;
+    private SessionInterface $session;
 
     public function __construct(SessionInterface $session, HydraService $hydra, Client $client)
     {
@@ -33,6 +33,7 @@ class MainController extends AbstractController
     {
         return $this->hydra->handleLoginRequest($request);
     }
+
     /*
     * Route de Healthcheck (notament pour kubernetes)
     */
@@ -43,7 +44,7 @@ class MainController extends AbstractController
     }
 
     #[Route('/connect/login-accept', name: 'app_login_accept', methods: ['GET'])]
-    public function loginAccept(Request $request, SQLLoginRequest $sqlLoginRequest): RedirectResponse
+    public function loginAccept(SQLLoginRequest $sqlLoginRequest): RedirectResponse
     {
         $user = $this->getUser();
 

src/Controller/SecurityController.php

@@ -56,7 +56,7 @@ class SecurityController extends AbstractController
     }
 
     #[Route('/logout', name: 'logout')]
-    public function logout(Request $request)
+    public function logout(Request $request): void
     {
     }
 }