Handle Gitea version upgrade in pretemplate script

Check for version update with script expected version versus installed
version

pretemplate/01-gitea-init

@@ -21,19 +21,14 @@ APPNAME="gitea"
 APPBINARY="gitea"
 APPSIG="7C9E68152594688862D62AF62D9AE806EC1592E2"
 APPASC="${APPNAME}-${APPVERSION}-${OS}-${ARCH}.asc"
-KEYSERV="pgp.mit.edu"
+KEYSERV="hkp://p80.pool.sks-keyservers.net:80"
 DLSERV="dl.gitea.io"
 APPDIR="${WKDIR}/gitea"
 APPBINDIR="${APPDIR}/bin"
 APPCONFDIR="/etc/${APPNAME}"
 
-if [[ -d ${APPCONFDIR} ]]
+function configure_proxy {
-then
-   exit 0
-fi
-
    proxy=$(CreoleGet activer_proxy_client non)
-
    if [[ ${proxy} == "oui" ]]
    then
       prAddr=$(CreoleGet proxy_client_adresse)
@@ -43,6 +38,9 @@ then
       export HTTPS_PROXY=http://${prAddr}:${prPort}
       export https_proxy=http://${prAddr}:${prPort}
    fi
+}
+
+function create_app_dir {
    
    if [[ ! -d ${APPDIR} ]] 
    then
@@ -50,21 +48,11 @@ then
       chown ${USER}:${GROUP} ${APPDIR} -R
    fi
 
-# Create app user and group
-groupadd ${GROUP}
-adduser \
-   --shell ${USERSHELL} \
-   --gecos "${GECOS}" \
-   --ingroup ${GROUP} \
-   --disabled-password \
-   --home ${HOMEDIR} \
-   ${USER}
-
    # Create app structure
    mkdir -p ${APPDIR}/{custom,data,indexers,public,log}
    chown ${USER}:${GROUP} ${APPDIR}/{data,indexers,log}
    chmod 750 ${APPDIR}/{data,indexers,log}
-mkdir ${APPCONFDIR}
+   mkdir -p ${APPCONFDIR}
    chown root:${GROUP} ${APPCONFDIR}
    chmod 770 ${APPCONFDIR}
 
@@ -73,24 +61,80 @@ then
       mkdir -p ${APPBINDIR}
       chown ${USER}:${GROUP} ${APPBINDIR}
    fi
+}
 
-cd $APPBINDIR
+function create_user_and_group {
-if [[ ! -f ${APPBINARY} ]]
+   local existing_group=$(getent group ${GROUP})
+   if [ -z "${existing_group}" ]; then
+      groupadd ${GROUP}
+   fi
+
+   local existing_user=$(getent passwd ${USER})
+   if [ -z "${existing_user}" ]; then
+      adduser \
+         --shell ${USERSHELL} \
+         --gecos "${GECOS}" \
+         --ingroup ${GROUP} \
+         --disabled-password \
+         --home ${HOMEDIR} \
+         ${USER}
+   fi
+}
+
+function download_binary {
+   local temp_bin=$(mktemp)
+
+   wget -O "${temp_bin}" https://${DLSERV}/${APPNAME}/${APPVERSION}/${APPNAME}-${APPVERSION}-${OS}-${ARCH}
+   if [[ $? -ne  0 ]]
    then
-  wget -O ${APPBINARY} https://${DLSERV}/${APPNAME}/${APPVERSION}/${APPNAME}-${APPVERSION}-${OS}-${ARCH}
-  if [[ $? -eq  0 ]]
-  then
-     chmod +x ${APPBINARY}
-  else
       echo "Error downloading binary for ${APPNAME}"
       return 123
    fi
+
+   wget -O "${temp_bin}.asc" https://${DLSERV}/${APPNAME}/${APPVERSION}/${APPASC}
+   gpg --keyserver ${KEYSERV} --recv ${APPSIG}
+   gpg --verify "${temp_bin}.asc" "${temp_bin}"
+
+   if [[ $? -ne  0 ]]
+   then
+      echo "Error downloading binary for ${APPNAME}"
+      return 123
    fi
 
-if [[ ! -f ${APPASC} ]] 
+   cd $APPBINDIR
-then
+   chmod +x "${temp_bin}"
-   wget -O ${APPASC} https://${DLSERV}/${APPNAME}/${APPVERSION}/${APPASC}
+   mv -f "${temp_bin}" ${APPBINARY}
-   gpg --keyserver ${KEYSERV} --recv ${APPSIG}
-   gpg --verify ${APPNAME}-${APPVERSION}-${OS}-${ARCH}.asc ${APPBINARY}
-fi
    cd -
+}
+
+function current_gitea_version {
+   if [[ ! -f "${APPBINDIR}/${APPBINARY}" ]]
+   then
+      return
+   fi
+   "${APPBINDIR}/${APPBINARY}" --version | cut -d' ' -f 3
+}
+
+function main {
+   
+   # Check that installed version if ok
+   local current_version=$(current_gitea_version)
+   if [ "$current_version" == "$APPVERSION" ]; then
+      exit 0
+   fi
+   
+   if [ -z "$current_version" ]
+   then
+      echo "Installing Gitea ${APPVERSION}..."
+   else
+      echo "Upgrade Gitea from ${current_version} to ${APPVERSION}..."
+   fi
+   
+   configure_proxy
+   create_user_and_group
+   create_app_dir
+   download_binary
+   
+}
+
+main