From 9c6ebae9bc41266a4cdb421b9982b581866dbff1 Mon Sep 17 00:00:00 2001
From: William Petit <wpetit@cadoles.com>
Date: Fri, 4 Sep 2020 11:19:24 +0200
Subject: [PATCH] =?UTF-8?q?Ajout=20d'une=20query=20GraphQL=20pour=20v?=
 =?UTF-8?q?=C3=A9rifier=20les=20autorisations=20c=C3=B4t=C3=A9=20serveur?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Intégration des vérifications de droits sur la page de
  création/modification des groupes de travail
---
 .../src/components/WorkgroupPage/InfoForm.tsx | 17 +++++-
 .../WorkgroupPage/WorkgroupPage.tsx           |  2 +
 client/src/gql/client.tsx                     |  5 ++
 client/src/gql/mutations/workgroups.tsx       | 39 +++++++++++-
 client/src/gql/queries/authorization.tsx      | 19 ++++++
 internal/graph/authorization_handler.go       | 59 +++++++++++++++++++
 internal/graph/error.go                       |  3 +-
 internal/graph/query.graphql                  |  7 +++
 internal/graph/query.resolvers.go             |  4 ++
 internal/model/user_repository.go             | 12 ++++
 10 files changed, 160 insertions(+), 7 deletions(-)
 create mode 100644 client/src/gql/queries/authorization.tsx
 create mode 100644 internal/graph/authorization_handler.go

diff --git a/client/src/components/WorkgroupPage/InfoForm.tsx b/client/src/components/WorkgroupPage/InfoForm.tsx
index cb3a3f8..9921b36 100644
--- a/client/src/components/WorkgroupPage/InfoForm.tsx
+++ b/client/src/components/WorkgroupPage/InfoForm.tsx
@@ -1,12 +1,13 @@
 import React, { useState, ChangeEvent, useEffect } from 'react';
 import { Workgroup } from '../../types/workgroup';
+import { useIsAuthorized } from '../../gql/queries/authorization';
 
 export interface InfoFormProps {
   workgroup: Workgroup
   onChange?: (workgroup: Workgroup) => void
 }
 
-export function InfoForm({ workgroup, onChange }: InfoFormProps) {  
+export function InfoForm({ workgroup, onChange }: InfoFormProps) {
   const [ state, setState ] = useState({
     changed: false,
     workgroup: {
@@ -17,6 +18,15 @@ export function InfoForm({ workgroup, onChange }: InfoFormProps) {
     }
   });
 
+  const { isAuthorized } = useIsAuthorized({
+    variables: {
+      action: 'update',
+      object: {
+        workgroupId: state.workgroup.id,
+      }
+    }
+  }, state.workgroup.id === '' ? true : false);
+
   useEffect(() => {
     setState({
       changed: false,
@@ -60,7 +70,8 @@ export function InfoForm({ workgroup, onChange }: InfoFormProps) {
       <div className="field">
         <label className="label">Nom du groupe</label>
         <div className="control">
-          <input type="text" className="input" value={state.workgroup.name} 
+          <input type="text" className="input" value={state.workgroup.name}
+            disabled={!isAuthorized}
             onChange={onWorkgroupAttrChange.bind(null, "name")} />
         </div>
       </div>
@@ -85,7 +96,7 @@ export function InfoForm({ workgroup, onChange }: InfoFormProps) {
         null
       }
       <div className="buttons is-right">
-        <button disabled={!state.changed} 
+        <button disabled={!state.changed || !isAuthorized}
           className="button is-success" onClick={onSaveClick}>
           <span>Enregistrer</span>
           <span className="icon"><i className="fa fa-save"></i></span>
diff --git a/client/src/components/WorkgroupPage/WorkgroupPage.tsx b/client/src/components/WorkgroupPage/WorkgroupPage.tsx
index a0a114c..99926af 100644
--- a/client/src/components/WorkgroupPage/WorkgroupPage.tsx
+++ b/client/src/components/WorkgroupPage/WorkgroupPage.tsx
@@ -20,9 +20,11 @@ export function WorkgroupPage() {
     }
   });
   const userProfileQuery = useUserProfileQuery();
+  
   const [ joinWorkgroup, joinWorkgroupMutation ] = useJoinWorkgroupMutation();
   const [ leaveWorkgroup, leaveWorkgroupMutation ] = useLeaveWorkgroupMutation();
   const [ closeWorkgroup, closeWorkgroupMutation ] = useCloseWorkgroupMutation();
+
   const [ state, setState ] = useState({
     userProfileId: '',
     workgroup: {
diff --git a/client/src/gql/client.tsx b/client/src/gql/client.tsx
index d773545..7af8aea 100644
--- a/client/src/gql/client.tsx
+++ b/client/src/gql/client.tsx
@@ -34,13 +34,17 @@ export const client = new ApolloClient<any>({
 
 function mergeArrayByField<T>(fieldName: string) {
   return (existing: T[] = [], incoming: T[], { readField, mergeObjects }) => {
+    if (incoming.length === 0) return [];
+
     const merged: any[] = existing ? existing.slice(0) : [];
+    
     const objectFieldToIndex: Record<string, number> = Object.create(null);
     if (existing) {
       existing.forEach((obj, index) => {
         objectFieldToIndex[readField(fieldName, obj)] = index;
       });
     }
+
     incoming.forEach(obj => {
       const field = readField(fieldName, obj);
       const index = objectFieldToIndex[field];
@@ -51,6 +55,7 @@ function mergeArrayByField<T>(fieldName: string) {
         merged.push(obj);
       }
     });
+    
     return merged;
   }
 }
\ No newline at end of file
diff --git a/client/src/gql/mutations/workgroups.tsx b/client/src/gql/mutations/workgroups.tsx
index 417aa19..b950a14 100644
--- a/client/src/gql/mutations/workgroups.tsx
+++ b/client/src/gql/mutations/workgroups.tsx
@@ -1,5 +1,6 @@
-import { gql, useQuery, useMutation } from '@apollo/client';
+import { gql, useQuery, useMutation, FetchResult } from '@apollo/client';
 import { QUERY_WORKGROUP } from '../queries/workgroups';
+import { QUERY_IS_AUTHORIZED } from '../queries/authorization';
 
 export const MUTATION_UPDATE_WORKGROUP = gql`
 mutation updateWorkgroup($workgroupId: ID!, $changes: WorkgroupChanges!) {
@@ -57,7 +58,19 @@ mutation joinWorkgroup($workgroupId: ID!) {
 }`;
 
 export function useJoinWorkgroupMutation() {
-  return useMutation(MUTATION_JOIN_WORKGROUP);
+  return useMutation(MUTATION_JOIN_WORKGROUP, {
+    refetchQueries: ({ data }: FetchResult) => {
+      return [{
+        query: QUERY_IS_AUTHORIZED,
+        variables: {
+          action: 'update',
+          object: {
+            workgroupId: data.joinWorkgroup.id,
+          }
+        }
+      }]
+    }
+  });
 }
 
 const MUTATION_LEAVE_WORKGROUP = gql`
@@ -76,7 +89,27 @@ mutation leaveWorkgroup($workgroupId: ID!) {
 }`;
 
 export function useLeaveWorkgroupMutation() {
-  return useMutation(MUTATION_LEAVE_WORKGROUP);
+  return useMutation(MUTATION_LEAVE_WORKGROUP, {
+    refetchQueries: ({ data }: FetchResult) => {
+      return [{
+        query: QUERY_WORKGROUP,
+        variables: {
+          filter: {
+            ids: [data.leaveWorkgroup.id],
+          }
+        }
+      },
+      {
+        query: QUERY_IS_AUTHORIZED,
+        variables: {
+          action: 'update',
+          object: {
+            workgroupId: data.leaveWorkgroup.id,
+          }
+        }
+      }]
+    }
+  });
 }
 
 const MUTATION_CLOSE_WORKGROUP = gql`
diff --git a/client/src/gql/queries/authorization.tsx b/client/src/gql/queries/authorization.tsx
new file mode 100644
index 0000000..d78a813
--- /dev/null
+++ b/client/src/gql/queries/authorization.tsx
@@ -0,0 +1,19 @@
+import { gql, useQuery } from '@apollo/client';
+import { useGraphQLData } from './helper';
+
+export const QUERY_IS_AUTHORIZED = gql`
+  query isAuthorized($action: String!, $object: AuthorizationObject!) {
+    isAuthorized(action: $action, object: $object)
+  }
+`;
+
+export function useIsAuthorizedQuery(options = {}) {
+  return useQuery(QUERY_IS_AUTHORIZED, options);
+}
+
+export function useIsAuthorized(options = {}, defaultValue = false) {
+  const { data, loading, error } = useGraphQLData<boolean>(
+    QUERY_IS_AUTHORIZED, 'isAuthorized', defaultValue, options
+  );
+  return { isAuthorized: data, loading, error };
+}
\ No newline at end of file
diff --git a/internal/graph/authorization_handler.go b/internal/graph/authorization_handler.go
new file mode 100644
index 0000000..e0b936e
--- /dev/null
+++ b/internal/graph/authorization_handler.go
@@ -0,0 +1,59 @@
+package graph
+
+import (
+	"context"
+
+	"forge.cadoles.com/Cadoles/daddy/internal/model"
+	errs "github.com/pkg/errors"
+)
+
+func handleIsAuthorized(ctx context.Context, action string, obj model.AuthorizationObject) (bool, error) {
+	db, err := getDB(ctx)
+	if err != nil {
+		return false, errs.WithStack(err)
+	}
+
+	var object interface{}
+
+	switch {
+	case obj.WorkgroupID != nil:
+		repo := model.NewWorkgroupRepository(db)
+
+		workgroup, err := repo.Find(ctx, *obj.WorkgroupID)
+		if err != nil {
+			return false, errs.WithStack(err)
+		}
+
+		object = workgroup
+
+	case obj.DecisionSupportFileID != nil:
+		repo := model.NewDSFRepository(db)
+
+		dsf, err := repo.Find(ctx, *obj.DecisionSupportFileID)
+		if err != nil {
+			return false, errs.WithStack(err)
+		}
+
+		object = dsf
+
+	case obj.UserID != nil:
+		repo := model.NewUserRepository(db)
+
+		user, err := repo.Find(ctx, *obj.UserID)
+		if err != nil {
+			return false, errs.WithStack(err)
+		}
+
+		object = user
+
+	default:
+		return false, errs.WithStack(ErrInvalidInput)
+	}
+
+	authorized, err := isAuthorized(ctx, object, model.Action(action))
+	if err != nil {
+		return false, errs.WithStack(err)
+	}
+
+	return authorized, nil
+}
diff --git a/internal/graph/error.go b/internal/graph/error.go
index 0228373..3e627ce 100644
--- a/internal/graph/error.go
+++ b/internal/graph/error.go
@@ -3,5 +3,6 @@ package graph
 import "errors"
 
 var (
-	ErrForbidden = errors.New("forbidden")
+	ErrForbidden    = errors.New("forbidden")
+	ErrInvalidInput = errors.New("invalid input")
 )
diff --git a/internal/graph/query.graphql b/internal/graph/query.graphql
index 3aca3c6..a84579b 100644
--- a/internal/graph/query.graphql
+++ b/internal/graph/query.graphql
@@ -38,8 +38,15 @@ input DecisionSupportFileFilter {
   ids: [ID]
 }
 
+input AuthorizationObject {
+  workgroupId: ID
+  userId: ID
+  decisionSupportFileId: ID
+}
+
 type Query {
   userProfile: User
   workgroups(filter: WorkgroupsFilter): [Workgroup]!
   decisionSupportFiles(filter: DecisionSupportFileFilter): [DecisionSupportFile]!
+  isAuthorized(action: String!, object: AuthorizationObject!): Boolean!
 }
diff --git a/internal/graph/query.resolvers.go b/internal/graph/query.resolvers.go
index 3cbe791..a36d7de 100644
--- a/internal/graph/query.resolvers.go
+++ b/internal/graph/query.resolvers.go
@@ -31,6 +31,10 @@ func (r *queryResolver) DecisionSupportFiles(ctx context.Context, filter *model1
 	return handleDecisionSupportFiles(ctx, filter)
 }
 
+func (r *queryResolver) IsAuthorized(ctx context.Context, action string, object model1.AuthorizationObject) (bool, error) {
+	return handleIsAuthorized(ctx, action, object)
+}
+
 func (r *userResolver) ID(ctx context.Context, obj *model1.User) (string, error) {
 	return strconv.FormatUint(uint64(obj.ID), 10), nil
 }
diff --git a/internal/model/user_repository.go b/internal/model/user_repository.go
index f84a70c..378982b 100644
--- a/internal/model/user_repository.go
+++ b/internal/model/user_repository.go
@@ -7,6 +7,7 @@ import (
 	"forge.cadoles.com/Cadoles/daddy/internal/orm"
 	"github.com/jinzhu/gorm"
 	"github.com/pkg/errors"
+	errs "github.com/pkg/errors"
 )
 
 type UserRepository struct {
@@ -68,6 +69,17 @@ func (r *UserRepository) UpdateUserByEmail(ctx context.Context, email string, ch
 	return user, nil
 }
 
+func (r *UserRepository) Find(ctx context.Context, id string) (*User, error) {
+	user := &User{}
+	query := r.db.Model(user).Where("id = ?", id)
+
+	if err := query.First(&user).Error; err != nil {
+		return nil, errs.WithStack(err)
+	}
+
+	return user, nil
+}
+
 func NewUserRepository(db *gorm.DB) *UserRepository {
 	return &UserRepository{db}
 }