Environement variables don't work with Redis configuraiton #9

New Issue

pcaseiro · 2023-07-10T14:34:10+02:00

pcaseiro commented

2023-07-10 14:34:10 +02:00

If you use env with redis configuration Bouncer don't work.

For this configuration :

redis:
    addresses:
        - ${REDIS_SERVER_NAME}:${REDIS_PORT}
    master: "${REDIS_MASTER_NAME}"

This code don't work


var reVar = regexp.MustCompile(`^\${(\w+)}$`)
...
type InterpolatedStringSlice []string

func (iss *InterpolatedStringSlice) UnmarshalYAML(value *yaml.Node) error {
	var data []string

	if err := value.Decode(&data); err != nil {
		return errors.Wrapf(err, "could not decode value '%v' (line '%d') into map", value.Value, value.Line)
	}

	for index, value := range data {
		if match := reVar.FindStringSubmatch(value); len(match) > 0 {
			value = os.Getenv(match[1])
		} 
        
		data[index] = value
	}

	*iss = data

	return nil
}

If you use env with redis configuration Bouncer don't work. For this configuration : ```yaml redis: addresses: - ${REDIS_SERVER_NAME}:${REDIS_PORT} master: "${REDIS_MASTER_NAME}" ``` This code don't work ```go var reVar = regexp.MustCompile(`^\${(\w+)}$`) ... type InterpolatedStringSlice []string func (iss *InterpolatedStringSlice) UnmarshalYAML(value *yaml.Node) error { var data []string if err := value.Decode(&data); err != nil { return errors.Wrapf(err, "could not decode value '%v' (line '%d') into map", value.Value, value.Line) } for index, value := range data { if match := reVar.FindStringSubmatch(value); len(match) > 0 { value = os.Getenv(match[1]) } data[index] = value } *iss = data return nil } ```

pcaseiro referenced this issue from a commit

2023-07-10 17:10:23 +02:00

fix(config): supporting multiple env variables in a value.

pcaseiro referenced this issue

2023-07-10 17:11:35 +02:00

fix(config): supporting multiple env variables in a value. #11

pcaseiro referenced this issue from a commit

2023-07-10 17:13:30 +02:00

fix(config): supporting multiple env variables in a value.

vfebvre referenced this issue from a commit

2024-02-05 11:13:48 +01:00

fix(config): supporting multiple env variables in a value.