mse-rgaa: utilisation de credentials pour l'authentification basic auth

pipelines/mse-rgaa.jenkinsfile

@@ -1,13 +1,10 @@
 import hudson.tasks.test.AbstractTestResultAction
 
-@Library("cadoles") _
+@Library('cadoles') _
 
 pipeline {
-    
   parameters {
     text(name: 'URLS', defaultValue: 'https://msedev.crous-toulouse.fr\nhttps://msedev.crous-toulouse.fr/envole/enregistrement\nhttps://msedev.crous-toulouse.fr/envole/page/faq\nhttps://msedev.crous-toulouse.fr/envole/page/?t=liens_utiles\nhttps://msedev.crous-toulouse.fr/envole/page/?t=mentions_legales\nhttps://msedev.crous-toulouse.fr/envole/message/new\nhttps://msedev.crous-toulouse.fr/envole/recuperation/email\nhttps://msedev.crous-toulouse.fr/envole/courriel/raz', description: 'Liste des URLs à tester, une par ligne')
-    string(name: 'USERNAME', defaultValue: '', description: "Nom d'utilisateur pour l'authentification Basic Auth, si nécessaire")
-    password(name: 'PASSWORD', defaultValue: '', description: "Mot de passe pour l'authentification Basic Auth, si nécessaire")
     booleanParam(name: 'INCLUDE_WARNINGS', defaultValue: false, description: 'Inclure les avertissements')
     booleanParam(name: 'INCLUDE_NOTICES', defaultValue: false, description: 'Inclure les notifications')
   }
@@ -18,12 +15,12 @@ pipeline {
 
   agent {
     node {
-      label "docker"
+      label 'docker'
     }
   }
 
   stages {
-    stage("Run RGAA audit") {
+    stage('Run RGAA audit') {
         steps {
             script {
           def urls = params.URLS.split('\n')
@@ -31,24 +28,32 @@ pipeline {
           def count = 0
           urls.each { u ->
             stage("Audit page '${u}'") {
+              withCredentials([
+                  usernamePassword(
+                    credentialsId: 'msedev-basic-auth',
+                    usernameVariable: 'MSEDEV_USERNAME',
+                    passwordVariable: 'MSEDEV_PASSWORD'
+                  )
+              ]) {
                 def report = pa11y.audit(u.trim(), [
                   reporter: 'junit',
-                            username: params.USERNAME,
-                            password: params.PASSWORD,
+                  username: env.MSEDEV_USERNAME,
+                  password: env.MSEDEV_PASSWORD,
                   standard: 'WCAG2AA',
                   includeNotices: params.INCLUDE_NOTICES,
                   includeWarnings: params.INCLUDE_WARNINGS,
-                        ]);
+                ])
 
                 writeFile file:"./report_${count}.xml", text:report
                 count++
               }
             }
+          }
 
           junit testResults: '*.xml', skipPublishingChecks: true
 
           rocketSend(
-                    channel: "#cnous-mse",
+                    channel: '#cnous-mse',
                     avatar: 'https://jenkins.cadol.es/static/b5f67753/images/headshot.png',
                     message: """
                     Audit RGAA | ${testStatuses()}
@@ -59,7 +64,6 @@ pipeline {
                     """.stripIndent(),
                     rawMessage: true,
                 )
-                
             }
         }
     }
@@ -70,14 +74,11 @@ pipeline {
       cleanWs()
     }
   }
-
-  
-
 }
 
 @NonCPS
 def testStatuses() {
-    def testStatus = ""
+  def testStatus = ''
   AbstractTestResultAction testResultAction = currentBuild.rawBuild.getAction(AbstractTestResultAction.class)
   if (testResultAction != null) {
     def total = testResultAction.totalCount