Cadoles
/
CaptchaBundle
20
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix: Bypass code incorrectly compared 

When the bypass code is given the value of '0', PHP equates it to boolean false causing the validation to fail.
This commit is contained in:
waldermort 2015-01-13 20:10:53 +08:00
parent 94c5f0a03b
commit 843f367540
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Validator/CaptchaValidator.php
View File

@ -82,7 +82,7 @@ class CaptchaValidator
} }
} }
if (!($code && is_string($code) && ($this->compare($code, $expectedCode) || $this->compare($code, $this->bypassCode)))) { if (!($code !== null && is_string($code) && ($this->compare($code, $expectedCode) || $this->compare($code, $this->bypassCode)))) {
$form->addError(new FormError($this->translator->trans($this->invalidMessage, array(), 'validators'))); $form->addError(new FormError($this->translator->trans($this->invalidMessage, array(), 'validators')));
} else { } else {
if ($this->humanity > 0) { if ($this->humanity > 0) {
@ -159,6 +159,6 @@ class CaptchaValidator
*/ */
protected function compare($code, $expectedCode) protected function compare($code, $expectedCode)
{ {
return ($expectedCode && is_string($expectedCode) && $this->niceize($code) == $this->niceize($expectedCode)); return ($expectedCode !== null && is_string($expectedCode) && $this->niceize($code) == $this->niceize($expectedCode));
} }
} }