From cb45fe2847258cb8bc73d0307bb0dc22082fde74 Mon Sep 17 00:00:00 2001 From: Rajini Kanth Date: Wed, 14 May 2014 10:32:02 +0530 Subject: [PATCH 1/2] separated class names to parameters Easier to override the services of this bundle without compiler pass. (http://symfony.com/doc/current/cookbook/bundles/override.html) --- Resources/config/services.yml | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/Resources/config/services.yml b/Resources/config/services.yml index 64827f0..786a6de 100755 --- a/Resources/config/services.yml +++ b/Resources/config/services.yml @@ -1,6 +1,13 @@ +parameters: + gregwar_captcha.captcha_type.class: Gregwar\CaptchaBundle\Type\CaptchaType + gregwar_captcha.captcha_generator.class: Gregwar\CaptchaBundle\Generator\CaptchaGenerator + gregwar_captcha.image_file_handler.class: Gregwar\CaptchaBundle\Generator\ImageFileHandler + gregwar_captcha.captcha_builder.class: Gregwar\Captcha\CaptchaBuilder + gregwar_captcha.phrase_builder.class: Gregwar\Captcha\PhraseBuilder + services: captcha.type: - class: Gregwar\CaptchaBundle\Type\CaptchaType + class: %gregwar_captcha.captch_type.class% arguments: - @session - @gregwar_captcha.generator @@ -10,7 +17,7 @@ services: - { name: form.type, alias: captcha } gregwar_captcha.generator: - class: Gregwar\CaptchaBundle\Generator\CaptchaGenerator + class: %gregwar_captcha.captch_generator.class% arguments: - @router - @gregwar_captcha.captcha_builder @@ -18,7 +25,7 @@ services: - @gregwar_captcha.image_file_handler gregwar_captcha.image_file_handler: - class: Gregwar\CaptchaBundle\Generator\ImageFileHandler + class: %gregwar_captch.image_file_handler.class% arguments: - %gregwar_captcha.config.image_folder% - %gregwar_captcha.config.web_path% @@ -26,7 +33,7 @@ services: - %gregwar_captcha.config.expiration% gregwar_captcha.captcha_builder: - class: Gregwar\Captcha\CaptchaBuilder + class: %gregwar_captcha.captcha_builder.class% gregwar_captcha.phrase_builder: - class: Gregwar\Captcha\PhraseBuilder + class: %gregwar_captcha.phrase_builder.class% From de0d9408d6df925ab72f76e704cd4b34c527097f Mon Sep 17 00:00:00 2001 From: Rajini Kanth Date: Wed, 14 May 2014 10:35:18 +0530 Subject: [PATCH 2/2] corrected typos --- Resources/config/services.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Resources/config/services.yml b/Resources/config/services.yml index 786a6de..7b552ca 100755 --- a/Resources/config/services.yml +++ b/Resources/config/services.yml @@ -7,7 +7,7 @@ parameters: services: captcha.type: - class: %gregwar_captcha.captch_type.class% + class: %gregwar_captcha.captcha_type.class% arguments: - @session - @gregwar_captcha.generator @@ -17,7 +17,7 @@ services: - { name: form.type, alias: captcha } gregwar_captcha.generator: - class: %gregwar_captcha.captch_generator.class% + class: %gregwar_captcha.captcha_generator.class% arguments: - @router - @gregwar_captcha.captcha_builder @@ -25,7 +25,7 @@ services: - @gregwar_captcha.image_file_handler gregwar_captcha.image_file_handler: - class: %gregwar_captch.image_file_handler.class% + class: %gregwar_captcha.image_file_handler.class% arguments: - %gregwar_captcha.config.image_folder% - %gregwar_captcha.config.web_path%